Commit graph

18632 commits

Author SHA1 Message Date
Álvaro Brey Vilas
3ff35d46e6 Fix some spotbugs stuff
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
56584c06e6 Fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
42c28dce70 ThemeModule: convert to Kotlin and fix copyright
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
nextcloud-android-bot
e2c3091fc0 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-29 06:38:14 +00:00
tobiasKaminsky
17828cb3b4 remove some spotbugs warnings
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
f627f3d976 Fix injection ofr RenameFileDialogFragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
6bd7d808f4 Put OCFileListBottomSheetDialog into a DialogFragment
Can't inject things into a Dialog

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
74e17ee7c6 Fixes after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fix after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Álvaro Brey Vilas
75cb8a767c Remove SyncedFoldersActivity.java
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
349a045b46 Move all Theme classes to DI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Nextcloud bot
0a802b51da
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-29 04:11:37 +00:00
Álvaro Brey
c81c1c83aa
Merge pull request #10117 from nextcloud/chore/screenshot-test-reliability
Screenshot tests reliability improvements
2022-04-28 14:05:23 +02:00
Álvaro Brey
87ed56f4d9
Merge pull request #10080 from nextcloud/thumbnailFetch
Parallel thumbnail fetching
2022-04-28 11:11:08 +02:00
Álvaro Brey Vilas
bc44b2c524
PasscodeActivityIT: add short sleep after closing keyboard
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 11:09:19 +02:00
tobiasKaminsky
73bb12f78a Parallel thumbnail fetching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-28 08:10:54 +00:00
Álvaro Brey Vilas
011d6c3ceb
ActivitiesActivityIT.error: more sleep
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 09:03:35 +02:00
Álvaro Brey Vilas
236925de99
Screenshot tests reliability improvements
Add more sleeps to SetupEncryptionDialogFragment.error and TrashBinActivity.empty, which fail frequently

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 09:03:29 +02:00
Tobias Kaminsky
a2d2c1a3c7
Merge pull request #10122 from nextcloud/fix/activity-constructor
Fixes for tests due changes in Activity constructor in library
2022-04-28 08:03:57 +02:00
Álvaro Brey Vilas
d79b20dbc5
ActivitiesPresenterTest: Activity no longer has empty constructor
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 19:02:43 +02:00
Álvaro Brey Vilas
98177e3eb3
Fix crash in screenshot test due to changes in library
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 19:02:26 +02:00
Álvaro Brey
c20c3e4066
Merge pull request #10014 from nextcloud/spotbugs-improvements
Spotbugs improvements
2022-04-27 11:34:35 +02:00
Álvaro Brey
23dd1f30f1
Merge pull request #10113 from nextcloud/chore/unit-tests-gh-actions
Run unit tests in GH actions
2022-04-27 11:21:49 +02:00
Álvaro Brey
176fb24d5b
Merge pull request #10084 from nextcloud/dependabot/gradle/com.google.firebase-firebase-messaging-23.0.3
Bump firebase-messaging from 23.0.2 to 23.0.3
2022-04-27 11:12:02 +02:00
Álvaro Brey Vilas
7073746309
Use defusedxml for xml parsing instead of etree
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 11:03:59 +02:00
Álvaro Brey Vilas
6eff01d735
Fix some codacy warnings
- Quote some strings in analysis-wrapper
 - Cleanup unneeded checks in spotbugs-up

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:53:30 +02:00
Álvaro Brey Vilas
79fc8c61d9
codecov: add flag to integration test coverage so the UI is clearer
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:19:23 +02:00
dependabot[bot]
f93e65872a
Bump firebase-messaging from 23.0.2 to 23.0.3
Bumps firebase-messaging from 23.0.2 to 23.0.3.

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-messaging
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-27 08:09:10 +00:00
Álvaro Brey Vilas
3879d90eec Ditch findbugs-results.txt: use the stable branch XML as single source of truth
Poor man's baseline

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00
Álvaro Brey Vilas
21a432dc9e Generate spotbugs summary from xml
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00
Álvaro Brey Vilas
c850d14fc0 spotbugs: Use fancy stylesheet
MUCH more readable and easier to find stuff

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00
Álvaro Brey Vilas
7f00cd6e46
Upload unit test results properly if they fail
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:43:51 +02:00
Álvaro Brey Vilas
3b80d4dc1f build: Remove combinedTestReport task
It's not working properly (complains about no classes, empty report), AND codecov should merge unit and integration coverages for us anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
Álvaro Brey Vilas
323fdda409 Drone: optimize assemble while waiting for server/emulator
- Don't assemble Gplay separately from gplayDebug. We already have some GH actions to verify that all flavors assemble.
- Assemble the AndroidTest task, so that there's less work to do when installGplayDebug is called

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
Álvaro Brey Vilas
f572176e4c Drone: don't run unit tests
Done in GH actions now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
Álvaro Brey Vilas
68b2665b09 Run unit tests in GH actions
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
Tobias Kaminsky
d61a8f3444
Merge pull request #10112 from nextcloud/fix/loginIT-master
Fix LoginIT for server master
2022-04-27 07:52:30 +02:00
Álvaro Brey
b3b3376c5b
Merge pull request #10069 from nextcloud/dependabot/gradle/com.vanniktech-emoji-google-0.9.0
Bump emoji-google from 0.8.0 to 0.9.0
2022-04-26 18:21:06 +02:00
Álvaro Brey Vilas
dd4a69d58c
LoginIT: convert to Kotlin
While we're at it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-26 09:51:39 +02:00
Álvaro Brey Vilas
85b5bf6875
Fix LoginIT submit click
In latest Nextcloud version the "submit" button does not have an ID, but we can use the type for selection

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-26 09:45:32 +02:00
Nextcloud bot
bd139f1afb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-26 04:11:10 +00:00
Álvaro Brey
d45e12c2b8
Merge pull request #10089 from nextcloud/remove-account-usage-from-manage-acconuts-activity
Remove account use from ManageAccountsActivity
2022-04-25 16:47:34 +02:00
Álvaro Brey
828bef6af7
Merge pull request #10102 from nextcloud/dependabot/gradle/kotlin_version-1.6.21
Bump kotlin_version from 1.6.20 to 1.6.21
2022-04-25 11:59:15 +02:00
Álvaro Brey
1095fd540d
Merge pull request #10065 from nextcloud/dependabot/gradle/byteBuddyVersion-1.12.9
Bump byteBuddyVersion from 1.12.8 to 1.12.9
2022-04-25 10:52:09 +02:00
Álvaro Brey
cae58daa4c
Merge pull request #10111 from nextcloud/dependabot/gradle/com.karumi-shot-5.14.0
Bump shot from 5.13.0 to 5.14.0
2022-04-25 10:42:47 +02:00
dependabot[bot]
93b236ff7c
Bump kotlin_version from 1.6.20 to 1.6.21
Bumps `kotlin_version` from 1.6.20 to 1.6.21.

Updates `kotlin-gradle-plugin` from 1.6.20 to 1.6.21
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `kotlin-stdlib` from 1.6.20 to 1.6.21
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-25 07:59:15 +00:00
dependabot[bot]
de0bcbb279
Bump shot from 5.13.0 to 5.14.0
Bumps [shot](https://github.com/pedrovgs/shot) from 5.13.0 to 5.14.0.
- [Release notes](https://github.com/pedrovgs/shot/releases)
- [Commits](https://github.com/pedrovgs/shot/compare/5.13.0...5.14.0)

---
updated-dependencies:
- dependency-name: com.karumi:shot
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-25 02:12:53 +00:00
Nextcloud bot
98075eba14
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-24 04:13:03 +00:00
Chris Narkiewicz
042c3758ac
Remove account use from ManageAccountsActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-04-23 16:49:13 +01:00
Nextcloud bot
14aac48b90
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-23 04:00:20 +00:00
Álvaro Brey
0ad80b89cc
Merge pull request #10106 from nextcloud/dependabot/gradle/mockitoVersion-4.5.1
Bump mockitoVersion from 4.4.0 to 4.5.1
2022-04-22 13:01:42 +02:00