Commit graph

18189 commits

Author SHA1 Message Date
Álvaro Brey Vilas
11e472b18b
PreviewVideoActivity: fix control buttons
For some reason only previous/next were working.

Manually bind play and pause, and remove the rest

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
22555a901a
PreviewVideoActivity: pause player when activity stops
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
e419144456
PreviewVideoActivity: ensure player is stopped when closing fullscreen
This already worked for onBackPressed

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
686748dda2
PreviewMediaFragment: stop video when stopping activity, and don't recreate existing player
This avoids multiple instances of the player opening when minimizing the app, for example.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey
c9018f8ba6
Merge pull request #9862 from nextcloud/fixLeakedCloseableViolation
Fix LeakedCloseableViolations in getScaledBitmap
2022-02-21 11:36:38 +01:00
Álvaro Brey
cb9d9ff1a2
Merge pull request #9858 from nextcloud/fix/preview-share
Fix UX issues with toolbar in preview media fragment when using the "share" option
2022-02-21 09:46:28 +01:00
Nextcloud bot
e4da58cfd2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-21 03:55:57 +00:00
Unpublished
2bd0bf0f14 Update findbugs-results.txt
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 13:22:48 +01:00
Unpublished
67397a4d7b Fix LeakedCloseableViolations in getScaledBitmap
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 12:56:28 +01:00
Nextcloud bot
5250b7380c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-20 03:55:24 +00:00
Nextcloud bot
c704f59b37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-19 03:55:54 +00:00
Álvaro Brey Vilas
7625275b07
Fix toolbar in PreviewMediaFragment after coming back from sharing fragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:48:17 +01:00
Álvaro Brey Vilas
66125d6a27
FileDisplayActivity: fix coordinator scrolling when opening share details from media preview
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:31:15 +01:00
Álvaro Brey
2b639f288b
Merge pull request #9852 from nextcloud/dependabot/gradle/daggerVersion-2.41
Bump daggerVersion from 2.40.5 to 2.41
2022-02-17 18:12:26 +01:00
Álvaro Brey
735cbfc7ab
Merge pull request #9851 from nextcloud/dependabot/gradle/com.github.spotbugs.snom-spotbugs-gradle-plugin-5.0.6
Bump spotbugs-gradle-plugin from 5.0.5 to 5.0.6
2022-02-17 17:45:08 +01:00
Tobias Kaminsky
41d1698ea3
Merge pull request #9717 from nextcloud/scan_doc
Scan doc
2022-02-17 14:31:02 +01:00
thelittlefireman
9e7a9b410f
Add scan document feature
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-17 10:10:36 +01:00
Nextcloud bot
ee000f7b4e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-17 03:55:25 +00:00
dependabot[bot]
c3939e881c
Bump daggerVersion from 2.40.5 to 2.41
Bumps `daggerVersion` from 2.40.5 to 2.41.

Updates `dagger` from 2.40.5 to 2.41
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.40.5...dagger-2.41)

Updates `dagger-android` from 2.40.5 to 2.41
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.40.5...dagger-2.41)

Updates `dagger-android-support` from 2.40.5 to 2.41
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.40.5...dagger-2.41)

Updates `dagger-compiler` from 2.40.5 to 2.41
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.40.5...dagger-2.41)

Updates `dagger-android-processor` from 2.40.5 to 2.41
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.40.5...dagger-2.41)

---
updated-dependencies:
- dependency-name: com.google.dagger:dagger
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android-support
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android-processor
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-17 02:05:47 +00:00
dependabot[bot]
70904ce924
Bump spotbugs-gradle-plugin from 5.0.5 to 5.0.6
Bumps [spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/spotbugs/spotbugs-gradle-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-gradle-plugin/compare/5.0.5...5.0.6)

---
updated-dependencies:
- dependency-name: com.github.spotbugs.snom:spotbugs-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-17 02:05:25 +00:00
Tobias Kaminsky
1e33020f80
Merge pull request #9783 from nextcloud/mediaEnhancement
Enhance media tab
2022-02-16 10:42:33 +01:00
dependabot[bot]
2d99d8a546
Bump ktlint from 0.43.2 to 0.44.0
Bumps [ktlint](https://github.com/pinterest/ktlint) from 0.43.2 to 0.44.0.
- [Release notes](https://github.com/pinterest/ktlint/releases)
- [Changelog](https://github.com/pinterest/ktlint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pinterest/ktlint/compare/0.43.2...0.44.0)

---
updated-dependencies:
- dependency-name: com.pinterest:ktlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-16 02:05:51 +00:00
Álvaro Brey
f9febe24ad
Fallback pdf viewer (#9806)
* Basic PDF preview

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Preview pdf: add dividers between pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Prefer third-party pdf viewers over fallback viewer

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Zoomable view for pdf pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

pdf preview: Show tip to indicate that zooming on images is possible

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix spotbugs and lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix toolbar when resuming

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewBitmapActivity: add screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix crash in screenshot tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: rename tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* pdf preview: Update copyright headers

Oops

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: use grey for background instead of black

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: add scrollbar

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: show zoom tip 3 times instead of only once

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: fix lint and improve styling

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 15:04:16 +01:00
Tobias Kaminsky
9723c0458e
Merge pull request #9816 from nextcloud/pin
Improve PIN lockout handling
2022-02-15 14:54:08 +01:00
tobiasKaminsky
ea863cd04c
Fix test, satisfy spotbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 14:52:55 +01:00
Tobias Kaminsky
e5131c59ca
Merge pull request #9736 from nextcloud/uploadCreationTimestamp
Make use of upload and creation timestamp
2022-02-15 14:22:08 +01:00
Álvaro Brey Vilas
df3c98a0c4
PassCodeManager: use abstracted Clock implementation rather than system clock directly
Improves testability

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 11:23:36 +01:00
Álvaro Brey Vilas
aafa7780f6
PassCodeActivity: update lock timestamp when lock has just been set
Prevents asking for pass immediately after setting it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 10:27:11 +01:00
tobiasKaminsky
607d008a75
Make use of upload and creation timestamp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:43:32 +01:00
tobiasKaminsky
3584b90bc6
Show empty message if no results
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:36:52 +01:00
tobiasKaminsky
b2bfd985da
Remove not needed check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:23:50 +01:00
tobiasKaminsky
0624e7eef3
Satisfy CI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 08:37:25 +01:00
tobiasKaminsky
cdd73d7d3d
Use master library again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 08:11:24 +01:00
Nextcloud bot
ac68a9269e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-15 05:33:30 +00:00
Álvaro Brey Vilas
8b03556f71
PassCodeManager: convert to Kotlin, clean up, use injection
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 18:28:56 +01:00
Álvaro Brey Vilas
579af4ab30
PassCodeManager: don't count passcode/credentials activity towards activity counter
This prevents repetition attacks

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 17:28:46 +01:00
Álvaro Brey
42b254dae6
Merge pull request #9829 from nextcloud/dependabot/gradle/com.google.code.gson-gson-2.9.0
Bump gson from 2.8.9 to 2.9.0
2022-02-14 13:49:31 +01:00
dependabot[bot]
b2652633d2
Bump gson from 2.8.9 to 2.9.0
Bumps [gson](https://github.com/google/gson) from 2.8.9 to 2.9.0.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/gson/compare/gson-parent-2.8.9...gson-parent-2.9.0)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-14 12:15:06 +00:00
Álvaro Brey
6d6183b3b0
Merge pull request #9208 from nextcloud/flaky-tests-again
Add RetryTestRule to DrawerActivityIT
2022-02-14 11:16:18 +01:00
Álvaro Brey
69033e25e9
Merge pull request #9823 from nextcloud/chore/mockitokotlin2
Chore: replace `com.nhaarman.mockitokotlin2` with `org.mockito.kotlin`
2022-02-14 11:09:47 +01:00
Tobias Kaminsky
b81027d057
Merge pull request #9791 from nextcloud/fix/shares-downloading-crash
FileActivity: fix crash on share operations when FileDetailFragment is second fragment
2022-02-14 09:06:22 +01:00
Tobias Kaminsky
c41f87d281
Merge pull request #9822 from nextcloud/chore/conflicts-dialog-logs
ConflictsResolveActivity: Add log messages when dialog can't be created
2022-02-14 09:00:28 +01:00
Tobias Kaminsky
1d4bc98de7
Merge pull request #9812 from nextcloud/avatarSize
Use 512px for avatar
2022-02-14 08:47:33 +01:00
Tobias Kaminsky
8b0674e29f
Merge pull request #9808 from nextcloud/resumeText
resuming TextEditor after splitting screens works now again
2022-02-14 08:40:09 +01:00
Tobias Kaminsky
541e55ff1c
Merge pull request #9821 from nextcloud/fix/db-upgrade-crash
FileContentProvider: fix crash on certain upgrades
2022-02-14 08:30:47 +01:00
tobiasKaminsky
fa73725815 Pin: use activity paused also, as stopped is sometimes too slow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:30:00 +00:00
tobiasKaminsky
556f856ac3
Update adapter after finish search (success/failure)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
e17beb00ad
Do not show meta info (favorite, download status) in media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
256656af5d
correctly return result
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
307a407631
fix reloading bug
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00