Commit graph

6581 commits

Author SHA1 Message Date
eho
d5b500559e fragment:util: Added private constructor to hide the inherit public one
Utility classes, which are collections of static members, are not meant to be instantiated.

Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
2018-06-09 23:06:12 +02:00
eho
06e85e8819 ui:fragment Inverted if-statement for increased readability. 2018-06-09 22:56:10 +02:00
Andy Scherzinger
9d963cec33
Merge pull request #2686 from nextcloud/correctException
Use correct exception
2018-06-09 18:55:48 +02:00
AndyScherzinger
fb094e7628
renamed due to CR 2018-06-09 14:23:17 +02:00
AndyScherzinger
eb6821dc25
codacy: organize imports 2018-06-09 14:23:17 +02:00
AndyScherzinger
f863ea9adc
extract UI init and show/hide parts in separate methods for a better overview 2018-06-09 14:23:16 +02:00
AndyScherzinger
7fb487f717
remove unused import 2018-06-09 14:23:16 +02:00
AndyScherzinger
05a0167255
extract open file intent creation into a separate method 2018-06-09 14:23:15 +02:00
AndyScherzinger
7d4a2ecfa8
change call order to not create unneeded objects before the checks haven't succeeded 2018-06-09 14:23:15 +02:00
AndyScherzinger
015aa06d79
use a more specific input param 2018-06-09 14:23:14 +02:00
AndyScherzinger
d663535ce6
extract credentials update notification 2018-06-09 14:23:14 +02:00
Andy Scherzinger
080acb2f8e
Merge pull request #2694 from nextcloud/whiteBadge
Tint badge to element color
2018-06-09 14:22:33 +02:00
tobiasKaminsky
59f1253a86
do not use static context
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-09 13:35:15 +02:00
Nextcloud bot
fe4b113b80
[tx-robot] updated from transifex 2018-06-09 00:47:24 +00:00
Nextcloud bot
711dd895e2
[tx-robot] updated from transifex 2018-06-08 00:47:35 +00:00
tobiasKaminsky
537a3b7eb9
tint badge to element color
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-07 14:57:21 +02:00
Nextcloud bot
bc374c8741
[tx-robot] updated from transifex 2018-06-07 00:46:20 +00:00
AndyScherzinger
c439e84880
make sort by date package private 2018-06-06 14:38:52 +02:00
AndyScherzinger
34568caba7
120character print margin 2018-06-06 14:37:46 +02:00
AndyScherzinger
9ce8b19aed
use method expression lambdas to further shorten the code 2018-06-06 14:37:00 +02:00
AndyScherzinger
379c461f33
Also use lambda for sorting 2018-06-06 14:33:05 +02:00
eho
51eab2457d
util: Use lambdas where applicable in the FileSortOrderByName/Size classes. 2018-06-06 14:27:51 +02:00
eho
754419090d
util: Made FileSortOrderByName and FileSortOrderBySize package private.
- Follows principle of least privilege.
2018-06-06 14:27:51 +02:00
Nextcloud bot
bb9a6a5364
[tx-robot] updated from transifex 2018-06-06 00:47:06 +00:00
Andy Scherzinger
0b2c986c0f
Merge pull request #2648 from nextcloud/resumeDetailView
File detail view: store file/account when suspending fragments
2018-06-05 16:39:26 +02:00
tobiasKaminsky
60a0df7020
use correct exception
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 14:52:12 +02:00
tobiasKaminsky
b4b1790ef6
Use context instead of static getAppContext 2018-06-05 13:19:17 +02:00
AndyScherzinger
c5e5868eec
ignore restricted API lint error for tinting a spinner icon 2018-06-05 12:58:42 +02:00
AndyScherzinger
119b8a5943
fix zip icon tinting after rebase 2018-06-05 12:46:37 +02:00
tobiasKaminsky
7ae333635a
tint search view in upload activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:02 +02:00
tobiasKaminsky
df01428150
tint spinner
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:02 +02:00
tobiasKaminsky
ebb04db951
tint action bar icon
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:01 +02:00
tobiasKaminsky
1c6fec7192
tint remove file dialog buttons
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:01 +02:00
tobiasKaminsky
8b2d082d32
tint pin elements
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:00 +02:00
tobiasKaminsky
9bb708dd08
tint "report button"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:00 +02:00
tobiasKaminsky
b13a3ae680
tint also upload file list
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:34:59 +02:00
tobiasKaminsky
c32e47f4ce
White theming
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:34:51 +02:00
Mario Đanić
b48a6e8d8e
Merge pull request #2626 from nextcloud/menuHelper
Shorten code and improve readability via a menu helper
2018-06-05 07:56:06 +02:00
Mario Đanić
c5bca087f2
Merge pull request #2631 from nextcloud/tintZip
tint zip icon same as folder icon
2018-06-05 07:55:00 +02:00
Mario Đanić
648b02ee8a
Merge pull request #2649 from nextcloud/finishPreferences
Explicitly finish preferences
2018-06-05 07:53:40 +02:00
Mario Đanić
f123c269f0
Merge pull request #2651 from nextcloud/resultOnStoppedAsync
Do not process result of async task if activity is stopped
2018-06-05 07:53:09 +02:00
Mario Đanić
2d4cb825f9
Merge pull request #2661 from nextcloud/rewordEmptyActivity
Reword empty activity message
2018-06-05 07:52:31 +02:00
eho
62fe30134c util: Added @Override annotation where applicable.
Using the @Override annotation is useful for two reasons :

It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
2018-06-04 16:10:08 +02:00
eho
b1e032cd6c ui:fragment: Use isEmpty() to check if list of activities is empty.
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
2018-06-04 16:07:29 +02:00
AndyScherzinger
4c6ffea5e4
massively shorten code and improve readability via a menu helper 2018-06-04 15:21:59 +02:00
AndyScherzinger
eb7e5f735d
lint: ignore setJavaScriptEnabled 2018-06-04 13:20:33 +02:00
AndyScherzinger
afc32f1cf1
fix he->iw and id->in 2018-06-02 22:23:21 +02:00
Nextcloud bot
18755ba08c
[tx-robot] updated from transifex 2018-06-02 00:45:28 +00:00
Nextcloud bot
f7f988bc15
[tx-robot] updated from transifex 2018-05-31 00:47:30 +00:00
tobiasKaminsky
6cf37f3a0d
reword empty activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 13:45:50 +02:00
tobiasKaminsky
8d7b16b3ca
do not process result of async task if activity is stopped
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 11:07:34 +02:00
Andy Scherzinger
8c5f564253
Merge pull request #2650 from nextcloud/explicitAllowGCM
Explicitly allow gcm on gplay
2018-05-30 10:32:22 +02:00
tobiasKaminsky
c1b1bc8fab
explicitly allow gcm on gplay
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 09:25:43 +02:00
tobiasKaminsky
7f28bad63e
explicitly finish preferences
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 08:23:49 +02:00
tobiasKaminsky
e718f49dea
store file/account when suspending fragments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 07:29:52 +02:00
tobiasKaminsky
cf8478b80d
as we use singleTop, we shall not start a new activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 06:34:11 +02:00
Nextcloud bot
d598c3afcf
[tx-robot] updated from transifex 2018-05-30 00:47:59 +00:00
Nextcloud bot
455a92849f
[tx-robot] updated from transifex 2018-05-29 11:28:08 +00:00
Nextcloud bot
46fb12a68f
[tx-robot] updated from transifex 2018-05-29 10:02:22 +00:00
AndyScherzinger
058eff9627
restore prematurely deleted strings 2018-05-29 11:38:59 +02:00
Nextcloud bot
9a65471805
[tx-robot] updated from transifex 2018-05-29 09:05:28 +00:00
AndyScherzinger
ba0aff41a7
Fix comment again 2018-05-29 09:14:22 +02:00
AndyScherzinger
c3209d817d
fix further review comments 2018-05-29 09:13:09 +02:00
AndyScherzinger
84401e73a7
fix menu filter 2018-05-29 09:01:41 +02:00
AndyScherzinger
f731e4d59b
java imports, unused java been removed... 2018-05-29 08:38:58 +02:00
AndyScherzinger
cf1b8f8f85
Fix theming issue with date picker dialog 2018-05-29 08:31:50 +02:00
AndyScherzinger
892db9f689
raise font size on file name 2018-05-29 07:58:41 +02:00
AndyScherzinger
d72eb2a4b7
fix codacy 2018-05-29 07:58:41 +02:00
AndyScherzinger
a3daf0642e
fix lint again 2018-05-29 07:58:41 +02:00
AndyScherzinger
f201a2dd66
first changes due to designers review 2018-05-29 07:58:40 +02:00
AndyScherzinger
d8c4be0604
fix lint for item divider, plus code formatting 2018-05-29 07:58:39 +02:00
AndyScherzinger
952db5a34b
added javaDoc for public methods 2018-05-29 07:58:39 +02:00
AndyScherzinger
5154280f00
fix refreshing OC file list after sharing info changes 2018-05-29 07:58:38 +02:00
AndyScherzinger
5c4a450b11
use file details sharing tab for files also via the share bottom sheet (only if FileDisplayActivity is the parent) 2018-05-29 07:58:38 +02:00
AndyScherzinger
abc2be7a23
further shortened the label 2018-05-29 07:58:37 +02:00
AndyScherzinger
f2edf5a7f5
shorten edit label 2018-05-29 07:58:37 +02:00
AndyScherzinger
90a129d232
use nicer UI element names 2018-05-29 07:58:36 +02:00
AndyScherzinger
e7a0f493f2
rewrite sharee list to recycler view, show can edit in list items 2018-05-29 07:58:36 +02:00
AndyScherzinger
c738d9e46a
optimize layout/design 2018-05-29 07:58:35 +02:00
AndyScherzinger
48992266fa
minor size optimizations 2018-05-29 07:58:35 +02:00
AndyScherzinger
cb6c56e391
save accent color 2018-05-29 07:58:34 +02:00
AndyScherzinger
ab973579cb
remove method call of formerly dropped method 2018-05-29 07:58:33 +02:00
AndyScherzinger
20d0307ca7
use general fallback theming for popup menu (checkable menu items) 2018-05-29 07:58:32 +02:00
AndyScherzinger
9e0e83872b
update license headers 2018-05-29 07:58:32 +02:00
AndyScherzinger
a00b89f972
add javaDoc comment 2018-05-29 07:58:31 +02:00
AndyScherzinger
42a0e28ee7
add ability to set expiration date for user shares 2018-05-29 07:58:31 +02:00
AndyScherzinger
2d55824cf6
fix name and javaDoc of updateMethod 2018-05-29 07:58:30 +02:00
AndyScherzinger
bb7c090d6e
remove unused legacy method 2018-05-29 07:58:30 +02:00
AndyScherzinger
d08a944b10
hide sync for folders 2018-05-29 07:58:29 +02:00
AndyScherzinger
f2dd5ea2a6
proper error snackbars for sharing errors, move feed back results to the sharing fragment+refresh 2018-05-29 07:58:29 +02:00
tobiasKaminsky
cab6555703
app restarts now after account switching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-29 07:58:28 +02:00
tobiasKaminsky
d0b9d58ec8
account switch on drawer without "singleTop" works again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-29 07:58:28 +02:00
AndyScherzinger
17093482fb
sort menu items according to webUI 2018-05-29 07:58:27 +02:00
AndyScherzinger
0e41ed7889
Use AppCompat checkbox 2018-05-29 07:58:27 +02:00
tobiasKaminsky
cc8914ed0f
type, code formatting
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-29 07:58:26 +02:00
AndyScherzinger
dba1042369
remove unused string 2018-05-29 07:58:26 +02:00
AndyScherzinger
b3f980c99d
show proper error view if activities failed to load 2018-05-29 07:58:25 +02:00
AndyScherzinger
d0dbc9e36a
remove unused import 2018-05-29 07:58:25 +02:00
AndyScherzinger
0a545dd9a6
fix NPEs in calling UI thread and within UI threads 2018-05-29 07:58:25 +02:00
AndyScherzinger
de51ba1aca
remove legacy code after refactoring to a helper class 2018-05-29 07:58:24 +02:00