Commit graph

11441 commits

Author SHA1 Message Date
Álvaro Brey Vilas
7ff1d0d7d3
GalleryFragment: restore title and fab on resume
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 17:33:08 +01:00
Álvaro Brey Vilas
eeee11e427 PreviewImageActivity: don't try to use virtual folder is type is NONE
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:11:09 +00:00
Álvaro Brey Vilas
967327e321 OCFileListFragment: don't reset title after clearing action mode (multiselect)
This breaks the title when in a virtual folder. There's no need for this, as the title is preserved anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:10:57 +00:00
tobiasKaminsky
6d6339ebf6 Correct handling of creation timestamp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-28 14:10:39 +00:00
Álvaro Brey Vilas
dd4770669f FileDisplayActivity: finally get rid of secondFragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:10:19 +00:00
Álvaro Brey Vilas
ba21b3a43f
OCFile: fix NPE in getLocalId when remoteID is null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 12:51:05 +01:00
Nextcloud bot
b8aa447056
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-28 04:13:54 +00:00
Nextcloud bot
76c5dded8f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-26 03:53:55 +00:00
tobiasKaminsky
8401427d96
Remove not needed toString() call
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Update src/main/java/com/owncloud/android/db/OCUpload.java

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-02-25 14:46:27 +01:00
tobiasKaminsky
7c7e7e845d remoteId not needed when deleting a file
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-25 12:49:47 +00:00
Nextcloud bot
5d943ad24b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-25 03:53:59 +00:00
Álvaro Brey Vilas
1a0d3ed65b
Cleanup
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:49:20 +01:00
Álvaro Brey Vilas
5d07c4c6e4
Better exception report template
With markdown now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:42:55 +01:00
Álvaro Brey Vilas
4cc4418bec
ExceptionHandler: format entire stack trace recursively
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:03:32 +01:00
tobiasKaminsky
53a04af735
Add stacktrace directly to github issue
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-24 11:03:26 +01:00
Álvaro Brey
9b3c08efcd
Merge pull request #9880 from nextcloud/fixLoggerImpl
Fix LoggerImpl to also log throwable
2022-02-24 10:15:58 +01:00
Nextcloud bot
b124793817
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-24 03:56:56 +00:00
Unpublished
f50def5e0d Fix LoggerImpl to also log throwable
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-23 22:02:59 +01:00
Unpublished
fcd1ab88b5 Migrate from Parceler to kotlin-parcelize
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-23 17:08:32 +01:00
Álvaro Brey
00009680a3
Merge pull request #9859 from nextcloud/fix/video-stacking
Misc fixes for video player
2022-02-22 12:09:26 +01:00
Nextcloud bot
8f6e8f4927
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-22 03:56:19 +00:00
Álvaro Brey Vilas
71c0f657e2
PreviewVideoActivity: improve button UX
- Add ripple on button click
 - Only show play OR pause button depending on playback state

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:43 +01:00
Álvaro Brey Vilas
87e508d2b1
Restore fast forward/rewind buttons in fullscreen video
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
7d89d68df6
PreviewVideoActivity: convert to Kotlin
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
329dea57a3
PreviewMediaFragment: fix restoring seek position when returning from fullscreen stream
The stream asynctask was just ignoring the saved time

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
11e472b18b
PreviewVideoActivity: fix control buttons
For some reason only previous/next were working.

Manually bind play and pause, and remove the rest

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
22555a901a
PreviewVideoActivity: pause player when activity stops
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
e419144456
PreviewVideoActivity: ensure player is stopped when closing fullscreen
This already worked for onBackPressed

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
686748dda2
PreviewMediaFragment: stop video when stopping activity, and don't recreate existing player
This avoids multiple instances of the player opening when minimizing the app, for example.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey
c9018f8ba6
Merge pull request #9862 from nextcloud/fixLeakedCloseableViolation
Fix LeakedCloseableViolations in getScaledBitmap
2022-02-21 11:36:38 +01:00
Álvaro Brey
cb9d9ff1a2
Merge pull request #9858 from nextcloud/fix/preview-share
Fix UX issues with toolbar in preview media fragment when using the "share" option
2022-02-21 09:46:28 +01:00
Nextcloud bot
e4da58cfd2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-21 03:55:57 +00:00
Unpublished
67397a4d7b Fix LeakedCloseableViolations in getScaledBitmap
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 12:56:28 +01:00
Nextcloud bot
5250b7380c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-20 03:55:24 +00:00
Nextcloud bot
c704f59b37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-19 03:55:54 +00:00
Álvaro Brey Vilas
7625275b07
Fix toolbar in PreviewMediaFragment after coming back from sharing fragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:48:17 +01:00
Álvaro Brey Vilas
66125d6a27
FileDisplayActivity: fix coordinator scrolling when opening share details from media preview
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:31:15 +01:00
thelittlefireman
9e7a9b410f
Add scan document feature
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-17 10:10:36 +01:00
Nextcloud bot
ee000f7b4e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-17 03:55:25 +00:00
Tobias Kaminsky
1e33020f80
Merge pull request #9783 from nextcloud/mediaEnhancement
Enhance media tab
2022-02-16 10:42:33 +01:00
Álvaro Brey
f9febe24ad
Fallback pdf viewer (#9806)
* Basic PDF preview

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Preview pdf: add dividers between pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Prefer third-party pdf viewers over fallback viewer

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Zoomable view for pdf pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

pdf preview: Show tip to indicate that zooming on images is possible

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix spotbugs and lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix toolbar when resuming

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewBitmapActivity: add screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix crash in screenshot tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: rename tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* pdf preview: Update copyright headers

Oops

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: use grey for background instead of black

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: add scrollbar

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: show zoom tip 3 times instead of only once

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: fix lint and improve styling

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 15:04:16 +01:00
Tobias Kaminsky
9723c0458e
Merge pull request #9816 from nextcloud/pin
Improve PIN lockout handling
2022-02-15 14:54:08 +01:00
tobiasKaminsky
ea863cd04c
Fix test, satisfy spotbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 14:52:55 +01:00
Álvaro Brey Vilas
df3c98a0c4
PassCodeManager: use abstracted Clock implementation rather than system clock directly
Improves testability

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 11:23:36 +01:00
Álvaro Brey Vilas
aafa7780f6
PassCodeActivity: update lock timestamp when lock has just been set
Prevents asking for pass immediately after setting it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 10:27:11 +01:00
tobiasKaminsky
607d008a75
Make use of upload and creation timestamp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:43:32 +01:00
tobiasKaminsky
3584b90bc6
Show empty message if no results
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:36:52 +01:00
tobiasKaminsky
b2bfd985da
Remove not needed check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:23:50 +01:00
tobiasKaminsky
0624e7eef3
Satisfy CI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 08:37:25 +01:00
Nextcloud bot
ac68a9269e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-15 05:33:30 +00:00
Álvaro Brey Vilas
8b03556f71
PassCodeManager: convert to Kotlin, clean up, use injection
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 18:28:56 +01:00
Álvaro Brey Vilas
579af4ab30
PassCodeManager: don't count passcode/credentials activity towards activity counter
This prevents repetition attacks

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 17:28:46 +01:00
Álvaro Brey
6d6183b3b0
Merge pull request #9208 from nextcloud/flaky-tests-again
Add RetryTestRule to DrawerActivityIT
2022-02-14 11:16:18 +01:00
Álvaro Brey
69033e25e9
Merge pull request #9823 from nextcloud/chore/mockitokotlin2
Chore: replace `com.nhaarman.mockitokotlin2` with `org.mockito.kotlin`
2022-02-14 11:09:47 +01:00
Tobias Kaminsky
b81027d057
Merge pull request #9791 from nextcloud/fix/shares-downloading-crash
FileActivity: fix crash on share operations when FileDetailFragment is second fragment
2022-02-14 09:06:22 +01:00
Tobias Kaminsky
c41f87d281
Merge pull request #9822 from nextcloud/chore/conflicts-dialog-logs
ConflictsResolveActivity: Add log messages when dialog can't be created
2022-02-14 09:00:28 +01:00
Tobias Kaminsky
1d4bc98de7
Merge pull request #9812 from nextcloud/avatarSize
Use 512px for avatar
2022-02-14 08:47:33 +01:00
Tobias Kaminsky
8b0674e29f
Merge pull request #9808 from nextcloud/resumeText
resuming TextEditor after splitting screens works now again
2022-02-14 08:40:09 +01:00
Tobias Kaminsky
541e55ff1c
Merge pull request #9821 from nextcloud/fix/db-upgrade-crash
FileContentProvider: fix crash on certain upgrades
2022-02-14 08:30:47 +01:00
tobiasKaminsky
fa73725815 Pin: use activity paused also, as stopped is sometimes too slow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:30:00 +00:00
tobiasKaminsky
556f856ac3
Update adapter after finish search (success/failure)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
e17beb00ad
Do not show meta info (favorite, download status) in media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
256656af5d
correctly return result
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
307a407631
fix reloading bug
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
07885c3a18
refactor/ clean up
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
5140d8d99f
sql typo
fix not showing images

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
3bfc373e50
Enhance media tab
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:50 +01:00
Nextcloud bot
6b8ce02a2e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-14 03:55:09 +00:00
Nextcloud bot
bbf1032845
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-12 03:55:56 +00:00
Álvaro Brey Vilas
2a6398adda
Chore: replace com.nhaarman.mockitokotlin2 with org.mockito.kotlin
It has been integrated into the main mockito org, and the old ID no longer receives updates

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 18:32:15 +01:00
tobiasKaminsky
e20555f5d0 resuming TextEditor after splitting screens works now again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 16:59:13 +00:00
Álvaro Brey Vilas
c506cda8a6 FileDisplayActivity: ditch secondFragment for FileDetailsFragment, use leftFragment instead
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
d82a989378 FileActivity: fix crash on share operations when FileDetailFragment is second fragment
When a file is downloaded, FileDetailFragment is opened as SECOND_FRAGMENT instead of LIST_OF_FILES, which breaks this logic.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
9cf0f1d6fa
ConflictsResolveActivity: Add log messages when dialog can't be created
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 17:33:58 +01:00
Álvaro Brey Vilas
b5d338fb8d
FileContentProvider: fix crash on certain upgrades
checkIfColumnExists should not use getColumnIndexOrThrow, as it's supposed to check if the index doesn't exist

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 13:57:03 +01:00
tobiasKaminsky
7ddbb65ca2 Use 512px for avatar
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:23 +00:00
tobiasKaminsky
1c9a3e0208 For display with >= 600dp use higher file icon resolution
use this resolution also default thumbnails

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:20 +00:00
Álvaro Brey
4d9c878d4f
Merge pull request #9801 from nextcloud/chore/test-sort-order
Update sorting tests
2022-02-07 09:21:24 +01:00
Nextcloud bot
73c01d1ef4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-07 03:54:38 +00:00
Nextcloud bot
559c41d880
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-05 03:54:13 +00:00
Álvaro Brey Vilas
08e7a761dc
NaturalSortTest: shuffle instead of duplicating parameters
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
64d386786c
Rename TestSorting to OCFileSortTest, conver to Kotlin, parameterize
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
bed01a2f0c
TestSorting: refactor and simplify since it's now only for OCFiles
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:12:52 +01:00
Álvaro Brey Vilas
e7e603f4d8
Move string sort tests from TestSorting to NaturalSortTest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:02:42 +01:00
Álvaro Brey Vilas
d40fc88754
Move TestSorting to unit tests
No reason for it to be an instrumented test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 12:54:45 +01:00
Álvaro Brey Vilas
91297b7ce0
Test AlphanumComparator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 10:49:08 +01:00
Nextcloud bot
927babb3bf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-04 03:55:25 +00:00
Nextcloud bot
c437db409e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 03:55:06 +00:00
Nextcloud bot
dba8da00f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 03:55:45 +00:00
Nextcloud bot
190332ceaa
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-01 03:55:35 +00:00
Álvaro Brey
1ecbf61cc7
Merge pull request #9776 from nextcloud/fix/activity-title
OCFileListFragment: set title when attached to activity
2022-01-31 15:42:16 +01:00
Álvaro Brey
0c5afce10e
Merge pull request #9770 from nextcloud/Valdnet-patch-1
i18n: Change to a capital letter
2022-01-31 13:43:46 +01:00
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-27 17:12:02 +01:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated
Fix crashes and double loading in GalleryFragment when changing dark theme
2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze
Improve freezes in local files screens when folder contains many files
2022-01-27 12:34:35 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00