mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-21 00:12:05 +03:00
Code Issues Projects Releases Packages Wiki Activity
19030 commits 220 branches 1587 tags 639 MiB
Commit graph

432 commits

Author SHA1 Message Date
tobiasKaminsky
9fb607cc9a
also allow export in FileDetailFragment 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 14:06:20 +02:00
tobiasKaminsky
72044454c1
rename last remaining FileDownload occurrences 
early exit in FilesExportWork.kt

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 14:06:20 +02:00
Álvaro Brey
db4e9887b1
FilesExportWork: use getActivity for PendingIntent 
With the broadcast, the notification drawer will not autoclose to show the file browser, which is not good UX.

With this approach the notification will not be autodismissed, but that's the lesser of two evils.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-06 14:06:20 +02:00
tobiasKaminsky
1d69dcfcaa
File export aka "download" 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 14:06:18 +02:00
tobiasKaminsky
3ec348d5f6
recreate StoragePermissionDialogFragment when rotating 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 12:18:52 +02:00
Tobias Kaminsky
6441e5d189
Merge pull request #10392 from nextcloud/encryptedFavorites 
on favorite/recent search: update encrypted files
 2022-07-06 12:13:17 +02:00
tobiasKaminsky
9d80622d23
only encrypt folder if key is setup 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 10:59:08 +02:00
Álvaro Brey
b8800a9906
FileDetailsSharingProcessFragment: avoid crashing when modifying existing shares 
This can only happen on certain codepaths but should be avoided anyway.

Fixes #10480

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-06 09:56:14 +02:00
tobiasKaminsky
5e58fdae4c
fix potential NPE 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-06 09:41:19 +02:00
Álvaro Brey
2e3ac1850b
FileActivity: fix crash when creating share link from FileDetailsFragment 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-06 09:41:14 +02:00
Tobias Kaminsky
d14ba71b10
Merge pull request #10388 from nextcloud/unsetEncryptedFolder 
Only allow folder to unset if not in e2e subtree
 2022-07-06 09:02:32 +02:00
Álvaro Brey
8cc3bd1d41
Merge pull request #10448 from nextcloud/fix/offline-sync-server-ping 
Avoid checking for walled connection until necessary
 2022-07-05 16:44:02 +02:00
Álvaro Brey
c8aa577589
When retrying failing uploads, delay connectivity check until last possible moment 
This avoids network calls if the uploads can't be done for other reason (such as missing files)

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-05 14:52:23 +02:00
Álvaro Brey
a62373efb4
OfflineSyncWork: minor refactor to make more readable 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-05 14:52:23 +02:00
Álvaro Brey
8a0609044f
OfflineSyncWork: remove unused wakelock 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-05 14:52:23 +02:00
Álvaro Brey
b7cf2a5d67
OfflineSyncWork: do not proactively ping server for connectivity unless sync fails 
Co-authored-by: obel1x <obel1x@web.de>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-05 14:52:23 +02:00
tobiasKaminsky
935b71ed86 rebase 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 12:25:23 +00:00
tobiasKaminsky
efa7875dcd explanation of tab count 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 12:25:23 +00:00
tobiasKaminsky
c6681407bf Do not show sharing option at all 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 12:25:23 +00:00
tobiasKaminsky
c8e523b2c1 Do not show sharing tab when folder is encrypted 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 12:25:23 +00:00
Tobias Kaminsky
074b914b5f
Merge pull request #10232 from nextcloud/offlineNavigation 
Fix Notification -> on device navigation path
 2022-07-05 14:21:29 +02:00
Tobias Kaminsky
00bf0f28fb
Merge pull request #10473 from nextcloud/onDeviceWrongMessage 
Shared -> OnDevice -> now correct message
 2022-07-05 10:59:02 +02:00
tobiasKaminsky
a4829d4567
on favorite/recent search: update encrypted files 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 10:57:12 +02:00
tobiasKaminsky
d31ba4b3e6
Only allow folder to unset if not in e2e subtree 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-05 10:44:26 +02:00
Álvaro Brey
e8d2989295
Prevent crash when selecting too many files to copy or move (#10476) 
* Prevent crash when selecting too many files to copy or move

This is caused by too much data in intent extras as we're passing a fat arraylist of objects.
As we only need the paths for the copy operation, change it so that only the paths are passed.

Ideally this would instead be stored in FDA or whatever listener we have for the folder picker,
rather than passed back and forth between the folder picker.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

* Convert FolderPickerActivity to Kotlin (step 1)

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

* FolderPickerActivity: convert to Kotlin step 2

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

* OCFileListFragment: deduplicate copy/move code

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-07-05 07:47:18 +00:00
Tobias Kaminsky
5cdace49ca
Merge pull request #10472 from nextcloud/thumbnailUpdateEnforced 
When thumbnail update enforced, do not use any cached version
 2022-07-04 14:36:43 +02:00
tobiasKaminsky
7ee18b735b
Shared -> OnDevice -> now correct message 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-04 11:45:41 +02:00
tobiasKaminsky
a981db2200
When thumbnail update enforced, do not use any cached version 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-07-04 10:00:28 +02:00
Álvaro Brey
fb8c6f4f23
Merge pull request #10471 from nextcloud/fix-flaky-logger-test 
Fix flaky Logger overflow test
 2022-07-04 09:01:58 +02:00
Nextcloud bot
d6cf7a97a3
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-07-04 04:09:52 +00:00
Chris Narkiewicz
98230e1296
Fix flaky Logger overflow test 
Load event is processed before overlow condition check can
result in warning log line being appended. This resulted
in a race condition.

We simply poll the log file until we either find interesting
log line or we give up after several seconds.

Fixes #10416

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-07-04 00:30:30 +01:00
Álvaro Brey
5cb0056db3
Merge pull request #10457 from nextcloud/dependabot/gradle/androidx.fragment-fragment-ktx-1.5.0 
Bump fragment-ktx from 1.4.1 to 1.5.0
 2022-06-30 11:35:54 +02:00
Álvaro Brey
084abc1a5e
Fix compilation error with new fragment ktx version 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-30 11:00:17 +02:00
Nextcloud bot
a453cf7640
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-30 04:09:30 +00:00
Nextcloud bot
502a936686
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-29 04:14:29 +00:00
Nextcloud bot
0feb695d0d
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-28 04:21:16 +00:00
Álvaro Brey
41639cf654
Remove bytebuddy library dependency 
Only used to generate random strings for tests and creates too many Dependabot PRs.
Let's just use Kotlin for that.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-27 11:47:00 +02:00
Álvaro Brey Vilas
d8b2a21823
Don't try to show share information in Favorites screen 
We don't have that info from the server

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-06-23 11:01:08 +02:00
Nextcloud bot
fa3d0b453f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-21 04:12:30 +00:00
Álvaro Brey
5386aa9229
Merge pull request #10384 from olebittner/master 
Check account in onResume fixing #7887
 2022-06-20 10:19:08 +02:00
Tobias Kaminsky
18ccf68e10
Merge pull request #10393 from nextcloud/fix/10383 
PreviewMediaFragment: prevent NPE on onSaveInstanceState
 2022-06-20 09:35:11 +02:00
Tobias Kaminsky
21458ce512
Merge pull request #10397 from nextcloud/fix/lock-screen-leak 
Lock: ensure underlying activity isn't shown while waiting for lock screen to render
 2022-06-20 08:54:23 +02:00
Tobias Kaminsky
e3e9d73b6b
Merge pull request #10401 from nextcloud/fix/prefill-filename-oob 
ChooseRichDocumentsTemplate: avoid IOOBE if there is no dot in field
 2022-06-20 08:53:06 +02:00
Tobias Kaminsky
c28a0779b5
Merge pull request #10403 from nextcloud/fix/upload_on_low_storage_move 
UploadFilesActivity: fix upload not working when space is insufficient for copy
 2022-06-20 08:49:18 +02:00
Ole Bittner
58cc417ea7
fix ktlint error 
Signed-off-by: Ole Bittner <dev@oleb.it>
 2022-06-16 18:03:58 +02:00
Álvaro Brey
2c45cd04db
FolderPickerActivity: fix search when copying/moving files 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-16 16:56:17 +02:00
Álvaro Brey
2130de152d
UploadFilesActivity: fix upload not working when space is insufficient 
LOCAL_BASE_PATH was missing

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-16 16:26:06 +02:00
Álvaro Brey
b7f7388802
ChooseRichDocumentsTemplate: avoid IOOBE if there is no dot in field 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-16 12:18:40 +02:00
Álvaro Brey
f1f44c4d5d
Lock: ensure underlying activity isn't shown while waiting for lock screen to render 
As lock screen is shown with `startActivityForResult`, which is asynchronous, the activity
can continue rendering while waiting for the lock screen, which leaks details and potentially allows interaction.

To counteract this, immediately hide the root view of the activity while the lock screen is launched.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-15 15:50:26 +02:00
Álvaro Brey
a7877ceb41
Make fast scroll bar and popup use the theme color 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-15 12:33:27 +02:00
Álvaro Brey
31c84d57e9
Merge pull request #10385 from nextcloud/account-culling 
Migrate Account to User in some APIs
 2022-06-14 21:32:49 +02:00
Álvaro Brey
84aa239c9a
Merge pull request #10391 from nextcloud/updateSharIcon 
Update share icon when sharing link directly
 2022-06-14 21:24:11 +02:00
Álvaro Brey
528705a31d
PreviewMediaFragment: prevent NPE on onSaveInstanceState 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-14 17:14:22 +02:00
Álvaro Brey
17ebc23621
Merge pull request #10377 from nextcloud/groupfolderCannotBeEncrypted 
Groupfolders cannot be encrypted
 2022-06-14 16:00:36 +02:00
tobiasKaminsky
d971bc849c
Update share icon when sharing link directly 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-06-14 08:46:20 +02:00
Nextcloud bot
9a1158d5a0
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-14 04:18:12 +00:00
Chris Narkiewicz
edc8149c1f
Migrate Account to User in some APIs 
Migrate remaining Account uses to User model when it was
possible without wider refactoring.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-06-13 23:37:16 +01:00
Ole Bittner
53ce285aac
test onResume account check in SessionMixin 
Signed-off-by: Ole Bittner <dev@oleb.it>
 2022-06-13 23:28:35 +02:00
Ole Bittner
190cd24d3a
check for account in onResume mixin 
Signed-off-by: Ole Bittner <dev@oleb.it>
 2022-06-13 23:28:20 +02:00
tobiasKaminsky
60757a1853
Groupfolders cannot be encrypted 
added test showing folder types

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-06-13 16:17:28 +02:00
Tobias Kaminsky
7854d48559
Merge pull request #10367 from nextcloud/moveMD5 
move md5 function to tests, as md5 should never be used is production
 2022-06-13 14:38:10 +02:00
Álvaro Brey
43215a0833 FileDetailsSharingProcessFragment: clean up last detekt issues 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-13 10:51:38 +00:00
Nextcloud bot
c56ccc8363
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-12 04:18:20 +00:00
Álvaro Brey
d432c8e46f
Merge pull request #10359 from nextcloud/enterCreatedFolder 
When copy/move a file and creating a new folder we now go directly into this freshly created folder
 2022-06-10 15:58:52 +02:00
Álvaro Brey
0f8a5b1bf3
Merge pull request #10353 from nextcloud/fix/invalid-folder-no-mediascan 
FileDataStorageManager: don't add files to media scan in android 11+
 2022-06-10 15:56:40 +02:00
Álvaro Brey
ede4790927
Merge pull request #10352 from nextcloud/fix/oob-gallery-scroll 
GalleryFastScrollViewHelper: fix index out of bounds in getScrollOffset
 2022-06-10 13:59:59 +02:00
tobiasKaminsky
ffdb26b4be
move md5 function to tests, as md5 should never be used is production 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-06-10 07:57:44 +02:00
Álvaro Brey
e644b12aee
Merge pull request #10355 from nextcloud/fix/synced-folders-adapter-performance 
SyncedFoldersActivity: don't refresh entire adapter when toggling a folder from dialog
 2022-06-09 11:44:07 +02:00
Tobias Kaminsky
266e45b098
Merge pull request #10343 from nextcloud/fix/community-report 
Use different link for automated bugreport and manual report
 2022-06-09 09:50:52 +02:00
tobiasKaminsky
67cb25a603
When copy/move a file and creating a new folder we now go directly into this freshly created folder 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-06-09 09:12:32 +02:00
Nextcloud bot
5538a5e734
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-09 04:22:28 +00:00
Álvaro Brey
fb4eaf11ff
SyncedFoldersActivity: don't refresh entire adapter when toggling a folder from dialog 
It's enough to refresh its header, and it doesn't have to refresh all pictures

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-08 16:54:20 +02:00
Álvaro Brey
306bcb09ef
Merge pull request #10348 from nextcloud/file-uploader-downloader-migration-to-user 
Migrate some FileUploader and FileDownloader APIs to User
 2022-06-08 09:38:50 +02:00
Nextcloud bot
f6bb42141e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-08 04:24:38 +00:00
Chris Narkiewicz
1d81a705bf
Migrate some FileUploader and FileDownloader APIs to User 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-06-07 20:56:43 +01:00
Álvaro Brey
c9933d558e
FileDataStorageManager: don't add files to media scan in android 11+ 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-07 10:20:17 +02:00
Álvaro Brey
301d9ae9a9
GalleryFastScrollViewHelper: fix index out of bounds in getScrollOffset 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-07 10:03:12 +02:00
Álvaro Brey
5944bfabdd
Merge pull request #10209 from nextcloud/migrate-remote-operation-execute-to-user 
Migrate RemoteOperation.execute calls to User
 2022-06-06 13:10:37 +02:00
Álvaro Brey
6f6bed084c
Use different link for automated bugreport and manual report 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-06 10:02:55 +02:00
Nextcloud bot
721f63971a
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-06 04:25:53 +00:00
Chris Narkiewicz
35e164fa2d
Migrate RemoteOperation.execute calls to User 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-06-04 23:59:50 +01:00
Nextcloud bot
bd5a99a10e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-04 04:22:45 +00:00
Tobias Kaminsky
3fd8928327
Merge pull request #10307 from nextcloud/fix/choosetemplate-button-nullpointer 
Fix NPE in ChooseTemplateDialogFragment
 2022-06-03 07:29:32 +02:00
Álvaro Brey
4011fa7b7d
Exclude all activities except AuthenticatorActivity from security key listener (#10311) 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-06-03 07:28:27 +02:00
Álvaro Brey
0767e4fe43 GalleryAdapter: cleanup index out of bounds 2022-06-01 07:28:17 +00:00
tobiasKaminsky
0748ba19af Harden thumbnail generation 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-06-01 07:28:17 +00:00
Nextcloud bot
d971d0a619
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-01 04:24:28 +00:00
Álvaro Brey
51aa8cbd35 ChooseTemplateDialogFragment: convert to Kotlin 
Since I'm here...

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-31 09:34:18 +00:00
Álvaro Brey
3ce883466b Fix NPE in ChooseTemplateDialogFragment.checkEnablingCreateButton 
This method can be called before positiveButton is initialized

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-31 09:34:18 +00:00
Nextcloud bot
d51a9426d4
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-27 04:16:05 +00:00
Nextcloud bot
a13c4c1906
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-26 04:16:47 +00:00
Tobias Kaminsky
c1cf416872
Merge pull request #10148 from nextcloud/proseMirror 
Test proseMirror with custom user agent
 2022-05-25 15:40:54 +02:00
Nextcloud bot
78e689b2f1
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-25 04:51:04 +00:00
Nextcloud bot
2a3bc3b0dc
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-24 04:30:55 +00:00
Nextcloud bot
ea16420d37
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-23 04:15:15 +00:00
Nextcloud bot
748f2ac903
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-22 04:17:24 +00:00
tobiasKaminsky
8bd3243238
Do not set custom user agent for Text/ProseMirror 
Use EditorUtils

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-20 11:39:38 +02:00
tobiasKaminsky
6a4c4c0b28
Project_id is needed 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-19 09:54:03 +02:00
Nextcloud bot
294db08117
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-16 04:11:57 +00:00
Nextcloud bot
f3b80053f6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-15 04:11:12 +00:00
Tobias Kaminsky
bd4b35d41b
Merge pull request #10228 from nextcloud/fix/getpopuptext-crash 
OCFileListAdapter: skip popup text generation if no sortOrder is present
 2022-05-12 12:22:27 +02:00
Álvaro Brey
b2630f532a
SetStatusDialogFragment: fix EmojiPopup after API changes 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-12 09:29:12 +02:00
tobiasKaminsky
6704bb0427
Fix Notification -> on device navigation path 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-12 09:26:14 +02:00
Álvaro Brey
0a1736dc75
OCFileListAdapter: skip popup text generation if no sortOrder is present 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-11 15:28:29 +02:00
Nextcloud bot
4cab92f48e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-10 04:24:14 +00:00
Álvaro Brey
e7ea566bb6
Merge pull request #10217 from nextcloud/fix/on-device-crash 
Fix crash when navigating from Gallery to On device
 2022-05-09 15:03:34 +02:00
Álvaro Brey Vilas
62d58d0a36
Fix and enable FDAScreenshotIT.showMediaThenAllFiles 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-09 13:24:33 +02:00
Álvaro Brey
1955e46a10
Fix crash when navigating from Gallery to On device 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-09 13:15:36 +02:00
Álvaro Brey
91efa194c1
Merge pull request #10191 from nextcloud/fix/some-detekt 
Fix a bunch of Detekt issues
 2022-05-09 10:04:47 +02:00
Álvaro Brey
454f7c6b96
Merge pull request #10168 from pelzvieh/patch-1 
Make SAF root IDs stable through server version updates
 2022-05-09 10:03:27 +02:00
tobiasKaminsky
c0c094c30e
Play video in gallery 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-09 08:17:12 +02:00
Nextcloud bot
0649f787b8
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-09 04:12:54 +00:00
Nextcloud bot
55cffc80d1
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-08 04:11:49 +00:00
Nextcloud bot
51eb6e8620
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-07 04:09:35 +00:00
Álvaro Brey
8ef80aa105
Fix DocumentsStorageProviderIT for new root ID 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 18:16:11 +02:00
Álvaro Brey
fb1469aeea
UriUtils: refactor to keep detekt happy 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 18:06:51 +02:00
Álvaro Brey
6297742f01
SyncedFoldersActivity: suppress detekt warning 
This entire class is legacy and should be refactored

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 18:00:01 +02:00
Álvaro Brey
a6dc89a8e5
ShareeListAdapterTest: refactor to fix detekt issues 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 17:57:56 +02:00
Álvaro Brey
7adadbb53c
SetStatusDialogFragment: some easy & safe cleanups 
Make detekt happy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 17:57:43 +02:00
Álvaro Brey
9cff9725fc
HttpStreamFetcher: reduce nesting in loadData 
Make detekt happy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 17:22:18 +02:00
Álvaro Brey
02f23f326d
DocumentsStorageProvider: hash the accountName for rootId map 
This should handle the fact that accountNames are of arbitrary length

MD5 is fine for this, as it should be quicker than SHA and the chance of collisions here is very low

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 17:05:53 +02:00
Álvaro Brey
3b3d23ff0a
DocumentsStorageProvider: fix build error due to missing import 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 17:05:34 +02:00
pelzvieh
43c4876ef3
Update app/src/main/java/com/owncloud/android/providers/DocumentsStorageProvider.java 
Co-authored-by: Álvaro Brey <alvaro.brv@gmail.com>
 2022-05-06 16:11:50 +02:00
Tobias Kaminsky
8d4ed0a862
Merge pull request #10181 from nextcloud/videoFullscreenPause 
Correctly obey play/pause state
 2022-05-06 14:43:43 +02:00
Álvaro Brey
b950be1f7d
Merge pull request #10178 from nextcloud/galleryLongRunning 
Media search improvement
 2022-05-06 13:47:09 +02:00
Álvaro Brey
ac208945e8
DocumentsStorageProvider: key can't be parsed into Int, since it's String now 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 13:13:50 +02:00
Álvaro Brey
8a9a9ec66d
GallerySearchTask: remove leftover testing code 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-06 13:04:50 +02:00
Álvaro Brey
27be297146
Merge pull request #10179 from nextcloud/throttleShareOverflowMenu 
Throttle click on share icon
 2022-05-06 12:55:50 +02:00
Álvaro Brey
db85ebba94
Merge pull request #10174 from nextcloud/new-fastscroll-lib 
Fast scrolling fixes
 2022-05-06 12:08:06 +02:00
Andreas Feldner
04a0ce1e71 Update DocumentsStorageProvider.java 
Change root id for an nextcloud account to urlencoded user@uri. This is to avoid issues with unstable hashCodes.
 2022-05-06 10:24:45 +02:00
Andreas Feldner
805ec3e61a Revert "Make Server's hashCode stable vs. version changes" 
This reverts commit 5627e92619.
 2022-05-06 09:17:32 +02:00
tobiasKaminsky
d33d5a20fd
Throttle click on share icon 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-06 09:11:10 +02:00
tobiasKaminsky
f34fff62a8
Fix #10176 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-05-06 07:55:29 +02:00
Nextcloud bot
73a18fbf6e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-06 04:11:46 +00:00
Álvaro Brey
ea4222a1ae
FileDisplayActivity: fix appbar for fast scroll 
Adds padding at the bottom if appbar is not collapsed

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-05 15:51:58 +02:00
Álvaro Brey
09b95951c5
Fix fast scroll in gallery 
Gallery has a grid layout + variable row height (due to section titles)

This is a no-no in all fastscroll libraries. However, the new one supports writing custom logic
to handle this, which is what this commit is.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-05 15:51:58 +02:00
Tobias Kaminsky
d374d87c24
Merge pull request #10163 from nextcloud/fix/previewmedia-exoplayer-null 
PreviewMediaFragment: prevent crash due to onStop called before exoplayer initialization
 2022-05-05 15:28:03 +02:00
Álvaro Brey
12312393b2
Replace fastscroll library 
Smoother scrolling

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-05 11:03:00 +02:00
Nextcloud bot
d6f6f36d52
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-05 04:12:34 +00:00
pelzvieh
5627e92619
Make Server's hashCode stable vs. version changes 
Bug #9906 seems to be triggered by a version change of the nextcloud server the client is connected to. It appears the most logical solution to make nextcloud object IDs stable against server version changes. These object IDs are derived from the User object using account/anonymous, and the referenced Server object. Providing a hashCode function in Server that ignores the server's version therefore provides stability of object IDs. This seems safe to do, as an URI is already designed to be an identificator.
 2022-05-04 17:40:32 +02:00
Álvaro Brey
aac4a0cd67
PreviewMediaFragment: prevent crash due to onStop called before exoplayer initialization 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-04 11:23:54 +02:00
Nextcloud bot
1924041e4b
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-04 04:19:43 +00:00
Nextcloud bot
76ab52499d
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-03 04:11:34 +00:00
Álvaro Brey
3c97b4b619
Merge pull request #10133 from nextcloud/fix/more-scrolling-bugs 
Fix contents cut off when scrolling is locked
 2022-05-02 18:10:53 +02:00
Álvaro Brey
f0b77e5751
Merge pull request #10052 from nextcloud/file_locking 
File locking
 2022-05-02 17:19:49 +02:00
Álvaro Brey
26aef8e462
Merge pull request #10134 from nextcloud/fix/dagger-mediacontrolview 
Fix theme utils injection in custom views
 2022-05-02 17:19:30 +02:00
Álvaro Brey
d34d3b419a
Fix mocking in FileMenuFilterIT 
Not sure why this wasn't a compilation error

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-02 15:43:12 +02:00
Álvaro Brey Vilas
81ce812d86
Fix some licenses 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
3eb3079757
Fix spotbugs 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f079f030cf
Remove unused resources 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f50d9f8451
Add test for FileMenuFilter that verifies file locking menu items 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
6d40f25f29
Add unit tests for FileLockingHelper 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
2cd2e29b86
FileMenuFilter: don't show lock options if there's no locking capability 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
db30142ad3
Fix lock info in actionMode menu when selecting a single, locked, file 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f8ad9ae413
FileMenuFilter: don't show move, remove or rename options when file is locked 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
d90083fc07
Show file lock info in actions menu instead of separate dialog 
Requested by design team

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
46ccddcef4
Combine lock indicator with overflow icon 
Requested by design

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a902fb6f84
FileMenuFilter: properly filter lock/unlock depending on lock status 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a88b03a0c8
Show lock details when tapping on lock indicator 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
68b2535481
Retrieve and persist more locking attributes from remote files 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
356db04aa8
Add ability to toggle file lock from file context menu 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
fd2435379a
FileDataStorageManager: small cleanup 
- Remove two unused methods
- Make some fields final

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
f5ecaf91d1
Show file locking status on list 
Also includes a refactor of how ContentValues are created in FileDataStorageManager.

The code for that was triplicated. now it's not.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
b8cf8dade8
Store file locking capability 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 12:49:36 +02:00
Álvaro Brey
9a2cbcbba4
FileDisplayActivity: wait until OCFileListFragment is initialized to trigger browseToRoot() 
This solves a bug which caused a "Directory does not exist" popup when coming back from Gallery,
as it tried to call browseToRoot on GalleryFragment due it being executed before the fragment transaction.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-05-02 11:02:46 +02:00
Álvaro Brey Vilas
13e061e7d7 PreviewMediaFragment: Remove margin from top bar 
Not needed since previous commit fixing scroll bugs, creates unwanted space

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 07:55:34 +00:00
Álvaro Brey Vilas
7a2c735795 Fix contents cut off when scrolling is locked 
Don't need to touch the coordinator params, just set scroll flags properly

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-05-02 07:55:34 +00:00
Nextcloud bot
ddb96e7b17
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-01 04:10:03 +00:00
Álvaro Brey Vilas
2560d1be3c
Inject ThemeColorUtils into ThemeableSwitchPreference too 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 16:56:56 +02:00
Álvaro Brey Vilas
b58749d459
Fix ThemeUtils injection for MediaControlView 
Inflation of this view was failing as there was no proper constructor

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 16:50:35 +02:00
Álvaro Brey Vilas
7e31a71ba0 FileDetailsSharing: Preserve selected date when recreating expiration date dialog 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
85dcbe542e FileDetailsSharingProcess: force recreation of date picked on config changes 
See added comment for details

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
8c2fc3ee87 ExpirationDatePickerDF: customize buttons on onStart instead of showing dialog on onCreate 
That is how DialogFragment is supposed to work

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
4ff54bb48b Fix and update testBottomSheet screenshot test 
We can't edit the capability in FDA directly

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
bdd1daa10e SyncFileNotEnoughSpaceDialogFragment needs injector 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
e023cedd7f Fix GalleryAdapterTest 
GalleryAdapter needs theme stuff now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
3ff35d46e6 Fix some spotbugs stuff 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
56584c06e6 Fix detekt 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
42c28dce70 ThemeModule: convert to Kotlin and fix copyright 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
tobiasKaminsky
17828cb3b4 remove some spotbugs warnings 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
f627f3d976 Fix injection ofr RenameFileDialogFragment 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
6bd7d808f4 Put OCFileListBottomSheetDialog into a DialogFragment 
Can't inject things into a Dialog

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:13 +00:00
tobiasKaminsky
74e17ee7c6 Fixes after rebase 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fix after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-04-29 06:38:13 +00:00
Álvaro Brey Vilas
75cb8a767c Remove SyncedFoldersActivity.java 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-29 06:38:13 +00:00
tobiasKaminsky
349a045b46 Move all Theme classes to DI 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-04-29 06:38:13 +00:00
Nextcloud bot
0a802b51da
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-04-29 04:11:37 +00:00
Álvaro Brey
c81c1c83aa
Merge pull request #10117 from nextcloud/chore/screenshot-test-reliability 
Screenshot tests reliability improvements
 2022-04-28 14:05:23 +02:00
Álvaro Brey Vilas
bc44b2c524
PasscodeActivityIT: add short sleep after closing keyboard 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-28 11:09:19 +02:00
tobiasKaminsky
73bb12f78a Parallel thumbnail fetching 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-04-28 08:10:54 +00:00
Álvaro Brey Vilas
011d6c3ceb
ActivitiesActivityIT.error: more sleep 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-28 09:03:35 +02:00
Álvaro Brey Vilas
236925de99
Screenshot tests reliability improvements 
Add more sleeps to SetupEncryptionDialogFragment.error and TrashBinActivity.empty, which fail frequently

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-28 09:03:29 +02:00
Álvaro Brey Vilas
d79b20dbc5
ActivitiesPresenterTest: Activity no longer has empty constructor 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-27 19:02:43 +02:00
Álvaro Brey Vilas
98177e3eb3
Fix crash in screenshot test due to changes in library 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-27 19:02:26 +02:00
Álvaro Brey Vilas
dd4a69d58c
LoginIT: convert to Kotlin 
While we're at it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-26 09:51:39 +02:00
Álvaro Brey Vilas
85b5bf6875
Fix LoginIT submit click 
In latest Nextcloud version the "submit" button does not have an ID, but we can use the type for selection

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-04-26 09:45:32 +02:00
Nextcloud bot
bd139f1afb
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-04-26 04:11:10 +00:00
Álvaro Brey
d45e12c2b8
Merge pull request #10089 from nextcloud/remove-account-usage-from-manage-acconuts-activity 
Remove account use from ManageAccountsActivity
 2022-04-25 16:47:34 +02:00
Nextcloud bot
98075eba14
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-04-24 04:13:03 +00:00
Chris Narkiewicz
042c3758ac
Remove account use from ManageAccountsActivity 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-04-23 16:49:13 +01:00
Nextcloud bot
14aac48b90
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-04-23 04:00:20 +00:00