It is almost always a mistake to compare two instances of java.lang.String using reference equality == or !=, because it is not comparing actual value but locations in memory.
Signed-off-by: ardevd <edvard.holst@gmail.com>
- add svg, convert to android xml, removed png
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
renamed user -> ic_user (icon)
make favorite mutable
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
replace further png resources with xml drawables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fixes after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
allow for vector compat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
add missing icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
add yet another missing icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
lint: When using VectorDrawableCompat, you need to use app:srcCompat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
lint: When using VectorDrawableCompat, you need to use app:srcCompat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fix lint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
improve findbugs score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
use correct icon for user account settings within drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
icons needs to be grey600 by default, don't tint grey600 to not tint avatars
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
programmatically set in-View drawables, in-view drawables can't be set via XML when supporting pre-lollipop
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: Useless parentheses & organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: useless paranthesis
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
revert programmatically set
do not use vectorDrawables.useSupportLibrary
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
use 128dp for talk
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"
This reverts commit 80068e7d37f3a8c6b7096c51543bda68443e4341.
Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"
This reverts commit 0130e9a96d2602ad4b5d33aae67f34a458366d70.
revert srcCompat
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. try-with-resources does this for you automatically.
Signed-off-by: ardevd <edvard.holst@gmail.com>
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.
Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
Signed-off-by: ardevd <edvard.holst@gmail.com>
it seems the `capability` object can be null. In which case it is probably a bad idea to pass a null object into `getRichDocumentsDirectEditing()`.
Signed-off-by: ardevd <edvard.holst@gmail.com>
The `mAuthTokenType` variable is declared and assigned a null value but no value is subsequently assigned, making the null check later on redundant. The `AccountAuthenticator.KEY_AUTH_TOKEN_TYPE` extra value should therefore be assigned the `mAuthTokenType` value I'm assuming.
Signed-off-by: ardevd <edvard.holst@gmail.com>
The `mAuthTokenType` variable is declared and assigned a null value but no value is subsequently assigned, making the null check later on redundant. The `AccountAuthenticator.KEY_AUTH_TOKEN_TYPE` extra value should therefore be assigned the `mAuthTokenType` value I'm assuming.
