Commit graph

14390 commits

Author SHA1 Message Date
tobiasKaminsky
221d3cc327
fix crash when sorting in folder picker
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 15:55:00 +01:00
Andy Scherzinger
f7ffbe689f
Merge pull request #5608 from nextcloud/accountSwitchingTest
Fix account switching
2020-03-11 14:13:56 +01:00
tobiasKaminsky
c771db8bb5
Add missing @ for test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 11:07:20 +01:00
Andy Scherzinger
2a57580cc7
Merge pull request #5624 from nextcloud/gradleWrapperValidation
Gradle wrapper validation
2020-03-11 10:50:09 +01:00
tobiasKaminsky
65e3c66d14
See: https://github.com/gradle/wrapper-validation-action
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 08:43:06 +01:00
Nextcloud bot
7cdf890bf4
[tx-robot] updated from transifex 2020-03-11 03:31:14 +00:00
Andy Scherzinger
4920991618
Merge pull request #5617 from nextcloud/allFiles
All files shows root again
2020-03-11 00:00:59 +01:00
Andy Scherzinger
e891411a56
Merge pull request #5614 from nextcloud/postEncoding
Use UTF8 PostMethod everywhere
2020-03-10 22:52:20 +01:00
Andy Scherzinger
b97df4eb08
Merge pull request #5616 from nextcloud/darkModeActiveItem
Improve readability on active drawer item
2020-03-10 22:40:34 +01:00
tobiasKaminsky
25a67fe4cb
All files shows root again
annotated functions with correct NonNull

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 11:56:34 +01:00
tobiasKaminsky
92dd3a0e94
Improve readability on active drawer item
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 11:18:11 +01:00
Andy Scherzinger
43977198f2
Merge pull request #5611 from nextcloud/staleBot
Stale bot shall close only bugs with "need info" and no reply
2020-03-10 11:18:05 +01:00
tobiasKaminsky
adae2e48da
Use UTF8 PostMethod everywhere
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 10:42:51 +01:00
tobiasKaminsky
4ce2729a8f
Adjust test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 10:07:10 +01:00
Tobias Kaminsky
d5e1209d00
Merge pull request #5607 from nextcloud/viewBinding
Use view bindings: https://developer.android.com/topic/libraries/view-binding
2020-03-10 09:58:27 +01:00
tobiasKaminsky
9ead4432e8
manually increase spotbug/lint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 09:21:00 +01:00
tobiasKaminsky
b0234d895e
Update contributing.md
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 07:24:57 +01:00
tobiasKaminsky
d741ca7724
stale bot: close only bugs with "need info"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 07:23:34 +01:00
Nextcloud bot
9710a8a863
[tx-robot] updated from transifex 2020-03-10 03:30:49 +00:00
tobiasKaminsky
14f6353cb3
Integration test for account switching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 15:39:35 +01:00
tobiasKaminsky
593b684d4d
Use view bindings: https://developer.android.com/topic/libraries/view-binding
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 11:34:19 +01:00
Andy Scherzinger
cedb397566
Merge pull request #5605 from nextcloud/fixNPEonRestoreSharingFragment
Fix NPE on restoring file detail sharing fragment
2020-03-09 09:38:09 +01:00
tobiasKaminsky
8e45d953f1
Fix NPE on restoring file detail sharing fragment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 08:51:23 +01:00
Nextcloud bot
19333cef78
[tx-robot] updated from transifex 2020-03-09 03:25:08 +00:00
Nextcloud bot
e32364d2fd
[tx-robot] updated from transifex 2020-03-08 03:30:50 +00:00
Nextcloud bot
a52277e5c0
[tx-robot] updated from transifex 2020-03-07 03:28:49 +00:00
Andy Scherzinger
3598ed75a3
Merge pull request #5595 from nextcloud/dependabot/gradle/pl.droidsonroids.gif-android-gif-drawable-1.2.19
Bump android-gif-drawable from 1.2.15 to 1.2.19
2020-03-06 13:44:33 +01:00
Andy Scherzinger
770f5264fc
Merge pull request #5596 from nextcloud/dependabot/gradle/org.mockito-mockito-android-3.3.1
Bump mockito-android from 3.3.0 to 3.3.1
2020-03-06 13:35:49 +01:00
dependabot-preview[bot]
8e5fc8ea9c
Bump android-gif-drawable from 1.2.15 to 1.2.19
Bumps [android-gif-drawable](https://github.com/koral--/android-gif-drawable) from 1.2.15 to 1.2.19.
- [Release notes](https://github.com/koral--/android-gif-drawable/releases)
- [Changelog](https://github.com/koral--/android-gif-drawable/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/koral--/android-gif-drawable/compare/v1.2.15...v1.2.19)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-06 12:19:19 +00:00
Andy Scherzinger
12d4a93144
Merge pull request #5594 from nextcloud/feature/minSdk17
change minimum supported Android version to 4.2
2020-03-06 13:16:59 +01:00
dependabot-preview[bot]
54889cb418
Bump mockito-android from 3.3.0 to 3.3.1
Bumps [mockito-android](https://github.com/mockito/mockito) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v3.3.0...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-06 12:06:41 +00:00
Andy Scherzinger
03c586bd94
remove unused dimens value
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:39 +01:00
Andy Scherzinger
be4efdd8ce
remove unneeded call
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:38 +01:00
Andy Scherzinger
37cc49b2d0
use correct dimens id
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:38 +01:00
Andy Scherzinger
3cfec4e0ba
remove sdk17 checks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:37 +01:00
tobiasKaminsky
7a6ae44d77
Remove outdated right/left as now only start/end is needed
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-06 12:49:36 +01:00
Andy Scherzinger
4a6f5b2da7
change minimum supported Android version to 4.2
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:36 +01:00
Andy Scherzinger
b960e9c9ba
Merge pull request #5584 from nextcloud/dependabot/gradle/androidx.work-work-runtime-ktx-2.3.3
Bump work-runtime-ktx from 2.3.2 to 2.3.3
2020-03-06 12:46:41 +01:00
Tobias Kaminsky
581c12a867
Merge pull request #5546 from nextcloud/ezaquarii/migrations-manager
Migrations manager
2020-03-06 12:25:23 +01:00
dependabot-preview[bot]
4a957714ea
Bump work-runtime-ktx from 2.3.2 to 2.3.3
Bumps work-runtime-ktx from 2.3.2 to 2.3.3.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-06 11:06:50 +00:00
Andy Scherzinger
232c801c9f
Merge pull request #5569 from nextcloud/removeUnusedClass
remove unused class
2020-03-06 12:03:37 +01:00
Andy Scherzinger
11aa3e1575
master is at 94 lint warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 11:10:30 +01:00
tobiasKaminsky
5872a973a7
Bump after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-06 10:36:10 +01:00
Chris Narkiewicz
1ba288e5e6
Properly signal error when user id migration fails
Previous implementation was returning success status
when *any* account was migrated, despite possible
failures.

Return error when any account fails to be migrated.

The migration remines idempotent and can be re-run
again, until if finally succeeds.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
9ef27576e1
Enabled migration manager in MainApp
Migration manager added to DI.

Migration manager called in place of legacy migration code.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
439dd4ff78
Removed MigrationManager Robolectric tests
Robolectric tests are removed as we don't want to emulate
platform.

Renamed instrumentation tests to match expected naming.

Updated detekt rule to allow human readable test function
names in kt files. This naming convention was adopted in
test code to enable human-readable test reports, but
DEX does not support spaces in names. Underscore _ is
a good replacement providnig similar level of readability.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
1ab8d98d85
Support for optional migrations
Optional migrations care not causing migration failure
and can be applied again on next application run.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
b87bf1f10e
Migrations manager
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:56 +01:00
Andy Scherzinger
98e4acc75a
remove ununsed raw files
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 09:59:35 +01:00
tobiasKaminsky
793dd901a2
remove unused class
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-06 09:59:34 +01:00