Commit graph

1187 commits

Author SHA1 Message Date
Álvaro Brey
dd8a70262e FileEntity: fix parent and contentLength types
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
71180412f9 Use Room/DAO for getFileById
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
32a7120610 Old implementation of getFolderContent ordered results by file name
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
45b9006068 Convert NULL values for integer/long columns to 0 (SpotBugs)
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
1d44674d83 Seems that timestamps need Long rather than Int
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
092a3051df Missing newline (detekt)
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Dariusz Olszewski
cdeff1696b Use Room/DAO for getFolderContent
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-12-13 23:28:15 +01:00
Álvaro Brey
cd36721f2b
Merge pull request #11156 from nextcloud/dependabot/gradle/com.google.firebase-firebase-messaging-23.1.1
Bump firebase-messaging from 23.1.0 to 23.1.1
2022-12-13 17:38:31 +01:00
Álvaro Brey
6284acebc4
Merge pull request #11151 from nextcloud/dependabot/gradle/androidx.fragment-fragment-ktx-1.5.5
Bump fragment-ktx from 1.5.4 to 1.5.5
2022-12-13 17:33:32 +01:00
Álvaro Brey
c0788b11b0
Merge pull request #11139 from nextcloud/doNotDeleteEncryptedFolder
Encrypted folder cannot be deleted, must first unset encryption
2022-12-13 16:57:42 +01:00
Nextcloud bot
3c945f6fb2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-13 03:44:38 +00:00
Nextcloud bot
1d026aae34
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-13 03:44:22 +00:00
Tobias Kaminsky
dcfd42e5b9 daily dev 20221213 2022-12-13 02:35:54 +01:00
Tobias Kaminsky
eba4cc8404 Merge remote-tracking branch 'origin/master' into dev 2022-12-13 02:31:01 +01:00
dependabot[bot]
9f4d59b3e3
Bump firebase-messaging from 23.1.0 to 23.1.1
Bumps firebase-messaging from 23.1.0 to 23.1.1.

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-messaging
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-12 14:11:09 +00:00
Álvaro Brey
66c617828a
Merge pull request #11124 from nextcloud/fix/upload-worker-infinite-loop
Fix infinite loop in upload worker
2022-12-12 13:14:20 +01:00
Álvaro Brey
396b920d4f
Merge pull request #11119 from nextcloud/fix/fullscreen-dialog-insets-android9
PreviewVideoFullscreenDialog: fix immersive mode logic
2022-12-12 12:46:27 +01:00
Nextcloud bot
84754790bd
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-12 03:31:14 +00:00
Nextcloud bot
022b076ec0
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-12 03:30:56 +00:00
Nextcloud bot
45d1183749
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-11 03:42:48 +00:00
Nextcloud bot
700d9806c8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-11 03:42:33 +00:00
Nextcloud bot
cfcf6036ab
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-10 03:38:56 +00:00
Nextcloud bot
35e4dec024
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-10 03:38:39 +00:00
Nextcloud bot
6dd923a69d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-09 03:47:31 +00:00
Nextcloud bot
1a3e4d4b7a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-09 03:47:17 +00:00
Nextcloud bot
2d2d01e472
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-08 03:32:24 +00:00
Nextcloud bot
31736039d9
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-08 03:32:07 +00:00
dependabot[bot]
41b59e19f7
Bump fragment-ktx from 1.5.4 to 1.5.5
Bumps fragment-ktx from 1.5.4 to 1.5.5.

---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-08 02:01:54 +00:00
Tobias Kaminsky
030b59785b daily dev 20221208 2022-12-08 02:37:25 +01:00
Tobias Kaminsky
a07e8e05a4 Merge remote-tracking branch 'origin/master' into dev 2022-12-08 02:31:45 +01:00
tobiasKaminsky
7235a8dcf6
For our daily build on F-Droid we cannot add our document scanning
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-07 14:56:14 +01:00
Nextcloud bot
a6cdde372a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-07 03:32:43 +00:00
Nextcloud bot
041568d0ce
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-07 03:32:27 +00:00
Tobias Kaminsky
f1a9940725 daily dev 20221207 2022-12-07 02:38:14 +01:00
Tobias Kaminsky
6e4697b867 Merge remote-tracking branch 'origin/master' into dev 2022-12-07 02:31:40 +01:00
Tobias Kaminsky
0e50595345
Merge pull request #11093 from nextcloud/bottomsheet-style-improvement
"Add to nextcloud" bottom sheet: add drag handle and style title
2022-12-06 08:21:16 +01:00
Tobias Kaminsky
b40f7f6e0b
Merge pull request #11122 from nextcloud/fixTemplateId
Template id must be long, as it is fileID, which can be very big
2022-12-06 08:15:19 +01:00
Álvaro Brey
006c5b49d5
"Add to nextcloud" bottom sheet: add drag handle and style title
This brings the title in line with the other bottom sheet, and looks better IMO.

The DragHandleView is recommended for accesibility.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-06 07:56:18 +01:00
Nextcloud bot
ff9b37c795
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-06 03:40:09 +00:00
Nextcloud bot
b28a33c142
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-06 03:39:52 +00:00
tobiasKaminsky
1d62ee7835
Encrypted folder cannot be deleted, must first unset encryption
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-05 09:43:40 +01:00
Nextcloud bot
dea0b2e782
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-05 03:28:16 +00:00
Nextcloud bot
57ef92fc4e
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-05 03:27:59 +00:00
Nextcloud bot
e6785d4d91
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-04 03:27:41 +00:00
Nextcloud bot
f81ae6db1c
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-04 03:27:24 +00:00
Nextcloud bot
13f6d36c40
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-03 03:27:55 +00:00
Nextcloud bot
2449b8dfff
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-03 03:27:35 +00:00
Tobias Kaminsky
bbffd188be daily dev 20221203 2022-12-03 02:40:05 +01:00
Tobias Kaminsky
5fe940c797 Merge remote-tracking branch 'origin/master' into dev 2022-12-03 02:32:42 +01:00
Álvaro Brey
f403b25599 SettingsActivity: Better error message when davdroid login fails
Server URI is not the only problem that can happen here.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-02 12:36:14 +00:00
Álvaro Brey
aa938747ff
Merge pull request #11106 from nextcloud/throttleSetup
show only one setup dialog, prevents strange situation on double tapping
2022-12-02 11:31:56 +01:00
Nextcloud bot
401086cc71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-02 03:29:14 +00:00
Nextcloud bot
cc695a2a47
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-02 03:28:57 +00:00
Tobias Kaminsky
802232ded9 daily dev 20221202 2022-12-02 02:41:36 +01:00
Tobias Kaminsky
132db0ada1 Merge remote-tracking branch 'origin/master' into dev 2022-12-02 02:33:31 +01:00
Álvaro Brey
84044905d1
UploadsStorageManager: remove in-memory limit for queries
Only added for FilesUploadWorker workaround that is no longer used

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 17:00:02 +01:00
Álvaro Brey
f425045a31
FilesUploadWorker: fix infinite loop when uploads failed
With the previous approach (uploadsStorageManager.gtCurrentAndPendingUploadsForAccount),
an upload that is, for example, waiting for wifi, would always be returned in the call,
thus the list would never be empty.

To avoid this but still process the uploads in pages to avoid OOM, we'll request them page-wise
from the StorageManager, with the pages ordered by ascending ID. This way we will only process each upload once,
but newly added uploads after we start will not be missed.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 16:52:43 +01:00
Álvaro Brey
a3e21d719b
UploadsStorageManager: extract getUploadsPage from getUploads
First step for making it accessible from outside

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 16:17:22 +01:00
Tobias Kaminsky
3f6832eaf1
Merge pull request #11118 from nextcloud/revert-sdk-32
Revert "Bump targetSdk to 32"
2022-12-01 12:27:15 +01:00
tobiasKaminsky
52497bb3e3
Template id must be long, as it is fileID, which can be very big
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-01 12:13:50 +01:00
Álvaro Brey
4a14602f0e
PreviewVideoFullscreenDialog: fix insets
This was breaking the window in Android 9 when going back twice from a fullscreen video.

Testing steps:
1. Open a video
2. Go to fullscreen
3. Close fullscreen
4. Press Back

This caused a white screen in Android 9 before this PR

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 11:04:24 +01:00
Nextcloud bot
7698b4b088
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:33:15 +00:00
Nextcloud bot
c3b1957ef8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:32:57 +00:00
Tobias Kaminsky
980bb736a0 daily dev 20221201
Bump mockkVersion from 1.13.2 to 1.13.3
Update 3rd-party dependencies
2022-12-01 02:38:18 +01:00
Tobias Kaminsky
ab3bf3e7ca Merge remote-tracking branch 'origin/master' into dev 2022-12-01 02:31:51 +01:00
Álvaro Brey
13f37c04f8
Revert "Bump targetSdk to 32"
This reverts commit 8c8723c7c5.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-30 12:21:37 +01:00
Álvaro Brey
5d4b7a6d04
Merge pull request #11113 from nextcloud/fix-crash-when-disabling-airplane-mode
Fix crash when disabling airplane mode
2022-11-30 09:33:56 +01:00
Nextcloud bot
cf148a0558
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-30 06:35:10 +00:00
Tobias Kaminsky
013f6dc7d2
Merge pull request #11075 from nextcloud/chore/sdk-32
Bump targetSdk to 32
2022-11-30 07:24:33 +01:00
Tobias Kaminsky
c2fc3424bc daily dev 20221130
Bump kotlin_version from 1.7.21 to 1.7.22
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-30 03:45:47 +01:00
Tobias Kaminsky
5b89024800 Merge remote-tracking branch 'origin/master' into dev 2022-11-30 03:37:33 +01:00
Chris Narkiewicz
45567fb6d4
Fix crash when disabling airplane mode
Fixes #11096

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-11-29 20:17:38 +00:00
Álvaro Brey
f74f59220c
Merge pull request #11089 from nextcloud/fix/video-fullscreen-buffer
Video preview: use fullscreen dialog for video instead of new activity
2022-11-29 13:33:10 +01:00
Álvaro Brey
bbaf8d369d
Merge pull request #11073 from nextcloud/chore/strictmode-optional
Disable StrictMode by default
2022-11-29 13:23:52 +01:00
Nextcloud bot
d584c8416b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-29 03:32:20 +00:00
Tobias Kaminsky
7ba1a9fa5b daily dev 20221129
Bump mockito-kotlin from 4.0.0 to 4.1.0
Update 3rd-party dependencies
2022-11-29 02:38:13 +01:00
Tobias Kaminsky
eddd776d4b Merge remote-tracking branch 'origin/master' into dev 2022-11-29 02:32:10 +01:00
Álvaro Brey
3f990c3f21 PreviewVideoFullscreenDialog: workaround for rotated videos on sdk < 29
See comments in added code for explanation

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bdc0fc71e5 PreviewVideoFullscreenDialog: use listeners to control transfer, and pause the video while transfer is happening
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
efa7d9e317 Remove unused theme
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
b55d5768de Fix lint and spotbugs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bbb85513e1 Video preview: use fullscreen dialog for video instead of new activity
This allows transfering the playback directly between Player views, thus avoiding creating
a new ExoPlayer, re-starting the stream, having to pass playing status/current position, etc.

Additionally:
- Always enable buffering animation so it's clear when a video is loading
- Add padding to fullscreen duration numbers so they don't get cut off on rounded screens

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Tobias Kaminsky
397ba74274 use getParentFragmentManager
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-28 14:18:09 +00:00
tobiasKaminsky
831bffe571 show only one setup dialog, prevents strange situation on double tapping
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-28 14:18:09 +00:00
Álvaro Brey
e85737f41d Disable StrictMode by default
StrictMode is not a good fit for the state of our app, since we are way too far from async operations or correct threading.
As a result, we find ourselves disabling the strict mode manually every time we actually want to work on something, as otherwise the
logspam drowns everything else.

With this PR I propose to disable StrictMode unless a prop is set in the Gradle build, which will also control LeakCanary.
Running `./gradlew installGplayDebug -P perfAnalysis` will install the app with both LeakCanary and StrictMode enabled.
This allows us to analyze performance problems on demand, without making our daily work harder.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 15:09:04 +01:00
Andy Scherzinger
c66491a02f
update screenshot test results
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-11-28 13:03:10 +01:00
Valdnet
d184aa6690
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
1433dec21b
i18n: Change to lower case
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
e57bf0eb2a
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:31 +01:00
Valdnet
a65b896ce6
i18n: Change name of encryption
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:19 +01:00
Nextcloud bot
759b799e37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:17 +00:00
Nextcloud bot
adcfaf381b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:00 +00:00
Nextcloud bot
b9e1bb3f81
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:59 +00:00
Nextcloud bot
cf17a9fbfc
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:41 +00:00
Nextcloud bot
23d0b40d5b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:47 +00:00
Nextcloud bot
5d9e0e6e0a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:27 +00:00
Tobias Kaminsky
72c8248a43 daily dev 20221126
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-26 03:43:42 +01:00
Tobias Kaminsky
eb2b9ec935 Merge remote-tracking branch 'origin/master' into dev 2022-11-26 03:36:27 +01:00
Álvaro Brey
16023016d7
Merge pull request #11091 from nextcloud/dependabot/gradle/com.diffplug.spotless-6.12.0
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
2022-11-25 14:01:12 +01:00
Tobias Kaminsky
161bc98bde
Merge pull request #11031 from nextcloud/e2eUX
E2e ux
2022-11-25 11:30:43 +01:00