Commit graph

2497 commits

Author SHA1 Message Date
Álvaro Brey Vilas
a785135b1b
GalleryAdapterTest: fix wrong parameter list for GalleryAdapter constructor
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 19:14:22 +02:00
Álvaro Brey Vilas
ff3833c62f
OCFileListDelegate: fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:40:25 +02:00
Álvaro Brey Vilas
0def0a8af8
Format with ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:21:35 +02:00
tobiasKaminsky
97d71d0383
Group media by month 2022-04-18 18:18:19 +02:00
Álvaro Brey
0e03400486
Merge pull request #10074 from nextcloud/equals
Replace equals with == on enums
2022-04-18 12:49:14 +02:00
Álvaro Brey
9a899ce3dc
Merge pull request #10070 from nextcloud/trashbinNav
Fix trashbin navigation
2022-04-18 12:30:48 +02:00
Álvaro Brey
66b500b9dc
Merge pull request #10085 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.20.0
Bump detekt-gradle-plugin from 1.19.0 to 1.20.0
2022-04-18 11:42:15 +02:00
Álvaro Brey Vilas
3930633272
Fix detekt.yml for new detekt version
Remove formatting (that is handled by ktlint), update some other properties

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 11:14:17 +02:00
Nextcloud bot
58b34c3ee4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-16 03:59:30 +00:00
Nextcloud bot
df887ce4f2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-15 04:04:35 +00:00
dependabot[bot]
7ed1b84375
Bump detekt-gradle-plugin from 1.19.0 to 1.20.0
Bumps detekt-gradle-plugin from 1.19.0 to 1.20.0.

---
updated-dependencies:
- dependency-name: io.gitlab.arturbosch.detekt:detekt-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-15 01:09:47 +00:00
tobiasKaminsky
a9608108ac
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-13 10:19:30 +02:00
tobiasKaminsky
b4dc084d65
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 14:30:43 +02:00
tobiasKaminsky
075e91d9ba
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 09:15:33 +02:00
tobiasKaminsky
f57aa2037b
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:45:10 +02:00
tobiasKaminsky
3c69ae92bb
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:05:17 +02:00
tobiasKaminsky
e67fc70451
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
930d3e61fd
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
cf932e69e7
Fastscroll for all lists
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
abc9f14555
Fix trashbin navigation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-11 08:33:00 +02:00
Álvaro Brey
86ee9dff69
Merge pull request #10064 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-7.1.3
Bump gradle from 7.1.2 to 7.1.3
2022-04-08 09:06:31 +02:00
Nextcloud bot
7c6bce5617
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-08 04:05:40 +00:00
dependabot[bot]
f8f46e62b9
Bump gradle from 7.1.2 to 7.1.3
Bumps gradle from 7.1.2 to 7.1.3.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-08 01:32:06 +00:00
Álvaro Brey
d97edf023d
Merge pull request #10051 from nextcloud/fdroid-no-scan
Don't include document scanner in FDroid version
2022-04-07 12:46:08 +02:00
Álvaro Brey
ace6b49786
Merge pull request #10059 from nextcloud/exceptionHandling
Do not use ExceptionHandler on debug builds
2022-04-07 12:18:50 +02:00
tobiasKaminsky
df7e70a3f1
Do not use ExceptionHandler on debug builds
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-07 11:47:42 +02:00
Tobias Kaminsky
b84149ac7c
Merge pull request #10034 from nextcloud/fix/details-title-again
Better approach for avoiding state loss in FileDetailFragment
2022-04-07 11:07:11 +02:00
Tobias Kaminsky
69234dec5f
Merge pull request #10049 from nextcloud/fix/camera2_not_required
AndroidManifest: set camera2 feature to not required
2022-04-07 10:44:34 +02:00
Álvaro Brey
d781583c6c
Merge pull request #10007 from nextcloud/fixVideoStreaming
Use remoteId to properly fetch streaming video url
2022-04-07 10:36:07 +02:00
dependabot[bot]
d33a3ce9e4
Bump findsecbugs-plugin from 1.11.0 to 1.12.0
Bumps [findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/find-sec-bugs/find-sec-bugs/releases)
- [Changelog](https://github.com/find-sec-bugs/find-sec-bugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/find-sec-bugs/find-sec-bugs/commits)

---
updated-dependencies:
- dependency-name: com.h3xstream.findsecbugs:findsecbugs-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-07 01:13:27 +00:00
Álvaro Brey Vilas
9827612010
Don't include document scanner in FDroid version
Not allowed due to binary OpenCV

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 14:43:05 +02:00
Álvaro Brey Vilas
ba369f22ab
AndroidManifest: set camera2 feature to not required
Brought by document scanner lib, but not actually required. If set to required,
devices without this feature will not see the app in Play Store.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 09:26:39 +02:00
Álvaro Brey
5b8d11f738
Optimize loading time for Shared view (#10015)
* Don't load entire OCFiles in the Shared view, as it takes too long

Instead, build partially-filled OCFiles from the OCShares we get

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Load metadata of shared files only when attempting to interact with them

This was quite a big undertaking and required a whole new fragment

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix wrong usages of deprecaed OCShare shareType setter

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-04 18:52:21 +02:00
Tobias Kaminsky
b324f0d784
- no camera permission (#10042)
- scan document
- approve permission
- see scan document activity, previously it was wrong upload image activity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-04 09:13:21 +00:00
Nextcloud bot
77507f9c9b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-03 04:01:33 +00:00
Álvaro Brey Vilas
cd895ad2cf
Better approach for avoiding state loss in FileDetailFragment
Do not overwrite file when updating share information, instead of holding the file in FDA

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-31 15:04:19 +02:00
Nextcloud bot
7285ddc4cb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-31 04:08:34 +00:00
Álvaro Brey
d9811e1f34
Merge pull request #10013 from nextcloud/fix/login-after-logout
Fix bugs when removing accounts
2022-03-30 18:29:24 +02:00
Nextcloud bot
9a94cb1e12
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-30 04:03:28 +00:00
Nextcloud bot
4b8bb8a707
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-28 04:02:23 +00:00
Nextcloud bot
ca751d0f71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-27 04:01:42 +00:00
Nextcloud bot
3753ef361c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-25 05:41:13 +00:00
Álvaro Brey Vilas
a1901ca3e8
ManageAccountsActivity: go back to AuthenticatorActivity after removing last account
Instead of waiting for FileDisplayActivity to make a network request and fail

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:23:57 +01:00
Álvaro Brey Vilas
95046c4b5d
AccountRemovalWork: remove cached owncloudClient after removing account
Otherwise, the account (which is identified by account name only) will reuse old token, if login is done right after account removal.

Three hours of debugging for one line of code

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:22:11 +01:00
Álvaro Brey Vilas
2e593a034b
Fix FileDisplayActivity screenshot tests
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:08 +01:00
Álvaro Brey Vilas
154755af9b
Fix scrolling behaviour when changing dark mode
Also fixes "scrolling on top bar" for empty folders

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
b8bb261234
PreviewMediaFragment: fix crash when changing theme with audio fragment
Exoplayer is null when recreating

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
6a527a6e87
FileDisplayActivity: properly lock scrollbar for media preview
This locks the scrolling of the CoordinatorLayout AND removes the scroll flags from the AppbarLayout

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey
d013464320
Merge pull request #9959 from nextcloud/shareFromMediaView
Fix sharing from media view
2022-03-23 09:30:26 +01:00
tobiasKaminsky
f522446d13
Correctly show edit share link
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-23 06:50:51 +01:00
Nextcloud bot
0c5a9fd155
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-23 03:59:59 +00:00
tobiasKaminsky
e481382c28
Use remoteId to properly fetch streaming video url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-22 16:36:11 +01:00
Álvaro Brey Vilas
f6298f7904
FileDetialsSharing...: add minHeight to content instead of scrollview
This still keeps the minimum height, but doesn't center the content vertically which looked odd

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-22 10:10:55 +01:00
Tobias Kaminsky
646f857890 daily dev 20220322
Update Nextcloud Android library
2022-03-22 08:03:02 +01:00
tobiasKaminsky
d91d2996ab
Fix sharing from media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-21 15:06:06 +01:00
Álvaro Brey
a9bc999574
Merge pull request #9991 from nextcloud/dependabot/gradle/org.json-json-20220320
Bump json from 20211205 to 20220320
2022-03-21 10:48:01 +01:00
Álvaro Brey Vilas
d63d22d066
GooglePlayUtils: convert to Kotlin, fix spotbugs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-21 09:40:18 +01:00
dependabot[bot]
abf14b52cf
Bump firebase-messaging from 20.1.3 to 23.0.2
Bumps firebase-messaging from 20.1.3 to 23.0.2.

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-messaging
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 09:40:09 +01:00
Nextcloud bot
321a97acf7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-21 03:59:20 +00:00
dependabot[bot]
5cadf81c43
Bump json from 20211205 to 20220320
Bumps [json](https://github.com/douglascrockford/JSON-java) from 20211205 to 20220320.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 02:06:05 +00:00
Nextcloud bot
98575bc8ca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-20 04:00:57 +00:00
Nextcloud bot
d7dbef4085
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-19 04:01:55 +00:00
Nextcloud bot
6d1b14785c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-18 04:00:34 +00:00
Álvaro Brey
138d3a03a9
Merge pull request #9972 from nextcloud/fix/search-loading
Fix search loading animation and display
2022-03-17 13:04:10 +01:00
Álvaro Brey
e7e2ab8a96
Merge pull request #9976 from nextcloud/fix/receive-crash-no-account
ReceiveExternalFilesActivity: don't crash if no user present
2022-03-17 10:44:45 +01:00
Álvaro Brey Vilas
769816978a
OCFileListFragment: extract seach async task and convert it to kotlin
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-17 10:38:30 +01:00
Nextcloud bot
886400b5e0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-17 04:04:03 +00:00
Álvaro Brey
b70eeaae3a
Merge pull request #9977 from nextcloud/chore/ktlint-gradle
Use ktlint plugin instead of manual ktlint tasks
2022-03-16 13:05:23 +01:00
Álvaro Brey
ad13f544ee
Merge pull request #9974 from nextcloud/chore/espresso-intents-version
build.gradle: Don't hardcode espresso-intents version, use the same as other espresso libs
2022-03-16 13:00:49 +01:00
Álvaro Brey Vilas
3e2eba34a5
Update FolderPickerActivity screenshot
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
0af297735c
ExtendedListFragment: Remove ViewTreeObserver on search frame
This was incorrectly setting empty message when switching search types. And it makes no sense: search is only executed when submitted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
e8e18609e5
OCFileListFragment: make search async task static, fix loading animation usage
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey
e8acc254b8
Merge pull request #9969 from nextcloud/chore/ndk-version
build: Specify NDK version (optional install)
2022-03-16 11:38:15 +01:00
Álvaro Brey Vilas
3597fb0a53
Use ktlint plugin instead of manual ktlint tasks
- Recommended by ktlint
 - Analyzes sources for all sourcesets without extra config
 - Less gradle code to maintain

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:30:39 +01:00
Tobias Kaminsky
eccd9205bd
Merge pull request #9970 from nextcloud/fix/share-screen-update
FileDisplayActivity: set file when opening FileDetailsFragment
2022-03-16 11:03:28 +01:00
Álvaro Brey
76d9bbfba3
Merge pull request #9432 from nextcloud/showCorrectNoShared
if no shared files are on server, show correct empty message
2022-03-16 10:45:08 +01:00
Álvaro Brey Vilas
3975839d53
ReceiveExternalFilesActivity: don't crash if no user present
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 10:38:37 +01:00
Álvaro Brey Vilas
d6f32eb5ce
build.gradle: Don't hardcode espresso-intents version, use the same as other espresso libs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 10:01:04 +01:00
Nextcloud bot
e82fb2c6da
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-16 04:01:13 +00:00
tobiasKaminsky
080736af30
if no shared files are on server, show correct empty message
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-15 17:36:20 +01:00
Álvaro Brey Vilas
934953506f
FileDisplayActivity: set file when opening FileDetailsFragment
Solves issues when creating or removing shares, at which point the file would be re-set to the root folder

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-15 17:26:35 +01:00
Álvaro Brey Vilas
ec98c5db52
Centralize NDK and CMAKE versions
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-15 14:43:05 +01:00
Álvaro Brey Vilas
12ce7c2837
build: Specify NDK version (optional install)
If this + CMake is installed, native libraries are correctly stripped, and then APK size is reduced.
If not installed, everything still works as we don't actually need to compile any native stuff.

If `ndkVersion` is not specified, then the default version for Android Gradle Plugin is expected,
and stripping will not work even if other NDK version is installed. So it's better to use a
specific version, to prevent it from stopping working in the future.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-15 10:29:20 +01:00
Álvaro Brey Vilas
1a9014ee3b
FileDisplayActivity: always try to reload folder on onResume
This makes it so that the folder loads even without granting storage permission, which is the expected behaviour now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:39:21 +01:00
Álvaro Brey Vilas
2a4316a298
PermissionUtil: ensure permission choice dialog doesn't overlap itself
(ensure only one instance of it is ever shown at the same time)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:22:17 +01:00
Álvaro Brey Vilas
d8811c97a1
StoragePermissionDialogFragment: fix theming of buttons
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:18:07 +01:00
Álvaro Brey Vilas
db196c68a4
Design updates for storage permission dialog
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:18 +01:00
Álvaro Brey Vilas
ad5b443489
Choice between All Files and read-only external storage in SDK >=30
- Allow users to choose between MANAGE_EXTERNAL_STORAGE (full access) and READ_EXTERNAL_STORAGE (media read-only) in sdk >=30, with a dialog
- If All Files is not available (activity to manage not present, or permission not in manifest), request READ_EXTERNAL_STORAGE instead
- Misc improvements to permission request in UploadFilesActivity and SyncedFoldersActivity

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:17 +01:00
Álvaro Brey Vilas
7d2f0fa017
Make external storage permission optional
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:12 +01:00
tobiasKaminsky
05bd775171
only have one place for capability
update cache entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-14 13:23:14 +01:00
Nextcloud bot
d2f670369f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-14 11:15:03 +00:00
Álvaro Brey Vilas
785767ae70
Screenshot tests for UploadFilesActivity
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:22:50 +01:00
Álvaro Brey Vilas
900145da05
Fix folder selection in custom autoupload folders
Hide checkboxes and keep choose button enabled. The flow to select folders is to navigate into them and tap "Choose", as is typical in file browsers.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:21:31 +01:00
Álvaro Brey Vilas
d23d20f31b
Fix git hooks for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:42:11 +01:00
Álvaro Brey Vilas
d8e5691366
Fix detekt and ktlint for new source path
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:23:31 +01:00
Álvaro Brey Vilas
516544115c
Fix screenshot tests after subproject change
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:14:46 +01:00
Álvaro Brey Vilas
e57176f009
Move app source to subproject
Android Studio has started to fail for some stuff with that old structure (for example connected tests don't work).
It's about time to do this.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:10:51 +01:00