Commit graph

15381 commits

Author SHA1 Message Date
Chris Narkiewicz
e13a3ca7cb
Migate file details and share details to User model
UserAccountManager:
 - added userOwnsFile API that replaces accountOwnsFile
 - deprecated accountOwnsFile

FileDisplayActivity:
 - simplified initFragmentWithFile by passing non-null instanecs
   of user and file and thus avoiding numerous redundant null-checks
 - fragments are initialized using User model instead of Account
 - transfer and download callbacks use getUser() instead of getAccount()
   and pass user instance to framents

ShareActivity
 - initlize fragment using user model instead of account
 - close acivity immediately if current user is not available
   (cannot reach such state not, but historically account was nullable)

FileDetailTabAdapter
 - framents are initialized using User model instead of Account

FileDetailActivitiesFragment
 - migrated to User
 - removed dependency on constants from FileActivity

FileDetailFragment
 - migrated to User
 - removed dependency on constants from FileActivity

FileDetailsSharingFragment
 - migrated to User
 - removed dependency on constants from FileActivity

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-26 23:07:40 +01:00
nextcloud-android-bot
79f4270bb9 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-26 13:35:51 +00:00
Andy Scherzinger
5f73a5ec75
update screenshots
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:30 +02:00
Andy Scherzinger
0ad81bdd29
remove element color references
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:29 +02:00
Andy Scherzinger
8af257d54f
remove unused method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:27 +02:00
Andy Scherzinger
a7088c8c87
improve edge case FAB coloring
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:25 +02:00
Andy Scherzinger
5b76892ab1
move primary action button theming to new theming method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:24 +02:00
Andy Scherzinger
7005cdef2e
Introduce light/dark theme / black/white primary-color-aware primary-button theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:22 +02:00
Andy Scherzinger
643454c1d7
proper coloring of drawer items in black/white edge case scenarios
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:21 +02:00
Andy Scherzinger
20d2ef989d
proper button coloring for dark theme + black primary color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:14 +02:00
Andy Scherzinger
dfc94f4505
Merge pull request #6354 from nextcloud/noShare
Enhance FileDetailSharingFragment
2020-06-26 13:27:16 +02:00
tobiasKaminsky
8f0e4eab60
Delete outdated comments in case of success
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 12:51:47 +02:00
Andy Scherzinger
93d0875883
Merge pull request #6253 from nextcloud/noNothingIfNoActivity
PreviewImageFragment: if we have no activity, do nothing
2020-06-26 11:13:58 +02:00
Joris Bodin
947e4a1b10
Remove duplacation
Signed-off-by: Joris Bodin <joris.bodin@infomaniak.com>
2020-06-26 11:05:44 +02:00
tobiasKaminsky
c55e9b8fd2
black nav bar on image preview
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 11:05:44 +02:00
Andy Scherzinger
2b5c39095d
lint: remove unused resource
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 11:03:09 +02:00
tobiasKaminsky
348ae4435a
Enhance FileDetailSharingFragment:
- remove no users text
- disable search view if reshare is not allowed
- show note icon

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 11:03:03 +02:00
Tobias Kaminsky
a22b0724ae
Merge pull request #6367 from nextcloud/fixTypeInReport
type -> TYPE
2020-06-26 10:58:58 +02:00
tobiasKaminsky
c42c24be80
type -> TYPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 10:58:34 +02:00
Tobias Kaminsky
7e03aa39b5
Merge pull request #6365 from nextcloud/fixDeleteCommits
fix deleting outdated comments
2020-06-26 10:36:11 +02:00
tobiasKaminsky
097434916e
fix deleting outdated comments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 10:35:48 +02:00
Tobias Kaminsky
728de81736
Merge pull request #6263 from nextcloud/scrollPart2
Hide on scrolling for activities and notifications
2020-06-26 08:39:57 +02:00
Chris Narkiewicz
5609b5041e
Fix NPE in OCFileListFragment when OCFile is null
1. Fixed NPE
2. Audited all use of nullable field in all called APIs
3. Updated called APIs nullability documentation

Fixes #6282

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-25 22:55:08 +01:00
tobiasKaminsky
d36c2d35a5
Hide on scrolling for activities and notifications
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:44:03 +02:00
tobiasKaminsky
741cc24d11
fix #5468
if we have no activity, do nothing

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:36:05 +02:00
Andy Scherzinger
5288548e70
Merge pull request #6338 from nextcloud/legacyLoginFlow
Removed legacy login
2020-06-25 23:33:57 +02:00
nextcloud-android-bot
e0d5676151 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 21:18:34 +00:00
tobiasKaminsky
7ed4e2b24e
changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:48 +02:00
tobiasKaminsky
58ba15ac95
Removed legacy login
cleaned up a bit AuthenticatorActivity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:22 +02:00
Andy Scherzinger
fe1cd33c26
Merge pull request #6344 from nextcloud/ocp
fix OCP_OVERLY_CONCRETE_PARAMETER
2020-06-25 20:30:34 +02:00
Andy Scherzinger
c3f838d445
Merge pull request #6349 from nextcloud/dependabot/gradle/gradle.plugin.com.github.spotbugs.snom-spotbugs-gradle-plugin-4.4.3
Bump spotbugs-gradle-plugin from 4.3.0 to 4.4.3
2020-06-25 20:29:45 +02:00
Andy Scherzinger
2f60b75fc5
add null check 2020-06-25 18:55:50 +02:00
nextcloud-android-bot
f6e7c44596 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 16:55:05 +00:00
tobiasKaminsky
1017e3ac3b
fix OCP_OVERLY_CONCRETE_PARAMETER
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 18:45:28 +02:00
Andy Scherzinger
2913918232
Merge pull request #6361 from nextcloud/fixZoom
Fix zoom, toggle background
2020-06-25 17:12:00 +02:00
tobiasKaminsky
ca7350fa8a
use fixed spotbug version
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 16:52:12 +02:00
dependabot-preview[bot]
2c5fb2b2f9
Bump spotbugs-gradle-plugin from 4.3.0 to 4.4.3
Bumps spotbugs-gradle-plugin from 4.3.0 to 4.4.3.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-25 16:52:12 +02:00
Tobias Kaminsky
d70502f747
Merge pull request #6262 from nextcloud/hideOnScrolling
Hide on scrolling
2020-06-25 16:18:40 +02:00
tobiasKaminsky
38c28332e2
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:57:46 +02:00
tobiasKaminsky
bd5c9dfa1e
make function puplic for testing
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:22:58 +02:00
tobiasKaminsky
db4a7ee8f5
Fix zoom, toggle background
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:17:54 +02:00
Andy Scherzinger
066fef03c2
Merge pull request #6359 from nextcloud/photoBugfix
use view instead of linear layout as common parent
2020-06-25 13:44:32 +02:00
nextcloud-android-bot
741fb410f1 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 11:13:55 +00:00
nextcloud-android-bot
961e6c179a
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 13:00:04 +02:00
tobiasKaminsky
22657040bd
Removed possible NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
a9dc3f5787
removed duplicated sort/switch grid buttons
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
e5ec91b5a7
Changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
1ecd64f128
Hide on scrolling, fix https://github.com/nextcloud/android/issues/6238
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
6dfb4c7ef6
use view instead of linear layout as common parent
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:48:40 +02:00
Nextcloud bot
56a1fc868d
[tx-robot] updated from transifex 2020-06-25 03:28:24 +00:00