Commit graph

19538 commits

Author SHA1 Message Date
Álvaro Brey
ec4067c199 ArbitraryDataProvider: distinguish between null value and nonexisting entities
Not the same thing!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
9c218ed18a Fix nullability of types for ArbitraryDataProvider interface
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
f490823e4e Extract interface from ArbitraryDataProvider for better decoupling and testing
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
5499441738 Use Room DAO for ArbitraryDataProvider instead of contentResolver
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Nextcloud bot
13071ed5ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:40 +00:00
Nextcloud bot
a7a9da4bc2
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:19 +00:00
Álvaro Brey
aa355e7efd
Merge pull request #11054 from nextcloud/bump-master-3.24
Bump app version on master to 3.24
2022-11-17 14:49:52 +01:00
Álvaro Brey
ab13b9873c
Merge pull request #11052 from nextcloud/doNotAllowSharedEncryptedFolder
prohibit share of an encrypted folder
2022-11-17 14:47:23 +01:00
Álvaro Brey
b31e3c1061
Bump app version on master to 3.24
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 13:48:43 +01:00
Tobias Kaminsky
1b0a2cce72
also check for shared with me
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-17 13:14:37 +01:00
tobiasKaminsky
66746a6b12
prohibit share of an encrypted folder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-17 12:50:59 +01:00
Álvaro Brey
05200914d9
Merge pull request #11051 from nextcloud/chore/remove-unused-migration-code
chore: Remove unused legacy migration code
2022-11-17 12:26:16 +01:00
Álvaro Brey
b78c236a59
chore: Remove unused legacy migration code
This was leftover in the Room PR, where we removed support for DB version <24. As such, all the code supporting those older versions is unused now.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 10:24:47 +01:00
Álvaro Brey
75774ed2ce
Merge pull request #11008 from nextcloud/feature/file-actions-bottom-sheet
Redesign file actions menu as a BottomSheet
2022-11-17 09:50:13 +01:00
Álvaro Brey
c71ce3a3ee
Add screenshot test for FileActionsBottomSheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
a0ac194467
Fix lint
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
f8f0d46633
Fix FileMenuFilterIT
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
7cb85ec6a1
FileActionsBottomSheet: color loading animation with primary color
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
4523537587
File actions bottom sheet: show file thumbnail
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
829c10f9de
Fix FileMenuFilterIT for real
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
6b470f86bb
Fix mock order for FileMenuFilter
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
422c0a5011
Small spotbugs cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
a160ccd936
Clean up unused resources
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
b43df7c711
Minor cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
27e40440db
Fix bottom sheet background for PreviewImageFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
6d97bd5145
Remove obsolete TODOs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
36f918da7e
Fix icon tinting for fake placeholder menu iteFix icon tinting for fake placeholder menu itemm
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
0cc2e6875d
FileActionsBottomSheet: parse arguments in ViewModel, handle errors
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
702a9cedf0
FileActionsBottomSheet: fix things that were parameters, but shouldn't
- Result listener should be done through the fragmentResultListener API
- ComponentsGetter is attached on onAttach

This avoids crashes on config changes, etc

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
263d139fe2
FileMenuFilter: simplify and remove unneeded stuff for new approach
We're always starting from the full list and removing stuff now, so toShow makes no sense

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
7c53e77e57
FileActionsBottomSheet: additional filtering in FileDetailFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
dd94167733
FileActionsBottomSheet: show loading animation, load items in background
Since we're going to load the files in background too, it's a good idea to start doing this already

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
0e0935bef6
FileActionsBottomSheet: add drag handle for accesibility
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
5ff16b9ba5
Show lock info in bottom sheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
1aa248d1bf
FileActionsBottomSheet: Display file name or file count as bottom sheet title
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
e7ff6df581
FileActionsBottomSheet: make scrollable in case full list doesn't fit in screen
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
a1265bdae7
FileActionsBottomSheet: handle additional filtering for preview fragments
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
689a4bda6a
Extract responsibilities from FileMenuFilter static methods to utility classes.
God class count -= 1

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:56 +01:00
Álvaro Brey
e41d474e89
FileActionsBottomSheet: use ViewModel
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:46 +01:00
Álvaro Brey
5b628f520c
Set icons for file actions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:09 +01:00
Álvaro Brey
f2d0acdba3
Use bottom sheet for file actions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:02 +01:00
Nextcloud bot
1cd0bbf75e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 03:29:03 +00:00
Nextcloud bot
937aa10fc8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 03:28:49 +00:00
Álvaro Brey
2651dcee0a
Merge pull request #11041 from nextcloud/fix/storage-permission-loop
Fix storage permission loop when permission denied, and remember permission asked
2022-11-16 21:01:55 +01:00
Álvaro Brey
08e2006737
Merge pull request #10996 from nextcloud/cache-walled-check
Cache walled check for 10 minutes
2022-11-16 21:00:58 +01:00
Álvaro Brey
b32ea65774 WalledCheckCache: use current epoch instead of millis since boot to avoid problems on reboot
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
f3a810600d WalledCheckCache: rename field and parameter for clarity
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
4118cd69c1 Cache walled check for 10 minutes
Tentative cache time, accepting other proposals. My rationale for 10 minutes was that 6 checks an hour seems like not too much,
while not locking the app for too long in case there's an error and the cache is not cleared on network change.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
2ad11ad7f5
Merge pull request #11040 from nextcloud/fix/home-icon
Fix toolbar home icon being arrow in places where it should be hamburger menu
2022-11-16 12:38:25 +01:00
Álvaro Brey
e0ef3bf0b5
Merge pull request #10953 from nextcloud/chore/bump-uploader
FileUploader: bump down min sdk for upload worker for 3.23
2022-11-16 12:37:45 +01:00