diff --git a/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java b/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
index 08cc75a1e3..4d08b67991 100644
--- a/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
+++ b/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
@@ -281,8 +281,7 @@ public class FileDetailSharingFragment extends Fragment implements UserListAdapt
);
FileDetailSharingFragmentHelper.setupPasswordMenuItem(
menu.findItem(R.id.action_share_link_password),
- publicShare.isPasswordProtected(),
- res
+ publicShare.isPasswordProtected()
);
FileDetailSharingFragmentHelper.setupExpirationDateMenuItem(
menu.findItem(R.id.action_share_link_expiration_date),
diff --git a/src/main/java/com/owncloud/android/ui/fragment/util/FileDetailSharingFragmentHelper.java b/src/main/java/com/owncloud/android/ui/fragment/util/FileDetailSharingFragmentHelper.java
index 29133d5216..68aaba9761 100644
--- a/src/main/java/com/owncloud/android/ui/fragment/util/FileDetailSharingFragmentHelper.java
+++ b/src/main/java/com/owncloud/android/ui/fragment/util/FileDetailSharingFragmentHelper.java
@@ -69,23 +69,15 @@ public class FileDetailSharingFragmentHelper {
*
* @param password the password {@link MenuItem}
* @param isPasswordProtected flag is a password is present
- * @param res Resources to load the corresponding strings.
*/
- public static void setupPasswordMenuItem(MenuItem password, boolean isPasswordProtected, Resources res) {
+ public static void setupPasswordMenuItem(MenuItem password, boolean isPasswordProtected) {
if (isPasswordProtected) {
- password.setTitle(getPasswordTitle(res, R.string.share_via_link_password_title));
+ password.setTitle(R.string.share_password_title);
} else {
- password.setTitle(getPasswordTitle(res, R.string.share_via_link_no_password_title));
+ password.setTitle(R.string.share_no_password_title);
}
}
- private static String getPasswordTitle(Resources res, @StringRes int passwordValue) {
- return res.getString(
- R.string.share_via_link_menu_password_label,
- res.getString(passwordValue)
- );
- }
-
/**
* sets up the expiration date {@link MenuItem}'s title based on the fact if an expiration date is present.
*
@@ -100,10 +92,7 @@ public class FileDetailSharingFragmentHelper {
SimpleDateFormat.getDateInstance().format(new Date(expirationDateValue))
));
} else {
- expirationDate.setTitle(res.getString(
- R.string.share_expiration_date_label,
- res.getString(R.string.share_via_link_menu_expiration_date_never)
- ));
+ expirationDate.setTitle(R.string.share_no_expiration_date_label);
}
}
diff --git a/src/main/res/layout/file_details_fragment.xml b/src/main/res/layout/file_details_fragment.xml
index fc5f7c6538..afe1b93885 100644
--- a/src/main/res/layout/file_details_fragment.xml
+++ b/src/main/res/layout/file_details_fragment.xml
@@ -52,6 +52,7 @@
android:ellipsize="middle"
android:text="@string/placeholder_filename"
android:textColor="@color/black"
+ android:textStyle="bold"
android:textSize="16sp" />
@@ -73,6 +73,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
+ android:textSize="16sp"
android:text="@string/edit_permission_label"/>
+ android:textSize="16sp" />
diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
index 457e35a1a1..22409b797a 100644
--- a/src/main/res/values/strings.xml
+++ b/src/main/res/values/strings.xml
@@ -479,13 +479,11 @@
No data shared with users yet
Add user or group
Password protect (%1$s)
- Set expiration date (%1$s)
- never
+ Expires %1$s
+ Set expiration date
Share link
- Set expiration date
- Protect with password
- Secured
- none
+ Password-protected
+ Set password
edit
Hide file listing
Get link
diff --git a/src/main/res/values/styles.xml b/src/main/res/values/styles.xml
index ff529779ec..c3fa501890 100644
--- a/src/main/res/values/styles.xml
+++ b/src/main/res/values/styles.xml
@@ -250,4 +250,9 @@
- @color/login_text_color
- @color/login_text_color
+
+