mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-26 15:15:51 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3789 from nextcloud/try-with-resources-in-download-file-operation

Browse source 
operations: properly close FileOutputStream.
This commit is contained in:
Andy Scherzinger 2019-03-27 10:11:23 +01:00 committed by GitHub
commit d4c008188a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/analysis/findbugs-results.txt
View file

@ -1 +1 @@
474 473

5
src/main/java/com/owncloud/android/operations/DownloadFileOperation.java
View file

@ -203,8 +203,9 @@ public class DownloadFileOperation extends RemoteOperation {
try { try {
byte[] decryptedBytes = EncryptionUtils.decryptFile(tmpFile, key, iv, authenticationTag); byte[] decryptedBytes = EncryptionUtils.decryptFile(tmpFile, key, iv, authenticationTag);
FileOutputStream fileOutputStream = new FileOutputStream(tmpFile); try (FileOutputStream fileOutputStream = new FileOutputStream(tmpFile)) {
fileOutputStream.write(decryptedBytes); fileOutputStream.write(decryptedBytes);
}
} catch (Exception e) { } catch (Exception e) {
return new RemoteOperationResult(e); return new RemoteOperationResult(e);
} }