Fix mocking in FileMenuFilterIT

Not sure why this wasn't a compilation error

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
This commit is contained in:
Álvaro Brey 2022-05-02 13:38:05 +02:00
parent 49ad952544
commit d34d3b419a
No known key found for this signature in database
GPG key ID: 2585783189A62105
2 changed files with 30 additions and 21 deletions

View file

@ -36,7 +36,7 @@ import org.mockito.kotlin.eq
import org.mockito.kotlin.verify
@RunWith(AndroidJUnit4::class)
class ContentResolverHelperTest {
class ContentResolverHelperIT {
companion object {
private val URI = Uri.parse("http://foo.bar")

View file

@ -30,39 +30,48 @@ import com.owncloud.android.AbstractIT
import com.owncloud.android.R
import com.owncloud.android.datamodel.FileDataStorageManager
import com.owncloud.android.datamodel.OCFile
import com.owncloud.android.files.services.FileDownloader
import com.owncloud.android.files.services.FileUploader
import com.owncloud.android.lib.resources.files.model.FileLockType
import com.owncloud.android.lib.resources.status.CapabilityBooleanType
import com.owncloud.android.lib.resources.status.OCCapability
import com.owncloud.android.services.OperationsService
import com.owncloud.android.ui.activity.ComponentsGetter
import org.junit.After
import io.mockk.MockKAnnotations
import io.mockk.every
import io.mockk.impl.annotations.MockK
import org.junit.Assert
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.MockitoAnnotations
import org.mockito.kotlin.any
import org.mockito.kotlin.whenever
@RunWith(AndroidJUnit4::class)
class FileMenuFilterIT : AbstractIT() {
@Mock
private lateinit var componentsGetter: ComponentsGetter
@MockK
private lateinit var mockComponentsGetter: ComponentsGetter
@Mock
private lateinit var fileDataStorageManager: FileDataStorageManager
@MockK
private lateinit var mockStorageManager: FileDataStorageManager
private lateinit var mocks: AutoCloseable
@MockK
private lateinit var mockFileUploaderBinder: FileUploader.FileUploaderBinder
@MockK
private lateinit var mockFileDownloaderBinder: FileDownloader.FileDownloaderBinder
@MockK
private lateinit var mockOperationsServiceBinder: OperationsService.OperationsServiceBinder
@Before
fun setup() {
mocks = MockitoAnnotations.openMocks(this)
}
@After
fun tearDown() {
mocks.close()
MockKAnnotations.init(this)
every { mockFileUploaderBinder.isUploading(any(), any()) } returns false
every { mockComponentsGetter.fileUploaderBinder } returns mockFileUploaderBinder
every { mockFileDownloaderBinder.isDownloading(any(), any()) } returns false
every { mockComponentsGetter.fileDownloaderBinder } returns mockFileDownloaderBinder
every { mockOperationsServiceBinder.isSynchronizing(any(), any()) } returns false
every { mockComponentsGetter.operationsServiceBinder } returns mockOperationsServiceBinder
}
@Test
@ -149,9 +158,9 @@ class FileMenuFilterIT : AbstractIT() {
)
private fun configureCapability(capability: OCCapability) {
whenever(fileDataStorageManager.getCapability(any<User>())).thenReturn(capability)
whenever(fileDataStorageManager.getCapability(any<String>())).thenReturn(capability)
whenever(componentsGetter.storageManager).thenReturn(fileDataStorageManager)
every { mockStorageManager.getCapability(any<User>()) } returns capability
every { mockStorageManager.getCapability(any<String>()) } returns capability
every { mockComponentsGetter.storageManager } returns mockStorageManager
}
private fun getMenu(activity: TestActivity): Menu {
@ -172,7 +181,7 @@ class FileMenuFilterIT : AbstractIT() {
it.onActivity { activity ->
val menu = getMenu(activity)
val sut = FileMenuFilter(file, componentsGetter, activity, true, user)
val sut = FileMenuFilter(file, mockComponentsGetter, activity, true, user)
sut.filter(menu, false)