mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-27 09:39:25 +03:00
Code Issues Projects Releases Packages Wiki Activity

- fix showing spinner when opening keyboard in file detail view

Browse source 
- first simple checks in if tests
- prevent NPE

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
This commit is contained in:
tobiasKaminsky 2019-01-22 07:56:32 +01:00 committed by Andy Scherzinger
parent cf6dccc835
commit b3bfa8641e
No known key found for this signature in database
GPG key ID: 6CADC7E3523C308B
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
View file

@ -213,7 +213,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
public void onResume() {
super.onResume();
if (getFile()!= null && MimeTypeUtil.isImage(getFile()) && previewLoaded) {
if (previewLoaded && getFile() != null && MimeTypeUtil.isImage(getFile())) {
activatePreviewImage();
}
}
@ -259,6 +259,8 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
if (getFile() == null || account == null) {
showEmptyContent();
} else {
emptyContentContainer.setVisibility(View.GONE);
}
return view;
@ -317,7 +319,11 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
viewPager.setCurrentItem(tab.getPosition());
if (tab.getPosition() == 0) {
getFileDetailActivitiesFragment().markCommentsAsRead();
FileDetailActivitiesFragment fragment = getFileDetailActivitiesFragment();
if (fragment != null) {
fragment.markCommentsAsRead();
}
}
}
@ -602,7 +608,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
private void setFilePreview(OCFile file) {
Bitmap resizedImage;
if (MimeTypeUtil.isImage(file) && activity != null) {
if (activity != null && MimeTypeUtil.isImage(file)) {
String tagId = String.valueOf(ThumbnailsCacheManager.PREFIX_RESIZED_IMAGE + getFile().getRemoteId());
resizedImage = ThumbnailsCacheManager.getBitmapFromDiskCache(tagId);
@ -722,6 +728,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
private void showEmptyContent() {
if (emptyContentContainer != null) {
emptyContentContainer.setVisibility(View.VISIBLE);
detailContainer.setVisibility(View.GONE);
emptyContentHeadline.setText(R.string.file_details_no_content);