mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-27 09:39:25 +03:00
Code Issues Projects Releases Packages Wiki Activity

codacy: Unnecessary use of fully qualified name

Browse source 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This commit is contained in:
Andy Scherzinger 2019-05-27 16:40:41 +02:00
parent 035342895f
commit 81bec0fdc6
No known key found for this signature in database
GPG key ID: 6CADC7E3523C308B
4 changed files with 21 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java
View file

@ -67,7 +67,6 @@ import androidx.annotation.Nullable;
import lombok.Getter;
import lombok.Setter;
import static com.owncloud.android.datamodel.OCFile.ROOT_PATH;
@Getter
public class FileDataStorageManager {
@ -266,7 +265,7 @@ public class FileDataStorageManager {
* @return the parent file
*/
public OCFile saveFileWithParent(OCFile file, Context context) {
if (file.getParentId() == 0 && !ROOT_PATH.equals(file.getRemotePath())) {
if (file.getParentId() == 0 && !OCFile.ROOT_PATH.equals(file.getRemotePath())) {
String remotePath = file.getRemotePath();
String parentPath = remotePath.substring(0, remotePath.lastIndexOf(file.getFileName()));

36
src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java
View file

@ -62,19 +62,6 @@ import android.widget.ListView;
import android.widget.ProgressBar;
import android.widget.Spinner;
import android.widget.TextView;
import androidx.annotation.DrawableRes;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.annotation.StringRes;
import androidx.appcompat.app.ActionBar;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AlertDialog.Builder;
import androidx.appcompat.widget.SearchView;
import androidx.core.content.ContextCompat;
import androidx.core.graphics.drawable.DrawableCompat;
import androidx.core.view.MenuItemCompat;
import androidx.fragment.app.DialogFragment;
import androidx.fragment.app.FragmentManager;
import com.nextcloud.client.account.UserAccountManager;
import com.nextcloud.client.di.Injectable;
@ -124,8 +111,19 @@ import java.util.Vector;
import javax.inject.Inject;
import static com.owncloud.android.datamodel.OCFile.PATH_SEPARATOR;
import static com.owncloud.android.datamodel.OCFile.ROOT_PATH;
import androidx.annotation.DrawableRes;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.annotation.StringRes;
import androidx.appcompat.app.ActionBar;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AlertDialog.Builder;
import androidx.appcompat.widget.SearchView;
import androidx.core.content.ContextCompat;
import androidx.core.graphics.drawable.DrawableCompat;
import androidx.core.view.MenuItemCompat;
import androidx.fragment.app.DialogFragment;
import androidx.fragment.app.FragmentManager;
/**
* This can be used to upload things to an ownCloud instance.
@ -178,7 +176,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
String parentPath = savedInstanceState.getString(KEY_PARENTS);
if (parentPath != null) {
mParents.addAll(Arrays.asList(parentPath.split(PATH_SEPARATOR)));
mParents.addAll(Arrays.asList(parentPath.split(OCFile.PATH_SEPARATOR)));
}
mFile = savedInstanceState.getParcelable(KEY_FILE);
@ -888,7 +886,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
String full_path = "";
for (String a : dirs) {
full_path += a + PATH_SEPARATOR;
full_path += a + OCFile.PATH_SEPARATOR;
}
return full_path;
}
@ -1038,10 +1036,10 @@ public class ReceiveExternalFilesActivity extends FileActivity
if (mParents.empty()) {
String lastPath = preferences.getLastUploadPath();
// "/" equals root-directory
if (ROOT_PATH.equals(lastPath)) {
if (OCFile.ROOT_PATH.equals(lastPath)) {
mParents.add("");
} else {
String[] dir_names = lastPath.split(PATH_SEPARATOR);
String[] dir_names = lastPath.split(OCFile.PATH_SEPARATOR);
mParents.clear();
mParents.addAll(Arrays.asList(dir_names));
}

4
src/main/java/com/owncloud/android/ui/errorhandling/ExceptionHandler.java
View file

@ -27,7 +27,7 @@ import android.util.Log;
import java.io.PrintWriter;
import java.io.StringWriter;
public class ExceptionHandler implements java.lang.Thread.UncaughtExceptionHandler {
public class ExceptionHandler implements Thread.UncaughtExceptionHandler {
private final Activity mContext;
private static final String TAG = ExceptionHandler.class.getSimpleName();
@ -79,4 +79,4 @@ public class ExceptionHandler implements java.lang.Thread.UncaughtExceptionHandl
System.exit(1000);
}
}
}

2
src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.java
View file

@ -267,7 +267,7 @@ public class PreviewTextFragment extends FileFragment implements SearchView.OnQu
}
@Override
protected StringWriter doInBackground(java.lang.Object... params) {
protected StringWriter doInBackground(Object... params) {
if (params.length != PARAMS_LENGTH) {
throw new IllegalArgumentException("The parameter to " + TextLoadAsyncTask.class.getName()
+ " must be (1) the file location");