mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-27 17:46:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

operations: Replace use of Vector with a unsynchronized equivalent.

Browse source 
Early classes of the Java API, such as Vector, Hashtable and StringBuffer, were synchronized to make them thread-safe. Unfortunately, synchronization has a big negative impact on performance, even when using these collections from a single thread.

It is better to use their new unsynchronized replacements. ArrayList is pretty much a drop-in replacement for Vectors and I cant see any reason to use Vector unless there is some sort of special requirement for it. ArrayList will generally give you better performance and only half the data growth when items are added to the list.
This commit is contained in:
ardevd 2018-07-13 10:16:24 +02:00
parent d54b666d02
commit 62c4836fc1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java
View file

@ -360,7 +360,7 @@ public class RefreshFolderOperation extends RemoteOperation {
Log_OC.d(TAG, "Remote folder " + mLocalFolder.getRemotePath() + " changed - starting update of local data ");
List<OCFile> updatedFiles = new Vector<>(folderAndFiles.size() - 1);
List<OCFile> updatedFiles = new ArrayList<>(folderAndFiles.size() - 1);
mFilesToSyncContents.clear();
// if local folder is encrypted, download fresh metadata