mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-27 09:39:25 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix magic numbers in ssl_untrusted_cert_layout.xml #12

Browse source
This commit is contained in:
Divay Prakash 2016-10-07 07:17:29 +05:30
parent 2a782e7b2e
commit 544aa3997a
No known key found for this signature in database
GPG key ID: 81365216092AA888
2 changed files with 34 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
res/layout/ssl_untrusted_cert_layout.xml
View file

@ -41,7 +41,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="0" android:layout_weight="0"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="8dp" android:paddingLeft="@dimen/standard_half_padding"
android:text="@string/ssl_validator_reason_cert_not_trusted" android:text="@string/ssl_validator_reason_cert_not_trusted"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -52,7 +52,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="8dp" android:paddingLeft="@dimen/standard_half_padding"
android:text="@string/ssl_validator_reason_cert_expired" android:text="@string/ssl_validator_reason_cert_expired"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -62,7 +62,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="8dp" android:paddingLeft="@dimen/standard_half_padding"
android:text="@string/ssl_validator_reason_cert_not_yet_valid" android:text="@string/ssl_validator_reason_cert_not_yet_valid"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -72,7 +72,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="8dp" android:paddingLeft="@dimen/standard_half_padding"
android:text="@string/ssl_validator_reason_hostname_not_verified" android:text="@string/ssl_validator_reason_hostname_not_verified"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -82,7 +82,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="8dp" android:paddingLeft="@dimen/standard_half_padding"
android:text="@string/ssl_validator_no_info_about_error" android:text="@string/ssl_validator_no_info_about_error"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -90,9 +90,9 @@
<ScrollView <ScrollView
android:id="@+id/details_scroll" android:id="@+id/details_scroll"
android:visibility="gone" android:visibility="gone"
android:padding="8dp" android:padding="@dimen/standard_half_padding"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="0dp" android:layout_height="@dimen/zero"
android:layout_weight="1" android:layout_weight="1"
> >
@ -108,7 +108,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="left" android:layout_gravity="left"
android:paddingLeft="20dp" android:paddingLeft="@dimen/ssl_untrusted_cert_layout_padding"
android:text="@string/ssl_validator_null_cert" android:text="@string/ssl_validator_null_cert"
android:textAppearance="?android:attr/textAppearanceSmall" /> android:textAppearance="?android:attr/textAppearanceSmall" />
@ -116,7 +116,7 @@
android:id="@+id/label_subject" android:id="@+id/label_subject"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="@string/ssl_validator_label_subject" android:text="@string/ssl_validator_label_subject"
android:textAppearance="?android:attr/textAppearanceMedium" android:textAppearance="?android:attr/textAppearanceMedium"
/> />
@ -133,7 +133,7 @@
android:id="@+id/value_subject_CN" android:id="@+id/value_subject_CN"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -150,7 +150,7 @@
android:id="@+id/value_subject_O" android:id="@+id/value_subject_O"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -167,7 +167,7 @@
android:id="@+id/value_subject_OU" android:id="@+id/value_subject_OU"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -184,7 +184,7 @@
android:id="@+id/value_subject_ST" android:id="@+id/value_subject_ST"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -201,7 +201,7 @@
android:id="@+id/value_subject_C" android:id="@+id/value_subject_C"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -218,7 +218,7 @@
android:id="@+id/value_subject_L" android:id="@+id/value_subject_L"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -228,7 +228,7 @@
android:id="@+id/label_issuer" android:id="@+id/label_issuer"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="@string/ssl_validator_label_issuer" android:text="@string/ssl_validator_label_issuer"
android:textAppearance="?android:attr/textAppearanceMedium" android:textAppearance="?android:attr/textAppearanceMedium"
/> />
@ -245,7 +245,7 @@
android:id="@+id/value_issuer_CN" android:id="@+id/value_issuer_CN"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -262,7 +262,7 @@
android:id="@+id/value_issuer_O" android:id="@+id/value_issuer_O"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -279,7 +279,7 @@
android:id="@+id/value_issuer_OU" android:id="@+id/value_issuer_OU"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -296,7 +296,7 @@
android:id="@+id/value_issuer_ST" android:id="@+id/value_issuer_ST"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -313,7 +313,7 @@
android:id="@+id/value_issuer_C" android:id="@+id/value_issuer_C"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -330,7 +330,7 @@
android:id="@+id/value_issuer_L" android:id="@+id/value_issuer_L"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -339,7 +339,7 @@
android:id="@+id/label_validity" android:id="@+id/label_validity"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="@string/ssl_validator_label_validity" android:text="@string/ssl_validator_label_validity"
android:textAppearance="?android:attr/textAppearanceMedium" android:textAppearance="?android:attr/textAppearanceMedium"
/> />
@ -356,7 +356,7 @@
android:id="@+id/value_validity_from" android:id="@+id/value_validity_from"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -373,7 +373,7 @@
android:id="@+id/value_validity_to" android:id="@+id/value_validity_to"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -382,7 +382,7 @@
android:id="@+id/label_signature" android:id="@+id/label_signature"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="@string/ssl_validator_label_signature" android:text="@string/ssl_validator_label_signature"
android:textAppearance="?android:attr/textAppearanceMedium" android:textAppearance="?android:attr/textAppearanceMedium"
/> />
@ -399,7 +399,7 @@
android:id="@+id/value_signature_algorithm" android:id="@+id/value_signature_algorithm"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -408,7 +408,7 @@
android:id="@+id/label_certificate_fingerprint" android:id="@+id/label_certificate_fingerprint"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="@string/ssl_validator_label_certificate_fingerprint" android:text="@string/ssl_validator_label_certificate_fingerprint"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -417,7 +417,7 @@
android:id="@+id/value_certificate_fingerprint" android:id="@+id/value_certificate_fingerprint"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingBottom="5dp" android:paddingBottom="@dimen/alternate_half_padding"
android:text="" android:text=""
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
/> />
@ -445,7 +445,7 @@
<android.support.v7.widget.AppCompatButton <android.support.v7.widget.AppCompatButton
android:id="@+id/cancel" android:id="@+id/cancel"
style="@style/Button.Borderless" style="@style/Button.Borderless"
android:layout_width="0dp" android:layout_width="@dimen/zero"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="1" android:layout_weight="1"
android:text="@string/common_no" /> android:text="@string/common_no" />
@ -453,7 +453,7 @@
<android.support.v7.widget.AppCompatButton <android.support.v7.widget.AppCompatButton
android:id="@+id/details_btn" android:id="@+id/details_btn"
style="@style/Button.Borderless" style="@style/Button.Borderless"
android:layout_width="0dp" android:layout_width="@dimen/zero"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="2" android:layout_weight="2"
android:text="@string/ssl_validator_btn_details_see" /> android:text="@string/ssl_validator_btn_details_see" />
@ -461,7 +461,7 @@
<android.support.v7.widget.AppCompatButton <android.support.v7.widget.AppCompatButton
android:id="@+id/ok" android:id="@+id/ok"
style="@style/Button.Borderless" style="@style/Button.Borderless"
android:layout_width="0dp" android:layout_width="@dimen/zero"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="1" android:layout_weight="1"
android:text="@string/common_yes" /> android:text="@string/common_yes" />

2
res/values/dims.xml
View file

@ -118,4 +118,6 @@
<dimen name="unshare_icon_size">36dp</dimen> <dimen name="unshare_icon_size">36dp</dimen>
<dimen name="simple_dialog_list_item_layout_size">48dp</dimen> <dimen name="simple_dialog_list_item_layout_size">48dp</dimen>
<dimen name="ssl_untrusted_cert_layout_padding">20dp</dimen>
</resources> </resources>