From 028b934c0bc6cc80b51de59ddc8e64f43788abf7 Mon Sep 17 00:00:00 2001
From: Divay Prakash <divayprakash3@gmail.com>
Date: Fri, 7 Oct 2016 06:11:34 +0530
Subject: [PATCH] Fix magic numbers in file_download_fragment.xml #12

---
 res/layout/file_download_fragment.xml | 16 ++++++++--------
 res/values/dims.xml                   |  4 ++++
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/res/layout/file_download_fragment.xml b/res/layout/file_download_fragment.xml
index fb3fa99731..28d1846dda 100644
--- a/res/layout/file_download_fragment.xml
+++ b/res/layout/file_download_fragment.xml
@@ -22,7 +22,7 @@
 	android:orientation="vertical" 
 	android:layout_gravity="center"
 	android:gravity="center_vertical"
-	android:padding="20dp"
+	android:padding="@dimen/file_download_fragment_layout_padding"
 	android:background="@color/black"
 	>
 	
@@ -32,7 +32,7 @@
 		android:layout_height="wrap_content"
 		android:textColor="@color/dark_background_text_color"
 		android:text="@string/downloader_not_downloaded_yet"
-		android:layout_marginBottom="15dp"
+		android:layout_marginBottom="@dimen/alternate_fragment_margin"
 	/>
 	
     <LinearLayout
@@ -40,13 +40,13 @@
 		android:layout_width="match_parent"
 		android:layout_height="wrap_content"
 		android:gravity="center"
-		android:layout_marginTop="12dp"
-		android:layout_marginBottom="15dp"
+		android:layout_marginTop="@dimen/fragment_margin"
+		android:layout_marginBottom="@dimen/alternate_fragment_margin"
 		android:orientation="horizontal"
 		>
 	    				
 		<ProgressBar android:id="@+id/progressBar"
-			android:layout_width="0dp"
+			android:layout_width="@dimen/zero"
 			android:layout_height="wrap_content"
 			android:layout_weight="1"
 			style="?android:attr/progressBarStyleHorizontal"
@@ -59,7 +59,7 @@
 			android:id="@+id/cancelBtn"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content"
-			android:layout_marginLeft="12dp"
+			android:layout_marginLeft="@dimen/fragment_margin"
 			android:src="@drawable/ic_action_cancel_grey"
 			android:background="@android:color/transparent"
 		/>
@@ -70,7 +70,7 @@
 		android:id="@+id/error_image"
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
-		android:layout_margin="0dp"
+		android:layout_margin="@dimen/zero"
 		android:layout_gravity="center_horizontal"
 		android:contentDescription="@string/downloader_download_failed_ticker"
 		android:src="@drawable/image_fail" />
@@ -80,7 +80,7 @@
 	    android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
 		android:layout_gravity="center_horizontal"
-		android:layout_margin="40dp"
+		android:layout_margin="@dimen/file_download_fragment_display_text_margin"
 		android:textColor="@color/dark_background_text_color"
 		android:text="@string/downloader_download_failed_ticker"
 	/>
diff --git a/res/values/dims.xml b/res/values/dims.xml
index 5b4b3b2b74..42d3ae5e9a 100644
--- a/res/values/dims.xml
+++ b/res/values/dims.xml
@@ -81,4 +81,8 @@
     <dimen name="file_actions_view_height">2dp</dimen>
 
     <dimen name="fragment_margin">12dp</dimen>
+
+    <dimen name="file_download_fragment_layout_padding">20dp</dimen>
+    <dimen name="alternate_fragment_margin">15dp</dimen>
+    <dimen name="file_download_fragment_display_text_margin">40dp</dimen>
 </resources>