mirrors/mCaptcha
1
0
Fork 0
mirror of https://github.com/mCaptcha/mCaptcha.git synced 2024-11-26 19:36:01 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix: initialize DOM elements only when executing methods/in pages that

Browse source 
contain those elements

SUMMARY
    Trying to grab elements globally in a script results in it trying to
    initialize in all pages. When the element is absent, the script
    fails and JavaScript crashes.
This commit is contained in:
realaravinth 2022-07-23 00:48:15 +05:30
parent b12c30e956
commit b6afe79a81
No known key found for this signature in database
GPG key ID: AD9F0F08E855ED88
3 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
templates/index.ts
View file

@ -49,8 +49,14 @@ router.register(VIEWS.notifications, notidications.index);
router.register(VIEWS.listSitekey, listSitekeys.index); router.register(VIEWS.listSitekey, listSitekeys.index);
router.register(VIEWS.addSiteKeyAdvance, addSiteKeyAdvance.index); router.register(VIEWS.addSiteKeyAdvance, addSiteKeyAdvance.index);
router.register(VIEWS.addSiteKeyEasy, addSiteKeyEasy.index); router.register(VIEWS.addSiteKeyEasy, addSiteKeyEasy.index);
router.register(VIEWS.editSitekeyAdvance("[A-Z),a-z,0-9]+"), editSitekeyAdvance.index); router.register(
router.register(VIEWS.editSitekeyEasy("[A-Z),a-z,0-9]+"), editSitekeyEasy.index); VIEWS.editSitekeyAdvance("[A-Z),a-z,0-9]+"),
editSitekeyAdvance.index
);
router.register(
VIEWS.editSitekeyEasy("[A-Z),a-z,0-9]+"),
editSitekeyEasy.index
);
router.register(VIEWS.deleteSitekey("[A-Z),a-z,0-9]+"), deleteSitekey.index); router.register(VIEWS.deleteSitekey("[A-Z),a-z,0-9]+"), deleteSitekey.index);
try { try {

18
templates/panel/sitekey/add/novice/ts/form.ts
View file

@ -30,14 +30,6 @@ export const FORM = <HTMLFormElement>(
document.querySelector(`.${SITE_KEY_FORM_CLASS}`) document.querySelector(`.${SITE_KEY_FORM_CLASS}`)
); );
export const AVG_TRAFFIC = <HTMLInputElement>FORM.querySelector("#avg_traffic");
export const PEAK_TRAFFIC = <HTMLInputElement>(
FORM.querySelector("#peak_sustainable_traffic")
);
export const BROKE_MY_SITE_TRAFFIC = <HTMLInputElement>(
FORM.querySelector("#broke_my_site_traffic")
);
export const addSubmitEventListener = (): void => export const addSubmitEventListener = (): void =>
FORM.addEventListener("submit", submit, true); FORM.addEventListener("submit", submit, true);
@ -57,6 +49,16 @@ export const validate = (e: Event): TrafficPattern => {
let broke_is_set = false; let broke_is_set = false;
const AVG_TRAFFIC = <HTMLInputElement>(
FORM.querySelector("#avg_traffic")
);
const PEAK_TRAFFIC = <HTMLInputElement>(
FORM.querySelector("#peak_sustainable_traffic")
);
const BROKE_MY_SITE_TRAFFIC = <HTMLInputElement>(
FORM.querySelector("#broke_my_site_traffic")
);
isBlankString(AVG_TRAFFIC.value, avg_traffic_name); isBlankString(AVG_TRAFFIC.value, avg_traffic_name);
isBlankString(PEAK_TRAFFIC.value, peak_traffic_name); isBlankString(PEAK_TRAFFIC.value, peak_traffic_name);

2
templates/panel/sitekey/edit/easy/form.ts
View file

@ -25,10 +25,10 @@ import { validate, FORM } from "../../add/novice/ts/form";
const SUBMIT_BTN = <HTMLButtonElement>( const SUBMIT_BTN = <HTMLButtonElement>(
document.querySelector(".sitekey-form__submit") document.querySelector(".sitekey-form__submit")
); );
const key = SUBMIT_BTN.dataset.sitekey;
const submit = async (e: Event) => { const submit = async (e: Event) => {
e.preventDefault(); e.preventDefault();
const key = SUBMIT_BTN.dataset.sitekey;
const formUrl = getFormUrl(FORM); const formUrl = getFormUrl(FORM);
const payload = { const payload = {
pattern: validate(e), pattern: validate(e),