mirror of
https://codeberg.org/superseriousbusiness/gotosocial.git
synced 2024-12-27 19:38:26 +03:00
ac6ed3d939
* upstep bun and sqlite versions * allow specific columns to be updated in the db * only update necessary columns for user * bit tidier * only update necessary fields of media_attachment * only update relevant instance fields * update tests * update only specific account columns * use bool pointers on gtsmodels includes attachment, status, account, user * update columns more selectively * test all default fields on new account insert * updating remaining bools on gtsmodels * initialize pointer fields when extracting AP emoji * copy bools properly * add copyBoolPtr convenience function + test it * initialize false bool ptrs a bit more neatly
117 lines
4 KiB
Go
117 lines
4 KiB
Go
package auth_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gin-contrib/sessions"
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/client/auth"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
type AuthAuthorizeTestSuite struct {
|
|
AuthStandardTestSuite
|
|
}
|
|
|
|
type authorizeHandlerTestCase struct {
|
|
description string
|
|
mutateUserAccount func(*gtsmodel.User, *gtsmodel.Account) []string
|
|
expectedStatusCode int
|
|
expectedLocationHeader string
|
|
}
|
|
|
|
func (suite *AuthAuthorizeTestSuite) TestAccountAuthorizeHandler() {
|
|
tests := []authorizeHandlerTestCase{
|
|
{
|
|
description: "user has their email unconfirmed",
|
|
mutateUserAccount: func(user *gtsmodel.User, account *gtsmodel.Account) []string {
|
|
// nothing to do, weed_lord420 already has their email unconfirmed
|
|
return nil
|
|
},
|
|
expectedStatusCode: http.StatusSeeOther,
|
|
expectedLocationHeader: auth.CheckYourEmailPath,
|
|
},
|
|
{
|
|
description: "user has their email confirmed but is not approved",
|
|
mutateUserAccount: func(user *gtsmodel.User, account *gtsmodel.Account) []string {
|
|
user.ConfirmedAt = time.Now()
|
|
user.Email = user.UnconfirmedEmail
|
|
return []string{"confirmed_at", "email"}
|
|
},
|
|
expectedStatusCode: http.StatusSeeOther,
|
|
expectedLocationHeader: auth.WaitForApprovalPath,
|
|
},
|
|
{
|
|
description: "user has their email confirmed and is approved, but User entity has been disabled",
|
|
mutateUserAccount: func(user *gtsmodel.User, account *gtsmodel.Account) []string {
|
|
user.ConfirmedAt = time.Now()
|
|
user.Email = user.UnconfirmedEmail
|
|
user.Approved = testrig.TrueBool()
|
|
user.Disabled = testrig.TrueBool()
|
|
return []string{"confirmed_at", "email", "approved", "disabled"}
|
|
},
|
|
expectedStatusCode: http.StatusSeeOther,
|
|
expectedLocationHeader: auth.AccountDisabledPath,
|
|
},
|
|
{
|
|
description: "user has their email confirmed and is approved, but Account entity has been suspended",
|
|
mutateUserAccount: func(user *gtsmodel.User, account *gtsmodel.Account) []string {
|
|
user.ConfirmedAt = time.Now()
|
|
user.Email = user.UnconfirmedEmail
|
|
user.Approved = testrig.TrueBool()
|
|
user.Disabled = testrig.FalseBool()
|
|
account.SuspendedAt = time.Now()
|
|
return []string{"confirmed_at", "email", "approved", "disabled"}
|
|
},
|
|
expectedStatusCode: http.StatusSeeOther,
|
|
expectedLocationHeader: auth.AccountDisabledPath,
|
|
},
|
|
}
|
|
|
|
doTest := func(testCase authorizeHandlerTestCase) {
|
|
ctx, recorder := suite.newContext(http.MethodGet, auth.OauthAuthorizePath, nil, "")
|
|
|
|
user := suite.testUsers["unconfirmed_account"]
|
|
account := suite.testAccounts["unconfirmed_account"]
|
|
|
|
testSession := sessions.Default(ctx)
|
|
testSession.Set(sessionUserID, user.ID)
|
|
testSession.Set(sessionClientID, suite.testApplications["application_1"].ClientID)
|
|
if err := testSession.Save(); err != nil {
|
|
panic(fmt.Errorf("failed on case %s: %w", testCase.description, err))
|
|
}
|
|
|
|
updatingColumns := testCase.mutateUserAccount(user, account)
|
|
|
|
testCase.description = fmt.Sprintf("%s, %t, %s", user.Email, *user.Disabled, account.SuspendedAt)
|
|
|
|
updatingColumns = append(updatingColumns, "updated_at")
|
|
user.UpdatedAt = time.Now()
|
|
err := suite.db.UpdateByPrimaryKey(context.Background(), user, updatingColumns...)
|
|
suite.NoError(err)
|
|
_, err = suite.db.UpdateAccount(context.Background(), account)
|
|
suite.NoError(err)
|
|
|
|
// call the handler
|
|
suite.authModule.AuthorizeGETHandler(ctx)
|
|
|
|
// 1. we should have a redirect
|
|
suite.Equal(testCase.expectedStatusCode, recorder.Code, fmt.Sprintf("failed on case: %s", testCase.description))
|
|
|
|
// 2. we should have a redirect to the check your email path, as this user has not confirmed their email yet.
|
|
suite.Equal(testCase.expectedLocationHeader, recorder.Header().Get("Location"), fmt.Sprintf("failed on case: %s", testCase.description))
|
|
}
|
|
|
|
for _, testCase := range tests {
|
|
doTest(testCase)
|
|
}
|
|
}
|
|
|
|
func TestAccountUpdateTestSuite(t *testing.T) {
|
|
suite.Run(t, new(AuthAuthorizeTestSuite))
|
|
}
|