mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-23 13:55:42 +03:00
e24f651c86
So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well). |
||
---|---|---|
.. | ||
webhook | ||
actions.tmpl | ||
branches.tmpl | ||
collaboration.tmpl | ||
deploy_keys.tmpl | ||
githook_edit.tmpl | ||
githooks.tmpl | ||
layout_footer.tmpl | ||
layout_head.tmpl | ||
lfs.tmpl | ||
lfs_file.tmpl | ||
lfs_file_find.tmpl | ||
lfs_locks.tmpl | ||
lfs_pointers.tmpl | ||
nav.tmpl | ||
navbar.tmpl | ||
options.tmpl | ||
protected_branch.tmpl | ||
runner_edit.tmpl | ||
secrets.tmpl | ||
tags.tmpl |