mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-30 08:03:52 +03:00
93ab90743d
If the context is cancelled `.NotificationUnreadCount` in a template can cause an infinite loop with `ctx.ServerError()` being called, which creates a template that then calls `.NotificationUnreadCount` calling `GetNotificationCount()` with the cancelled context resulting in an error that calls `ctx.ServerError`... and so on... This PR simply stops calling `ctx.ServerError` in the error handler code for `.NotificationUnreadCount` as we have already started rendering and so it is too late to call `ctx.ServerError`. Additionally we skip logging the error if it's a context cancelled error. Fix #19793 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
203 lines
5.2 KiB
Go
203 lines
5.2 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package user
|
|
|
|
import (
|
|
goctx "context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/base"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/structs"
|
|
)
|
|
|
|
const (
|
|
tplNotification base.TplName = "user/notification/notification"
|
|
tplNotificationDiv base.TplName = "user/notification/notification_div"
|
|
)
|
|
|
|
// GetNotificationCount is the middleware that sets the notification count in the context
|
|
func GetNotificationCount(c *context.Context) {
|
|
if strings.HasPrefix(c.Req.URL.Path, "/api") {
|
|
return
|
|
}
|
|
|
|
if !c.IsSigned {
|
|
return
|
|
}
|
|
|
|
c.Data["NotificationUnreadCount"] = func() int64 {
|
|
count, err := models.GetNotificationCount(c, c.Doer, models.NotificationStatusUnread)
|
|
if err != nil {
|
|
if err != goctx.Canceled {
|
|
log.Error("Unable to GetNotificationCount for user:%-v: %v", c.Doer, err)
|
|
}
|
|
return -1
|
|
}
|
|
|
|
return count
|
|
}
|
|
}
|
|
|
|
// Notifications is the notifications page
|
|
func Notifications(c *context.Context) {
|
|
getNotifications(c)
|
|
if c.Written() {
|
|
return
|
|
}
|
|
if c.FormBool("div-only") {
|
|
c.Data["SequenceNumber"] = c.FormString("sequence-number")
|
|
c.HTML(http.StatusOK, tplNotificationDiv)
|
|
return
|
|
}
|
|
c.HTML(http.StatusOK, tplNotification)
|
|
}
|
|
|
|
func getNotifications(c *context.Context) {
|
|
var (
|
|
keyword = c.FormTrim("q")
|
|
status models.NotificationStatus
|
|
page = c.FormInt("page")
|
|
perPage = c.FormInt("perPage")
|
|
)
|
|
if page < 1 {
|
|
page = 1
|
|
}
|
|
if perPage < 1 {
|
|
perPage = 20
|
|
}
|
|
|
|
switch keyword {
|
|
case "read":
|
|
status = models.NotificationStatusRead
|
|
default:
|
|
status = models.NotificationStatusUnread
|
|
}
|
|
|
|
total, err := models.GetNotificationCount(c, c.Doer, status)
|
|
if err != nil {
|
|
c.ServerError("ErrGetNotificationCount", err)
|
|
return
|
|
}
|
|
|
|
// redirect to last page if request page is more than total pages
|
|
pager := context.NewPagination(int(total), perPage, page, 5)
|
|
if pager.Paginater.Current() < page {
|
|
c.Redirect(fmt.Sprintf("%s/notifications?q=%s&page=%d", setting.AppSubURL, url.QueryEscape(c.FormString("q")), pager.Paginater.Current()))
|
|
return
|
|
}
|
|
|
|
statuses := []models.NotificationStatus{status, models.NotificationStatusPinned}
|
|
notifications, err := models.NotificationsForUser(c, c.Doer, statuses, page, perPage)
|
|
if err != nil {
|
|
c.ServerError("ErrNotificationsForUser", err)
|
|
return
|
|
}
|
|
|
|
failCount := 0
|
|
|
|
repos, failures, err := notifications.LoadRepos()
|
|
if err != nil {
|
|
c.ServerError("LoadRepos", err)
|
|
return
|
|
}
|
|
notifications = notifications.Without(failures)
|
|
if err := repos.LoadAttributes(); err != nil {
|
|
c.ServerError("LoadAttributes", err)
|
|
return
|
|
}
|
|
failCount += len(failures)
|
|
|
|
failures, err = notifications.LoadIssues()
|
|
if err != nil {
|
|
c.ServerError("LoadIssues", err)
|
|
return
|
|
}
|
|
notifications = notifications.Without(failures)
|
|
failCount += len(failures)
|
|
|
|
failures, err = notifications.LoadComments()
|
|
if err != nil {
|
|
c.ServerError("LoadComments", err)
|
|
return
|
|
}
|
|
notifications = notifications.Without(failures)
|
|
failCount += len(failures)
|
|
|
|
if failCount > 0 {
|
|
c.Flash.Error(fmt.Sprintf("ERROR: %d notifications were removed due to missing parts - check the logs", failCount))
|
|
}
|
|
|
|
c.Data["Title"] = c.Tr("notifications")
|
|
c.Data["Keyword"] = keyword
|
|
c.Data["Status"] = status
|
|
c.Data["Notifications"] = notifications
|
|
|
|
pager.SetDefaultParams(c)
|
|
c.Data["Page"] = pager
|
|
}
|
|
|
|
// NotificationStatusPost is a route for changing the status of a notification
|
|
func NotificationStatusPost(c *context.Context) {
|
|
var (
|
|
notificationID = c.FormInt64("notification_id")
|
|
statusStr = c.FormString("status")
|
|
status models.NotificationStatus
|
|
)
|
|
|
|
switch statusStr {
|
|
case "read":
|
|
status = models.NotificationStatusRead
|
|
case "unread":
|
|
status = models.NotificationStatusUnread
|
|
case "pinned":
|
|
status = models.NotificationStatusPinned
|
|
default:
|
|
c.ServerError("InvalidNotificationStatus", errors.New("Invalid notification status"))
|
|
return
|
|
}
|
|
|
|
if _, err := models.SetNotificationStatus(notificationID, c.Doer, status); err != nil {
|
|
c.ServerError("SetNotificationStatus", err)
|
|
return
|
|
}
|
|
|
|
if !c.FormBool("noredirect") {
|
|
url := fmt.Sprintf("%s/notifications?page=%s", setting.AppSubURL, url.QueryEscape(c.FormString("page")))
|
|
c.Redirect(url, http.StatusSeeOther)
|
|
}
|
|
|
|
getNotifications(c)
|
|
if c.Written() {
|
|
return
|
|
}
|
|
c.Data["Link"] = setting.AppURL + "notifications"
|
|
c.Data["SequenceNumber"] = c.Req.PostFormValue("sequence-number")
|
|
|
|
c.HTML(http.StatusOK, tplNotificationDiv)
|
|
}
|
|
|
|
// NotificationPurgePost is a route for 'purging' the list of notifications - marking all unread as read
|
|
func NotificationPurgePost(c *context.Context) {
|
|
err := models.UpdateNotificationStatuses(c.Doer, models.NotificationStatusUnread, models.NotificationStatusRead)
|
|
if err != nil {
|
|
c.ServerError("ErrUpdateNotificationStatuses", err)
|
|
return
|
|
}
|
|
|
|
c.Redirect(setting.AppSubURL+"/notifications", http.StatusSeeOther)
|
|
}
|
|
|
|
// NewAvailable returns the notification counts
|
|
func NewAvailable(ctx *context.Context) {
|
|
ctx.JSON(http.StatusOK, structs.NotificationCount{New: models.CountUnread(ctx, ctx.Doer.ID)})
|
|
}
|