mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-21 05:42:28 +03:00
07bc099401
Follow-up of #2282 and #2296 (which tried to address #2278) One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated). To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding). Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr> |
||
|---|---|---|
| .. | ||
| blob_excerpt.tmpl | ||
| box.tmpl | ||
| comment_form.tmpl | ||
| comment_form_datahandler.tmpl | ||
| comments.tmpl | ||
| compare.tmpl | ||
| conversation.tmpl | ||
| conversations.tmpl | ||
| csv_diff.tmpl | ||
| escape_title.tmpl | ||
| image_diff.tmpl | ||
| new_comment.tmpl | ||
| new_review.tmpl | ||
| options_dropdown.tmpl | ||
| section_code.tmpl | ||
| section_split.tmpl | ||
| section_unified.tmpl | ||
| stats.tmpl | ||
| whitespace_dropdown.tmpl | ||