mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-15 02:41:48 +03:00
3362620ee3
On the @Forgejo instance of Codeberg, we discovered that forking a repo which is already forked now returns a 500 Internal Server Error, which is unexpected. This is an attempt at fixing this. The error message in the log: ~~~ 2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E] [6450cb8e-113] ForkRepository: repository is already forked by user [uname: ...., repo path: .../..., fork path: .../...] ~~~ The service that is used for forking returns a custom error message which is not checked against. About the order of options: The case that the fork already exists should be more common, followed by the case that a repo with the same name already exists for other reasons. The case that the global repo limit is hit is probably not the likeliest. Co-authored-by: Otto Richter <otto@codeberg.org> Co-authored-by: Giteabot <teabot@gitea.io>
154 lines
4.2 KiB
Go
154 lines
4.2 KiB
Go
// Copyright 2016 The Gogs Authors. All rights reserved.
|
|
// Copyright 2020 The Gitea Authors.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"code.gitea.io/gitea/models/organization"
|
|
"code.gitea.io/gitea/models/perm"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/context"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/web"
|
|
"code.gitea.io/gitea/routers/api/v1/utils"
|
|
"code.gitea.io/gitea/services/convert"
|
|
repo_service "code.gitea.io/gitea/services/repository"
|
|
)
|
|
|
|
// ListForks list a repository's forks
|
|
func ListForks(ctx *context.APIContext) {
|
|
// swagger:operation GET /repos/{owner}/{repo}/forks repository listForks
|
|
// ---
|
|
// summary: List a repository's forks
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: owner
|
|
// in: path
|
|
// description: owner of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: repo
|
|
// in: path
|
|
// description: name of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: page
|
|
// in: query
|
|
// description: page number of results to return (1-based)
|
|
// type: integer
|
|
// - name: limit
|
|
// in: query
|
|
// description: page size of results
|
|
// type: integer
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/RepositoryList"
|
|
|
|
forks, err := repo_model.GetForks(ctx.Repo.Repository, utils.GetListOptions(ctx))
|
|
if err != nil {
|
|
ctx.Error(http.StatusInternalServerError, "GetForks", err)
|
|
return
|
|
}
|
|
apiForks := make([]*api.Repository, len(forks))
|
|
for i, fork := range forks {
|
|
access, err := access_model.AccessLevel(ctx, ctx.Doer, fork)
|
|
if err != nil {
|
|
ctx.Error(http.StatusInternalServerError, "AccessLevel", err)
|
|
return
|
|
}
|
|
apiForks[i] = convert.ToRepo(ctx, fork, access)
|
|
}
|
|
|
|
ctx.SetTotalCountHeader(int64(ctx.Repo.Repository.NumForks))
|
|
ctx.JSON(http.StatusOK, apiForks)
|
|
}
|
|
|
|
// CreateFork create a fork of a repo
|
|
func CreateFork(ctx *context.APIContext) {
|
|
// swagger:operation POST /repos/{owner}/{repo}/forks repository createFork
|
|
// ---
|
|
// summary: Fork a repository
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: owner
|
|
// in: path
|
|
// description: owner of the repo to fork
|
|
// type: string
|
|
// required: true
|
|
// - name: repo
|
|
// in: path
|
|
// description: name of the repo to fork
|
|
// type: string
|
|
// required: true
|
|
// - name: body
|
|
// in: body
|
|
// schema:
|
|
// "$ref": "#/definitions/CreateForkOption"
|
|
// responses:
|
|
// "202":
|
|
// "$ref": "#/responses/Repository"
|
|
// "403":
|
|
// "$ref": "#/responses/forbidden"
|
|
// "409":
|
|
// description: The repository with the same name already exists.
|
|
// "422":
|
|
// "$ref": "#/responses/validationError"
|
|
|
|
form := web.GetForm(ctx).(*api.CreateForkOption)
|
|
repo := ctx.Repo.Repository
|
|
var forker *user_model.User // user/org that will own the fork
|
|
if form.Organization == nil {
|
|
forker = ctx.Doer
|
|
} else {
|
|
org, err := organization.GetOrgByName(ctx, *form.Organization)
|
|
if err != nil {
|
|
if organization.IsErrOrgNotExist(err) {
|
|
ctx.Error(http.StatusUnprocessableEntity, "", err)
|
|
} else {
|
|
ctx.Error(http.StatusInternalServerError, "GetOrgByName", err)
|
|
}
|
|
return
|
|
}
|
|
isMember, err := org.IsOrgMember(ctx.Doer.ID)
|
|
if err != nil {
|
|
ctx.Error(http.StatusInternalServerError, "IsOrgMember", err)
|
|
return
|
|
} else if !isMember {
|
|
ctx.Error(http.StatusForbidden, "isMemberNot", fmt.Sprintf("User is no Member of Organisation '%s'", org.Name))
|
|
return
|
|
}
|
|
forker = org.AsUser()
|
|
}
|
|
|
|
var name string
|
|
if form.Name == nil {
|
|
name = repo.Name
|
|
} else {
|
|
name = *form.Name
|
|
}
|
|
|
|
fork, err := repo_service.ForkRepository(ctx, ctx.Doer, forker, repo_service.ForkRepoOptions{
|
|
BaseRepo: repo,
|
|
Name: name,
|
|
Description: repo.Description,
|
|
})
|
|
if err != nil {
|
|
if repo_service.IsErrForkAlreadyExist(err) || repo_model.IsErrRepoAlreadyExist(err) || repo_model.IsErrReachLimitOfRepo(err) {
|
|
ctx.Error(http.StatusConflict, "ForkRepository", err)
|
|
} else {
|
|
ctx.Error(http.StatusInternalServerError, "ForkRepository", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
// TODO change back to 201
|
|
ctx.JSON(http.StatusAccepted, convert.ToRepo(ctx, fork, perm.AccessModeOwner))
|
|
}
|