mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-29 19:58:57 +03:00
26ef180f46
The rollback functionality in services/repository/repository.go:ForkRepository is incorrect and could lead to a deadlock as it uses DeleteRepository to delete the rolled-back repository - a function which creates its own transaction. This PR adjusts the rollback function to only use RemoveAll as any database changes will be automatically rolled-back. It also handles panics and adjusts the Close within WithTx to ensure that if there is a panic the session will always be closed. Signed-off-by: Andrew Thornton <art27@cantab.net>
71 lines
1.7 KiB
Go
71 lines
1.7 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package models
|
|
|
|
import (
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
// DBContext represents a db context
|
|
type DBContext struct {
|
|
e Engine
|
|
}
|
|
|
|
// DefaultDBContext represents a DBContext with default Engine
|
|
func DefaultDBContext() DBContext {
|
|
return DBContext{x}
|
|
}
|
|
|
|
// Committer represents an interface to Commit or Close the dbcontext
|
|
type Committer interface {
|
|
Commit() error
|
|
Close() error
|
|
}
|
|
|
|
// TxDBContext represents a transaction DBContext
|
|
func TxDBContext() (DBContext, Committer, error) {
|
|
sess := x.NewSession()
|
|
if err := sess.Begin(); err != nil {
|
|
sess.Close()
|
|
return DBContext{}, nil, err
|
|
}
|
|
|
|
return DBContext{sess}, sess, nil
|
|
}
|
|
|
|
// WithContext represents executing database operations
|
|
func WithContext(f func(ctx DBContext) error) error {
|
|
return f(DBContext{x})
|
|
}
|
|
|
|
// WithTx represents executing database operations on a transaction
|
|
func WithTx(f func(ctx DBContext) error) error {
|
|
sess := x.NewSession()
|
|
defer sess.Close()
|
|
if err := sess.Begin(); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := f(DBContext{sess}); err != nil {
|
|
return err
|
|
}
|
|
|
|
return sess.Commit()
|
|
}
|
|
|
|
// Iterate iterates the databases and doing something
|
|
func Iterate(ctx DBContext, tableBean interface{}, cond builder.Cond, fun func(idx int, bean interface{}) error) error {
|
|
return ctx.e.Where(cond).
|
|
BufferSize(setting.Database.IterateBufferSize).
|
|
Iterate(tableBean, fun)
|
|
}
|
|
|
|
// Insert inserts records into database
|
|
func Insert(ctx DBContext, beans ...interface{}) error {
|
|
_, err := ctx.e.Insert(beans...)
|
|
return err
|
|
}
|