mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-19 12:52:11 +03:00
ef05332c3b
- On the wiki and revisions page, information is shown about the last
commit that modified that wiki page. This includes the time it was last
edited and by whom. That whole string is not being sanitized (passed
trough `Safe` in the templates), because the last edited bit is
formatted as an HTML element and thus shouldn't be sanitized. The
problem with this is that now `.Author.Name` is not being sanitized.
- This can be exploited, the names of authors and commiters on a Git
commit is user controlled, they can be any value and thus also include
HTML. It's not easy to actually exploit this, as you cannot use the
official git binary to do use, as they actually strip `<` and `>` from
user names (trivia: this behaviour was introduced in the initial commit
of Git). In the integration testing, go-git actually has to generate
this commit as they don't have such restrictions.
- Pass `.Author.Name` trough `Escape` in order to be sanitized.
(cherry picked from commit d24c37e132)
Conflicts:
templates/repo/wiki/revision.tmpl
templates/repo/wiki/view.tmpl
trivial context conflict
45 lines
1.4 KiB
Handlebars
45 lines
1.4 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository wiki revisions">
|
|
{{template "repo/header" .}}
|
|
{{$title := .title}}
|
|
<div class="ui container">
|
|
<div class="ui stackable grid">
|
|
<div class="ui eight wide column">
|
|
<div class="ui header">
|
|
<a class="file-revisions-btn ui basic button" title="{{.locale.Tr "repo.wiki.back_to_wiki"}}" href="{{.RepoLink}}/wiki/{{.PageURL}}"><span>{{.revision}}</span> {{svg "octicon-home"}}</a>
|
|
{{$title}}
|
|
<div class="ui sub header gt-word-break">
|
|
{{$timeSince := TimeSince .Author.When $.locale}}
|
|
{{.locale.Tr "repo.wiki.last_commit_info" (.Author.Name | Escape) $timeSince | Safe}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="ui eight wide column text right">
|
|
<div class="ui action small input" id="clone-panel">
|
|
{{template "repo/clone_buttons" .}}
|
|
{{template "repo/clone_script" .}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<h2 class="ui top header">{{.locale.Tr "repo.wiki.wiki_page_revisions"}}</h2>
|
|
<div class="gt-mt-4">
|
|
<h4 class="ui top attached header">
|
|
<div class="ui stackable grid">
|
|
<div class="sixteen wide column">
|
|
{{.CommitCount}} {{.locale.Tr "repo.commits.commits"}}
|
|
</div>
|
|
</div>
|
|
</h4>
|
|
|
|
{{if and .Commits (gt .CommitCount 0)}}
|
|
{{template "repo/commits_list" .}}
|
|
{{end}}
|
|
|
|
{{template "base/paginate" .}}
|
|
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
|
|
{{template "base/footer" .}}
|