mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-26 23:35:51 +03:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
413 lines
9.1 KiB
Go
413 lines
9.1 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/context"
|
|
auth "code.gitea.io/gitea/modules/forms"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/test"
|
|
"code.gitea.io/gitea/modules/util"
|
|
"code.gitea.io/gitea/modules/web"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func createSSHAuthorizedKeysTmpPath(t *testing.T) func() {
|
|
tmpDir, err := ioutil.TempDir("", "tmp-ssh")
|
|
if err != nil {
|
|
assert.Fail(t, "Unable to create temporary directory: %v", err)
|
|
return nil
|
|
}
|
|
|
|
oldPath := setting.SSH.RootPath
|
|
setting.SSH.RootPath = tmpDir
|
|
|
|
return func() {
|
|
setting.SSH.RootPath = oldPath
|
|
util.RemoveAll(tmpDir)
|
|
}
|
|
}
|
|
|
|
func TestAddReadOnlyDeployKey(t *testing.T) {
|
|
if deferable := createSSHAuthorizedKeysTmpPath(t); deferable != nil {
|
|
defer deferable()
|
|
} else {
|
|
return
|
|
}
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/settings/keys")
|
|
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 2)
|
|
|
|
addKeyForm := auth.AddKeyForm{
|
|
Title: "read-only",
|
|
Content: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n",
|
|
}
|
|
web.SetForm(ctx, &addKeyForm)
|
|
DeployKeysPost(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
|
|
models.AssertExistsAndLoadBean(t, &models.DeployKey{
|
|
Name: addKeyForm.Title,
|
|
Content: addKeyForm.Content,
|
|
Mode: models.AccessModeRead,
|
|
})
|
|
}
|
|
|
|
func TestAddReadWriteOnlyDeployKey(t *testing.T) {
|
|
if deferable := createSSHAuthorizedKeysTmpPath(t); deferable != nil {
|
|
defer deferable()
|
|
} else {
|
|
return
|
|
}
|
|
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/settings/keys")
|
|
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 2)
|
|
|
|
addKeyForm := auth.AddKeyForm{
|
|
Title: "read-write",
|
|
Content: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n",
|
|
IsWritable: true,
|
|
}
|
|
web.SetForm(ctx, &addKeyForm)
|
|
DeployKeysPost(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
|
|
models.AssertExistsAndLoadBean(t, &models.DeployKey{
|
|
Name: addKeyForm.Title,
|
|
Content: addKeyForm.Content,
|
|
Mode: models.AccessModeWrite,
|
|
})
|
|
}
|
|
|
|
func TestCollaborationPost(t *testing.T) {
|
|
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadUser(t, ctx, 4)
|
|
test.LoadRepo(t, ctx, 1)
|
|
|
|
ctx.Req.Form.Set("collaborator", "user4")
|
|
|
|
u := &models.User{
|
|
LowerName: "user2",
|
|
Type: models.UserTypeIndividual,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 2,
|
|
Owner: u,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: u,
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
CollaborationPost(ctx)
|
|
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
|
|
exists, err := re.IsCollaborator(4)
|
|
assert.NoError(t, err)
|
|
assert.True(t, exists)
|
|
}
|
|
|
|
func TestCollaborationPost_InactiveUser(t *testing.T) {
|
|
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadUser(t, ctx, 9)
|
|
test.LoadRepo(t, ctx, 1)
|
|
|
|
ctx.Req.Form.Set("collaborator", "user9")
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
LowerName: "user2",
|
|
},
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
CollaborationPost(ctx)
|
|
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestCollaborationPost_AddCollaboratorTwice(t *testing.T) {
|
|
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadUser(t, ctx, 4)
|
|
test.LoadRepo(t, ctx, 1)
|
|
|
|
ctx.Req.Form.Set("collaborator", "user4")
|
|
|
|
u := &models.User{
|
|
LowerName: "user2",
|
|
Type: models.UserTypeIndividual,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 2,
|
|
Owner: u,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: u,
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
CollaborationPost(ctx)
|
|
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
|
|
exists, err := re.IsCollaborator(4)
|
|
assert.NoError(t, err)
|
|
assert.True(t, exists)
|
|
|
|
// Try adding the same collaborator again
|
|
CollaborationPost(ctx)
|
|
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestCollaborationPost_NonExistentUser(t *testing.T) {
|
|
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
|
|
ctx.Req.Form.Set("collaborator", "user34")
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
LowerName: "user2",
|
|
},
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
CollaborationPost(ctx)
|
|
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestAddTeamPost(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "org26/repo43")
|
|
|
|
ctx.Req.Form.Set("team", "team11")
|
|
|
|
org := &models.User{
|
|
LowerName: "org26",
|
|
Type: models.UserTypeOrganization,
|
|
}
|
|
|
|
team := &models.Team{
|
|
ID: 11,
|
|
OrgID: 26,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 43,
|
|
Owner: org,
|
|
OwnerID: 26,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
ID: 26,
|
|
LowerName: "org26",
|
|
RepoAdminChangeTeamAccess: true,
|
|
},
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
AddTeamPost(ctx)
|
|
|
|
assert.True(t, team.HasRepository(re.ID))
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.Empty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestAddTeamPost_NotAllowed(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "org26/repo43")
|
|
|
|
ctx.Req.Form.Set("team", "team11")
|
|
|
|
org := &models.User{
|
|
LowerName: "org26",
|
|
Type: models.UserTypeOrganization,
|
|
}
|
|
|
|
team := &models.Team{
|
|
ID: 11,
|
|
OrgID: 26,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 43,
|
|
Owner: org,
|
|
OwnerID: 26,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
ID: 26,
|
|
LowerName: "org26",
|
|
RepoAdminChangeTeamAccess: false,
|
|
},
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
AddTeamPost(ctx)
|
|
|
|
assert.False(t, team.HasRepository(re.ID))
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
|
|
}
|
|
|
|
func TestAddTeamPost_AddTeamTwice(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "org26/repo43")
|
|
|
|
ctx.Req.Form.Set("team", "team11")
|
|
|
|
org := &models.User{
|
|
LowerName: "org26",
|
|
Type: models.UserTypeOrganization,
|
|
}
|
|
|
|
team := &models.Team{
|
|
ID: 11,
|
|
OrgID: 26,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 43,
|
|
Owner: org,
|
|
OwnerID: 26,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
ID: 26,
|
|
LowerName: "org26",
|
|
RepoAdminChangeTeamAccess: true,
|
|
},
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
AddTeamPost(ctx)
|
|
|
|
AddTeamPost(ctx)
|
|
assert.True(t, team.HasRepository(re.ID))
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestAddTeamPost_NonExistentTeam(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "org26/repo43")
|
|
|
|
ctx.Req.Form.Set("team", "team-non-existent")
|
|
|
|
org := &models.User{
|
|
LowerName: "org26",
|
|
Type: models.UserTypeOrganization,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 43,
|
|
Owner: org,
|
|
OwnerID: 26,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
ID: 26,
|
|
LowerName: "org26",
|
|
RepoAdminChangeTeamAccess: true,
|
|
},
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
AddTeamPost(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
|
}
|
|
|
|
func TestDeleteTeam(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "org3/team1/repo3")
|
|
|
|
ctx.Req.Form.Set("id", "2")
|
|
|
|
org := &models.User{
|
|
LowerName: "org3",
|
|
Type: models.UserTypeOrganization,
|
|
}
|
|
|
|
team := &models.Team{
|
|
ID: 2,
|
|
OrgID: 3,
|
|
}
|
|
|
|
re := &models.Repository{
|
|
ID: 3,
|
|
Owner: org,
|
|
OwnerID: 3,
|
|
}
|
|
|
|
repo := &context.Repository{
|
|
Owner: &models.User{
|
|
ID: 3,
|
|
LowerName: "org3",
|
|
RepoAdminChangeTeamAccess: true,
|
|
},
|
|
Repository: re,
|
|
}
|
|
|
|
ctx.Repo = repo
|
|
|
|
DeleteTeam(ctx)
|
|
|
|
assert.False(t, team.HasRepository(re.ID))
|
|
}
|