mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-22 21:35:35 +03:00
036f1eddc5
* Split TestPullRequest out of AddTestPullRequestTask
* Before scheduling the task, AddTestPullRequestTask stores the max
index of the repository
* When the task runs, it does not take into account pull requests that
have an index higher than the recorded max index
When AddTestPullRequestTask is called with isSync == true, it is the
direct consequence of a new commit being pushed. Forgejo knows nothing
of this new commit yet. If a PR is created later and its head
references the new commit, it will have an index that is higher and
must not be taken into account. It would be acting and triggering a
notification for a PR based on an event that happened before it
existed.
Refs: https://codeberg.org/forgejo/forgejo/issues/2009
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2236
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| archiver | ||
| files | ||
| adopt.go | ||
| adopt_test.go | ||
| avatar.go | ||
| avatar_test.go | ||
| branch.go | ||
| cache.go | ||
| check.go | ||
| collaboration.go | ||
| collaboration_test.go | ||
| commit.go | ||
| create.go | ||
| create_test.go | ||
| delete.go | ||
| delete_test.go | ||
| fork.go | ||
| fork_test.go | ||
| hooks.go | ||
| lfs.go | ||
| lfs_test.go | ||
| main_test.go | ||
| push.go | ||
| repository.go | ||
| repository_test.go | ||
| review.go | ||
| review_test.go | ||
| setting.go | ||
| template.go | ||
| transfer.go | ||
| transfer_test.go | ||