From 577dc2d7d6464a579a264f59edb8a9d2c9bfe609 Mon Sep 17 00:00:00 2001
From: 0ko <0ko@noreply.codeberg.org>
Date: Sun, 7 Jul 2024 14:37:45 +0500
Subject: [PATCH] i18n: fix sign up strings

To avoid conflicting with existing strings in translations. Also improve localizability.
---
 options/locale/locale_en-US.ini          | 4 ++--
 templates/user/auth/finalize_openid.tmpl | 2 +-
 templates/user/auth/signin_inner.tmpl    | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index b5bd435990..cc8689af67 100644
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -408,8 +408,8 @@ remember_me = Remember this device
 remember_me.compromised = The login token is not valid anymore which may indicate a compromised account. Please check your account for unusual activities.
 forgot_password_title= Forgot password
 forgot_password = Forgot password?
-need_account = Need an account?
-sign_up_now = Register now.
+hint_register = Need an account? <a href="%s">Register now</a>.
+sign_up_button = Register now.
 sign_up_successful = Account was successfully created. Welcome!
 confirmation_mail_sent_prompt = A new confirmation email has been sent to <b>%s</b>. Please check your inbox within the next %s to complete the registration process. If the email is incorrect, you can log in, and request another confirmation email to be sent to a different address.
 must_change_password = Update your password
diff --git a/templates/user/auth/finalize_openid.tmpl b/templates/user/auth/finalize_openid.tmpl
index 1c1dcdb825..f84f860b02 100644
--- a/templates/user/auth/finalize_openid.tmpl
+++ b/templates/user/auth/finalize_openid.tmpl
@@ -35,7 +35,7 @@
 					{{if .ShowRegistrationButton}}
 						<div class="inline field">
 							<label></label>
-							<a href="{{AppSubUrl}}/user/sign_up">{{ctx.Locale.Tr "auth.sign_up_now"}}</a>
+							<a href="{{AppSubUrl}}/user/sign_up">{{ctx.Locale.Tr "auth.sign_up_button"}}</a>
 						</div>
 					{{end}}
 					</form>
diff --git a/templates/user/auth/signin_inner.tmpl b/templates/user/auth/signin_inner.tmpl
index b0a52d2c64..444e4a12f4 100644
--- a/templates/user/auth/signin_inner.tmpl
+++ b/templates/user/auth/signin_inner.tmpl
@@ -57,8 +57,7 @@
 
 		{{if .ShowRegistrationButton}}
 			<div class="field">
-				<span>{{ctx.Locale.Tr "auth.need_account"}}</span>
-				<a href="{{AppSubUrl}}/user/sign_up">{{ctx.Locale.Tr "auth.sign_up_now"}}</a>
+				{{ctx.Locale.Tr "auth.hint_register" (printf "%s/user/sign_up" AppSubUrl)}}
 			</div>
 		{{end}}
 	</div>