2020-01-07 21:27:36 +03:00
|
|
|
// Copyright 2019 The Gitea Authors. All rights reserved.
|
2022-11-27 21:20:29 +03:00
|
|
|
// SPDX-License-Identifier: MIT
|
2020-01-07 21:27:36 +03:00
|
|
|
|
|
|
|
package wiki
|
|
|
|
|
|
|
|
import (
|
2023-04-19 20:50:10 +03:00
|
|
|
"math/rand"
|
2020-01-07 21:27:36 +03:00
|
|
|
"path/filepath"
|
2023-04-19 20:50:10 +03:00
|
|
|
"strings"
|
2020-01-07 21:27:36 +03:00
|
|
|
"testing"
|
|
|
|
|
2021-12-10 04:27:50 +03:00
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
2021-11-12 17:36:47 +03:00
|
|
|
"code.gitea.io/gitea/models/unittest"
|
2021-11-24 12:49:20 +03:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2020-01-07 21:27:36 +03:00
|
|
|
"code.gitea.io/gitea/modules/git"
|
2021-08-01 20:04:32 +03:00
|
|
|
|
2020-01-07 21:27:36 +03:00
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestMain(m *testing.M) {
|
2022-04-14 16:58:21 +03:00
|
|
|
unittest.MainTest(m, &unittest.TestOptions{
|
|
|
|
GiteaRootPath: filepath.Join("..", ".."),
|
|
|
|
})
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
func TestWebPathSegments(t *testing.T) {
|
|
|
|
a := WebPathSegments("a%2Fa/b+c/d-e/f-g.-")
|
|
|
|
assert.EqualValues(t, []string{"a/a", "b c", "d e", "f-g"}, a)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestUserTitleToWebPath(t *testing.T) {
|
2020-01-07 21:27:36 +03:00
|
|
|
type test struct {
|
2023-04-19 20:50:10 +03:00
|
|
|
Expected string
|
|
|
|
UserTitle string
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
for _, test := range []test{
|
2023-05-06 14:24:18 +03:00
|
|
|
{"unnamed", ""},
|
|
|
|
{"unnamed", "."},
|
|
|
|
{"unnamed", ".."},
|
2020-01-07 21:27:36 +03:00
|
|
|
{"wiki-name", "wiki name"},
|
2023-04-23 14:16:30 +03:00
|
|
|
{"title.md.-", "title.md"},
|
2023-04-19 20:50:10 +03:00
|
|
|
{"wiki-name.-", "wiki-name"},
|
|
|
|
{"the+wiki-name.-", "the wiki-name"},
|
|
|
|
{"a%2Fb", "a/b"},
|
|
|
|
{"a%25b", "a%b"},
|
2020-01-07 21:27:36 +03:00
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, test.Expected, UserTitleToWebPath("", test.UserTitle))
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
func TestWebPathToDisplayName(t *testing.T) {
|
2020-01-07 21:27:36 +03:00
|
|
|
type test struct {
|
|
|
|
Expected string
|
2023-04-19 20:50:10 +03:00
|
|
|
WebPath WebPath
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
for _, test := range []test{
|
|
|
|
{"wiki name", "wiki-name"},
|
2023-04-19 20:50:10 +03:00
|
|
|
{"wiki-name", "wiki-name.-"},
|
|
|
|
{"name with / slash", "name-with %2F slash"},
|
|
|
|
{"name with % percent", "name-with %25 percent"},
|
|
|
|
{"2000-01-02 meeting", "2000-01-02+meeting.-.md"},
|
2020-01-07 21:27:36 +03:00
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
_, displayName := WebPathToUserTitle(test.WebPath)
|
|
|
|
assert.EqualValues(t, test.Expected, displayName)
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
func TestWebPathToGitPath(t *testing.T) {
|
2020-01-07 21:27:36 +03:00
|
|
|
type test struct {
|
|
|
|
Expected string
|
2023-04-19 20:50:10 +03:00
|
|
|
WikiName WebPath
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
for _, test := range []test{
|
2023-04-19 20:50:10 +03:00
|
|
|
{"wiki-name.md", "wiki%20name"},
|
|
|
|
{"wiki-name.md", "wiki+name"},
|
|
|
|
{"wiki%20name.md", "wiki%20name.md"},
|
|
|
|
{"2000-01-02-meeting.md", "2000-01-02+meeting"},
|
|
|
|
{"2000-01-02 meeting.-.md", "2000-01-02%20meeting.-"},
|
2020-01-07 21:27:36 +03:00
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, test.Expected, WebPathToGitPath(test.WikiName))
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
func TestGitPathToWebPath(t *testing.T) {
|
2020-01-07 21:27:36 +03:00
|
|
|
type test struct {
|
|
|
|
Expected string
|
|
|
|
Filename string
|
|
|
|
}
|
|
|
|
for _, test := range []test{
|
2023-04-19 20:50:10 +03:00
|
|
|
{"hello-world", "hello-world.md"}, // this shouldn't happen, because it should always have a ".-" suffix
|
|
|
|
{"hello-world", "hello world.md"},
|
|
|
|
{"hello-world.-", "hello-world.-.md"},
|
|
|
|
{"hello+world.-", "hello world.-.md"},
|
|
|
|
{"symbols-%2F", "symbols %2F.md"},
|
2020-01-07 21:27:36 +03:00
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
name, err := GitPathToWebPath(test.Filename)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, test.Expected, name)
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
for _, badFilename := range []string{
|
|
|
|
"nofileextension",
|
|
|
|
"wrongfileextension.txt",
|
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
_, err := GitPathToWebPath(badFilename)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.Error(t, err)
|
2022-08-25 05:31:57 +03:00
|
|
|
assert.True(t, repo_model.IsErrWikiInvalidFileName(err))
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
2023-04-19 20:50:10 +03:00
|
|
|
_, err := GitPathToWebPath("badescaping%%.md")
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.Error(t, err)
|
2022-08-25 05:31:57 +03:00
|
|
|
assert.False(t, repo_model.IsErrWikiInvalidFileName(err))
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
func TestUserWebGitPathConsistency(t *testing.T) {
|
|
|
|
maxLen := 20
|
|
|
|
b := make([]byte, maxLen)
|
|
|
|
for i := 0; i < 1000; i++ {
|
|
|
|
l := rand.Intn(maxLen)
|
|
|
|
for j := 0; j < l; j++ {
|
|
|
|
r := rand.Intn(0x80-0x20) + 0x20
|
|
|
|
b[j] = byte(r)
|
|
|
|
}
|
|
|
|
|
|
|
|
userTitle := strings.TrimSpace(string(b[:l]))
|
2023-05-06 14:24:18 +03:00
|
|
|
if userTitle == "" || userTitle == "." || userTitle == ".." {
|
2023-04-19 20:50:10 +03:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
webPath := UserTitleToWebPath("", userTitle)
|
|
|
|
gitPath := WebPathToGitPath(webPath)
|
|
|
|
|
|
|
|
webPath1, _ := GitPathToWebPath(gitPath)
|
|
|
|
_, userTitle1 := WebPathToUserTitle(webPath1)
|
|
|
|
gitPath1 := WebPathToGitPath(webPath1)
|
|
|
|
|
|
|
|
assert.EqualValues(t, userTitle, userTitle1, "UserTitle for userTitle: %q", userTitle)
|
|
|
|
assert.EqualValues(t, webPath, webPath1, "WebPath for userTitle: %q", userTitle)
|
|
|
|
assert.EqualValues(t, gitPath, gitPath1, "GitPath for userTitle: %q", userTitle)
|
2020-01-07 21:27:36 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRepository_InitWiki(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
unittest.PrepareTestEnv(t)
|
2020-01-07 21:27:36 +03:00
|
|
|
// repo1 already has a wiki
|
2022-08-16 05:22:25 +03:00
|
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
2022-01-20 02:26:57 +03:00
|
|
|
assert.NoError(t, InitWiki(git.DefaultContext, repo1))
|
2020-01-07 21:27:36 +03:00
|
|
|
|
|
|
|
// repo2 does not already have a wiki
|
2022-08-16 05:22:25 +03:00
|
|
|
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
2022-01-20 02:26:57 +03:00
|
|
|
assert.NoError(t, InitWiki(git.DefaultContext, repo2))
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.True(t, repo2.HasWiki())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRepository_AddWikiPage(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2020-01-07 21:27:36 +03:00
|
|
|
const wikiContent = "This is the wiki content"
|
|
|
|
const commitMsg = "Commit message"
|
2022-08-16 05:22:25 +03:00
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
2023-04-19 20:50:10 +03:00
|
|
|
for _, userTitle := range []string{
|
2020-01-07 21:27:36 +03:00
|
|
|
"Another page",
|
|
|
|
"Here's a <tag> and a/slash",
|
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
t.Run("test wiki exist: "+userTitle, func(t *testing.T) {
|
|
|
|
webPath := UserTitleToWebPath("", userTitle)
|
|
|
|
assert.NoError(t, AddWikiPage(git.DefaultContext, doer, repo, webPath, wikiContent, commitMsg))
|
2020-01-07 21:27:36 +03:00
|
|
|
// Now need to show that the page has been added:
|
2022-03-29 22:13:41 +03:00
|
|
|
gitRepo, err := git.OpenRepository(git.DefaultContext, repo.WikiPath())
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
|
|
|
defer gitRepo.Close()
|
2022-10-15 17:40:32 +03:00
|
|
|
masterTree, err := gitRepo.GetTree(DefaultBranch)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
gitPath := WebPathToGitPath(webPath)
|
|
|
|
entry, err := masterTree.GetTreeEntryByPath(gitPath)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, gitPath, entry.Name(), "%s not added correctly", userTitle)
|
2020-01-07 21:27:36 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("check wiki already exist", func(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
// test for already-existing wiki name
|
2022-01-20 02:26:57 +03:00
|
|
|
err := AddWikiPage(git.DefaultContext, doer, repo, "Home", wikiContent, commitMsg)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.Error(t, err)
|
2022-08-25 05:31:57 +03:00
|
|
|
assert.True(t, repo_model.IsErrWikiAlreadyExist(err))
|
2020-01-07 21:27:36 +03:00
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("check wiki reserved name", func(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
// test for reserved wiki name
|
2022-01-20 02:26:57 +03:00
|
|
|
err := AddWikiPage(git.DefaultContext, doer, repo, "_edit", wikiContent, commitMsg)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.Error(t, err)
|
2022-08-25 05:31:57 +03:00
|
|
|
assert.True(t, repo_model.IsErrWikiReservedName(err))
|
2020-01-07 21:27:36 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRepository_EditWikiPage(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2021-05-12 07:13:42 +03:00
|
|
|
|
2020-01-07 21:27:36 +03:00
|
|
|
const newWikiContent = "This is the new content"
|
|
|
|
const commitMsg = "Commit message"
|
2022-08-16 05:22:25 +03:00
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
2020-01-07 21:27:36 +03:00
|
|
|
for _, newWikiName := range []string{
|
|
|
|
"Home", // same name as before
|
|
|
|
"New home",
|
|
|
|
"New/name/with/slashes",
|
|
|
|
} {
|
2023-04-19 20:50:10 +03:00
|
|
|
webPath := UserTitleToWebPath("", newWikiName)
|
2021-11-12 17:36:47 +03:00
|
|
|
unittest.PrepareTestEnv(t)
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.NoError(t, EditWikiPage(git.DefaultContext, doer, repo, "Home", webPath, newWikiContent, commitMsg))
|
2020-01-07 21:27:36 +03:00
|
|
|
|
|
|
|
// Now need to show that the page has been added:
|
2022-03-29 22:13:41 +03:00
|
|
|
gitRepo, err := git.OpenRepository(git.DefaultContext, repo.WikiPath())
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2022-10-15 17:40:32 +03:00
|
|
|
masterTree, err := gitRepo.GetTree(DefaultBranch)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
gitPath := WebPathToGitPath(webPath)
|
|
|
|
entry, err := masterTree.GetTreeEntryByPath(gitPath)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, gitPath, entry.Name(), "%s not edited correctly", newWikiName)
|
2020-01-07 21:27:36 +03:00
|
|
|
|
|
|
|
if newWikiName != "Home" {
|
|
|
|
_, err := masterTree.GetTreeEntryByPath("Home.md")
|
|
|
|
assert.Error(t, err)
|
|
|
|
}
|
|
|
|
gitRepo.Close()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRepository_DeleteWikiPage(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
unittest.PrepareTestEnv(t)
|
2022-08-16 05:22:25 +03:00
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
2022-01-20 02:26:57 +03:00
|
|
|
assert.NoError(t, DeleteWikiPage(git.DefaultContext, doer, repo, "Home"))
|
2020-01-07 21:27:36 +03:00
|
|
|
|
|
|
|
// Now need to show that the page has been added:
|
2022-03-29 22:13:41 +03:00
|
|
|
gitRepo, err := git.OpenRepository(git.DefaultContext, repo.WikiPath())
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
|
|
|
defer gitRepo.Close()
|
2022-10-15 17:40:32 +03:00
|
|
|
masterTree, err := gitRepo.GetTree(DefaultBranch)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
gitPath := WebPathToGitPath("Home")
|
|
|
|
_, err = masterTree.GetTreeEntryByPath(gitPath)
|
2020-01-07 21:27:36 +03:00
|
|
|
assert.Error(t, err)
|
|
|
|
}
|
2021-07-20 16:16:20 +03:00
|
|
|
|
|
|
|
func TestPrepareWikiFileName(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
unittest.PrepareTestEnv(t)
|
2022-08-16 05:22:25 +03:00
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
2022-03-29 22:13:41 +03:00
|
|
|
gitRepo, err := git.OpenRepository(git.DefaultContext, repo.WikiPath())
|
2021-07-20 16:16:20 +03:00
|
|
|
defer gitRepo.Close()
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
tests := []struct {
|
|
|
|
name string
|
|
|
|
arg string
|
|
|
|
existence bool
|
|
|
|
wikiPath string
|
|
|
|
wantErr bool
|
|
|
|
}{{
|
|
|
|
name: "add suffix",
|
|
|
|
arg: "Home",
|
|
|
|
existence: true,
|
|
|
|
wikiPath: "Home.md",
|
|
|
|
wantErr: false,
|
|
|
|
}, {
|
|
|
|
name: "test special chars",
|
|
|
|
arg: "home of and & or wiki page!",
|
|
|
|
existence: false,
|
|
|
|
wikiPath: "home-of-and-%26-or-wiki-page%21.md",
|
|
|
|
wantErr: false,
|
|
|
|
}}
|
|
|
|
for _, tt := range tests {
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
2023-04-19 20:50:10 +03:00
|
|
|
webPath := UserTitleToWebPath("", tt.arg)
|
|
|
|
existence, newWikiPath, err := prepareGitPath(gitRepo, webPath)
|
2021-07-20 16:16:20 +03:00
|
|
|
if (err != nil) != tt.wantErr {
|
|
|
|
assert.NoError(t, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if existence != tt.existence {
|
|
|
|
if existence {
|
|
|
|
t.Errorf("expect to find no escaped file but we detect one")
|
|
|
|
} else {
|
|
|
|
t.Errorf("expect to find an escaped file but we could not detect one")
|
|
|
|
}
|
|
|
|
}
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, tt.wikiPath, newWikiPath)
|
2021-07-20 16:16:20 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
2021-08-01 20:04:32 +03:00
|
|
|
|
|
|
|
func TestPrepareWikiFileName_FirstPage(t *testing.T) {
|
2021-11-12 17:36:47 +03:00
|
|
|
unittest.PrepareTestEnv(t)
|
2021-08-01 20:04:32 +03:00
|
|
|
|
|
|
|
// Now create a temporaryDirectory
|
2022-09-04 18:14:53 +03:00
|
|
|
tmpDir := t.TempDir()
|
2021-08-01 20:04:32 +03:00
|
|
|
|
2022-09-04 18:14:53 +03:00
|
|
|
err := git.InitRepository(git.DefaultContext, tmpDir, true)
|
2021-08-01 20:04:32 +03:00
|
|
|
assert.NoError(t, err)
|
|
|
|
|
2022-03-29 22:13:41 +03:00
|
|
|
gitRepo, err := git.OpenRepository(git.DefaultContext, tmpDir)
|
2021-08-01 20:04:32 +03:00
|
|
|
defer gitRepo.Close()
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
2023-04-19 20:50:10 +03:00
|
|
|
existence, newWikiPath, err := prepareGitPath(gitRepo, "Home")
|
2021-08-01 20:04:32 +03:00
|
|
|
assert.False(t, existence)
|
|
|
|
assert.NoError(t, err)
|
2023-04-19 20:50:10 +03:00
|
|
|
assert.EqualValues(t, "Home.md", newWikiPath)
|
2021-08-01 20:04:32 +03:00
|
|
|
}
|
2023-08-03 04:37:48 +03:00
|
|
|
|
|
|
|
func TestWebPathConversion(t *testing.T) {
|
|
|
|
assert.Equal(t, "path/wiki", WebPathToURLPath(WebPath("path/wiki")))
|
|
|
|
assert.Equal(t, "wiki", WebPathToURLPath(WebPath("wiki")))
|
|
|
|
assert.Equal(t, "", WebPathToURLPath(WebPath("")))
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestWebPathFromRequest(t *testing.T) {
|
|
|
|
assert.Equal(t, WebPath("a%2Fb"), WebPathFromRequest("a/b"))
|
|
|
|
assert.Equal(t, WebPath("a"), WebPathFromRequest("a"))
|
|
|
|
assert.Equal(t, WebPath("b"), WebPathFromRequest("a/../b"))
|
|
|
|
}
|