2014-04-15 20:27:29 +04:00
|
|
|
// Copyright 2014 The Gogs Authors. All rights reserved.
|
2018-11-18 21:45:40 +03:00
|
|
|
// Copyright 2018 The Gitea Authors. All rights reserved.
|
2022-11-27 21:20:29 +03:00
|
|
|
// SPDX-License-Identifier: MIT
|
2014-04-15 20:27:29 +04:00
|
|
|
|
|
|
|
package repo
|
|
|
|
|
|
|
|
import (
|
2022-05-09 18:54:51 +03:00
|
|
|
"path"
|
|
|
|
"time"
|
|
|
|
|
2022-06-12 18:51:54 +03:00
|
|
|
git_model "code.gitea.io/gitea/models/git"
|
2019-03-27 12:33:00 +03:00
|
|
|
"code.gitea.io/gitea/modules/git"
|
2021-04-12 17:49:26 +03:00
|
|
|
"code.gitea.io/gitea/modules/httpcache"
|
2019-02-12 18:09:43 +03:00
|
|
|
"code.gitea.io/gitea/modules/lfs"
|
2019-06-12 22:41:28 +03:00
|
|
|
"code.gitea.io/gitea/modules/log"
|
2021-08-21 21:22:06 +03:00
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
"code.gitea.io/gitea/modules/storage"
|
2021-06-09 02:33:54 +03:00
|
|
|
"code.gitea.io/gitea/routers/common"
|
2024-02-27 10:12:22 +03:00
|
|
|
"code.gitea.io/gitea/services/context"
|
2014-04-15 20:27:29 +04:00
|
|
|
)
|
|
|
|
|
2019-02-12 18:09:43 +03:00
|
|
|
// ServeBlobOrLFS download a git.Blob redirecting to LFS if necessary
|
2023-07-07 08:31:56 +03:00
|
|
|
func ServeBlobOrLFS(ctx *context.Context, blob *git.Blob, lastModified *time.Time) error {
|
2022-05-09 18:54:51 +03:00
|
|
|
if httpcache.HandleGenericETagTimeCache(ctx.Req, ctx.Resp, `"`+blob.ID.String()+`"`, lastModified) {
|
2021-04-12 17:49:26 +03:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-02-12 18:09:43 +03:00
|
|
|
dataRc, err := blob.DataAsync()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2021-05-10 04:27:03 +03:00
|
|
|
closed := false
|
2019-06-12 22:41:28 +03:00
|
|
|
defer func() {
|
2021-05-10 04:27:03 +03:00
|
|
|
if closed {
|
|
|
|
return
|
|
|
|
}
|
2019-06-12 22:41:28 +03:00
|
|
|
if err = dataRc.Close(); err != nil {
|
|
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
|
|
}
|
|
|
|
}()
|
2019-02-12 18:09:43 +03:00
|
|
|
|
2021-04-09 01:25:57 +03:00
|
|
|
pointer, _ := lfs.ReadPointer(dataRc)
|
|
|
|
if pointer.IsValid() {
|
2023-01-09 06:50:54 +03:00
|
|
|
meta, _ := git_model.GetLFSMetaObjectByOid(ctx, ctx.Repo.Repository.ID, pointer.Oid)
|
2019-02-12 18:09:43 +03:00
|
|
|
if meta == nil {
|
2021-05-10 04:27:03 +03:00
|
|
|
if err = dataRc.Close(); err != nil {
|
|
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
|
|
}
|
|
|
|
closed = true
|
2023-05-21 04:50:53 +03:00
|
|
|
return common.ServeBlob(ctx.Base, ctx.Repo.TreePath, blob, lastModified)
|
2019-02-12 18:09:43 +03:00
|
|
|
}
|
2021-04-12 17:49:26 +03:00
|
|
|
if httpcache.HandleGenericETagCache(ctx.Req, ctx.Resp, `"`+pointer.Oid+`"`) {
|
|
|
|
return nil
|
|
|
|
}
|
2021-08-21 21:22:06 +03:00
|
|
|
|
2023-06-14 06:42:38 +03:00
|
|
|
if setting.LFS.Storage.MinioConfig.ServeDirect {
|
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365)
Fix #28121
I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.
https://github.com/go-gitea/gitea/blob/348d1d0f322ca57c459acd902f54821d687ca804/routers/api/packages/container/container.go#L712-L717
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>
In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.
```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
---
Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.
https://github.com/go-gitea/gitea/blob/b7fb20e73e63b8edc9b90c52073e248bef428fcc/modules/storage/minio.go#L214-L221
(cherry picked from commit 0690cb076bf63f71988a709f62a9c04660b51a4f)
Conflicts:
- modules/storage/azureblob.go
Dropped the change, as we do not support Azure blob storage.
- modules/storage/helper.go
Resolved by adjusting their `discardStorage` to our
`DiscardStorage`
- routers/api/actions/artifacts.go
routers/api/actions/artifactsv4.go
routers/web/repo/actions/view.go
routers/web/repo/download.go
Resolved the conflicts by manually adding the new `nil`
parameter to the `storage.Attachments.URL()` calls.
Originally conflicted due to differences in the if expression
above these calls.
2024-10-31 18:28:25 +03:00
|
|
|
// If we have a signed url (S3, object storage, blob storage), redirect to this directly.
|
|
|
|
u, err := storage.LFS.URL(pointer.RelativePath(), blob.Name(), nil)
|
2021-08-21 21:22:06 +03:00
|
|
|
if u != nil && err == nil {
|
|
|
|
ctx.Redirect(u.String())
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-09 01:25:57 +03:00
|
|
|
lfsDataRc, err := lfs.ReadMetaObject(meta.Pointer)
|
2019-02-12 18:09:43 +03:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2019-10-16 08:55:31 +03:00
|
|
|
defer func() {
|
|
|
|
if err = lfsDataRc.Close(); err != nil {
|
|
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
|
|
}
|
|
|
|
}()
|
2023-05-21 04:50:53 +03:00
|
|
|
common.ServeContentByReadSeeker(ctx.Base, ctx.Repo.TreePath, lastModified, lfsDataRc)
|
2023-05-09 10:34:36 +03:00
|
|
|
return nil
|
2019-02-12 18:09:43 +03:00
|
|
|
}
|
2021-05-10 04:27:03 +03:00
|
|
|
if err = dataRc.Close(); err != nil {
|
|
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
|
|
}
|
|
|
|
closed = true
|
2019-02-12 18:09:43 +03:00
|
|
|
|
2023-05-21 04:50:53 +03:00
|
|
|
return common.ServeBlob(ctx.Base, ctx.Repo.TreePath, blob, lastModified)
|
2019-02-12 18:09:43 +03:00
|
|
|
}
|
|
|
|
|
2023-07-07 08:31:56 +03:00
|
|
|
func getBlobForEntry(ctx *context.Context) (blob *git.Blob, lastModified *time.Time) {
|
2022-05-09 18:54:51 +03:00
|
|
|
entry, err := ctx.Repo.Commit.GetTreeEntryByPath(ctx.Repo.TreePath)
|
2014-11-17 05:32:26 +03:00
|
|
|
if err != nil {
|
2015-12-10 04:46:05 +03:00
|
|
|
if git.IsErrNotExist(err) {
|
2022-05-09 18:54:51 +03:00
|
|
|
ctx.NotFound("GetTreeEntryByPath", err)
|
2014-11-17 05:32:26 +03:00
|
|
|
} else {
|
2022-05-09 18:54:51 +03:00
|
|
|
ctx.ServerError("GetTreeEntryByPath", err)
|
2014-11-17 05:32:26 +03:00
|
|
|
}
|
2023-07-07 08:31:56 +03:00
|
|
|
return nil, nil
|
2014-11-17 05:32:26 +03:00
|
|
|
}
|
2022-05-09 18:54:51 +03:00
|
|
|
|
|
|
|
if entry.IsDir() || entry.IsSubModule() {
|
|
|
|
ctx.NotFound("getBlobForEntry", nil)
|
2023-07-07 08:31:56 +03:00
|
|
|
return nil, nil
|
2022-05-09 18:54:51 +03:00
|
|
|
}
|
|
|
|
|
2022-07-25 18:39:42 +03:00
|
|
|
info, _, err := git.Entries([]*git.TreeEntry{entry}).GetCommitsInfo(ctx, ctx.Repo.Commit, path.Dir("/" + ctx.Repo.TreePath)[1:])
|
2022-05-09 18:54:51 +03:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetCommitsInfo", err)
|
2023-07-07 08:31:56 +03:00
|
|
|
return nil, nil
|
2022-05-09 18:54:51 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if len(info) == 1 {
|
|
|
|
// Not Modified
|
2023-07-07 08:31:56 +03:00
|
|
|
lastModified = &info[0].Commit.Committer.When
|
2022-05-09 18:54:51 +03:00
|
|
|
}
|
|
|
|
blob = entry.Blob()
|
|
|
|
|
2022-06-20 13:02:49 +03:00
|
|
|
return blob, lastModified
|
2022-05-09 18:54:51 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
// SingleDownload download a file by repos path
|
|
|
|
func SingleDownload(ctx *context.Context) {
|
|
|
|
blob, lastModified := getBlobForEntry(ctx)
|
|
|
|
if blob == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2023-05-21 04:50:53 +03:00
|
|
|
if err := common.ServeBlob(ctx.Base, ctx.Repo.TreePath, blob, lastModified); err != nil {
|
2018-01-11 00:34:17 +03:00
|
|
|
ctx.ServerError("ServeBlob", err)
|
2014-11-17 05:32:26 +03:00
|
|
|
}
|
2014-04-15 20:27:29 +04:00
|
|
|
}
|
2018-11-18 21:45:40 +03:00
|
|
|
|
2019-02-12 18:09:43 +03:00
|
|
|
// SingleDownloadOrLFS download a file by repos path redirecting to LFS if necessary
|
|
|
|
func SingleDownloadOrLFS(ctx *context.Context) {
|
2022-05-09 18:54:51 +03:00
|
|
|
blob, lastModified := getBlobForEntry(ctx)
|
|
|
|
if blob == nil {
|
2019-02-12 18:09:43 +03:00
|
|
|
return
|
|
|
|
}
|
2022-05-09 18:54:51 +03:00
|
|
|
|
|
|
|
if err := ServeBlobOrLFS(ctx, blob, lastModified); err != nil {
|
2019-02-12 18:09:43 +03:00
|
|
|
ctx.ServerError("ServeBlobOrLFS", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-11-18 21:45:40 +03:00
|
|
|
// DownloadByID download a file by sha1 ID
|
|
|
|
func DownloadByID(ctx *context.Context) {
|
|
|
|
blob, err := ctx.Repo.GitRepo.GetBlob(ctx.Params("sha"))
|
|
|
|
if err != nil {
|
|
|
|
if git.IsErrNotExist(err) {
|
|
|
|
ctx.NotFound("GetBlob", nil)
|
|
|
|
} else {
|
|
|
|
ctx.ServerError("GetBlob", err)
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
2023-07-07 08:31:56 +03:00
|
|
|
if err = common.ServeBlob(ctx.Base, ctx.Repo.TreePath, blob, nil); err != nil {
|
2018-11-18 21:45:40 +03:00
|
|
|
ctx.ServerError("ServeBlob", err)
|
|
|
|
}
|
|
|
|
}
|
2019-02-12 18:09:43 +03:00
|
|
|
|
|
|
|
// DownloadByIDOrLFS download a file by sha1 ID taking account of LFS
|
|
|
|
func DownloadByIDOrLFS(ctx *context.Context) {
|
|
|
|
blob, err := ctx.Repo.GitRepo.GetBlob(ctx.Params("sha"))
|
|
|
|
if err != nil {
|
|
|
|
if git.IsErrNotExist(err) {
|
|
|
|
ctx.NotFound("GetBlob", nil)
|
|
|
|
} else {
|
|
|
|
ctx.ServerError("GetBlob", err)
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
2023-07-07 08:31:56 +03:00
|
|
|
if err = ServeBlobOrLFS(ctx, blob, nil); err != nil {
|
2019-02-12 18:09:43 +03:00
|
|
|
ctx.ServerError("ServeBlob", err)
|
|
|
|
}
|
|
|
|
}
|