2014-03-21 00:04:56 +04:00
// Copyright 2014 The Gogs Authors. All rights reserved.
2020-01-02 01:51:10 +03:00
// Copyright 2020 The Gitea Authors. All rights reserved.
2014-03-21 00:04:56 +04:00
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package models
2014-03-22 21:50:50 +04:00
import (
2021-09-23 18:45:36 +03:00
"context"
2015-08-10 09:42:50 +03:00
"fmt"
2018-01-03 11:34:13 +03:00
"regexp"
2017-01-30 15:46:45 +03:00
"sort"
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
"strconv"
2014-03-22 21:50:50 +04:00
"strings"
2014-05-08 00:51:14 +04:00
2021-09-19 14:49:59 +03:00
"code.gitea.io/gitea/models/db"
2021-10-11 01:40:03 +03:00
"code.gitea.io/gitea/models/issues"
2021-11-28 14:58:28 +03:00
"code.gitea.io/gitea/models/perm"
2021-11-19 16:39:57 +03:00
repo_model "code.gitea.io/gitea/models/repo"
2021-11-09 22:57:58 +03:00
"code.gitea.io/gitea/models/unit"
2021-11-24 12:49:20 +03:00
user_model "code.gitea.io/gitea/models/user"
2016-11-10 19:24:48 +03:00
"code.gitea.io/gitea/modules/base"
2021-12-02 10:28:08 +03:00
"code.gitea.io/gitea/modules/git"
2016-11-10 19:24:48 +03:00
"code.gitea.io/gitea/modules/log"
2021-01-02 20:04:02 +03:00
"code.gitea.io/gitea/modules/references"
2019-05-11 13:21:34 +03:00
api "code.gitea.io/gitea/modules/structs"
2019-08-15 17:46:21 +03:00
"code.gitea.io/gitea/modules/timeutil"
2017-01-25 05:43:02 +03:00
"code.gitea.io/gitea/modules/util"
2017-12-26 02:25:16 +03:00
2019-06-23 18:22:43 +03:00
"xorm.io/builder"
2019-10-17 12:26:49 +03:00
"xorm.io/xorm"
2014-03-22 21:50:50 +04:00
)
// Issue represents an issue or pull request of repository.
2014-03-21 00:04:56 +04:00
type Issue struct {
2021-12-10 04:27:50 +03:00
ID int64 ` xorm:"pk autoincr" `
RepoID int64 ` xorm:"INDEX UNIQUE(repo_index)" `
Repo * repo_model . Repository ` xorm:"-" `
Index int64 ` xorm:"UNIQUE(repo_index)" ` // Index in one repository.
PosterID int64 ` xorm:"INDEX" `
Poster * user_model . User ` xorm:"-" `
2019-07-08 05:14:12 +03:00
OriginalAuthor string
2019-10-14 09:10:42 +03:00
OriginalAuthorID int64 ` xorm:"index" `
2019-07-08 05:14:12 +03:00
Title string ` xorm:"name" `
2021-08-22 18:33:05 +03:00
Content string ` xorm:"LONGTEXT" `
2019-07-08 05:14:12 +03:00
RenderedContent string ` xorm:"-" `
Labels [ ] * Label ` xorm:"-" `
MilestoneID int64 ` xorm:"INDEX" `
Milestone * Milestone ` xorm:"-" `
2020-08-17 06:07:38 +03:00
Project * Project ` xorm:"-" `
2019-07-08 05:14:12 +03:00
Priority int
2021-11-24 12:49:20 +03:00
AssigneeID int64 ` xorm:"-" `
Assignee * user_model . User ` xorm:"-" `
IsClosed bool ` xorm:"INDEX" `
IsRead bool ` xorm:"-" `
IsPull bool ` xorm:"INDEX" ` // Indicates whether is a pull request or not.
PullRequest * PullRequest ` xorm:"-" `
2019-07-08 05:14:12 +03:00
NumComments int
Ref string
2016-03-10 03:53:30 +03:00
2019-08-15 17:46:21 +03:00
DeadlineUnix timeutil . TimeStamp ` xorm:"INDEX" `
2018-05-01 22:05:28 +03:00
2019-08-15 17:46:21 +03:00
CreatedUnix timeutil . TimeStamp ` xorm:"INDEX created" `
UpdatedUnix timeutil . TimeStamp ` xorm:"INDEX updated" `
ClosedUnix timeutil . TimeStamp ` xorm:"INDEX" `
2015-08-12 12:04:23 +03:00
2021-11-19 16:39:57 +03:00
Attachments [ ] * repo_model . Attachment ` xorm:"-" `
Comments [ ] * Comment ` xorm:"-" `
Reactions ReactionList ` xorm:"-" `
TotalTrackedTime int64 ` xorm:"-" `
2021-11-24 12:49:20 +03:00
Assignees [ ] * user_model . User ` xorm:"-" `
2019-02-18 23:55:04 +03:00
// IsLocked limits commenting abilities to users on an issue
// with write access
IsLocked bool ` xorm:"NOT NULL DEFAULT false" `
2020-09-10 21:09:14 +03:00
// For view issue page.
2021-11-11 09:29:30 +03:00
ShowRole RoleDescriptor ` xorm:"-" `
2015-08-12 12:04:23 +03:00
}
2018-01-03 11:34:13 +03:00
var (
issueTasksPat * regexp . Regexp
issueTasksDonePat * regexp . Regexp
)
2021-03-14 21:52:12 +03:00
const (
2021-06-14 05:22:55 +03:00
issueTasksRegexpStr = ` (^\s*[-*]\s\[[\sxX]\]\s.)|(\n\s*[-*]\s\[[\sxX]\]\s.) `
issueTasksDoneRegexpStr = ` (^\s*[-*]\s\[[xX]\]\s.)|(\n\s*[-*]\s\[[xX]\]\s.) `
2021-03-14 21:52:12 +03:00
)
2018-01-03 11:34:13 +03:00
2021-09-19 14:49:59 +03:00
// IssueIndex represents the issue index table
type IssueIndex db . ResourceIndex
2018-01-03 11:34:13 +03:00
func init ( ) {
issueTasksPat = regexp . MustCompile ( issueTasksRegexpStr )
issueTasksDonePat = regexp . MustCompile ( issueTasksDoneRegexpStr )
2021-09-19 14:49:59 +03:00
db . RegisterModel ( new ( Issue ) )
db . RegisterModel ( new ( IssueIndex ) )
2018-01-03 11:34:13 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadTotalTimes ( e db . Engine ) ( err error ) {
2018-04-29 08:58:47 +03:00
opts := FindTrackedTimesOptions { IssueID : issue . ID }
2021-08-12 15:43:08 +03:00
issue . TotalTrackedTime , err = opts . toSession ( e ) . SumInt ( & TrackedTime { } , "time" )
2018-04-29 08:58:47 +03:00
if err != nil {
return err
}
return nil
}
2018-05-01 22:05:28 +03:00
// IsOverdue checks if the issue is overdue
func ( issue * Issue ) IsOverdue ( ) bool {
2021-03-08 04:55:57 +03:00
if issue . IsClosed {
return issue . ClosedUnix >= issue . DeadlineUnix
}
2019-08-15 17:46:21 +03:00
return timeutil . TimeStampNow ( ) >= issue . DeadlineUnix
2018-05-01 22:05:28 +03:00
}
2018-12-13 18:55:43 +03:00
// LoadRepo loads issue's repository
func ( issue * Issue ) LoadRepo ( ) error {
2021-12-10 04:27:50 +03:00
return issue . loadRepo ( db . DefaultContext )
2018-12-13 18:55:43 +03:00
}
2021-12-10 04:27:50 +03:00
func ( issue * Issue ) loadRepo ( ctx context . Context ) ( err error ) {
2016-08-26 23:40:53 +03:00
if issue . Repo == nil {
2021-12-10 04:27:50 +03:00
issue . Repo , err = repo_model . GetRepositoryByIDCtx ( ctx , issue . RepoID )
2016-03-14 06:20:22 +03:00
if err != nil {
2016-08-26 23:40:53 +03:00
return fmt . Errorf ( "getRepositoryByID [%d]: %v" , issue . RepoID , err )
2016-03-14 06:20:22 +03:00
}
2016-08-26 23:40:53 +03:00
}
2016-12-17 14:49:17 +03:00
return nil
}
2018-04-29 08:58:47 +03:00
// IsTimetrackerEnabled returns true if the repo enables timetracking
func ( issue * Issue ) IsTimetrackerEnabled ( ) bool {
2021-12-10 04:27:50 +03:00
return issue . isTimetrackerEnabled ( db . DefaultContext )
2019-01-14 05:29:58 +03:00
}
2021-12-10 04:27:50 +03:00
func ( issue * Issue ) isTimetrackerEnabled ( ctx context . Context ) bool {
if err := issue . loadRepo ( ctx ) ; err != nil {
2019-04-02 10:48:31 +03:00
log . Error ( fmt . Sprintf ( "loadRepo: %v" , err ) )
2018-04-29 08:58:47 +03:00
return false
}
2021-12-14 01:59:39 +03:00
return issue . Repo . IsTimetrackerEnabledCtx ( ctx )
2018-04-29 08:58:47 +03:00
}
2017-01-28 19:01:07 +03:00
// GetPullRequest returns the issue pull request
func ( issue * Issue ) GetPullRequest ( ) ( pr * PullRequest , err error ) {
if ! issue . IsPull {
return nil , fmt . Errorf ( "Issue is not a pull request" )
}
2021-09-23 18:45:36 +03:00
pr , err = getPullRequestByIssueID ( db . GetEngine ( db . DefaultContext ) , issue . ID )
2018-10-18 14:23:05 +03:00
if err != nil {
return nil , err
}
pr . Issue = issue
2017-01-28 19:01:07 +03:00
return
}
2020-02-29 05:49:50 +03:00
// LoadLabels loads labels
func ( issue * Issue ) LoadLabels ( ) error {
2021-09-23 18:45:36 +03:00
return issue . loadLabels ( db . GetEngine ( db . DefaultContext ) )
2020-02-29 05:49:50 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadLabels ( e db . Engine ) ( err error ) {
2017-01-30 15:46:45 +03:00
if issue . Labels == nil {
issue . Labels , err = getLabelsByIssueID ( e , issue . ID )
if err != nil {
return fmt . Errorf ( "getLabelsByIssueID [%d]: %v" , issue . ID , err )
}
2016-12-17 14:49:17 +03:00
}
2017-01-30 15:46:45 +03:00
return nil
}
2016-03-14 06:20:22 +03:00
2018-12-13 18:55:43 +03:00
// LoadPoster loads poster
func ( issue * Issue ) LoadPoster ( ) error {
2021-09-23 18:45:36 +03:00
return issue . loadPoster ( db . GetEngine ( db . DefaultContext ) )
2018-12-13 18:55:43 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadPoster ( e db . Engine ) ( err error ) {
2016-08-26 23:40:53 +03:00
if issue . Poster == nil {
2021-11-24 12:49:20 +03:00
issue . Poster , err = user_model . GetUserByIDEngine ( e , issue . PosterID )
2016-03-14 06:20:22 +03:00
if err != nil {
2016-09-20 12:54:47 +03:00
issue . PosterID = - 1
2021-11-24 12:49:20 +03:00
issue . Poster = user_model . NewGhostUser ( )
if ! user_model . IsErrUserNotExist ( err ) {
2016-08-26 23:40:53 +03:00
return fmt . Errorf ( "getUserByID.(poster) [%d]: %v" , issue . PosterID , err )
2016-03-14 06:20:22 +03:00
}
2016-11-09 08:07:01 +03:00
err = nil
2016-03-14 06:20:22 +03:00
return
}
2016-08-26 23:40:53 +03:00
}
2017-01-30 15:46:45 +03:00
return
}
2016-03-14 06:20:22 +03:00
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadPullRequest ( e db . Engine ) ( err error ) {
2017-07-26 10:16:45 +03:00
if issue . IsPull && issue . PullRequest == nil {
issue . PullRequest , err = getPullRequestByIssueID ( e , issue . ID )
if err != nil {
if IsErrPullRequestNotExist ( err ) {
return err
}
return fmt . Errorf ( "getPullRequestByIssueID [%d]: %v" , issue . ID , err )
}
2018-12-13 18:55:43 +03:00
issue . PullRequest . Issue = issue
2017-07-26 10:16:45 +03:00
}
return nil
}
2018-12-13 18:55:43 +03:00
// LoadPullRequest loads pull request info
func ( issue * Issue ) LoadPullRequest ( ) error {
2021-09-23 18:45:36 +03:00
return issue . loadPullRequest ( db . GetEngine ( db . DefaultContext ) )
2018-12-13 18:55:43 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadComments ( e db . Engine ) ( err error ) {
2019-02-19 17:39:39 +03:00
return issue . loadCommentsByType ( e , CommentTypeUnknown )
}
// LoadDiscussComments loads discuss comments
func ( issue * Issue ) LoadDiscussComments ( ) error {
2021-09-23 18:45:36 +03:00
return issue . loadCommentsByType ( db . GetEngine ( db . DefaultContext ) , CommentTypeComment )
2019-02-19 17:39:39 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadCommentsByType ( e db . Engine , tp CommentType ) ( err error ) {
2017-09-16 23:16:21 +03:00
if issue . Comments != nil {
return nil
}
2021-08-12 15:43:08 +03:00
issue . Comments , err = findComments ( e , & FindCommentsOptions {
2017-09-16 23:16:21 +03:00
IssueID : issue . ID ,
2019-02-19 17:39:39 +03:00
Type : tp ,
2017-09-16 23:16:21 +03:00
} )
return err
}
2021-12-10 04:27:50 +03:00
func ( issue * Issue ) loadReactions ( ctx context . Context ) ( err error ) {
2017-12-04 02:14:26 +03:00
if issue . Reactions != nil {
return nil
}
2021-12-10 04:27:50 +03:00
e := db . GetEngine ( ctx )
2021-12-15 08:39:34 +03:00
reactions , _ , err := findReactions ( e , FindReactionsOptions {
2017-12-04 02:14:26 +03:00
IssueID : issue . ID ,
} )
if err != nil {
return err
}
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2020-01-15 14:14:07 +03:00
return err
}
2017-12-04 02:14:26 +03:00
// Load reaction user data
2020-01-15 14:14:07 +03:00
if _ , err := ReactionList ( reactions ) . loadUsers ( e , issue . Repo ) ; err != nil {
2017-12-04 02:14:26 +03:00
return err
}
// Cache comments to map
comments := make ( map [ int64 ] * Comment )
for _ , comment := range issue . Comments {
comments [ comment . ID ] = comment
}
// Add reactions either to issue or comment
for _ , react := range reactions {
if react . CommentID == 0 {
issue . Reactions = append ( issue . Reactions , react )
} else if comment , ok := comments [ react . CommentID ] ; ok {
comment . Reactions = append ( comment . Reactions , react )
}
}
return nil
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) loadMilestone ( e db . Engine ) ( err error ) {
2020-05-24 17:38:34 +03:00
if ( issue . Milestone == nil || issue . Milestone . ID != issue . MilestoneID ) && issue . MilestoneID > 0 {
2020-01-02 01:51:10 +03:00
issue . Milestone , err = getMilestoneByRepoID ( e , issue . RepoID , issue . MilestoneID )
if err != nil && ! IsErrMilestoneNotExist ( err ) {
return fmt . Errorf ( "getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %v" , issue . RepoID , issue . MilestoneID , err )
}
}
return nil
}
2021-11-19 16:39:57 +03:00
func ( issue * Issue ) loadAttributes ( ctx context . Context ) ( err error ) {
e := db . GetEngine ( ctx )
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2017-01-30 15:46:45 +03:00
return
}
if err = issue . loadPoster ( e ) ; err != nil {
return
}
if err = issue . loadLabels ( e ) ; err != nil {
return
2016-08-26 23:40:53 +03:00
}
2015-08-10 16:47:23 +03:00
2020-01-02 01:51:10 +03:00
if err = issue . loadMilestone ( e ) ; err != nil {
return
2015-08-05 15:23:08 +03:00
}
2020-08-17 06:07:38 +03:00
if err = issue . loadProject ( e ) ; err != nil {
return
}
2018-05-09 19:29:04 +03:00
if err = issue . loadAssignees ( e ) ; err != nil {
2017-06-23 16:43:37 +03:00
return
2016-08-14 13:32:24 +03:00
}
2017-07-26 10:16:45 +03:00
if err = issue . loadPullRequest ( e ) ; err != nil && ! IsErrPullRequestNotExist ( err ) {
2016-08-14 13:32:24 +03:00
// It is possible pull request is not yet created.
2017-07-26 10:16:45 +03:00
return err
2016-08-14 13:32:24 +03:00
}
2016-08-26 23:40:53 +03:00
if issue . Attachments == nil {
2021-11-19 16:39:57 +03:00
issue . Attachments , err = repo_model . GetAttachmentsByIssueIDCtx ( ctx , issue . ID )
2016-08-26 23:40:53 +03:00
if err != nil {
return fmt . Errorf ( "getAttachmentsByIssueID [%d]: %v" , issue . ID , err )
}
}
2017-09-16 23:16:21 +03:00
if err = issue . loadComments ( e ) ; err != nil {
2017-12-04 02:14:26 +03:00
return err
2016-08-26 23:40:53 +03:00
}
2019-04-18 08:00:03 +03:00
2021-12-10 04:27:50 +03:00
if err = CommentList ( issue . Comments ) . loadAttributes ( ctx ) ; err != nil {
2019-04-18 08:00:03 +03:00
return err
}
2021-12-10 04:27:50 +03:00
if issue . isTimetrackerEnabled ( ctx ) {
2018-04-29 08:58:47 +03:00
if err = issue . loadTotalTimes ( e ) ; err != nil {
return err
}
}
2016-08-26 23:40:53 +03:00
2021-12-10 04:27:50 +03:00
return issue . loadReactions ( ctx )
2016-08-14 13:32:24 +03:00
}
2016-11-24 11:41:11 +03:00
// LoadAttributes loads the attribute of this issue.
2016-08-14 13:32:24 +03:00
func ( issue * Issue ) LoadAttributes ( ) error {
2021-11-19 16:39:57 +03:00
return issue . loadAttributes ( db . DefaultContext )
2015-08-19 19:12:43 +03:00
}
2020-01-02 01:51:10 +03:00
// LoadMilestone load milestone of this issue.
func ( issue * Issue ) LoadMilestone ( ) error {
2021-09-23 18:45:36 +03:00
return issue . loadMilestone ( db . GetEngine ( db . DefaultContext ) )
2020-01-02 01:51:10 +03:00
}
2017-02-03 10:22:39 +03:00
// GetIsRead load the `IsRead` field of the issue
func ( issue * Issue ) GetIsRead ( userID int64 ) error {
issueUser := & IssueUser { IssueID : issue . ID , UID : userID }
2021-09-23 18:45:36 +03:00
if has , err := db . GetEngine ( db . DefaultContext ) . Get ( issueUser ) ; err != nil {
2017-02-03 10:22:39 +03:00
return err
} else if ! has {
2017-02-09 06:47:24 +03:00
issue . IsRead = false
return nil
2017-02-03 10:22:39 +03:00
}
issue . IsRead = issueUser . IsRead
return nil
}
2017-03-03 17:35:42 +03:00
// APIURL returns the absolute APIURL to this issue.
func ( issue * Issue ) APIURL ( ) string {
2020-04-21 16:48:53 +03:00
if issue . Repo == nil {
err := issue . LoadRepo ( )
if err != nil {
log . Error ( "Issue[%d].APIURL(): %v" , issue . ID , err )
return ""
}
}
2020-01-14 18:37:19 +03:00
return fmt . Sprintf ( "%s/issues/%d" , issue . Repo . APIURL ( ) , issue . Index )
2017-03-03 17:35:42 +03:00
}
2016-11-24 11:41:11 +03:00
// HTMLURL returns the absolute URL to this issue.
2016-08-16 20:19:09 +03:00
func ( issue * Issue ) HTMLURL ( ) string {
var path string
if issue . IsPull {
path = "pulls"
} else {
path = "issues"
}
return fmt . Sprintf ( "%s/%s/%d" , issue . Repo . HTMLURL ( ) , path , issue . Index )
}
2021-11-16 21:18:25 +03:00
// Link returns the Link URL to this issue.
func ( issue * Issue ) Link ( ) string {
var path string
if issue . IsPull {
path = "pulls"
} else {
path = "issues"
}
return fmt . Sprintf ( "%s/%s/%d" , issue . Repo . Link ( ) , path , issue . Index )
}
2016-12-02 14:10:39 +03:00
// DiffURL returns the absolute URL to this diff
func ( issue * Issue ) DiffURL ( ) string {
if issue . IsPull {
return fmt . Sprintf ( "%s/pulls/%d.diff" , issue . Repo . HTMLURL ( ) , issue . Index )
}
return ""
}
// PatchURL returns the absolute URL to this patch
func ( issue * Issue ) PatchURL ( ) string {
if issue . IsPull {
return fmt . Sprintf ( "%s/pulls/%d.patch" , issue . Repo . HTMLURL ( ) , issue . Index )
}
return ""
}
2016-03-14 06:20:22 +03:00
// State returns string representation of issue status.
2016-11-22 14:24:39 +03:00
func ( issue * Issue ) State ( ) api . StateType {
if issue . IsClosed {
2016-11-29 11:25:47 +03:00
return api . StateClosed
2016-03-14 06:20:22 +03:00
}
2016-11-29 11:25:47 +03:00
return api . StateOpen
2016-08-14 13:32:24 +03:00
}
// HashTag returns unique hash tag for issue.
2016-11-22 14:24:39 +03:00
func ( issue * Issue ) HashTag ( ) string {
2020-12-25 12:59:32 +03:00
return fmt . Sprintf ( "issue-%d" , issue . ID )
2016-03-14 06:20:22 +03:00
}
2015-08-13 11:07:11 +03:00
// IsPoster returns true if given user by ID is the poster.
2016-11-22 14:24:39 +03:00
func ( issue * Issue ) IsPoster ( uid int64 ) bool {
2020-01-17 13:23:46 +03:00
return issue . OriginalAuthorID == 0 && issue . PosterID == uid
2015-08-13 11:07:11 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) hasLabel ( e db . Engine , labelID int64 ) bool {
2016-11-22 14:24:39 +03:00
return hasIssueLabel ( e , issue . ID , labelID )
2015-08-10 09:42:50 +03:00
}
// HasLabel returns true if issue has been labeled by given ID.
2016-11-22 14:24:39 +03:00
func ( issue * Issue ) HasLabel ( labelID int64 ) bool {
2021-09-23 18:45:36 +03:00
return issue . hasLabel ( db . GetEngine ( db . DefaultContext ) , labelID )
2015-08-10 09:42:50 +03:00
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) addLabel ( ctx context . Context , label * Label , doer * user_model . User ) error {
2021-11-19 16:39:57 +03:00
return newIssueLabel ( ctx , issue , label , doer )
2015-08-10 09:42:50 +03:00
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) addLabels ( ctx context . Context , labels [ ] * Label , doer * user_model . User ) error {
2021-11-19 16:39:57 +03:00
return newIssueLabels ( ctx , issue , labels , doer )
2016-08-03 21:51:22 +03:00
}
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) getLabels ( e db . Engine ) ( err error ) {
2016-08-03 21:51:22 +03:00
if len ( issue . Labels ) > 0 {
2014-05-24 10:31:58 +04:00
return nil
}
2016-08-03 21:51:22 +03:00
issue . Labels , err = getLabelsByIssueID ( e , issue . ID )
2015-08-10 09:42:50 +03:00
if err != nil {
return fmt . Errorf ( "getLabelsByIssueID: %v" , err )
2014-05-24 10:31:58 +04:00
}
return nil
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) removeLabel ( ctx context . Context , doer * user_model . User , label * Label ) error {
2021-11-19 16:39:57 +03:00
return deleteIssueLabel ( ctx , issue , label , doer )
2015-08-10 09:42:50 +03:00
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) clearLabels ( ctx context . Context , doer * user_model . User ) ( err error ) {
2021-11-19 16:39:57 +03:00
if err = issue . getLabels ( db . GetEngine ( ctx ) ) ; err != nil {
2016-08-03 21:51:22 +03:00
return fmt . Errorf ( "getLabels: %v" , err )
}
for i := range issue . Labels {
2021-11-19 16:39:57 +03:00
if err = issue . removeLabel ( ctx , doer , issue . Labels [ i ] ) ; err != nil {
2016-08-03 21:51:22 +03:00
return fmt . Errorf ( "removeLabel: %v" , err )
}
}
return nil
}
2016-11-24 11:41:11 +03:00
// ClearLabels removes all issue labels as the given user.
// Triggers appropriate WebHooks, if any.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ClearLabels ( doer * user_model . User ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2015-08-14 19:42:43 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2015-08-14 19:42:43 +03:00
2021-12-10 04:27:50 +03:00
if err := issue . loadRepo ( ctx ) ; err != nil {
2016-12-17 14:49:17 +03:00
return err
2021-09-23 18:45:36 +03:00
} else if err = issue . loadPullRequest ( db . GetEngine ( ctx ) ) ; err != nil {
2017-07-26 10:16:45 +03:00
return err
2016-12-17 14:49:17 +03:00
}
2021-12-10 04:27:50 +03:00
perm , err := getUserRepoPermission ( ctx , issue . Repo , doer )
2018-11-28 14:26:14 +03:00
if err != nil {
2016-12-17 14:49:17 +03:00
return err
2018-11-28 14:26:14 +03:00
}
if ! perm . CanWriteIssuesOrPulls ( issue . IsPull ) {
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 07:14:46 +03:00
return ErrRepoLabelNotExist { }
2016-12-17 14:49:17 +03:00
}
2021-11-19 16:39:57 +03:00
if err = issue . clearLabels ( ctx , doer ) ; err != nil {
2015-08-14 19:42:43 +03:00
return err
}
2021-09-19 14:49:59 +03:00
if err = committer . Commit ( ) ; err != nil {
2016-08-14 13:32:24 +03:00
return fmt . Errorf ( "Commit: %v" , err )
}
return nil
2015-08-14 19:42:43 +03:00
}
2017-01-30 15:46:45 +03:00
type labelSorter [ ] * Label
func ( ts labelSorter ) Len ( ) int {
return len ( [ ] * Label ( ts ) )
}
func ( ts labelSorter ) Less ( i , j int ) bool {
return [ ] * Label ( ts ) [ i ] . ID < [ ] * Label ( ts ) [ j ] . ID
}
func ( ts labelSorter ) Swap ( i , j int ) {
[ ] * Label ( ts ) [ i ] , [ ] * Label ( ts ) [ j ] = [ ] * Label ( ts ) [ j ] , [ ] * Label ( ts ) [ i ]
}
2016-08-03 21:51:22 +03:00
// ReplaceLabels removes all current labels and add new labels to the issue.
2016-11-24 11:41:11 +03:00
// Triggers appropriate WebHooks, if any.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ReplaceLabels ( labels [ ] * Label , doer * user_model . User ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2015-08-14 19:42:43 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2015-08-14 19:42:43 +03:00
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2021-03-12 20:45:49 +03:00
return err
}
2021-09-23 18:45:36 +03:00
if err = issue . loadLabels ( db . GetEngine ( ctx ) ) ; err != nil {
2017-01-30 15:46:45 +03:00
return err
}
sort . Sort ( labelSorter ( labels ) )
sort . Sort ( labelSorter ( issue . Labels ) )
var toAdd , toRemove [ ] * Label
2017-02-28 04:35:55 +03:00
addIndex , removeIndex := 0 , 0
for addIndex < len ( labels ) && removeIndex < len ( issue . Labels ) {
addLabel := labels [ addIndex ]
removeLabel := issue . Labels [ removeIndex ]
if addLabel . ID == removeLabel . ID {
2021-03-12 20:45:49 +03:00
// Silently drop invalid labels
if removeLabel . RepoID != issue . RepoID && removeLabel . OrgID != issue . Repo . OwnerID {
toRemove = append ( toRemove , removeLabel )
}
2017-02-28 04:35:55 +03:00
addIndex ++
removeIndex ++
} else if addLabel . ID < removeLabel . ID {
2021-03-12 20:45:49 +03:00
// Only add if the label is valid
if addLabel . RepoID == issue . RepoID || addLabel . OrgID == issue . Repo . OwnerID {
toAdd = append ( toAdd , addLabel )
}
2017-02-28 04:35:55 +03:00
addIndex ++
} else {
toRemove = append ( toRemove , removeLabel )
removeIndex ++
2017-01-30 15:46:45 +03:00
}
}
2017-02-28 04:35:55 +03:00
toAdd = append ( toAdd , labels [ addIndex : ] ... )
toRemove = append ( toRemove , issue . Labels [ removeIndex : ] ... )
2017-01-30 15:46:45 +03:00
if len ( toAdd ) > 0 {
2021-11-19 16:39:57 +03:00
if err = issue . addLabels ( ctx , toAdd , doer ) ; err != nil {
2017-01-30 15:46:45 +03:00
return fmt . Errorf ( "addLabels: %v" , err )
}
}
2017-02-28 04:35:55 +03:00
for _ , l := range toRemove {
2021-11-19 16:39:57 +03:00
if err = issue . removeLabel ( ctx , doer , l ) ; err != nil {
2017-02-28 04:35:55 +03:00
return fmt . Errorf ( "removeLabel: %v" , err )
2017-01-30 15:46:45 +03:00
}
2015-08-14 19:42:43 +03:00
}
2020-10-05 09:49:11 +03:00
issue . Labels = nil
2021-09-23 18:45:36 +03:00
if err = issue . loadLabels ( db . GetEngine ( ctx ) ) ; err != nil {
2020-10-05 09:49:11 +03:00
return err
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2015-08-10 09:42:50 +03:00
}
2015-08-12 13:44:09 +03:00
// ReadBy sets issue to be read by given user.
2016-12-30 19:44:54 +03:00
func ( issue * Issue ) ReadBy ( userID int64 ) error {
if err := UpdateIssueUserByRead ( userID , issue . ID ) ; err != nil {
return err
}
2021-09-23 18:45:36 +03:00
return setIssueNotificationStatusReadIfUnread ( db . GetEngine ( db . DefaultContext ) , userID , issue . ID )
2014-07-23 23:15:47 +04:00
}
2021-09-19 14:49:59 +03:00
func updateIssueCols ( e db . Engine , issue * Issue , cols ... string ) error {
2017-10-05 07:43:04 +03:00
if _ , err := e . ID ( issue . ID ) . Cols ( cols ... ) . Update ( issue ) ; err != nil {
2017-01-25 05:43:02 +03:00
return err
}
return nil
2016-08-14 13:32:24 +03:00
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) changeStatus ( ctx context . Context , doer * user_model . User , isClosed , isMergePull bool ) ( * Comment , error ) {
2019-03-05 05:52:52 +03:00
// Reload the issue
2021-11-19 16:39:57 +03:00
currentIssue , err := getIssueByID ( db . GetEngine ( ctx ) , issue . ID )
2019-03-05 05:52:52 +03:00
if err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2019-03-05 05:52:52 +03:00
}
2016-03-05 20:58:51 +03:00
// Nothing should be performed if current status is same as target status
2019-03-05 05:52:52 +03:00
if currentIssue . IsClosed == isClosed {
2019-12-16 00:57:34 +03:00
if ! issue . IsPull {
return nil , ErrIssueWasClosed {
ID : issue . ID ,
}
}
return nil , ErrPullWasClosed {
ID : issue . ID ,
}
2015-08-13 11:07:11 +03:00
}
2018-07-18 00:23:58 +03:00
2020-05-17 00:05:19 +03:00
issue . IsClosed = isClosed
2021-11-19 16:39:57 +03:00
return issue . doChangeStatus ( ctx , doer , isMergePull )
2020-05-17 00:05:19 +03:00
}
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) doChangeStatus ( ctx context . Context , doer * user_model . User , isMergePull bool ) ( * Comment , error ) {
2021-11-19 16:39:57 +03:00
e := db . GetEngine ( ctx )
2018-07-18 00:23:58 +03:00
// Check for open dependencies
2021-12-10 04:27:50 +03:00
if issue . IsClosed && issue . Repo . IsDependenciesEnabledCtx ( ctx ) {
2018-07-18 00:23:58 +03:00
// only check if dependencies are enabled and we're about to close an issue, otherwise reopening an issue would fail when there are unsatisfied dependencies
2018-10-27 17:45:24 +03:00
noDeps , err := issueNoDependenciesLeft ( e , issue )
2018-07-18 00:23:58 +03:00
if err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2018-07-18 00:23:58 +03:00
}
if ! noDeps {
2019-12-16 00:57:34 +03:00
return nil , ErrDependenciesLeft { issue . ID }
2018-07-18 00:23:58 +03:00
}
}
2020-05-17 00:05:19 +03:00
if issue . IsClosed {
2019-08-15 17:46:21 +03:00
issue . ClosedUnix = timeutil . TimeStampNow ( )
2018-02-19 05:39:26 +03:00
} else {
issue . ClosedUnix = 0
}
2015-08-13 11:07:11 +03:00
2020-05-17 00:05:19 +03:00
if err := updateIssueCols ( e , issue , "is_closed" , "closed_unix" ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2015-08-13 11:07:11 +03:00
}
2016-03-05 20:58:51 +03:00
// Update issue count of labels
2020-05-17 00:05:19 +03:00
if err := issue . getLabels ( e ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2015-08-13 11:07:11 +03:00
}
2016-11-22 14:24:39 +03:00
for idx := range issue . Labels {
2020-05-17 00:05:19 +03:00
if err := updateLabelCols ( e , issue . Labels [ idx ] , "num_issues" , "num_closed_issue" ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2015-08-13 11:07:11 +03:00
}
}
2016-03-05 20:58:51 +03:00
// Update issue count of milestone
2021-06-21 21:34:58 +03:00
if issue . MilestoneID > 0 {
if err := updateMilestoneCounters ( e , issue . MilestoneID ) ; err != nil {
return nil , err
}
2015-08-13 11:07:11 +03:00
}
2020-02-20 10:46:46 +03:00
if err := issue . updateClosedNum ( e ) ; err != nil {
return nil , err
}
2016-03-05 20:58:51 +03:00
// New action comment
2019-11-15 21:18:09 +03:00
cmtType := CommentTypeClose
if ! issue . IsClosed {
cmtType = CommentTypeReopen
2020-04-14 04:06:23 +03:00
} else if isMergePull {
cmtType = CommentTypeMergePull
2019-11-15 21:18:09 +03:00
}
2019-12-01 05:44:39 +03:00
2021-11-19 16:39:57 +03:00
return createComment ( ctx , & CreateCommentOptions {
2019-11-15 21:18:09 +03:00
Type : cmtType ,
Doer : doer ,
Repo : issue . Repo ,
Issue : issue ,
2019-12-16 00:57:34 +03:00
} )
2015-08-13 11:07:11 +03:00
}
2016-03-05 20:58:51 +03:00
// ChangeStatus changes issue status to open or closed.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ChangeStatus ( doer * user_model . User , isClosed bool ) ( * Comment , error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2015-08-13 11:07:11 +03:00
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2015-08-13 11:07:11 +03:00
2021-12-10 04:27:50 +03:00
if err := issue . loadRepo ( ctx ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2018-12-13 18:55:43 +03:00
}
2021-09-23 18:45:36 +03:00
if err := issue . loadPoster ( db . GetEngine ( ctx ) ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , err
2018-12-13 18:55:43 +03:00
}
2021-11-19 16:39:57 +03:00
comment , err := issue . changeStatus ( ctx , doer , isClosed , false )
2019-12-16 00:57:34 +03:00
if err != nil {
return nil , err
2015-08-13 11:07:11 +03:00
}
2021-09-19 14:49:59 +03:00
if err = committer . Commit ( ) ; err != nil {
2019-12-16 00:57:34 +03:00
return nil , fmt . Errorf ( "Commit: %v" , err )
2016-08-14 13:32:24 +03:00
}
2019-12-16 00:57:34 +03:00
return comment , nil
2016-08-14 13:32:24 +03:00
}
2016-11-24 11:41:11 +03:00
// ChangeTitle changes the title of this issue, as the given user.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ChangeTitle ( doer * user_model . User , oldTitle string ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2017-02-05 17:36:00 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2017-02-05 17:36:00 +03:00
2021-09-23 18:45:36 +03:00
if err = updateIssueCols ( db . GetEngine ( ctx ) , issue , "name" ) ; err != nil {
2017-02-05 17:36:00 +03:00
return fmt . Errorf ( "updateIssueCols: %v" , err )
}
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2018-12-13 18:55:43 +03:00
return fmt . Errorf ( "loadRepo: %v" , err )
}
2021-03-14 21:52:12 +03:00
opts := & CreateCommentOptions {
2019-11-15 21:18:09 +03:00
Type : CommentTypeChangeTitle ,
Doer : doer ,
Repo : issue . Repo ,
Issue : issue ,
OldTitle : oldTitle ,
NewTitle : issue . Title ,
2019-12-01 05:44:39 +03:00
}
2021-11-19 16:39:57 +03:00
if _ , err = createComment ( ctx , opts ) ; err != nil {
2019-11-15 21:18:09 +03:00
return fmt . Errorf ( "createComment: %v" , err )
2017-02-05 17:36:00 +03:00
}
2021-11-19 16:39:57 +03:00
if err = issue . addCrossReferences ( ctx , doer , true ) ; err != nil {
2019-09-20 08:45:38 +03:00
return err
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2015-08-13 11:07:11 +03:00
}
2020-09-08 19:29:51 +03:00
// ChangeRef changes the branch of this issue, as the given user.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ChangeRef ( doer * user_model . User , oldRef string ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2020-09-08 19:29:51 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2020-09-08 19:29:51 +03:00
2021-09-23 18:45:36 +03:00
if err = updateIssueCols ( db . GetEngine ( ctx ) , issue , "ref" ) ; err != nil {
2020-09-08 19:29:51 +03:00
return fmt . Errorf ( "updateIssueCols: %v" , err )
}
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2021-11-19 12:54:31 +03:00
return fmt . Errorf ( "loadRepo: %v" , err )
}
2021-12-02 10:28:08 +03:00
oldRefFriendly := strings . TrimPrefix ( oldRef , git . BranchPrefix )
newRefFriendly := strings . TrimPrefix ( issue . Ref , git . BranchPrefix )
2021-11-19 12:54:31 +03:00
opts := & CreateCommentOptions {
Type : CommentTypeChangeIssueRef ,
Doer : doer ,
Repo : issue . Repo ,
Issue : issue ,
OldRef : oldRefFriendly ,
NewRef : newRefFriendly ,
}
2021-11-19 16:39:57 +03:00
if _ , err = createComment ( ctx , opts ) ; err != nil {
2021-11-19 12:54:31 +03:00
return fmt . Errorf ( "createComment: %v" , err )
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2020-09-08 19:29:51 +03:00
}
2017-02-11 07:00:29 +03:00
// AddDeletePRBranchComment adds delete branch comment for pull request issue
2021-12-10 04:27:50 +03:00
func AddDeletePRBranchComment ( doer * user_model . User , repo * repo_model . Repository , issueID int64 , branchName string ) error {
2021-09-23 18:45:36 +03:00
issue , err := getIssueByID ( db . GetEngine ( db . DefaultContext ) , issueID )
2017-02-11 07:00:29 +03:00
if err != nil {
return err
}
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2017-02-11 07:00:29 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2021-03-14 21:52:12 +03:00
opts := & CreateCommentOptions {
2021-02-08 06:09:14 +03:00
Type : CommentTypeDeleteBranch ,
Doer : doer ,
Repo : repo ,
Issue : issue ,
OldRef : branchName ,
2019-12-01 05:44:39 +03:00
}
2021-11-19 16:39:57 +03:00
if _ , err = createComment ( ctx , opts ) ; err != nil {
2017-02-11 07:00:29 +03:00
return err
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2017-02-11 07:00:29 +03:00
}
2019-10-15 15:19:32 +03:00
// UpdateAttachments update attachments by UUIDs for the issue
func ( issue * Issue ) UpdateAttachments ( uuids [ ] string ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2019-10-15 15:19:32 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2021-11-19 16:39:57 +03:00
attachments , err := repo_model . GetAttachmentsByUUIDs ( ctx , uuids )
2019-10-15 15:19:32 +03:00
if err != nil {
return fmt . Errorf ( "getAttachmentsByUUIDs [uuids: %v]: %v" , uuids , err )
}
for i := 0 ; i < len ( attachments ) ; i ++ {
attachments [ i ] . IssueID = issue . ID
2021-11-19 16:39:57 +03:00
if err := repo_model . UpdateAttachmentCtx ( ctx , attachments [ i ] ) ; err != nil {
2019-10-15 15:19:32 +03:00
return fmt . Errorf ( "update attachment [id: %d]: %v" , attachments [ i ] . ID , err )
}
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2019-10-15 15:19:32 +03:00
}
2016-11-24 11:41:11 +03:00
// ChangeContent changes issue content, as the given user.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ChangeContent ( doer * user_model . User , content string ) ( err error ) {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2019-09-20 08:45:38 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2019-09-20 08:45:38 +03:00
2021-11-22 15:20:16 +03:00
hasContentHistory , err := issues . HasIssueContentHistory ( ctx , issue . ID , 0 )
if err != nil {
return fmt . Errorf ( "HasIssueContentHistory: %v" , err )
}
if ! hasContentHistory {
if err = issues . SaveIssueContentHistory ( db . GetEngine ( ctx ) , issue . PosterID , issue . ID , 0 ,
issue . CreatedUnix , issue . Content , true ) ; err != nil {
return fmt . Errorf ( "SaveIssueContentHistory: %v" , err )
}
}
issue . Content = content
2021-09-23 18:45:36 +03:00
if err = updateIssueCols ( db . GetEngine ( ctx ) , issue , "content" ) ; err != nil {
2016-08-14 13:32:24 +03:00
return fmt . Errorf ( "UpdateIssueCols: %v" , err )
}
2019-11-19 02:43:03 +03:00
2021-10-23 17:47:38 +03:00
if err = issues . SaveIssueContentHistory ( db . GetEngine ( ctx ) , doer . ID , issue . ID , 0 ,
2021-10-11 01:40:03 +03:00
timeutil . TimeStampNow ( ) , issue . Content , false ) ; err != nil {
return fmt . Errorf ( "SaveIssueContentHistory: %v" , err )
}
2021-11-19 16:39:57 +03:00
if err = issue . addCrossReferences ( ctx , doer , true ) ; err != nil {
2021-10-11 01:40:03 +03:00
return fmt . Errorf ( "addCrossReferences: %v" , err )
2019-09-20 08:45:38 +03:00
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2016-08-14 13:32:24 +03:00
}
2018-01-03 11:34:13 +03:00
// GetTasks returns the amount of tasks in the issues content
func ( issue * Issue ) GetTasks ( ) int {
return len ( issueTasksPat . FindAllStringIndex ( issue . Content , - 1 ) )
}
// GetTasksDone returns the amount of completed tasks in the issues content
func ( issue * Issue ) GetTasksDone ( ) int {
return len ( issueTasksDonePat . FindAllStringIndex ( issue . Content , - 1 ) )
}
2019-02-13 11:14:17 +03:00
// GetLastEventTimestamp returns the last user visible event timestamp, either the creation of this issue or the close.
2019-08-15 17:46:21 +03:00
func ( issue * Issue ) GetLastEventTimestamp ( ) timeutil . TimeStamp {
2019-02-13 11:14:17 +03:00
if issue . IsClosed {
return issue . ClosedUnix
}
return issue . CreatedUnix
}
// GetLastEventLabel returns the localization label for the current issue.
func ( issue * Issue ) GetLastEventLabel ( ) string {
if issue . IsClosed {
if issue . IsPull && issue . PullRequest . HasMerged {
return "repo.pulls.merged_by"
}
return "repo.issues.closed_by"
}
return "repo.issues.opened_by"
}
2020-01-09 14:56:32 +03:00
// GetLastComment return last comment for the current issue.
func ( issue * Issue ) GetLastComment ( ) ( * Comment , error ) {
var c Comment
2021-09-23 18:45:36 +03:00
exist , err := db . GetEngine ( db . DefaultContext ) . Where ( "type = ?" , CommentTypeComment ) .
2021-10-06 23:36:24 +03:00
And ( "issue_id = ?" , issue . ID ) . Desc ( "created_unix" ) . Get ( & c )
2020-01-09 14:56:32 +03:00
if err != nil {
return nil , err
}
if ! exist {
return nil , nil
}
return & c , nil
}
2019-03-28 01:22:39 +03:00
// GetLastEventLabelFake returns the localization label for the current issue without providing a link in the username.
func ( issue * Issue ) GetLastEventLabelFake ( ) string {
if issue . IsClosed {
if issue . IsPull && issue . PullRequest . HasMerged {
return "repo.pulls.merged_by_fake"
}
return "repo.issues.closed_by_fake"
}
return "repo.issues.opened_by_fake"
}
2016-11-24 11:41:11 +03:00
// NewIssueOptions represents the options of a new issue.
2016-08-16 04:40:32 +03:00
type NewIssueOptions struct {
2021-12-10 04:27:50 +03:00
Repo * repo_model . Repository
2016-08-16 04:40:32 +03:00
Issue * Issue
2017-03-01 04:08:45 +03:00
LabelIDs [ ] int64
2016-08-16 04:40:32 +03:00
Attachments [ ] string // In UUID format.
IsPull bool
}
2016-03-14 06:20:22 +03:00
2021-11-24 12:49:20 +03:00
func newIssue ( ctx context . Context , doer * user_model . User , opts NewIssueOptions ) ( err error ) {
2021-11-19 16:39:57 +03:00
e := db . GetEngine ( ctx )
2016-08-16 04:40:32 +03:00
opts . Issue . Title = strings . TrimSpace ( opts . Issue . Title )
2019-05-18 05:37:49 +03:00
2016-08-16 20:19:09 +03:00
if opts . Issue . MilestoneID > 0 {
2016-08-25 02:05:56 +03:00
milestone , err := getMilestoneByRepoID ( e , opts . Issue . RepoID , opts . Issue . MilestoneID )
2016-08-16 20:19:09 +03:00
if err != nil && ! IsErrMilestoneNotExist ( err ) {
return fmt . Errorf ( "getMilestoneByID: %v" , err )
}
// Assume milestone is invalid and drop silently.
opts . Issue . MilestoneID = 0
if milestone != nil {
opts . Issue . MilestoneID = milestone . ID
opts . Issue . Milestone = milestone
}
}
2021-06-14 05:22:55 +03:00
if opts . Issue . Index <= 0 {
return fmt . Errorf ( "no issue index provided" )
}
if opts . Issue . ID > 0 {
return fmt . Errorf ( "issue exist" )
2019-08-27 05:17:23 +03:00
}
2021-06-14 05:22:55 +03:00
if _ , err := e . Insert ( opts . Issue ) ; err != nil {
2014-05-07 20:09:30 +04:00
return err
2015-09-02 23:18:09 +03:00
}
2017-02-01 05:36:08 +03:00
if opts . Issue . MilestoneID > 0 {
2021-06-21 21:34:58 +03:00
if err := updateMilestoneCounters ( e , opts . Issue . MilestoneID ) ; err != nil {
2017-02-01 05:36:08 +03:00
return err
}
2019-10-25 10:19:04 +03:00
2021-03-14 21:52:12 +03:00
opts := & CreateCommentOptions {
2019-12-01 05:44:39 +03:00
Type : CommentTypeMilestone ,
Doer : doer ,
Repo : opts . Repo ,
Issue : opts . Issue ,
OldMilestoneID : 0 ,
MilestoneID : opts . Issue . MilestoneID ,
}
2021-11-19 16:39:57 +03:00
if _ , err = createComment ( ctx , opts ) ; err != nil {
2019-10-25 10:19:04 +03:00
return err
}
2017-02-01 05:36:08 +03:00
}
2016-08-16 04:40:32 +03:00
if opts . IsPull {
_ , err = e . Exec ( "UPDATE `repository` SET num_pulls = num_pulls + 1 WHERE id = ?" , opts . Issue . RepoID )
2015-09-02 23:18:09 +03:00
} else {
2016-08-16 04:40:32 +03:00
_ , err = e . Exec ( "UPDATE `repository` SET num_issues = num_issues + 1 WHERE id = ?" , opts . Issue . RepoID )
2015-09-02 23:18:09 +03:00
}
if err != nil {
2014-05-07 20:09:30 +04:00
return err
2014-03-27 20:48:29 +04:00
}
2014-07-22 15:50:34 +04:00
2017-03-01 04:08:45 +03:00
if len ( opts . LabelIDs ) > 0 {
2016-11-21 22:08:21 +03:00
// During the session, SQLite3 driver cannot handle retrieve objects after update something.
2016-03-06 04:45:23 +03:00
// So we have to get all needed labels first.
2017-03-01 04:08:45 +03:00
labels := make ( [ ] * Label , 0 , len ( opts . LabelIDs ) )
if err = e . In ( "id" , opts . LabelIDs ) . Find ( & labels ) ; err != nil {
return fmt . Errorf ( "find all labels [label_ids: %v]: %v" , opts . LabelIDs , err )
2016-03-06 04:45:23 +03:00
}
2015-08-14 19:42:43 +03:00
2017-01-30 15:46:45 +03:00
if err = opts . Issue . loadPoster ( e ) ; err != nil {
return err
}
2016-03-06 04:45:23 +03:00
for _ , label := range labels {
2016-08-16 04:40:32 +03:00
// Silently drop invalid labels.
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 07:14:46 +03:00
if label . RepoID != opts . Repo . ID && label . OrgID != opts . Repo . OwnerID {
2016-03-14 06:20:22 +03:00
continue
}
2021-11-19 16:39:57 +03:00
if err = opts . Issue . addLabel ( ctx , label , opts . Issue . Poster ) ; err != nil {
2016-08-16 04:40:32 +03:00
return fmt . Errorf ( "addLabel [id: %d]: %v" , label . ID , err )
2016-03-06 04:45:23 +03:00
}
2015-08-10 11:52:08 +03:00
}
}
2021-12-10 04:27:50 +03:00
if err = newIssueUsers ( ctx , opts . Repo , opts . Issue ) ; err != nil {
2015-08-10 16:47:23 +03:00
return err
}
2016-08-16 04:40:32 +03:00
if len ( opts . Attachments ) > 0 {
2021-11-19 16:39:57 +03:00
attachments , err := repo_model . GetAttachmentsByUUIDs ( ctx , opts . Attachments )
2015-09-02 02:07:02 +03:00
if err != nil {
2016-08-16 04:40:32 +03:00
return fmt . Errorf ( "getAttachmentsByUUIDs [uuids: %v]: %v" , opts . Attachments , err )
2015-09-02 02:07:02 +03:00
}
2016-08-16 04:40:32 +03:00
for i := 0 ; i < len ( attachments ) ; i ++ {
attachments [ i ] . IssueID = opts . Issue . ID
2017-10-05 07:43:04 +03:00
if _ , err = e . ID ( attachments [ i ] . ID ) . Update ( attachments [ i ] ) ; err != nil {
2016-08-16 04:40:32 +03:00
return fmt . Errorf ( "update attachment [id: %d]: %v" , attachments [ i ] . ID , err )
}
2015-08-11 18:24:40 +03:00
}
}
2021-11-19 16:39:57 +03:00
if err = opts . Issue . loadAttributes ( ctx ) ; err != nil {
2019-09-20 08:45:38 +03:00
return err
}
2021-10-11 01:40:03 +03:00
2021-11-19 16:39:57 +03:00
return opts . Issue . addCrossReferences ( ctx , doer , false )
2015-09-02 02:07:02 +03:00
}
2021-08-13 16:06:18 +03:00
// RecalculateIssueIndexForRepo create issue_index for repo if not exist and
// update it based on highest index of existing issues assigned to a repo
func RecalculateIssueIndexForRepo ( repoID int64 ) error {
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2021-08-13 16:06:18 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2021-08-13 16:06:18 +03:00
2021-09-23 18:45:36 +03:00
if err := db . UpsertResourceIndex ( db . GetEngine ( ctx ) , "issue_index" , repoID ) ; err != nil {
2021-08-13 16:06:18 +03:00
return err
}
var max int64
2021-09-23 18:45:36 +03:00
if _ , err := db . GetEngine ( ctx ) . Select ( " MAX(`index`)" ) . Table ( "issue" ) . Where ( "repo_id=?" , repoID ) . Get ( & max ) ; err != nil {
2021-08-13 16:06:18 +03:00
return err
}
2021-09-23 18:45:36 +03:00
if _ , err := db . GetEngine ( ctx ) . Exec ( "UPDATE `issue_index` SET max_index=? WHERE group_id=?" , max , repoID ) ; err != nil {
2021-08-13 16:06:18 +03:00
return err
}
2021-09-19 14:49:59 +03:00
return committer . Commit ( )
2021-08-13 16:06:18 +03:00
}
2015-09-02 02:07:02 +03:00
// NewIssue creates new issue with labels for repository.
2021-12-10 04:27:50 +03:00
func NewIssue ( repo * repo_model . Repository , issue * Issue , labelIDs [ ] int64 , uuids [ ] string ) ( err error ) {
2021-09-19 14:49:59 +03:00
idx , err := db . GetNextResourceIndex ( "issue_index" , repo . ID )
2021-06-14 05:22:55 +03:00
if err != nil {
return fmt . Errorf ( "generate issue index failed: %v" , err )
2019-10-03 01:28:30 +03:00
}
2021-06-14 05:22:55 +03:00
issue . Index = idx
2021-09-19 14:49:59 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2015-09-02 02:07:02 +03:00
return err
}
2021-09-19 14:49:59 +03:00
defer committer . Close ( )
2015-09-02 02:07:02 +03:00
2021-11-19 16:39:57 +03:00
if err = newIssue ( ctx , issue . Poster , NewIssueOptions {
2016-08-16 04:40:32 +03:00
Repo : repo ,
Issue : issue ,
2017-03-01 04:08:45 +03:00
LabelIDs : labelIDs ,
2016-08-16 04:40:32 +03:00
Attachments : uuids ,
} ) ; err != nil {
2019-10-03 01:28:30 +03:00
if IsErrUserDoesNotHaveAccessToRepo ( err ) || IsErrNewIssueInsert ( err ) {
2018-05-09 19:29:04 +03:00
return err
}
2015-09-02 02:07:02 +03:00
return fmt . Errorf ( "newIssue: %v" , err )
}
2021-09-19 14:49:59 +03:00
if err = committer . Commit ( ) ; err != nil {
2016-03-14 06:20:22 +03:00
return fmt . Errorf ( "Commit: %v" , err )
}
return nil
2014-03-21 00:04:56 +04:00
}
2018-12-13 18:55:43 +03:00
// GetIssueByIndex returns raw issue without loading attributes by index in a repository.
func GetIssueByIndex ( repoID , index int64 ) ( * Issue , error ) {
2021-07-12 23:22:27 +03:00
if index < 1 {
return nil , ErrIssueNotExist { }
}
2015-08-12 12:04:23 +03:00
issue := & Issue {
RepoID : repoID ,
Index : index ,
}
2021-09-23 18:45:36 +03:00
has , err := db . GetEngine ( db . DefaultContext ) . Get ( issue )
2014-03-23 00:00:46 +04:00
if err != nil {
return nil , err
} else if ! has {
2015-08-12 12:04:23 +03:00
return nil , ErrIssueNotExist { 0 , repoID , index }
2014-03-23 00:00:46 +04:00
}
2016-08-26 23:40:53 +03:00
return issue , nil
}
2018-12-13 18:55:43 +03:00
// GetIssueWithAttrsByIndex returns issue by index in a repository.
func GetIssueWithAttrsByIndex ( repoID , index int64 ) ( * Issue , error ) {
issue , err := GetIssueByIndex ( repoID , index )
2016-08-26 23:40:53 +03:00
if err != nil {
return nil , err
}
2016-07-21 09:26:30 +03:00
return issue , issue . LoadAttributes ( )
2014-03-23 00:00:46 +04:00
}
2021-09-19 14:49:59 +03:00
func getIssueByID ( e db . Engine , id int64 ) ( * Issue , error ) {
2015-08-12 12:04:23 +03:00
issue := new ( Issue )
2017-10-05 07:43:04 +03:00
has , err := e . ID ( id ) . Get ( issue )
2014-05-08 00:51:14 +04:00
if err != nil {
return nil , err
} else if ! has {
2015-08-12 12:04:23 +03:00
return nil , ErrIssueNotExist { id , 0 , 0 }
2014-05-08 00:51:14 +04:00
}
2018-12-13 18:55:43 +03:00
return issue , nil
}
// GetIssueWithAttrsByID returns an issue with attributes by given ID.
func GetIssueWithAttrsByID ( id int64 ) ( * Issue , error ) {
2021-09-23 18:45:36 +03:00
issue , err := getIssueByID ( db . GetEngine ( db . DefaultContext ) , id )
2018-12-13 18:55:43 +03:00
if err != nil {
return nil , err
}
2021-11-19 16:39:57 +03:00
return issue , issue . loadAttributes ( db . DefaultContext )
2014-05-08 00:51:14 +04:00
}
2016-08-14 13:32:24 +03:00
// GetIssueByID returns an issue by given ID.
func GetIssueByID ( id int64 ) ( * Issue , error ) {
2021-09-23 18:45:36 +03:00
return getIssueByID ( db . GetEngine ( db . DefaultContext ) , id )
2016-08-14 13:32:24 +03:00
}
2021-09-19 14:49:59 +03:00
func getIssuesByIDs ( e db . Engine , issueIDs [ ] int64 ) ( [ ] * Issue , error ) {
2017-03-15 04:10:35 +03:00
issues := make ( [ ] * Issue , 0 , 10 )
return issues , e . In ( "id" , issueIDs ) . Find ( & issues )
}
2021-09-19 14:49:59 +03:00
func getIssueIDsByRepoID ( e db . Engine , repoID int64 ) ( [ ] int64 , error ) {
2021-03-14 21:52:12 +03:00
ids := make ( [ ] int64 , 0 , 10 )
2021-06-10 03:08:19 +03:00
err := e . Table ( "issue" ) . Cols ( "id" ) . Where ( "repo_id = ?" , repoID ) . Find ( & ids )
2019-02-19 17:39:39 +03:00
return ids , err
}
2019-02-21 03:54:05 +03:00
// GetIssueIDsByRepoID returns all issue ids by repo id
func GetIssueIDsByRepoID ( repoID int64 ) ( [ ] int64 , error ) {
2021-09-23 18:45:36 +03:00
return getIssueIDsByRepoID ( db . GetEngine ( db . DefaultContext ) , repoID )
2019-02-21 03:54:05 +03:00
}
2017-03-15 04:10:35 +03:00
// GetIssuesByIDs return issues with the given IDs.
func GetIssuesByIDs ( issueIDs [ ] int64 ) ( [ ] * Issue , error ) {
2021-09-23 18:45:36 +03:00
return getIssuesByIDs ( db . GetEngine ( db . DefaultContext ) , issueIDs )
2017-03-15 04:10:35 +03:00
}
2016-11-24 11:41:11 +03:00
// IssuesOptions represents options of an issue.
2015-09-02 23:18:09 +03:00
type IssuesOptions struct {
2021-09-24 14:32:56 +03:00
db . ListOptions
2020-03-30 08:30:39 +03:00
RepoIDs [ ] int64 // include all repos if empty
AssigneeID int64
PosterID int64
MentionedID int64
2021-01-17 19:34:19 +03:00
ReviewRequestedID int64
2020-04-30 07:15:39 +03:00
MilestoneIDs [ ] int64
2020-08-17 06:07:38 +03:00
ProjectID int64
ProjectBoardID int64
2020-03-30 08:30:39 +03:00
IsClosed util . OptionalBool
IsPull util . OptionalBool
LabelIDs [ ] int64
IncludedLabelNames [ ] string
ExcludedLabelNames [ ] string
2021-06-17 09:40:59 +03:00
IncludeMilestones [ ] string
2020-03-30 08:30:39 +03:00
SortType string
IssueIDs [ ] int64
2020-11-23 23:49:36 +03:00
UpdatedAfterUnix int64
UpdatedBeforeUnix int64
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
// prioritize issues from this repo
PriorityRepoID int64
2021-01-13 07:19:17 +03:00
IsArchived util . OptionalBool
2021-12-29 16:02:12 +03:00
Org * Organization // issues permission scope
Team * Team // issues permission scope
User * user_model . User // issues permission scope
2015-09-02 23:18:09 +03:00
}
2017-01-01 21:15:09 +03:00
// sortIssuesSession sort an issues-related session based on the provided
// sortType string
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
func sortIssuesSession ( sess * xorm . Session , sortType string , priorityRepoID int64 ) {
2017-01-01 21:15:09 +03:00
switch sortType {
case "oldest" :
2021-12-29 06:12:19 +03:00
sess . Asc ( "issue.created_unix" ) . Asc ( "issue.id" )
2017-01-01 21:15:09 +03:00
case "recentupdate" :
2021-12-29 06:12:19 +03:00
sess . Desc ( "issue.updated_unix" ) . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2017-01-01 21:15:09 +03:00
case "leastupdate" :
2021-12-29 06:12:19 +03:00
sess . Asc ( "issue.updated_unix" ) . Asc ( "issue.created_unix" ) . Asc ( "issue.id" )
2017-01-01 21:15:09 +03:00
case "mostcomment" :
2021-12-29 06:12:19 +03:00
sess . Desc ( "issue.num_comments" ) . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2017-01-01 21:15:09 +03:00
case "leastcomment" :
2021-12-29 06:12:19 +03:00
sess . Asc ( "issue.num_comments" ) . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2017-01-01 21:15:09 +03:00
case "priority" :
2021-12-29 06:12:19 +03:00
sess . Desc ( "issue.priority" ) . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2019-03-05 17:39:41 +03:00
case "nearduedate" :
2019-11-09 16:09:01 +03:00
// 253370764800 is 01/01/9999 @ 12:00am (UTC)
2021-06-15 04:15:56 +03:00
sess . Join ( "LEFT" , "milestone" , "issue.milestone_id = milestone.id" ) .
OrderBy ( "CASE " +
"WHEN issue.deadline_unix = 0 AND (milestone.deadline_unix = 0 OR milestone.deadline_unix IS NULL) THEN 253370764800 " +
"WHEN milestone.deadline_unix = 0 OR milestone.deadline_unix IS NULL THEN issue.deadline_unix " +
"WHEN milestone.deadline_unix < issue.deadline_unix OR issue.deadline_unix = 0 THEN milestone.deadline_unix " +
2021-12-29 06:12:19 +03:00
"ELSE issue.deadline_unix END ASC" ) .
Desc ( "issue.created_unix" ) .
Desc ( "issue.id" )
2019-03-05 17:39:41 +03:00
case "farduedate" :
2021-06-15 04:15:56 +03:00
sess . Join ( "LEFT" , "milestone" , "issue.milestone_id = milestone.id" ) .
OrderBy ( "CASE " +
"WHEN milestone.deadline_unix IS NULL THEN issue.deadline_unix " +
"WHEN milestone.deadline_unix < issue.deadline_unix OR issue.deadline_unix = 0 THEN milestone.deadline_unix " +
2021-12-29 06:12:19 +03:00
"ELSE issue.deadline_unix END DESC" ) .
Desc ( "issue.created_unix" ) .
Desc ( "issue.id" )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
case "priorityrepo" :
2021-12-29 06:12:19 +03:00
sess . OrderBy ( "CASE " +
"WHEN issue.repo_id = " + strconv . FormatInt ( priorityRepoID , 10 ) + " THEN 1 " +
"ELSE 2 END ASC" ) .
Desc ( "issue.created_unix" ) .
Desc ( "issue.id" )
2021-12-08 09:57:18 +03:00
case "project-column-sorting" :
2021-12-29 06:12:19 +03:00
sess . Asc ( "project_issue.sorting" ) . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2017-01-01 21:15:09 +03:00
default :
2021-12-29 06:12:19 +03:00
sess . Desc ( "issue.created_unix" ) . Desc ( "issue.id" )
2017-01-01 21:15:09 +03:00
}
}
2019-06-12 22:41:28 +03:00
func ( opts * IssuesOptions ) setupSession ( sess * xorm . Session ) {
2017-08-03 08:09:16 +03:00
if opts . Page >= 0 && opts . PageSize > 0 {
2017-01-25 05:43:02 +03:00
var start int
if opts . Page == 0 {
start = 0
} else {
2017-08-03 08:09:16 +03:00
start = ( opts . Page - 1 ) * opts . PageSize
2017-01-25 05:43:02 +03:00
}
2017-08-03 08:09:16 +03:00
sess . Limit ( opts . PageSize , start )
2016-03-14 06:20:22 +03:00
}
2017-01-25 05:43:02 +03:00
if len ( opts . IssueIDs ) > 0 {
sess . In ( "issue.id" , opts . IssueIDs )
}
2014-03-23 00:00:46 +04:00
2019-10-08 20:55:16 +03:00
if len ( opts . RepoIDs ) > 0 {
2021-01-17 19:34:19 +03:00
applyReposCondition ( sess , opts . RepoIDs )
2014-03-23 00:00:46 +04:00
}
2017-01-25 05:43:02 +03:00
switch opts . IsClosed {
case util . OptionalBoolTrue :
2017-01-25 11:28:03 +03:00
sess . And ( "issue.is_closed=?" , true )
2017-01-25 05:43:02 +03:00
case util . OptionalBoolFalse :
2017-01-25 11:28:03 +03:00
sess . And ( "issue.is_closed=?" , false )
2017-01-25 05:43:02 +03:00
}
2014-03-23 00:00:46 +04:00
2015-09-02 23:18:09 +03:00
if opts . AssigneeID > 0 {
2021-01-17 19:34:19 +03:00
applyAssigneeCondition ( sess , opts . AssigneeID )
2016-12-24 13:33:21 +03:00
}
if opts . PosterID > 0 {
2021-01-17 19:34:19 +03:00
applyPosterCondition ( sess , opts . PosterID )
2014-03-22 21:50:50 +04:00
}
2016-12-24 13:33:21 +03:00
if opts . MentionedID > 0 {
2021-01-17 19:34:19 +03:00
applyMentionedCondition ( sess , opts . MentionedID )
}
if opts . ReviewRequestedID > 0 {
applyReviewRequestedCondition ( sess , opts . ReviewRequestedID )
2016-12-24 13:33:21 +03:00
}
2020-04-30 07:15:39 +03:00
if len ( opts . MilestoneIDs ) > 0 {
sess . In ( "issue.milestone_id" , opts . MilestoneIDs )
2014-03-22 21:50:50 +04:00
}
2020-11-23 23:49:36 +03:00
if opts . UpdatedAfterUnix != 0 {
sess . And ( builder . Gte { "issue.updated_unix" : opts . UpdatedAfterUnix } )
}
if opts . UpdatedBeforeUnix != 0 {
sess . And ( builder . Lte { "issue.updated_unix" : opts . UpdatedBeforeUnix } )
}
2020-08-17 06:07:38 +03:00
if opts . ProjectID > 0 {
sess . Join ( "INNER" , "project_issue" , "issue.id = project_issue.issue_id" ) .
And ( "project_issue.project_id=?" , opts . ProjectID )
}
if opts . ProjectBoardID != 0 {
if opts . ProjectBoardID > 0 {
sess . In ( "issue.id" , builder . Select ( "issue_id" ) . From ( "project_issue" ) . Where ( builder . Eq { "project_board_id" : opts . ProjectBoardID } ) )
} else {
sess . In ( "issue.id" , builder . Select ( "issue_id" ) . From ( "project_issue" ) . Where ( builder . Eq { "project_board_id" : 0 } ) )
}
}
2017-01-25 05:43:02 +03:00
switch opts . IsPull {
case util . OptionalBoolTrue :
2017-01-28 19:01:07 +03:00
sess . And ( "issue.is_pull=?" , true )
2017-01-25 05:43:02 +03:00
case util . OptionalBoolFalse :
2017-01-28 19:01:07 +03:00
sess . And ( "issue.is_pull=?" , false )
2017-01-25 05:43:02 +03:00
}
2015-09-02 23:18:09 +03:00
2021-01-13 07:19:17 +03:00
if opts . IsArchived != util . OptionalBoolNone {
2021-01-27 01:47:42 +03:00
sess . And ( builder . Eq { "repository.is_archived" : opts . IsArchived . IsTrue ( ) } )
2021-01-13 07:19:17 +03:00
}
2019-01-23 07:10:38 +03:00
if opts . LabelIDs != nil {
for i , labelID := range opts . LabelIDs {
2019-10-23 19:29:14 +03:00
if labelID > 0 {
sess . Join ( "INNER" , fmt . Sprintf ( "issue_label il%d" , i ) ,
fmt . Sprintf ( "issue.id = il%[1]d.issue_id AND il%[1]d.label_id = %[2]d" , i , labelID ) )
} else {
sess . Where ( "issue.id not in (select issue_id from issue_label where label_id = ?)" , - labelID )
}
2016-04-26 07:22:03 +03:00
}
2015-08-10 16:47:23 +03:00
}
2020-03-30 08:30:39 +03:00
if len ( opts . IncludedLabelNames ) > 0 {
sess . In ( "issue.id" , BuildLabelNamesIssueIDsCondition ( opts . IncludedLabelNames ) )
}
if len ( opts . ExcludedLabelNames ) > 0 {
sess . And ( builder . NotIn ( "issue.id" , BuildLabelNamesIssueIDsCondition ( opts . ExcludedLabelNames ) ) )
}
2021-06-17 09:40:59 +03:00
if len ( opts . IncludeMilestones ) > 0 {
sess . In ( "issue.milestone_id" ,
builder . Select ( "id" ) .
From ( "milestone" ) .
Where ( builder . In ( "name" , opts . IncludeMilestones ) ) )
}
2021-12-29 16:02:12 +03:00
if opts . User != nil {
sess . And (
issuePullAccessibleRepoCond ( "issue.repo_id" , opts . User . ID , opts . Org , opts . Team , opts . IsPull . IsTrue ( ) ) ,
)
}
}
// issuePullAccessibleRepoCond userID must not be zero, this condition require join repository table
func issuePullAccessibleRepoCond ( repoIDstr string , userID int64 , org * Organization , team * Team , isPull bool ) builder . Cond {
2022-01-05 06:37:00 +03:00
cond := builder . NewCond ( )
unitType := unit . TypeIssues
2021-12-29 16:02:12 +03:00
if isPull {
unitType = unit . TypePullRequests
}
if org != nil {
if team != nil {
cond = cond . And ( teamUnitsRepoCond ( repoIDstr , userID , org . ID , team . ID , unitType ) ) // special team member repos
} else {
cond = cond . And (
builder . Or (
userOrgUnitRepoCond ( repoIDstr , userID , org . ID , unitType ) , // team member repos
userOrgPublicUnitRepoCond ( userID , org . ID ) , // user org public non-member repos, TODO: check repo has issues
) ,
)
}
} else {
cond = cond . And (
builder . Or (
userOwnedRepoCond ( userID ) , // owned repos
userCollaborationRepoCond ( repoIDstr , userID ) , // collaboration repos
userAssignedRepoCond ( repoIDstr , userID ) , // user has been assigned accessible public repos
userMentionedRepoCond ( repoIDstr , userID ) , // user has been mentioned accessible public repos
userCreateIssueRepoCond ( repoIDstr , userID , isPull ) , // user has created issue/pr accessible public repos
) ,
)
}
return cond
2017-08-03 08:09:16 +03:00
}
2021-01-17 19:34:19 +03:00
func applyReposCondition ( sess * xorm . Session , repoIDs [ ] int64 ) * xorm . Session {
return sess . In ( "issue.repo_id" , repoIDs )
}
func applyAssigneeCondition ( sess * xorm . Session , assigneeID int64 ) * xorm . Session {
return sess . Join ( "INNER" , "issue_assignees" , "issue.id = issue_assignees.issue_id" ) .
And ( "issue_assignees.assignee_id = ?" , assigneeID )
}
func applyPosterCondition ( sess * xorm . Session , posterID int64 ) * xorm . Session {
return sess . And ( "issue.poster_id=?" , posterID )
}
func applyMentionedCondition ( sess * xorm . Session , mentionedID int64 ) * xorm . Session {
return sess . Join ( "INNER" , "issue_user" , "issue.id = issue_user.issue_id" ) .
And ( "issue_user.is_mentioned = ?" , true ) .
And ( "issue_user.uid = ?" , mentionedID )
}
func applyReviewRequestedCondition ( sess * xorm . Session , reviewRequestedID int64 ) * xorm . Session {
return sess . Join ( "INNER" , [ ] string { "review" , "r" } , "issue.id = r.issue_id" ) .
2021-01-18 08:13:15 +03:00
And ( "issue.poster_id <> ?" , reviewRequestedID ) .
2021-01-17 19:34:19 +03:00
And ( "r.type = ?" , ReviewTypeRequest ) .
And ( "r.reviewer_id = ? and r.id in (select max(id) from review where issue_id = r.issue_id and reviewer_id = r.reviewer_id and type in (?, ?, ?))" +
" or r.reviewer_team_id in (select team_id from team_user where uid = ?)" ,
reviewRequestedID , ReviewTypeApprove , ReviewTypeReject , ReviewTypeRequest , reviewRequestedID )
}
2017-08-03 08:09:16 +03:00
// CountIssuesByRepo map from repoID to number of issues matching the options
func CountIssuesByRepo ( opts * IssuesOptions ) ( map [ int64 ] int64 , error ) {
2021-11-21 18:41:00 +03:00
e := db . GetEngine ( db . DefaultContext )
2017-08-03 08:09:16 +03:00
2021-11-21 18:41:00 +03:00
sess := e . Join ( "INNER" , "repository" , "`issue`.repo_id = `repository`.id" )
2021-01-27 01:47:42 +03:00
2019-06-12 22:41:28 +03:00
opts . setupSession ( sess )
2017-08-03 08:09:16 +03:00
countsSlice := make ( [ ] * struct {
RepoID int64
Count int64
} , 0 , 10 )
if err := sess . GroupBy ( "issue.repo_id" ) .
Select ( "issue.repo_id AS repo_id, COUNT(*) AS count" ) .
Table ( "issue" ) .
Find ( & countsSlice ) ; err != nil {
return nil , err
}
countMap := make ( map [ int64 ] int64 , len ( countsSlice ) )
for _ , c := range countsSlice {
countMap [ c . RepoID ] = c . Count
}
return countMap , nil
}
2020-02-29 09:52:05 +03:00
// GetRepoIDsForIssuesOptions find all repo ids for the given options
2021-11-24 12:49:20 +03:00
func GetRepoIDsForIssuesOptions ( opts * IssuesOptions , user * user_model . User ) ( [ ] int64 , error ) {
2020-02-29 09:52:05 +03:00
repoIDs := make ( [ ] int64 , 0 , 5 )
2021-11-21 18:41:00 +03:00
e := db . GetEngine ( db . DefaultContext )
2020-02-29 09:52:05 +03:00
2021-11-21 18:41:00 +03:00
sess := e . Join ( "INNER" , "repository" , "`issue`.repo_id = `repository`.id" )
2021-01-27 01:47:42 +03:00
2020-02-29 09:52:05 +03:00
opts . setupSession ( sess )
accessCond := accessibleRepositoryCondition ( user )
if err := sess . Where ( accessCond ) .
Distinct ( "issue.repo_id" ) .
Table ( "issue" ) .
Find ( & repoIDs ) ; err != nil {
return nil , err
}
return repoIDs , nil
}
2017-08-03 08:09:16 +03:00
// Issues returns a list of issues by given conditions.
func Issues ( opts * IssuesOptions ) ( [ ] * Issue , error ) {
2021-11-21 18:41:00 +03:00
e := db . GetEngine ( db . DefaultContext )
2017-08-03 08:09:16 +03:00
2021-11-21 18:41:00 +03:00
sess := e . Join ( "INNER" , "repository" , "`issue`.repo_id = `repository`.id" )
2019-06-12 22:41:28 +03:00
opts . setupSession ( sess )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
sortIssuesSession ( sess , opts . SortType , opts . PriorityRepoID )
2015-08-10 16:47:23 +03:00
2020-09-25 02:30:40 +03:00
issues := make ( [ ] * Issue , 0 , opts . ListOptions . PageSize )
2016-08-26 23:40:53 +03:00
if err := sess . Find ( & issues ) ; err != nil {
return nil , fmt . Errorf ( "Find: %v" , err )
}
2019-06-23 18:22:43 +03:00
sess . Close ( )
2016-08-26 23:40:53 +03:00
2017-02-22 17:03:59 +03:00
if err := IssueList ( issues ) . LoadAttributes ( ) ; err != nil {
return nil , fmt . Errorf ( "LoadAttributes: %v" , err )
2016-08-26 23:40:53 +03:00
}
return issues , nil
2020-09-25 02:30:40 +03:00
}
// CountIssues number return of issues by given conditions.
func CountIssues ( opts * IssuesOptions ) ( int64 , error ) {
2021-11-21 18:41:00 +03:00
e := db . GetEngine ( db . DefaultContext )
2020-09-25 02:30:40 +03:00
countsSlice := make ( [ ] * struct {
RepoID int64
Count int64
} , 0 , 1 )
2021-11-21 18:41:00 +03:00
sess := e . Select ( "COUNT(issue.id) AS count" ) . Table ( "issue" )
2021-01-27 01:47:42 +03:00
sess . Join ( "INNER" , "repository" , "`issue`.repo_id = `repository`.id" )
2020-09-25 02:30:40 +03:00
opts . setupSession ( sess )
if err := sess . Find ( & countsSlice ) ; err != nil {
return 0 , fmt . Errorf ( "Find: %v" , err )
}
if len ( countsSlice ) < 1 {
return 0 , fmt . Errorf ( "there is less than one result sql record" )
}
return countsSlice [ 0 ] . Count , nil
2014-03-22 21:50:50 +04:00
}
2019-11-18 11:08:20 +03:00
// GetParticipantsIDsByIssueID returns the IDs of all users who participated in comments of an issue,
// but skips joining with `user` for performance reasons.
// User permissions must be verified elsewhere if required.
func GetParticipantsIDsByIssueID ( issueID int64 ) ( [ ] int64 , error ) {
userIDs := make ( [ ] int64 , 0 , 5 )
2021-09-23 18:45:36 +03:00
return userIDs , db . GetEngine ( db . DefaultContext ) . Table ( "comment" ) .
2019-11-18 11:08:20 +03:00
Cols ( "poster_id" ) .
Where ( "issue_id = ?" , issueID ) .
And ( "type in (?,?,?)" , CommentTypeComment , CommentTypeCode , CommentTypeReview ) .
Distinct ( "poster_id" ) .
Find ( & userIDs )
}
2020-02-28 11:16:41 +03:00
// IsUserParticipantsOfIssue return true if user is participants of an issue
2021-11-24 12:49:20 +03:00
func IsUserParticipantsOfIssue ( user * user_model . User , issue * Issue ) bool {
2021-09-23 18:45:36 +03:00
userIDs , err := issue . getParticipantIDsByIssue ( db . GetEngine ( db . DefaultContext ) )
2020-02-28 11:16:41 +03:00
if err != nil {
log . Error ( err . Error ( ) )
return false
2017-03-16 04:34:24 +03:00
}
2020-02-28 11:16:41 +03:00
return util . IsInt64InSlice ( user . ID , userIDs )
2017-03-16 04:34:24 +03:00
}
2019-10-10 19:45:11 +03:00
// UpdateIssueMentions updates issue-user relations for mentioned users.
2021-11-24 12:49:20 +03:00
func UpdateIssueMentions ( ctx context . Context , issueID int64 , mentions [ ] * user_model . User ) error {
2016-07-15 19:36:39 +03:00
if len ( mentions ) == 0 {
return nil
2015-12-21 15:24:11 +03:00
}
2019-10-10 19:45:11 +03:00
ids := make ( [ ] int64 , len ( mentions ) )
for i , u := range mentions {
ids [ i ] = u . ID
2015-12-21 15:24:11 +03:00
}
2019-09-24 08:02:49 +03:00
if err := UpdateIssueUsersByMentions ( ctx , issueID , ids ) ; err != nil {
2016-07-15 19:36:39 +03:00
return fmt . Errorf ( "UpdateIssueUsersByMentions: %v" , err )
2015-12-21 15:24:11 +03:00
}
return nil
}
2014-05-07 20:09:30 +04:00
// IssueStats represents issue statistic information.
type IssueStats struct {
OpenCount , ClosedCount int64
2017-02-14 17:15:18 +03:00
YourRepositoriesCount int64
2014-05-07 20:09:30 +04:00
AssignCount int64
CreateCount int64
MentionCount int64
2021-01-17 19:34:19 +03:00
ReviewRequestedCount int64
2014-05-07 20:09:30 +04:00
}
// Filter modes.
const (
2016-11-07 19:24:59 +03:00
FilterModeAll = iota
FilterModeAssign
FilterModeCreate
FilterModeMention
2021-01-17 19:34:19 +03:00
FilterModeReviewRequested
2014-05-07 20:09:30 +04:00
)
2015-08-10 16:47:23 +03:00
func parseCountResult ( results [ ] map [ string ] [ ] byte ) int64 {
if len ( results ) == 0 {
return 0
}
for _ , result := range results [ 0 ] {
2020-12-25 12:59:32 +03:00
c , _ := strconv . ParseInt ( string ( result ) , 10 , 64 )
return c
2015-08-10 16:47:23 +03:00
}
return 0
}
2016-11-24 11:41:11 +03:00
// IssueStatsOptions contains parameters accepted by GetIssueStats.
2015-09-02 23:18:09 +03:00
type IssueStatsOptions struct {
2021-01-17 19:34:19 +03:00
RepoID int64
Labels string
MilestoneID int64
AssigneeID int64
MentionedID int64
PosterID int64
ReviewRequestedID int64
IsPull util . OptionalBool
IssueIDs [ ] int64
2015-09-02 23:18:09 +03:00
}
2021-09-19 14:49:59 +03:00
const (
// When queries are broken down in parts because of the number
// of parameters, attempt to break by this amount
maxQueryParameters = 300
)
2014-05-08 00:51:14 +04:00
// GetIssueStats returns issue statistic information by given conditions.
2017-01-25 05:43:02 +03:00
func GetIssueStats ( opts * IssueStatsOptions ) ( * IssueStats , error ) {
2020-02-15 13:51:25 +03:00
if len ( opts . IssueIDs ) <= maxQueryParameters {
return getIssueStatsChunk ( opts , opts . IssueIDs )
}
// If too long a list of IDs is provided, we get the statistics in
// smaller chunks and get accumulates. Note: this could potentially
// get us invalid results. The alternative is to insert the list of
// ids in a temporary table and join from them.
accum := & IssueStats { }
for i := 0 ; i < len ( opts . IssueIDs ) ; {
chunk := i + maxQueryParameters
if chunk > len ( opts . IssueIDs ) {
chunk = len ( opts . IssueIDs )
}
stats , err := getIssueStatsChunk ( opts , opts . IssueIDs [ i : chunk ] )
if err != nil {
return nil , err
}
accum . OpenCount += stats . OpenCount
accum . ClosedCount += stats . ClosedCount
accum . YourRepositoriesCount += stats . YourRepositoriesCount
accum . AssignCount += stats . AssignCount
accum . CreateCount += stats . CreateCount
accum . OpenCount += stats . MentionCount
2021-01-17 19:34:19 +03:00
accum . ReviewRequestedCount += stats . ReviewRequestedCount
2020-02-15 13:51:25 +03:00
i = chunk
}
return accum , nil
}
func getIssueStatsChunk ( opts * IssueStatsOptions , issueIDs [ ] int64 ) ( * IssueStats , error ) {
2014-05-07 20:09:30 +04:00
stats := & IssueStats { }
2015-07-24 21:52:25 +03:00
2021-11-09 00:14:46 +03:00
countSession := func ( opts * IssueStatsOptions , issueIDs [ ] int64 ) * xorm . Session {
2021-09-23 18:45:36 +03:00
sess := db . GetEngine ( db . DefaultContext ) .
2018-11-29 04:46:30 +03:00
Where ( "issue.repo_id = ?" , opts . RepoID )
2015-08-10 16:47:23 +03:00
2021-11-09 00:14:46 +03:00
if len ( issueIDs ) > 0 {
sess . In ( "issue.id" , issueIDs )
2017-01-25 05:43:02 +03:00
}
2016-05-06 22:40:41 +03:00
if len ( opts . Labels ) > 0 && opts . Labels != "0" {
2016-12-22 11:58:04 +03:00
labelIDs , err := base . StringsToInt64s ( strings . Split ( opts . Labels , "," ) )
if err != nil {
log . Warn ( "Malformed Labels argument: %s" , opts . Labels )
2019-01-23 07:10:38 +03:00
} else {
for i , labelID := range labelIDs {
2019-11-05 09:48:51 +03:00
if labelID > 0 {
sess . Join ( "INNER" , fmt . Sprintf ( "issue_label il%d" , i ) ,
fmt . Sprintf ( "issue.id = il%[1]d.issue_id AND il%[1]d.label_id = %[2]d" , i , labelID ) )
} else {
sess . Where ( "issue.id NOT IN (SELECT issue_id FROM issue_label WHERE label_id = ?)" , - labelID )
}
2019-01-23 07:10:38 +03:00
}
2016-04-26 07:22:03 +03:00
}
2016-04-26 07:07:49 +03:00
}
if opts . MilestoneID > 0 {
sess . And ( "issue.milestone_id = ?" , opts . MilestoneID )
}
if opts . AssigneeID > 0 {
2021-01-17 19:34:19 +03:00
applyAssigneeCondition ( sess , opts . AssigneeID )
2016-04-26 07:07:49 +03:00
}
2016-12-24 13:33:21 +03:00
if opts . PosterID > 0 {
2021-01-17 19:34:19 +03:00
applyPosterCondition ( sess , opts . PosterID )
2016-12-24 13:33:21 +03:00
}
2015-07-24 21:52:25 +03:00
2016-12-24 13:33:21 +03:00
if opts . MentionedID > 0 {
2021-01-17 19:34:19 +03:00
applyMentionedCondition ( sess , opts . MentionedID )
}
if opts . ReviewRequestedID > 0 {
applyReviewRequestedCondition ( sess , opts . ReviewRequestedID )
2016-12-24 13:33:21 +03:00
}
2016-04-26 07:07:49 +03:00
2018-11-29 04:46:30 +03:00
switch opts . IsPull {
case util . OptionalBoolTrue :
sess . And ( "issue.is_pull=?" , true )
case util . OptionalBoolFalse :
sess . And ( "issue.is_pull=?" , false )
}
2016-12-24 13:33:21 +03:00
return sess
2015-07-24 21:52:25 +03:00
}
2016-12-24 13:33:21 +03:00
2017-01-25 05:43:02 +03:00
var err error
2021-11-09 00:14:46 +03:00
stats . OpenCount , err = countSession ( opts , issueIDs ) .
2017-06-15 06:09:03 +03:00
And ( "issue.is_closed = ?" , false ) .
Count ( new ( Issue ) )
if err != nil {
return stats , err
2017-01-25 05:43:02 +03:00
}
2021-11-09 00:14:46 +03:00
stats . ClosedCount , err = countSession ( opts , issueIDs ) .
2017-06-15 06:09:03 +03:00
And ( "issue.is_closed = ?" , true ) .
Count ( new ( Issue ) )
2017-02-14 17:15:18 +03:00
return stats , err
2014-05-07 20:09:30 +04:00
}
2017-12-26 02:25:16 +03:00
// UserIssueStatsOptions contains parameters accepted by GetUserIssueStats.
type UserIssueStatsOptions struct {
2021-12-29 16:02:12 +03:00
UserID int64
RepoIDs [ ] int64
FilterMode int
IsPull bool
IsClosed bool
IssueIDs [ ] int64
IsArchived util . OptionalBool
LabelIDs [ ] int64
Org * Organization
Team * Team
2017-12-26 02:25:16 +03:00
}
2014-05-08 00:51:14 +04:00
// GetUserIssueStats returns issue statistic information for dashboard by given conditions.
2017-12-26 02:25:16 +03:00
func GetUserIssueStats ( opts UserIssueStatsOptions ) ( * IssueStats , error ) {
var err error
2014-05-07 20:09:30 +04:00
stats := & IssueStats { }
2015-08-25 17:58:34 +03:00
2017-12-26 02:25:16 +03:00
cond := builder . NewCond ( )
cond = cond . And ( builder . Eq { "issue.is_pull" : opts . IsPull } )
2019-12-02 06:50:36 +03:00
if len ( opts . RepoIDs ) > 0 {
cond = cond . And ( builder . In ( "issue.repo_id" , opts . RepoIDs ) )
2015-09-02 23:18:09 +03:00
}
2020-02-29 09:52:05 +03:00
if len ( opts . IssueIDs ) > 0 {
cond = cond . And ( builder . In ( "issue.id" , opts . IssueIDs ) )
}
2015-09-02 23:18:09 +03:00
2021-12-29 16:02:12 +03:00
if opts . UserID > 0 {
cond = cond . And ( issuePullAccessibleRepoCond ( "issue.repo_id" , opts . UserID , opts . Org , opts . Team , opts . IsPull ) )
}
2021-01-01 20:49:42 +03:00
sess := func ( cond builder . Cond ) * xorm . Session {
2021-09-23 18:45:36 +03:00
s := db . GetEngine ( db . DefaultContext ) . Where ( cond )
2021-01-01 20:49:42 +03:00
if len ( opts . LabelIDs ) > 0 {
s . Join ( "INNER" , "issue_label" , "issue_label.issue_id = issue.id" ) .
In ( "issue_label.label_id" , opts . LabelIDs )
}
2021-12-29 16:02:12 +03:00
if opts . UserID > 0 || opts . IsArchived != util . OptionalBoolNone {
s . Join ( "INNER" , "repository" , "issue.repo_id = repository.id" )
if opts . IsArchived != util . OptionalBoolNone {
s . And ( builder . Eq { "repository.is_archived" : opts . IsArchived . IsTrue ( ) } )
}
2021-01-13 07:19:17 +03:00
}
2021-01-01 20:49:42 +03:00
return s
}
2017-12-26 02:25:16 +03:00
switch opts . FilterMode {
2017-02-14 17:15:18 +03:00
case FilterModeAll :
2021-12-29 16:02:12 +03:00
stats . OpenCount , err = sess ( cond ) .
2021-01-17 19:34:19 +03:00
And ( "issue.is_closed = ?" , false ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2021-12-29 16:02:12 +03:00
stats . ClosedCount , err = sess ( cond ) .
2021-01-17 19:34:19 +03:00
And ( "issue.is_closed = ?" , true ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2016-11-07 19:24:59 +03:00
case FilterModeAssign :
2021-01-17 19:34:19 +03:00
stats . OpenCount , err = applyAssigneeCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , false ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2021-01-17 19:34:19 +03:00
stats . ClosedCount , err = applyAssigneeCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , true ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2016-11-07 19:24:59 +03:00
case FilterModeCreate :
2021-01-17 19:34:19 +03:00
stats . OpenCount , err = applyPosterCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , false ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2021-01-17 19:34:19 +03:00
stats . ClosedCount , err = applyPosterCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , true ) .
2017-02-14 17:15:18 +03:00
Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2019-09-18 10:24:44 +03:00
case FilterModeMention :
2021-01-17 19:34:19 +03:00
stats . OpenCount , err = applyMentionedCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , false ) .
2019-09-18 10:24:44 +03:00
Count ( new ( Issue ) )
if err != nil {
return nil , err
}
2021-01-17 19:34:19 +03:00
stats . ClosedCount , err = applyMentionedCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , true ) .
Count ( new ( Issue ) )
if err != nil {
return nil , err
}
case FilterModeReviewRequested :
stats . OpenCount , err = applyReviewRequestedCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , false ) .
Count ( new ( Issue ) )
if err != nil {
return nil , err
}
stats . ClosedCount , err = applyReviewRequestedCondition ( sess ( cond ) , opts . UserID ) .
And ( "issue.is_closed = ?" , true ) .
2019-09-18 10:24:44 +03:00
Count ( new ( Issue ) )
if err != nil {
return nil , err
}
2017-12-26 02:25:16 +03:00
}
cond = cond . And ( builder . Eq { "issue.is_closed" : opts . IsClosed } )
2021-01-17 19:34:19 +03:00
stats . AssignCount , err = applyAssigneeCondition ( sess ( cond ) , opts . UserID ) . Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2021-01-17 19:34:19 +03:00
stats . CreateCount , err = applyPosterCondition ( sess ( cond ) , opts . UserID ) . Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
}
2021-01-17 19:34:19 +03:00
stats . MentionCount , err = applyMentionedCondition ( sess ( cond ) , opts . UserID ) . Count ( new ( Issue ) )
2019-09-18 10:24:44 +03:00
if err != nil {
return nil , err
}
2021-12-29 16:02:12 +03:00
stats . YourRepositoriesCount , err = sess ( cond ) . Count ( new ( Issue ) )
2021-01-17 19:34:19 +03:00
if err != nil {
return nil , err
}
stats . ReviewRequestedCount , err = applyReviewRequestedCondition ( sess ( cond ) , opts . UserID ) . Count ( new ( Issue ) )
2017-12-26 02:25:16 +03:00
if err != nil {
return nil , err
2015-08-25 17:58:34 +03:00
}
2017-12-26 02:25:16 +03:00
return stats , nil
2014-05-07 20:09:30 +04:00
}
2015-08-25 17:58:34 +03:00
// GetRepoIssueStats returns number of open and closed repository issues by given filter mode.
2021-03-14 21:52:12 +03:00
func GetRepoIssueStats ( repoID , uid int64 , filterMode int , isPull bool ) ( numOpen , numClosed int64 ) {
2016-04-26 07:07:49 +03:00
countSession := func ( isClosed , isPull bool , repoID int64 ) * xorm . Session {
2021-09-23 18:45:36 +03:00
sess := db . GetEngine ( db . DefaultContext ) .
2017-02-09 12:59:57 +03:00
Where ( "is_closed = ?" , isClosed ) .
2016-04-26 07:22:03 +03:00
And ( "is_pull = ?" , isPull ) .
And ( "repo_id = ?" , repoID )
2015-09-02 23:18:09 +03:00
2016-04-26 07:07:49 +03:00
return sess
2015-09-02 23:18:09 +03:00
}
2016-04-26 07:07:49 +03:00
openCountSession := countSession ( false , isPull , repoID )
closedCountSession := countSession ( true , isPull , repoID )
2015-08-25 17:58:34 +03:00
switch filterMode {
2016-11-07 19:24:59 +03:00
case FilterModeAssign :
2021-01-17 19:34:19 +03:00
applyAssigneeCondition ( openCountSession , uid )
applyAssigneeCondition ( closedCountSession , uid )
2016-11-07 19:24:59 +03:00
case FilterModeCreate :
2021-01-17 19:34:19 +03:00
applyPosterCondition ( openCountSession , uid )
applyPosterCondition ( closedCountSession , uid )
2015-08-25 17:58:34 +03:00
}
2017-02-14 17:15:18 +03:00
openResult , _ := openCountSession . Count ( new ( Issue ) )
closedResult , _ := closedCountSession . Count ( new ( Issue ) )
2016-04-26 07:07:49 +03:00
return openResult , closedResult
2015-08-25 17:58:34 +03:00
}
2019-02-21 08:01:28 +03:00
// SearchIssueIDsByKeyword search issues on database
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
func SearchIssueIDsByKeyword ( kw string , repoIDs [ ] int64 , limit , start int ) ( int64 , [ ] int64 , error ) {
2021-03-14 21:52:12 +03:00
repoCond := builder . In ( "repo_id" , repoIDs )
subQuery := builder . Select ( "id" ) . From ( "issue" ) . Where ( repoCond )
2021-03-02 16:07:01 +03:00
kw = strings . ToUpper ( kw )
2021-03-14 21:52:12 +03:00
cond := builder . And (
2019-02-21 08:01:28 +03:00
repoCond ,
builder . Or (
2021-03-02 16:07:01 +03:00
builder . Like { "UPPER(name)" , kw } ,
builder . Like { "UPPER(content)" , kw } ,
2019-02-21 08:01:28 +03:00
builder . In ( "id" , builder . Select ( "issue_id" ) .
From ( "comment" ) .
Where ( builder . And (
builder . Eq { "type" : CommentTypeComment } ,
builder . In ( "issue_id" , subQuery ) ,
2021-03-02 16:07:01 +03:00
builder . Like { "UPPER(content)" , kw } ,
2019-02-21 08:01:28 +03:00
) ) ,
) ,
) ,
)
2021-03-14 21:52:12 +03:00
ids := make ( [ ] int64 , 0 , limit )
res := make ( [ ] struct {
2021-03-06 18:11:12 +03:00
ID int64
UpdatedUnix int64
} , 0 , limit )
2021-09-23 18:45:36 +03:00
err := db . GetEngine ( db . DefaultContext ) . Distinct ( "id" , "updated_unix" ) . Table ( "issue" ) . Where ( cond ) .
2021-03-06 18:11:12 +03:00
OrderBy ( "`updated_unix` DESC" ) . Limit ( limit , start ) .
Find ( & res )
2019-02-21 08:01:28 +03:00
if err != nil {
return 0 , nil , err
}
2021-03-06 18:11:12 +03:00
for _ , r := range res {
ids = append ( ids , r . ID )
}
2019-02-21 08:01:28 +03:00
2021-09-23 18:45:36 +03:00
total , err := db . GetEngine ( db . DefaultContext ) . Distinct ( "id" ) . Table ( "issue" ) . Where ( cond ) . Count ( )
2019-02-21 08:01:28 +03:00
if err != nil {
return 0 , nil , err
}
return total , ids , nil
}
2020-01-02 01:51:10 +03:00
// UpdateIssueByAPI updates all allowed fields of given issue.
2020-05-17 00:05:19 +03:00
// If the issue status is changed a statusChangeComment is returned
// similarly if the title is changed the titleChanged bool is set to true
2021-11-24 12:49:20 +03:00
func UpdateIssueByAPI ( issue * Issue , doer * user_model . User ) ( statusChangeComment * Comment , titleChanged bool , err error ) {
2021-11-19 16:39:57 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2020-05-17 00:05:19 +03:00
return nil , false , err
}
2021-11-19 16:39:57 +03:00
defer committer . Close ( )
sess := db . GetEngine ( ctx )
2020-05-17 00:05:19 +03:00
2021-12-10 04:27:50 +03:00
if err := issue . loadRepo ( ctx ) ; err != nil {
2020-05-17 00:05:19 +03:00
return nil , false , fmt . Errorf ( "loadRepo: %v" , err )
}
// Reload the issue
currentIssue , err := getIssueByID ( sess , issue . ID )
if err != nil {
return nil , false , err
2019-09-20 08:45:38 +03:00
}
2020-01-02 01:51:10 +03:00
if _ , err := sess . ID ( issue . ID ) . Cols (
2020-05-17 00:05:19 +03:00
"name" , "content" , "milestone_id" , "priority" ,
"deadline_unix" , "updated_unix" , "is_locked" ) .
2020-01-02 01:51:10 +03:00
Update ( issue ) ; err != nil {
2020-05-17 00:05:19 +03:00
return nil , false , err
2019-09-20 08:45:38 +03:00
}
2020-01-02 10:54:22 +03:00
2020-05-17 00:05:19 +03:00
titleChanged = currentIssue . Title != issue . Title
if titleChanged {
2021-03-14 21:52:12 +03:00
opts := & CreateCommentOptions {
2020-05-17 00:05:19 +03:00
Type : CommentTypeChangeTitle ,
Doer : doer ,
Repo : issue . Repo ,
Issue : issue ,
OldTitle : currentIssue . Title ,
NewTitle : issue . Title ,
}
2021-11-19 16:39:57 +03:00
_ , err := createComment ( ctx , opts )
2020-05-17 00:05:19 +03:00
if err != nil {
return nil , false , fmt . Errorf ( "createComment: %v" , err )
}
2020-01-02 10:54:22 +03:00
}
2020-05-17 00:05:19 +03:00
if currentIssue . IsClosed != issue . IsClosed {
2021-11-19 16:39:57 +03:00
statusChangeComment , err = issue . doChangeStatus ( ctx , doer , false )
2020-05-17 00:05:19 +03:00
if err != nil {
return nil , false , err
}
2019-09-20 08:45:38 +03:00
}
2020-05-17 00:05:19 +03:00
2021-11-19 16:39:57 +03:00
if err := issue . addCrossReferences ( ctx , doer , true ) ; err != nil {
2020-05-17 00:05:19 +03:00
return nil , false , err
}
2021-11-19 16:39:57 +03:00
return statusChangeComment , titleChanged , committer . Commit ( )
2015-10-24 10:36:47 +03:00
}
2018-05-01 22:05:28 +03:00
// UpdateIssueDeadline updates an issue deadline and adds comments. Setting a deadline to 0 means deleting it.
2021-11-24 12:49:20 +03:00
func UpdateIssueDeadline ( issue * Issue , deadlineUnix timeutil . TimeStamp , doer * user_model . User ) ( err error ) {
2018-05-01 22:05:28 +03:00
// if the deadline hasn't changed do nothing
if issue . DeadlineUnix == deadlineUnix {
return nil
}
2021-11-19 16:39:57 +03:00
ctx , committer , err := db . TxContext ( )
if err != nil {
2018-05-01 22:05:28 +03:00
return err
}
2021-11-19 16:39:57 +03:00
defer committer . Close ( )
sess := db . GetEngine ( ctx )
2018-05-01 22:05:28 +03:00
// Update the deadline
if err = updateIssueCols ( sess , & Issue { ID : issue . ID , DeadlineUnix : deadlineUnix } , "deadline_unix" ) ; err != nil {
return err
}
// Make the comment
2021-11-19 16:39:57 +03:00
if _ , err = createDeadlineComment ( ctx , doer , issue , deadlineUnix ) ; err != nil {
2018-05-01 22:05:28 +03:00
return fmt . Errorf ( "createRemovedDueDateComment: %v" , err )
}
2021-11-19 16:39:57 +03:00
return committer . Commit ( )
2018-05-01 22:05:28 +03:00
}
2018-07-18 00:23:58 +03:00
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
// DependencyInfo represents high level information about an issue which is a dependency of another issue.
type DependencyInfo struct {
2021-12-10 04:27:50 +03:00
Issue ` xorm:"extends" `
repo_model . Repository ` xorm:"extends" `
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
}
2020-02-28 11:16:41 +03:00
// getParticipantIDsByIssue returns all userIDs who are participated in comments of an issue and issue author
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) getParticipantIDsByIssue ( e db . Engine ) ( [ ] int64 , error ) {
2020-02-28 11:16:41 +03:00
if issue == nil {
return nil , nil
}
userIDs := make ( [ ] int64 , 0 , 5 )
if err := e . Table ( "comment" ) . Cols ( "poster_id" ) .
Where ( "`comment`.issue_id = ?" , issue . ID ) .
And ( "`comment`.type in (?,?,?)" , CommentTypeComment , CommentTypeCode , CommentTypeReview ) .
And ( "`user`.is_active = ?" , true ) .
And ( "`user`.prohibit_login = ?" , false ) .
Join ( "INNER" , "`user`" , "`user`.id = `comment`.poster_id" ) .
Distinct ( "poster_id" ) .
Find ( & userIDs ) ; err != nil {
return nil , fmt . Errorf ( "get poster IDs: %v" , err )
}
if ! util . IsInt64InSlice ( issue . PosterID , userIDs ) {
return append ( userIDs , issue . PosterID ) , nil
}
return userIDs , nil
}
2018-07-18 00:23:58 +03:00
// Get Blocked By Dependencies, aka all issues this issue is blocked by.
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) getBlockedByDependencies ( e db . Engine ) ( issueDeps [ ] * DependencyInfo , err error ) {
2021-11-18 11:18:12 +03:00
err = e .
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
Table ( "issue" ) .
Join ( "INNER" , "repository" , "repository.id = issue.repo_id" ) .
Join ( "INNER" , "issue_dependency" , "issue_dependency.dependency_id = issue.id" ) .
2018-07-18 00:23:58 +03:00
Where ( "issue_id = ?" , issue . ID ) .
2021-03-14 21:52:12 +03:00
// sort by repo id then created date, with the issues of the same repo at the beginning of the list
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
OrderBy ( "CASE WHEN issue.repo_id = " + strconv . FormatInt ( issue . RepoID , 10 ) + " THEN 0 ELSE issue.repo_id END, issue.created_unix DESC" ) .
2018-07-18 00:23:58 +03:00
Find ( & issueDeps )
2021-11-18 11:18:12 +03:00
for _ , depInfo := range issueDeps {
depInfo . Issue . Repo = & depInfo . Repository
}
return issueDeps , err
2018-07-18 00:23:58 +03:00
}
// Get Blocking Dependencies, aka all issues this issue blocks.
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) getBlockingDependencies ( e db . Engine ) ( issueDeps [ ] * DependencyInfo , err error ) {
2021-11-18 11:18:12 +03:00
err = e .
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
Table ( "issue" ) .
Join ( "INNER" , "repository" , "repository.id = issue.repo_id" ) .
Join ( "INNER" , "issue_dependency" , "issue_dependency.issue_id = issue.id" ) .
2018-07-18 00:23:58 +03:00
Where ( "dependency_id = ?" , issue . ID ) .
2021-03-14 21:52:12 +03:00
// sort by repo id then created date, with the issues of the same repo at the beginning of the list
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
OrderBy ( "CASE WHEN issue.repo_id = " + strconv . FormatInt ( issue . RepoID , 10 ) + " THEN 0 ELSE issue.repo_id END, issue.created_unix DESC" ) .
2018-07-18 00:23:58 +03:00
Find ( & issueDeps )
2021-11-18 11:18:12 +03:00
for _ , depInfo := range issueDeps {
depInfo . Issue . Repo = & depInfo . Repository
}
return issueDeps , err
2018-07-18 00:23:58 +03:00
}
// BlockedByDependencies finds all Dependencies an issue is blocked by
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
func ( issue * Issue ) BlockedByDependencies ( ) ( [ ] * DependencyInfo , error ) {
2021-09-23 18:45:36 +03:00
return issue . getBlockedByDependencies ( db . GetEngine ( db . DefaultContext ) )
2018-07-18 00:23:58 +03:00
}
// BlockingDependencies returns all blocking dependencies, aka all other issues a given issue blocks
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
func ( issue * Issue ) BlockingDependencies ( ) ( [ ] * DependencyInfo , error ) {
2021-09-23 18:45:36 +03:00
return issue . getBlockingDependencies ( db . GetEngine ( db . DefaultContext ) )
2018-07-18 00:23:58 +03:00
}
2019-07-19 00:51:33 +03:00
2021-09-19 14:49:59 +03:00
func ( issue * Issue ) updateClosedNum ( e db . Engine ) ( err error ) {
2019-07-19 00:51:33 +03:00
if issue . IsPull {
_ , err = e . Exec ( "UPDATE `repository` SET num_closed_pulls=(SELECT count(*) FROM issue WHERE repo_id=? AND is_pull=? AND is_closed=?) WHERE id=?" ,
issue . RepoID ,
true ,
true ,
issue . RepoID ,
)
} else {
_ , err = e . Exec ( "UPDATE `repository` SET num_closed_issues=(SELECT count(*) FROM issue WHERE repo_id=? AND is_pull=? AND is_closed=?) WHERE id=?" ,
issue . RepoID ,
false ,
true ,
issue . RepoID ,
)
}
return
}
2019-10-10 19:45:11 +03:00
2021-01-02 20:04:02 +03:00
// FindAndUpdateIssueMentions finds users mentioned in the given content string, and saves them in the database.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) FindAndUpdateIssueMentions ( ctx context . Context , doer * user_model . User , content string ) ( mentions [ ] * user_model . User , err error ) {
2021-01-02 20:04:02 +03:00
rawMentions := references . FindAllMentionsMarkdown ( content )
mentions , err = issue . ResolveMentionsByVisibility ( ctx , doer , rawMentions )
if err != nil {
return nil , fmt . Errorf ( "UpdateIssueMentions [%d]: %v" , issue . ID , err )
}
if err = UpdateIssueMentions ( ctx , issue . ID , mentions ) ; err != nil {
return nil , fmt . Errorf ( "UpdateIssueMentions [%d]: %v" , issue . ID , err )
}
return
}
2019-10-10 19:45:11 +03:00
// ResolveMentionsByVisibility returns the users mentioned in an issue, removing those that
// don't have access to reading it. Teams are expanded into their users, but organizations are ignored.
2021-11-24 12:49:20 +03:00
func ( issue * Issue ) ResolveMentionsByVisibility ( ctx context . Context , doer * user_model . User , mentions [ ] string ) ( users [ ] * user_model . User , err error ) {
2019-10-10 19:45:11 +03:00
if len ( mentions ) == 0 {
return
}
2021-12-10 04:27:50 +03:00
if err = issue . loadRepo ( ctx ) ; err != nil {
2019-10-10 19:45:11 +03:00
return
}
2020-12-21 18:39:28 +03:00
resolved := make ( map [ string ] bool , 10 )
var mentionTeams [ ] string
2021-12-10 04:27:50 +03:00
if err := issue . Repo . GetOwner ( ctx ) ; err != nil {
2020-12-21 18:39:28 +03:00
return nil , err
}
repoOwnerIsOrg := issue . Repo . Owner . IsOrganization ( )
if repoOwnerIsOrg {
mentionTeams = make ( [ ] string , 0 , 5 )
}
2019-10-10 19:45:11 +03:00
resolved [ doer . LowerName ] = true
for _ , name := range mentions {
name := strings . ToLower ( name )
if _ , ok := resolved [ name ] ; ok {
continue
}
2020-12-21 18:39:28 +03:00
if repoOwnerIsOrg && strings . Contains ( name , "/" ) {
names := strings . Split ( name , "/" )
if len ( names ) < 2 || names [ 0 ] != issue . Repo . Owner . LowerName {
continue
}
mentionTeams = append ( mentionTeams , names [ 1 ] )
resolved [ name ] = true
} else {
resolved [ name ] = false
}
2019-10-10 19:45:11 +03:00
}
2020-12-21 18:39:28 +03:00
if issue . Repo . Owner . IsOrganization ( ) && len ( mentionTeams ) > 0 {
teams := make ( [ ] * Team , 0 , len ( mentionTeams ) )
2021-09-23 18:45:36 +03:00
if err := db . GetEngine ( ctx ) .
2019-10-10 19:45:11 +03:00
Join ( "INNER" , "team_repo" , "team_repo.team_id = team.id" ) .
Where ( "team_repo.repo_id=?" , issue . Repo . ID ) .
2020-12-21 18:39:28 +03:00
In ( "team.lower_name" , mentionTeams ) .
2019-10-10 19:45:11 +03:00
Find ( & teams ) ; err != nil {
return nil , fmt . Errorf ( "find mentioned teams: %v" , err )
}
if len ( teams ) != 0 {
checked := make ( [ ] int64 , 0 , len ( teams ) )
2021-11-09 22:57:58 +03:00
unittype := unit . TypeIssues
2019-10-10 19:45:11 +03:00
if issue . IsPull {
2021-11-09 22:57:58 +03:00
unittype = unit . TypePullRequests
2019-10-10 19:45:11 +03:00
}
for _ , team := range teams {
2022-01-05 06:37:00 +03:00
if team . AccessMode >= perm . AccessModeAdmin {
2019-10-10 19:45:11 +03:00
checked = append ( checked , team . ID )
2020-12-21 18:39:28 +03:00
resolved [ issue . Repo . Owner . LowerName + "/" + team . LowerName ] = true
2019-10-10 19:45:11 +03:00
continue
}
2021-09-23 18:45:36 +03:00
has , err := db . GetEngine ( ctx ) . Get ( & TeamUnit { OrgID : issue . Repo . Owner . ID , TeamID : team . ID , Type : unittype } )
2019-10-10 19:45:11 +03:00
if err != nil {
return nil , fmt . Errorf ( "get team units (%d): %v" , team . ID , err )
}
if has {
checked = append ( checked , team . ID )
2020-12-21 18:39:28 +03:00
resolved [ issue . Repo . Owner . LowerName + "/" + team . LowerName ] = true
2019-10-10 19:45:11 +03:00
}
}
if len ( checked ) != 0 {
2021-11-24 12:49:20 +03:00
teamusers := make ( [ ] * user_model . User , 0 , 20 )
2021-09-23 18:45:36 +03:00
if err := db . GetEngine ( ctx ) .
2019-10-10 19:45:11 +03:00
Join ( "INNER" , "team_user" , "team_user.uid = `user`.id" ) .
In ( "`team_user`.team_id" , checked ) .
And ( "`user`.is_active = ?" , true ) .
And ( "`user`.prohibit_login = ?" , false ) .
Find ( & teamusers ) ; err != nil {
return nil , fmt . Errorf ( "get teams users: %v" , err )
}
if len ( teamusers ) > 0 {
2021-11-24 12:49:20 +03:00
users = make ( [ ] * user_model . User , 0 , len ( teamusers ) )
2019-10-10 19:45:11 +03:00
for _ , user := range teamusers {
if already , ok := resolved [ user . LowerName ] ; ! ok || ! already {
users = append ( users , user )
resolved [ user . LowerName ] = true
}
}
}
}
}
2020-12-21 18:39:28 +03:00
}
2019-10-10 19:45:11 +03:00
2020-12-21 18:39:28 +03:00
// Remove names already in the list to avoid querying the database if pending names remain
mentionUsers := make ( [ ] string , 0 , len ( resolved ) )
for name , already := range resolved {
if ! already {
mentionUsers = append ( mentionUsers , name )
2019-10-10 19:45:11 +03:00
}
}
2020-12-21 18:39:28 +03:00
if len ( mentionUsers ) == 0 {
return
}
if users == nil {
2021-11-24 12:49:20 +03:00
users = make ( [ ] * user_model . User , 0 , len ( mentionUsers ) )
2020-12-21 18:39:28 +03:00
}
2019-10-10 19:45:11 +03:00
2021-11-24 12:49:20 +03:00
unchecked := make ( [ ] * user_model . User , 0 , len ( mentionUsers ) )
2021-09-23 18:45:36 +03:00
if err := db . GetEngine ( ctx ) .
2019-10-10 19:45:11 +03:00
Where ( "`user`.is_active = ?" , true ) .
And ( "`user`.prohibit_login = ?" , false ) .
2020-12-21 18:39:28 +03:00
In ( "`user`.lower_name" , mentionUsers ) .
2019-10-10 19:45:11 +03:00
Find ( & unchecked ) ; err != nil {
return nil , fmt . Errorf ( "find mentioned users: %v" , err )
}
for _ , user := range unchecked {
if already := resolved [ user . LowerName ] ; already || user . IsOrganization ( ) {
continue
}
// Normal users must have read access to the referencing issue
2021-12-10 04:27:50 +03:00
perm , err := getUserRepoPermission ( ctx , issue . Repo , user )
2019-10-10 19:45:11 +03:00
if err != nil {
return nil , fmt . Errorf ( "getUserRepoPermission [%d]: %v" , user . ID , err )
}
if ! perm . CanReadIssuesOrPulls ( issue . IsPull ) {
continue
}
users = append ( users , user )
}
return
}
2019-10-14 09:10:42 +03:00
// UpdateIssuesMigrationsByType updates all migrated repositories' issues from gitServiceType to replace originalAuthorID to posterID
2021-11-08 10:04:13 +03:00
func UpdateIssuesMigrationsByType ( gitServiceType api . GitServiceType , originalAuthorID string , posterID int64 ) error {
2021-09-23 18:45:36 +03:00
_ , err := db . GetEngine ( db . DefaultContext ) . Table ( "issue" ) .
2019-10-14 09:10:42 +03:00
Where ( "repo_id IN (SELECT id FROM repository WHERE original_service_type = ?)" , gitServiceType ) .
And ( "original_author_id = ?" , originalAuthorID ) .
Update ( map [ string ] interface { } {
"poster_id" : posterID ,
"original_author" : "" ,
"original_author_id" : 0 ,
} )
return err
}
2020-01-15 14:14:07 +03:00
// UpdateReactionsMigrationsByType updates all migrated repositories' reactions from gitServiceType to replace originalAuthorID to posterID
2021-11-08 10:04:13 +03:00
func UpdateReactionsMigrationsByType ( gitServiceType api . GitServiceType , originalAuthorID string , userID int64 ) error {
2021-09-23 18:45:36 +03:00
_ , err := db . GetEngine ( db . DefaultContext ) . Table ( "reaction" ) .
2020-02-18 03:42:13 +03:00
Where ( "original_author_id = ?" , originalAuthorID ) .
And ( migratedIssueCond ( gitServiceType ) ) .
2020-01-15 14:14:07 +03:00
Update ( map [ string ] interface { } {
"user_id" : userID ,
"original_author" : "" ,
"original_author_id" : 0 ,
} )
return err
}
2020-05-29 16:24:15 +03:00
2021-09-19 14:49:59 +03:00
func deleteIssuesByRepoID ( sess db . Engine , repoID int64 ) ( attachmentPaths [ ] string , err error ) {
2020-05-29 16:24:15 +03:00
deleteCond := builder . Select ( "id" ) . From ( "issue" ) . Where ( builder . Eq { "issue.repo_id" : repoID } )
2021-10-11 01:40:03 +03:00
// Delete content histories
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & issues . ContentHistory { } ) ; err != nil {
return
}
2020-05-29 16:24:15 +03:00
// Delete comments and attachments
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & Comment { } ) ; err != nil {
return
}
// Dependencies for issues in this repository
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & IssueDependency { } ) ; err != nil {
return
}
// Delete dependencies for issues in other repositories
if _ , err = sess . In ( "dependency_id" , deleteCond ) .
Delete ( & IssueDependency { } ) ; err != nil {
return
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & IssueUser { } ) ; err != nil {
return
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & Reaction { } ) ; err != nil {
return
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & IssueWatch { } ) ; err != nil {
return
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & Stopwatch { } ) ; err != nil {
return
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & TrackedTime { } ) ; err != nil {
return
}
2020-08-17 06:07:38 +03:00
if _ , err = sess . In ( "issue_id" , deleteCond ) .
Delete ( & ProjectIssue { } ) ; err != nil {
return
}
2020-09-04 04:36:56 +03:00
if _ , err = sess . In ( "dependent_issue_id" , deleteCond ) .
Delete ( & Comment { } ) ; err != nil {
return
}
2021-11-19 16:39:57 +03:00
var attachments [ ] * repo_model . Attachment
2020-05-29 16:24:15 +03:00
if err = sess . In ( "issue_id" , deleteCond ) .
Find ( & attachments ) ; err != nil {
return
}
2020-08-18 07:23:45 +03:00
2020-05-29 16:24:15 +03:00
for j := range attachments {
2020-08-18 07:23:45 +03:00
attachmentPaths = append ( attachmentPaths , attachments [ j ] . RelativePath ( ) )
2020-05-29 16:24:15 +03:00
}
if _ , err = sess . In ( "issue_id" , deleteCond ) .
2021-11-19 16:39:57 +03:00
Delete ( & repo_model . Attachment { } ) ; err != nil {
2020-05-29 16:24:15 +03:00
return
}
if _ , err = sess . Delete ( & Issue { RepoID : repoID } ) ; err != nil {
return
}
return
}