mirror of
https://github.com/element-hq/element-web.git
synced 2024-11-30 23:31:28 +03:00
1f06d97ffe
* Attempt to deflake a read-receipts test Hopefully, this will fix https://github.com/vector-im/element-web/issues/26679 (I think that the fourth message was arriving *after* the room was marked as read, meaning that we ended up with two unread messages rather than one.) * Update cypress/e2e/read-receipts/new-messages.spec.ts * prettier |
||
|---|---|---|
| .. | ||
| editing-messages.spec.ts | ||
| high-level.spec.ts | ||
| missing-referents.spec.ts | ||
| new-messages.spec.ts | ||
| reactions.spec.ts | ||
| read-receipts-utils.ts | ||
| read-receipts.spec.ts | ||
| readme.md | ||
| redactions.spec.ts | ||
High Level Read Receipt Tests
Tips for writing these tests:
-
Break up your tests into the smallest test case possible. The purpose of these tests is to understand hard-to-find bugs, so small tests are necessary. We know that Cypress recommends combining tests together for performance, but that will frustrate our goals here. (We will need to find a different way to reduce CI time.)
-
Try to assert something after every action, to make sure it has completed. E.g.: markAsRead(room2); assertRead(room2); You should especially follow this rule if you are jumping to a different room or similar straight afterwards.
-
Use assertStillRead() if you are asserting something is read when it was also read before. This waits a little while to make sure you're not getting a false positive.