mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2024-12-01 11:03:18 +03:00
Code Issues Projects Releases Packages Wiki Activity
element-web/res/css/views/messages
History
Eric Eastwood 9b0da552e7
Fix vertical spacing in compact <ContextMenu> (#7684) 
Fix https://github.com/vector-im/element-web/issues/20801

Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/7339

Relevant styles were first added in https://github.com/matrix-org/matrix-react-sdk/pull/4858
(context behind why the original styles were added)

---

## Cause

Battling CSS specificity between the default and compact styles, https://specificity.keegan.st/

Known good (On `app.element.io` (expected)):
```css
// 0 3 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton {
    padding-top: 12px;
    padding-bottom: 12px;
}

// Compact styles override our default rules because they come
// after the other styles (source order) and have the same specificity
// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
    padding: 8px 16px 8px 11px;
}
```

Bad (On `develop` (broken)):
```css
// Default rules always override because they have higher specificity.
// The `:not()` selector doesn't add any extra specificity but the selectors inside the `:not(...)` do.
// 0 4 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
    padding-top: 12px;
    padding-bottom: 12px;
}

// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
    padding: 8px 16px 8px 11px;
}
```
2022-02-01 11:23:21 -06:00
..
_CallEvent.scss Show bubble tile timestamps for bubble layout inside the bubble (#7622) 2022-01-25 13:10:17 +00:00
_common_CryptoEvent.scss Color cleanup number 10 (#7132) 2021-11-16 10:10:44 +00:00
_CreateEvent.scss Color cleanup number 10 (#7132) 2021-11-16 10:10:44 +00:00
_DateSeparator.scss Add jump to date functionality to date headers in timeline v2 (#7339) 2022-01-27 16:32:12 -06:00
_EventTileBubble.scss Show bubble tile timestamps for bubble layout inside the bubble (#7622) 2022-01-25 13:10:17 +00:00
_HiddenBody.scss MSC3531 - Implementing message hiding pending moderation (#7518) 2022-01-17 16:04:37 +01:00
_JumpToDatePicker.scss Fix vertical spacing in compact <ContextMenu> (#7684) 2022-02-01 11:23:21 -06:00
_MediaBody.scss
_MEmoteBody.scss
_MessageActionBar.scss Add view in room to action bar in thread list (#7519) 2022-01-19 10:39:33 +00:00
_MessageTimestamp.scss
_MFileBody.scss Color cleanup 8 (#7108) 2021-11-11 13:37:29 +00:00
_MImageBody.scss s/boarder/border/g (#7174) 2021-11-21 18:56:25 +01:00
_MImageReplyBody.scss
_MJitsiWidgetEvent.scss Color cleanup number 10 (#7132) 2021-11-16 10:10:44 +00:00
_MjolnirBody.scss
_MLocationBody.scss Display general marker on non-self location shares (#7574) 2022-01-19 09:33:49 +00:00
_MNoticeBody.scss
_MPollBody.scss Support reactions, replies and forwards of polls (#7318) 2021-12-09 12:54:31 +00:00
_MStickerBody.scss
_MTextBody.scss
_MVideoBody.scss s/boarder/border/g (#7174) 2021-11-21 18:56:25 +01:00
_ReactionsRow.scss A11y - fix anchors-as-buttons (#7444) 2022-01-07 10:40:53 +01:00
_ReactionsRowButton.scss Task/colors-13 (#7271) 2021-12-03 09:23:38 +00:00
_RedactedBody.scss
_RoomAvatarEvent.scss
_SenderProfile.scss
_TextualEvent.scss Color cleanup 8 (#7108) 2021-11-11 13:37:29 +00:00
_UnknownBody.scss
_ViewSourceEvent.scss A11y - fix anchors-as-buttons (#7444) 2022-01-07 10:40:53 +01:00