A glossy Matrix collaboration client for the web.
Find a file
Michael Telatynski 86017639c2
Accessibility improvements around aria-labels and tooltips (#12062)
* Prevent Cypress typechecking react-sdk components without strict mode

This prevented us from switching to `forwardRef` in a bunch of places
due to it behaving different with & without strict mode.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update global.d.ts

* Switch AccessibleButton and derivatives to using `forwardRef`

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add missing ref={ref}

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Ensure RefObjects are used consistently

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Re-add WysiwygAutocomplete displayname

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix forwardRef types

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add comments

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Remove unused export

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Readd comment

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Accessibility improvements around aria-labels and tooltips

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Tweak copy

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate types & comments

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* i18n

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update snapshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Add comment

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Improve comment

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Prettier & i18n

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2024-01-05 10:59:41 +00:00
.github update teams names in CODEOWNERS (#12101) 2024-01-03 11:34:21 +00:00
__mocks__ Appease the linter 2023-11-13 19:54:04 +01:00
cypress Playwright: Convert e2e/threads (#12066) 2024-01-05 09:56:54 +00:00
docs Improve usage of Playwright and documentation (#11999) 2023-12-06 10:13:48 +00:00
playwright Playwright: Convert e2e/threads (#12066) 2024-01-05 09:56:54 +00:00
res Factor out post-login splash screen to a new component (#12103) 2024-01-04 18:12:08 +00:00
scripts Allow element-web hash to be specified when calling playwright tests workflow (#12087) 2023-12-22 15:51:24 +00:00
src Accessibility improvements around aria-labels and tooltips (#12062) 2024-01-05 10:59:41 +00:00
test Accessibility improvements around aria-labels and tooltips (#12062) 2024-01-05 10:59:41 +00:00
.editorconfig Do not trim trailing whitespaces for test snapshots (#11066) 2023-07-03 13:38:21 +00:00
.eslintignore Step 14: Remove reskindex 2022-03-28 15:30:30 -06:00
.eslintrc.js Add Playwright end to end testing (#11912) 2023-11-21 17:33:32 +00:00
.git-blame-ignore-revs Add prettier formatting to .git-blame-ignore-revs (#9753) 2022-12-14 11:19:37 +00:00
.gitignore Cypress: write logs to file (#11712) 2023-10-04 10:03:33 +00:00
.node-version Update dependency node to v20 (#11822) 2023-10-31 17:14:52 +00:00
.percy.yml Apply prettier formatting 2022-12-12 12:24:14 +01:00
.prettierignore Exclude CHANGELOG from prettier 2022-12-14 08:57:44 +00:00
.prettierrc.js Add prettier 2022-12-12 12:20:54 +01:00
.stylelintrc.js Update dependency stylelint-config-standard to v33 (#10650) 2023-05-16 15:41:04 +00:00
babel.config.js Apply prettier formatting 2022-12-12 12:24:14 +01:00
CHANGELOG.md v3.88.0 2024-01-04 14:32:30 +00:00
CONTRIBUTING.md Apply prettier formatting 2022-12-12 12:24:14 +01:00
cypress-ci-reporter-config.json Cypress: write logs to file (#11712) 2023-10-04 10:03:33 +00:00
cypress.config.ts Always use cypress-multi-reporters XML report, not just in CI (#11731) 2023-10-13 08:50:05 +00:00
jest.config.ts Extra worklet module loading and mock it in tests 2023-11-13 19:52:15 +01:00
LICENSE Basic structure of a react SDK and start of an implementation. 2015-06-09 17:40:42 +01:00
localazy.json Update workflows around i18n to use Localazy (#11455) 2023-10-04 09:28:09 +00:00
package.json Merge branch 'master' into develop 2024-01-04 14:33:43 +00:00
playwright.config.ts Migrate timeline.spec.ts from Cypress to Playwright (#12025) 2023-12-13 14:59:08 +00:00
post-release.sh Simplify releases: move npm publishing to gha, consolidate scripts (#9216) 2022-09-06 12:10:28 +01:00
README.md Add Playwright badge 2023-12-21 10:22:42 +00:00
release.sh Simplify releases: move npm publishing to gha, consolidate scripts (#9216) 2022-09-06 12:10:28 +01:00
release_config.yaml Apply prettier formatting 2022-12-12 12:24:14 +01:00
sonar-project.properties Add mechanism to check only one instance of the app is running (#11416) 2023-08-22 14:10:47 +00:00
tsconfig.json Extract worker creation into factories and mack them in tests 2023-11-13 19:35:04 +01:00
yarn.lock Reset matrix-js-sdk back to develop branch 2024-01-04 14:33:56 +00:00

npm Tests Playwright Static Analysis Knapsack Pro Parallel CI builds for Cypress Test - Legacy Crypto Knapsack Pro Parallel CI builds for Cypress Test - Rust Crypto Localazy Quality Gate Status Coverage Vulnerabilities Bugs

matrix-react-sdk

This is a react-based SDK for inserting a Matrix chat/voip client into a web page.

This package provides the React components needed to build a Matrix web client using React. It is not useable in isolation, and instead must be used from a 'skin'. A skin provides:

  • Customised implementations of presentation components.
  • Custom CSS
  • The containing application
  • Zero or more 'modules' containing non-UI functionality

As of Aug 2018, the only skin that exists is vector-im/element-web; it and matrix-org/matrix-react-sdk should effectively be considered as a single project (for instance, matrix-react-sdk bugs are currently filed against vector-im/element-web rather than this project).

Developer Guide

Platform Targets:

All code lands on the develop branch - master is only used for stable releases. Please file PRs against develop!!

We use the same contribution guide as Element. Check it out here: https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md

Our code style is also the same as Element's: https://github.com/vector-im/element-web/blob/develop/code_style.md

Code should be committed as follows:

React components in matrix-react-sdk come in two different flavours: 'structures' and 'views'. Structures are stateful components which handle the more complicated business logic of the app, delegating their actual presentation rendering to stateless 'view' components. For instance, the RoomView component that orchestrates the act of visualising the contents of a given Matrix chat room tracks lots of state for its child components which it passes into them for visual rendering via props.

Good separation between the components is maintained by adopting various best practices that anyone working with the SDK needs to be aware of and uphold:

  • Components are named with upper camel case (e.g. views/rooms/EventTile.js)

  • They are organised in a typically two-level hierarchy - first whether the component is a view or a structure, and then a broad functional grouping (e.g. 'rooms' here)

  • The view's CSS file MUST have the same name (e.g. view/rooms/MessageTile.css). CSS for matrix-react-sdk currently resides in https://github.com/matrix-org/matrix-react-sdk/tree/master/res/css.

  • Per-view CSS is optional - it could choose to inherit all its styling from the context of the rest of the app, although this is unusual for any but

  • Theme specific CSS & resources: https://github.com/matrix-org/matrix-react-sdk/tree/master/res/themes structural components (lacking presentation logic) and the simplest view components.

  • The view MUST only refer to the CSS rules defined in its own CSS file. 'Stealing' styling information from other components (including parents) is not cool, as it breaks the independence of the components.

  • CSS classes are named with an app-specific name-spacing prefix to try to avoid CSS collisions. The base skin shipped by Matrix.org with the matrix-react-sdk uses the naming prefix "mx*". A company called Yoyodyne Inc might use a prefix like "yy*" for its app-specific classes.

  • CSS classes use upper camel case when they describe React components - e.g. .mx_MessageTile is the selector for the CSS applied to a MessageTile view.

  • CSS classes for DOM elements within a view which aren't components are named by appending a lower camel case identifier to the view's class name - e.g. .mx_MessageTile_randomDiv is how you'd name the class of an arbitrary div within the MessageTile view.

  • We deliberately use vanilla CSS 3.0 to avoid adding any more magic dependencies into the mix than we already have. App developers are welcome to use whatever floats their boat however. In future we'll start using css-next to pull in features like CSS variable support.

  • The CSS for a component can override the rules for child components. For instance, .mxRoomList .mx_RoomTile {} would be the selector to override styles of RoomTiles when viewed in the context of a RoomList view. Overrides _must be scoped to the View's CSS class - i.e. don't just define .mx_RoomTile {} in RoomList.css - only RoomTile.css is allowed to define its own CSS. Instead, say .mx_RoomList .mx_RoomTile {} to scope the override only to the context of RoomList views. N.B. overrides should be relatively rare as in general CSS inheritance should be enough.

  • Components should render only within the bounding box of their outermost DOM element. Page-absolute positioning and negative CSS margins and similar are generally not cool and stop the component from being reused easily in different places.

Originally matrix-react-sdk followed the Atomic design pattern as per http://patternlab.io to try to encourage a modular architecture. However, we found that the grouping of components into atoms/molecules/organisms made them harder to find relative to a functional split, and didn't emphasise the distinction between 'structural' and 'view' components, so we backed away from it.

Github Issues

All issues should be filed under https://github.com/vector-im/element-web/issues for now.

Development

Ensure you have the latest LTS version of Node.js installed.

Using yarn instead of npm is recommended. Please see the Yarn 1 install guide if you do not have it already. This project has not yet been migrated to Yarn 2, so please ensure yarn --version shows a version from the 1.x series.

matrix-react-sdk depends on matrix-js-sdk. To make use of changes in the latter and to ensure tests run against the develop branch of matrix-js-sdk, you should set up matrix-js-sdk:

git clone https://github.com/matrix-org/matrix-js-sdk
cd matrix-js-sdk
git checkout develop
yarn link
yarn install

Then check out matrix-react-sdk and pull in dependencies:

git clone https://github.com/matrix-org/matrix-react-sdk
cd matrix-react-sdk
git checkout develop
yarn link matrix-js-sdk
yarn install

See the help for yarn link for more details about this.

Running tests

Ensure you've followed the above development instructions and then:

yarn test

Running lint

To check your code complies with the project style, ensure you've followed the above development instructions and then:

yarn lint

Dependency problems

If you see errors (particularly "Cannot find module") running the lint or test commands, and yarn install doesn't fix them, it may be because yarn is not fetching git dependencies eagerly enough.

Try running this:

yarn cache clean && yarn install --force

Now the yarn commands should work as normal.

End-to-End tests

We use Cypress and Element Web for end-to-end tests. See docs/cypress.md for more information.