mirror of
https://github.com/element-hq/element-web.git
synced 2024-12-11 14:23:18 +03:00
1d9c24e96e
* add delegatedauthentication to validated server config * dynamic client registration functions * test OP registration functions * add stubbed nativeOidc flow setup in Login * cover more error cases in Login * tidy * test dynamic client registration in Login * comment oidc_static_clients * register oidc inside Login.getFlows * strict fixes * remove unused code * and imports * comments * comments 2 * util functions to get static client id * check static client ids in login flow * remove dead code * OidcRegistrationClientMetadata type * navigate to oidc authorize url * exchange code for token * navigate to oidc authorize url * navigate to oidc authorize url * test * adjust for js-sdk code * login with oidc native flow: messy version * tidy * update test for response_mode query * tidy up some TODOs * use new types * add identityServerUrl to stored params * unit test completeOidcLogin * test tokenlogin * strict * whitespace * tidy * unit test oidc login flow in MatrixChat * strict * tidy * extract success/failure handlers from token login function * typo * use for no homeserver error dialog too * reuse post-token login functions, test * shuffle testing utils around * shuffle testing utils around * i18n * tidy * Update src/Lifecycle.ts Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * tidy * comment * update tests for id token validation * move try again responsibility * prettier * add friendly error messages for oidc authorization failures * i18n * update for new translations, tidy --------- Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
154 lines
5.5 KiB
TypeScript
154 lines
5.5 KiB
TypeScript
/*
|
|
Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import fetchMock from "fetch-mock-jest";
|
|
import { completeAuthorizationCodeGrant } from "matrix-js-sdk/src/oidc/authorize";
|
|
import * as randomStringUtils from "matrix-js-sdk/src/randomstring";
|
|
import { BearerTokenResponse } from "matrix-js-sdk/src/oidc/validate";
|
|
import { mocked } from "jest-mock";
|
|
|
|
import { completeOidcLogin, startOidcLogin } from "../../../src/utils/oidc/authorize";
|
|
import { makeDelegatedAuthConfig } from "../../test-utils/oidc";
|
|
import { OidcClientError } from "../../../src/utils/oidc/error";
|
|
|
|
jest.unmock("matrix-js-sdk/src/randomstring");
|
|
|
|
jest.mock("matrix-js-sdk/src/oidc/authorize", () => ({
|
|
...jest.requireActual("matrix-js-sdk/src/oidc/authorize"),
|
|
completeAuthorizationCodeGrant: jest.fn(),
|
|
}));
|
|
|
|
describe("OIDC authorization", () => {
|
|
const issuer = "https://auth.com/";
|
|
const homeserverUrl = "https://matrix.org";
|
|
const identityServerUrl = "https://is.org";
|
|
const clientId = "xyz789";
|
|
const baseUrl = "https://test.com";
|
|
|
|
const delegatedAuthConfig = makeDelegatedAuthConfig(issuer);
|
|
|
|
// to restore later
|
|
const realWindowLocation = window.location;
|
|
|
|
beforeEach(() => {
|
|
// @ts-ignore allow delete of non-optional prop
|
|
delete window.location;
|
|
// @ts-ignore ugly mocking
|
|
window.location = {
|
|
href: baseUrl,
|
|
origin: baseUrl,
|
|
};
|
|
|
|
jest.spyOn(randomStringUtils, "randomString").mockRestore();
|
|
});
|
|
|
|
beforeAll(() => {
|
|
fetchMock.get(`${delegatedAuthConfig.issuer}.well-known/openid-configuration`, delegatedAuthConfig.metadata);
|
|
});
|
|
|
|
afterAll(() => {
|
|
window.location = realWindowLocation;
|
|
});
|
|
|
|
describe("startOidcLogin()", () => {
|
|
it("navigates to authorization endpoint with correct parameters", async () => {
|
|
await startOidcLogin(delegatedAuthConfig, clientId, homeserverUrl);
|
|
|
|
const expectedScopeWithoutDeviceId = `openid urn:matrix:org.matrix.msc2967.client:api:* urn:matrix:org.matrix.msc2967.client:device:`;
|
|
|
|
const authUrl = new URL(window.location.href);
|
|
|
|
expect(authUrl.searchParams.get("response_mode")).toEqual("query");
|
|
expect(authUrl.searchParams.get("response_type")).toEqual("code");
|
|
expect(authUrl.searchParams.get("client_id")).toEqual(clientId);
|
|
expect(authUrl.searchParams.get("code_challenge_method")).toEqual("S256");
|
|
|
|
// scope ends with a 10char randomstring deviceId
|
|
const scope = authUrl.searchParams.get("scope")!;
|
|
expect(scope.substring(0, scope.length - 10)).toEqual(expectedScopeWithoutDeviceId);
|
|
expect(scope.substring(scope.length - 10)).toBeTruthy();
|
|
|
|
// random string, just check they are set
|
|
expect(authUrl.searchParams.has("state")).toBeTruthy();
|
|
expect(authUrl.searchParams.has("nonce")).toBeTruthy();
|
|
expect(authUrl.searchParams.has("code_challenge")).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe("completeOidcLogin()", () => {
|
|
const state = "test-state-444";
|
|
const code = "test-code-777";
|
|
const queryDict = {
|
|
code,
|
|
state: state,
|
|
};
|
|
|
|
const tokenResponse: BearerTokenResponse = {
|
|
access_token: "abc123",
|
|
refresh_token: "def456",
|
|
scope: "test",
|
|
token_type: "Bearer",
|
|
expires_at: 12345,
|
|
};
|
|
|
|
beforeEach(() => {
|
|
mocked(completeAuthorizationCodeGrant)
|
|
.mockClear()
|
|
.mockResolvedValue({
|
|
oidcClientSettings: {
|
|
clientId,
|
|
issuer,
|
|
},
|
|
tokenResponse,
|
|
homeserverUrl,
|
|
identityServerUrl,
|
|
idTokenClaims: {
|
|
aud: "123",
|
|
iss: issuer,
|
|
sub: "123",
|
|
exp: 123,
|
|
iat: 456,
|
|
},
|
|
});
|
|
});
|
|
|
|
it("should throw when query params do not include state and code", async () => {
|
|
await expect(async () => await completeOidcLogin({})).rejects.toThrow(
|
|
OidcClientError.InvalidQueryParameters,
|
|
);
|
|
});
|
|
|
|
it("should make request complete authorization code grant", async () => {
|
|
await completeOidcLogin(queryDict);
|
|
|
|
expect(completeAuthorizationCodeGrant).toHaveBeenCalledWith(code, state);
|
|
});
|
|
|
|
it("should return accessToken, configured homeserver and identityServer", async () => {
|
|
const result = await completeOidcLogin(queryDict);
|
|
|
|
expect(result).toEqual({
|
|
accessToken: tokenResponse.access_token,
|
|
refreshToken: tokenResponse.refresh_token,
|
|
homeserverUrl,
|
|
identityServerUrl,
|
|
issuer,
|
|
clientId,
|
|
idTokenClaims: result.idTokenClaims,
|
|
});
|
|
});
|
|
});
|
|
});
|