mirror of
https://github.com/element-hq/element-web.git
synced 2024-12-21 07:55:33 +03:00
c61eca8c24
* Don't consider textual characters to be emoji We were using emojibase-regex to match emoji within messages. However, the docs (https://emojibase.dev/docs/regex/) state that this regex matches both emoji and text presentation characters. This is not what we want, and will result in false positives for characters like '↔' that could turn into an emoji if paired with a variation selector. Unfortunately, none of the other regexes provided by Emojibase do what we want either (https://github.com/milesj/emojibase/issues/174). In the meantime, browser support for the RGI_Emoji character sequence class has made it feasible to write an emoji regex by hand, so that's what I've done. * Add a fallback for BIGEMOJI_REGEX as well
208 lines
7.8 KiB
TypeScript
208 lines
7.8 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import React, { ReactElement } from "react";
|
|
import { mocked } from "jest-mock";
|
|
import { render, screen } from "@testing-library/react";
|
|
import { IContent } from "matrix-js-sdk/src/matrix";
|
|
|
|
import { bodyToHtml, formatEmojis, topicToHtml } from "../src/HtmlUtils";
|
|
import SettingsStore from "../src/settings/SettingsStore";
|
|
|
|
jest.mock("../src/settings/SettingsStore");
|
|
|
|
const enableHtmlTopicFeature = () => {
|
|
mocked(SettingsStore).getValue.mockImplementation((arg): any => {
|
|
return arg === "feature_html_topic";
|
|
});
|
|
};
|
|
|
|
describe("topicToHtml", () => {
|
|
function getContent() {
|
|
return screen.getByRole("contentinfo").children[0].innerHTML;
|
|
}
|
|
|
|
it("converts plain text topic to HTML", () => {
|
|
render(<div role="contentinfo">{topicToHtml("pizza", undefined, null, false)}</div>);
|
|
expect(getContent()).toEqual("pizza");
|
|
});
|
|
|
|
it("converts plain text topic with emoji to HTML", () => {
|
|
render(<div role="contentinfo">{topicToHtml("pizza 🍕", undefined, null, false)}</div>);
|
|
expect(getContent()).toEqual('pizza <span class="mx_Emoji" title=":pizza:">🍕</span>');
|
|
});
|
|
|
|
it("converts literal HTML topic to HTML", async () => {
|
|
enableHtmlTopicFeature();
|
|
render(<div role="contentinfo">{topicToHtml("<b>pizza</b>", undefined, null, false)}</div>);
|
|
expect(getContent()).toEqual("<b>pizza</b>");
|
|
});
|
|
|
|
it("converts true HTML topic to HTML", async () => {
|
|
enableHtmlTopicFeature();
|
|
render(<div role="contentinfo">{topicToHtml("**pizza**", "<b>pizza</b>", null, false)}</div>);
|
|
expect(getContent()).toEqual("<b>pizza</b>");
|
|
});
|
|
|
|
it("converts true HTML topic with emoji to HTML", async () => {
|
|
enableHtmlTopicFeature();
|
|
render(<div role="contentinfo">{topicToHtml("**pizza** 🍕", "<b>pizza</b> 🍕", null, false)}</div>);
|
|
expect(getContent()).toEqual('<b>pizza</b> <span class="mx_Emoji" title=":pizza:">🍕</span>');
|
|
});
|
|
});
|
|
|
|
describe("bodyToHtml", () => {
|
|
function getHtml(content: IContent, highlights?: string[]): string {
|
|
return (bodyToHtml(content, highlights, {}) as ReactElement).props.dangerouslySetInnerHTML.__html;
|
|
}
|
|
|
|
it("should apply highlights to HTML messages", () => {
|
|
const html = getHtml(
|
|
{
|
|
body: "test **foo** bar",
|
|
msgtype: "m.text",
|
|
formatted_body: "test <b>foo</b> bar",
|
|
format: "org.matrix.custom.html",
|
|
},
|
|
["test"],
|
|
);
|
|
|
|
expect(html).toMatchInlineSnapshot(`"<span class="mx_EventTile_searchHighlight">test</span> <b>foo</b> bar"`);
|
|
});
|
|
|
|
it("should apply highlights to plaintext messages", () => {
|
|
const html = getHtml(
|
|
{
|
|
body: "test foo bar",
|
|
msgtype: "m.text",
|
|
},
|
|
["test"],
|
|
);
|
|
|
|
expect(html).toMatchInlineSnapshot(`"<span class="mx_EventTile_searchHighlight">test</span> foo bar"`);
|
|
});
|
|
|
|
it("should not respect HTML tags in plaintext message highlighting", () => {
|
|
const html = getHtml(
|
|
{
|
|
body: "test foo <b>bar",
|
|
msgtype: "m.text",
|
|
},
|
|
["test"],
|
|
);
|
|
|
|
expect(html).toMatchInlineSnapshot(`"<span class="mx_EventTile_searchHighlight">test</span> foo <b>bar"`);
|
|
});
|
|
|
|
it("generates big emoji for emoji made of multiple characters", () => {
|
|
const { asFragment } = render(bodyToHtml({ body: "👨👩👧👦 ↔️ 🇮🇸", msgtype: "m.text" }, [], {}) as ReactElement);
|
|
|
|
expect(asFragment()).toMatchSnapshot();
|
|
});
|
|
|
|
it("should generate big emoji for an emoji-only reply to a message", () => {
|
|
const { asFragment } = render(
|
|
bodyToHtml(
|
|
{
|
|
"body": "> <@sender1:server> Test\n\n🥰",
|
|
"format": "org.matrix.custom.html",
|
|
"formatted_body":
|
|
'<mx-reply><blockquote><a href="https://matrix.to/#/!roomId:server/$eventId">In reply to</a> <a href="https://matrix.to/#/@sender1:server">@sender1:server</a><br>Test</blockquote></mx-reply>🥰',
|
|
"m.relates_to": {
|
|
"m.in_reply_to": {
|
|
event_id: "$eventId",
|
|
},
|
|
},
|
|
"msgtype": "m.text",
|
|
},
|
|
[],
|
|
{
|
|
stripReplyFallback: true,
|
|
},
|
|
) as ReactElement,
|
|
);
|
|
|
|
expect(asFragment()).toMatchSnapshot();
|
|
});
|
|
|
|
it("does not mistake characters in text presentation mode for emoji", () => {
|
|
const { asFragment } = render(bodyToHtml({ body: "↔ ❗︎", msgtype: "m.text" }, [], {}) as ReactElement);
|
|
|
|
expect(asFragment()).toMatchSnapshot();
|
|
});
|
|
|
|
describe("feature_latex_maths", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation((feature) => feature === "feature_latex_maths");
|
|
});
|
|
|
|
it("should render inline katex", () => {
|
|
const html = getHtml({
|
|
body: "hello \\xi world",
|
|
msgtype: "m.text",
|
|
formatted_body: 'hello <span data-mx-maths="\\xi"><code>\\xi</code></span> world',
|
|
format: "org.matrix.custom.html",
|
|
});
|
|
expect(html).toMatchSnapshot();
|
|
});
|
|
|
|
it("should render block katex", () => {
|
|
const html = getHtml({
|
|
body: "hello \\xi world",
|
|
msgtype: "m.text",
|
|
formatted_body: '<p>hello</p><div data-mx-maths="\\xi"><code>\\xi</code></div><p>world</p>',
|
|
format: "org.matrix.custom.html",
|
|
});
|
|
expect(html).toMatchSnapshot();
|
|
});
|
|
|
|
it("should not mangle code blocks", () => {
|
|
const html = getHtml({
|
|
body: "hello \\xi world",
|
|
msgtype: "m.text",
|
|
formatted_body: "<p>hello</p><pre><code>$\\xi$</code></pre><p>world</p>",
|
|
format: "org.matrix.custom.html",
|
|
});
|
|
expect(html).toMatchSnapshot();
|
|
});
|
|
|
|
it("should not mangle divs", () => {
|
|
const html = getHtml({
|
|
body: "hello world",
|
|
msgtype: "m.text",
|
|
formatted_body: "<p>hello</p><div>world</div>",
|
|
format: "org.matrix.custom.html",
|
|
});
|
|
expect(html).toMatchSnapshot();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("formatEmojis", () => {
|
|
it.each([
|
|
["🏴", [["🏴", "flag-england"]]],
|
|
["🏴", [["🏴", "flag-scotland"]]],
|
|
["🏴", [["🏴", "flag-wales"]]],
|
|
])("%s emoji", (emoji, expectations) => {
|
|
const res = formatEmojis(emoji, false);
|
|
expect(res).toHaveLength(expectations.length);
|
|
for (let i = 0; i < res.length; i++) {
|
|
const [emoji, title] = expectations[i];
|
|
expect(res[i].props.children).toEqual(emoji);
|
|
expect(res[i].props.title).toEqual(`:${title}:`);
|
|
}
|
|
});
|
|
});
|