* Add a basic PR checklist for all PRs
It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things.
Note that signoff is not required for core developers.
* *ahem*
https://github.com/matrix-org/matrix-react-sdk/pull/8747 made it more evident that the host signup dialog was relying on some quirks in how PersistedElement sizes and positions things that it probably shouldn't have been relying on. As far as I can tell, this dialog doesn't *need* to be a PersistedElement at all since it's mounted manually as part of LoggedInView, and so it doesn't look like there's any way for it to unexpectedly disappear on the user.
According to Travis this is supposed to be a bespoke widget in a proper dialog, but this is intended as a more short-term fix.
* Remove obsolete opacity value for E2E icons
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* The opacity declaration is not required after all
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move mx_EventTile_searchHighlight out of mx_EventTile:not([data-layout=bubble]) to enable it on bubble layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a logical property
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Unbreak URL preview for formatted links with tooltips
Fixes: vector-im/element-web#22764
Signed-off-by: Johannes Marbach <johannesm@element.io>
* Flip back the flag default value 🤦
* Move mx_EventTile out of mx_EventTile:not([data-layout=bubble]) in mx_ThreadView
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a logical property
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove a redundant declaration
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply zero inline start padding to group layout only
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Reorder style blocks; irc/group before bubble
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move styles for mx_EventTile_avatar of info event lines on ThreadView out of :not() pseudo class
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move styles in mx_GenericEventListSummary on ThreadView out of :not() pseudo class
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Shorthand for inline margin
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Re-add margin to HistoryTile, which is based on EventTileBubble
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Readd margin to the other tiles based on EventTileBubble
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Default margin is not required for mx_MJitsiWidgetEvent as it appears inside EventTile
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Cancel left value for cryptoEvent on IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Include mx_BaseAvatar
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Include style blocks of mx_MatrixChat_useCompactLayout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set top padding to avatars on group layout only
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove a redundant declaration for bubble layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set the same margin value to mx_GenericEventListSummary_avatars on every layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove margin-top from mx_GenericEventListSummary_toggle on IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove block margin from mx_GenericEventListSummary_toggle on both IRC layout and modern layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set spacing to mx_GenericEventListSummary instead of its child elements
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply the margin to every layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move general rules up
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply block margin to mx_GenericEventListSummary_toggle of every layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply top margin to modern layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Include mx_MatrixChat_useCompactLayout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set top margin to mx_GenericEventListSummary insted of toggle
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a spacing variable
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove a redundant declaration
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add a comment
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply display flex as a default value
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply margin to EventTileBubble on each layout
Use a variable to ensure alignment of EventTileBubble on IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Improve style rules
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply the same block margin to every layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move ':hover.mx_EventTile_verified .mx_EventTile_line' etc out of mx_EventTile:not([data-layout=bubble])
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use variables
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge mx_EventTile_line on hover
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply inline start padding effect on hovering info tile text line to modern/group layout only
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* live location without map POC
* styles
* force map tiles to show no map for test build
* check latestlocationstate exists
* just use loading style map fallback when cant display map
* style map error for tile view
* set pointer cursor when map error is clickable
* test mbeaconbody with map display error, lint
* lint more good
* remove changes for first attempt tile
* make maperror test id more accurate
* fussy import ordering
* PR tweaks
* add role=presentation to backdrop panle image
* replace img icons with svg components in InviteDialog
* replace img icon with svg component
* img icons to svg icons in MImageBody
* remove log
* img icon to svg in SecurityRoomSettingsTab
* use shared error message for media message tiles
* remove nbsp
* dont snapshot test entire rtl render response
* use aria-describedby for uploadconfirm preview
* use aria-labelledby instead
* Apply kind=link to 'Learn more' link on security user settings tab
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove specific margin setting from heading on security user settings tab
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Stop using :not() pseudo class for mx_GenericEventListSummary
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a CSS variable for mx_GenericEventListSummary on _EventTile.scss - icon-width
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a CSS variable for mx_GenericEventListSummary on _EventTile.scss - right-padding
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move declarations for EventTile_line of GenericEventListSummary for IRC layout from _IRCLayout.scss to _EventTile.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move mx_EventTile_line out of mx_GenericEventListSummary:not([data-layout=bubble])
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common style rules up
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set zero inline start padding to mx_EventTile_line of info tile of mx_GenericEventListSummary_unstyledList on IRC layout
There should not be spacing between avatars and info tile line on IRC Layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply the rule to group/modern layout only
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Apply the inline start padding to modern/group layout only
Overriding $left-gutter is not necessary for IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge the style block for mx_EventTile_info .mx_EventTile_line
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove padding from info event tile line from mx_GenericEventListSummary on IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add spacing between avatar and a single info event tile line on IRC layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Stop using :not() pseudo class for mx_GenericEventListSummary on TimelineCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Fix padding of line with redacted body text
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add option to display tooltip on link hover
This makes it possible for platforms like Electron apps, which lack
a built-in URL preview in the status bar, to enable tooltip previews
of links.
Relates to: vector-im/element-web#6532
Signed-off-by: Johannes Marbach <johannesm@element.io>
* Gracefully handle missing platform
* Use public access modifier
Co-authored-by: Travis Ralston <travpc@gmail.com>
* Use exact inequality
Co-authored-by: Travis Ralston <travpc@gmail.com>
* Document getAbsoluteUrl
* Appease the linter
* Clarify performance impact in comment
Co-authored-by: Travis Ralston <travpc@gmail.com>
* Use URL instead of anchor element hack
* Wrap anchor in tooltip target and only allow focus on anchor
* Use optional chaining
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Use double quotes for consistency
* Accumulate and unmount tooltips and extract tooltipify.tsx
* Fix indentation
* Blur tooltip target on click
* Remove space
* Mention platform flag in comment
* Add (simplistic) tests
* Fix lint errors
* Fix lint errors ... for real
* Replace snapshot tests with structural assertions
* Add missing semicolon
* Add tooltips in link previews
* Fix copyright
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Early implementation of module API surface + functions for ILAG module
* Wire up dialog functions and ILAG-needed surface
* Ensure component renders for modules get overridden
* Respond to changes from module API interface
* Use a real module-api dependency
* Update for new Dialogs interface
* Add support for getConfigValue from module API
* Update the remainder of the module API interface
* Docs & cleanup
* Add some unit tests around module stuff
Needs end-to-end tests still.
* Appease early linters
* Break import cycles by not directly depending on Lifecycle
* Appease the linter
* Fix bad merge
* Fix position of 'Show Advanced' on security room settings tab
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use flex to ensure alignment of the warning icon and message
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove an obsolete style block
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
