Commit graph

46007 commits

Author SHA1 Message Date
Andy Balaam
dbf73f725f
Disable two flaky Percy tests - see #25283 and #24881 (#10878) 2023-05-12 09:56:32 +00:00
Andy Balaam
415fcde5e8
Cypress tests for read receipts, threaded and unthreaded (#10872) 2023-05-12 08:04:33 +00:00
Michael Telatynski
f758cbd38a
Make more of the codebase conform to strict types (#10859) 2023-05-12 09:49:37 +01:00
Michael Telatynski
6f58dd49e3
Respect configured auth_header_logo_url for default Welcome page (#10870) 2023-05-12 09:45:04 +01:00
Kerry
2767fd623a
Percy: hide timestamp in permalink rendering screenshot test (#10836)
* hide timestamp

* retrigger sonar

* trigger build
2023-05-12 01:45:31 +00:00
Michael Telatynski
2cee8a4b01
Specify lazy loading for avatars (#10866)
* Specify lazy loading for avatars

so browser doesn't fetch eagerly if off-screen

* Update snapshots
2023-05-11 18:29:48 +00:00
Suguru Hirahara
73007d6dd6
Tidy up _AppsDrawer.pcss (#10775)
* Nesting

* Run prettier

* Common style rules for `mx_AppTileBody` and `mx_AppTileBody_mini`

* Common style rules for iframe

* Use a custom property for height

* Replace with a custom property - $MiniAppTileHeight

* Replace with a custom property - $MinWidth

* Group common declarations

* Sorting
2023-05-11 15:26:41 +00:00
alunturner
0889dc55da
Room and user mentions for plain text editor (#10665)
* update useSuggestion

* update useSuggestion-tests

* add processMention tests

* add test

* add getMentionOrCommand tests

* change mock href for codeQL reasons

* fix TS issue in test

* add a big old cypress test

* fix lint error

* update comments

* reorganise functions in order of importance

* rename functions and variables

* add endOffset to return object

* fix failing tests

* update function names and comments

* update comment, remove delay

* update comments and early return

* nest mappedSuggestion inside Suggestion state and update test

* rename suggestion => suggestionData

* update comment

* add argument to findSuggestionInText

* make findSuggestionInText return mappedSuggestion

* fix TS error

* update comments and index check from === -1 to < 0

* tidy logic in increment functions

* rename variable

* Big refactor to address multiple comments, improve behaviour and add tests

* improve comments

* tidy up comment

* extend comment

* combine similar returns

* update comment

* remove single use variable

* fix comments
2023-05-11 14:28:42 +00:00
Michael Telatynski
68ff19fb4b
Fix regression in emoji picker order mangling after clearing filter (#10854)
* Add regression test for emoji picker order mangling after clearing filter

* Fix regression in emoji picker order mangling after clearing filter

* Iterate

* Update src/components/views/emojipicker/EmojiPicker.tsx
2023-05-11 13:24:39 +00:00
Suguru Hirahara
d944422417
Tidy up _MemberInfo.pcss (#10862)
* Nest: mx_MemberInfo_name *

* Nest: mx_MemberInfo *

* Nest: mx_MemberInfo_avatar
2023-05-11 13:01:12 +00:00
Andy Balaam
2e4fc0a76d
Don't run SonarCloud when a change is in the merge queue (#10863)
We are not interested in coverage information when a PR has already been
approved, and we were seeing flakiness with SonarCloud with the "no
artifacts found" error
https://github.com/vector-im/element-web/issues/25334 .
2023-05-11 12:52:28 +00:00
Michael Weimann
0a6fe83a8c
Add audible notifcation on broadcast error (#10654)
* Add audible notifcation on broadcast error

* Add error audio file

* Add error ogg

* Catch play broadcast error

* Await play error sound

* Add promise error handling

* Add comment about audio elements
2023-05-11 12:15:34 +00:00
Richard van der Hoff
9aade5a4d5
Improve cypress logging output (#10845)
... by grouping together the output from some custom commands.
2023-05-11 10:46:50 +00:00
Richard van der Hoff
2d58489309
Cypress test to check cross-signing keys on register (#10850)
Part of https://github.com/vector-im/element-web/issues/25314
2023-05-11 10:34:52 +00:00
Richard van der Hoff
3c32ad7cab
Fix CSP problems due to cypress-axe (#10843)
* Fix CSP problems due to cypress-axe

Rewrite `injectAxe` to use a script tag instead of an `eval`.

* remove gha workflow hack
2023-05-11 10:31:09 +00:00
Kerry
41c96877d3
Fix: Edit history modal crash (#10834)
* failing test

* handle nodes without children in messagediffutils
2023-05-11 10:21:02 +00:00
Suguru Hirahara
eac548c25a
Fix snapshot File Panel - empty (#10855) 2023-05-11 09:25:28 +00:00
Michael Telatynski
949557b5c6
Fall back from server generated thumbnail to original image (#10853)
* Add test for falling back from thumbnail to original

* Fall back from server generated thumbnail to original image
2023-05-11 09:20:14 +00:00
Michael Telatynski
82e32035fd
Conform more of the codebase to strictNullChecks (#10842) 2023-05-11 09:56:56 +01:00
Suguru Hirahara
5eea2c8b02
Remove unused class name - mx_AppsDrawer_fullWidth (#10830)
Added by e897e97fd6
Deprecated by bf3c49b8df
2023-05-11 08:14:43 +00:00
Suguru Hirahara
16ec3b5d7b
Add appearance-user-settings-tab.spec.ts (#10697)
* Add `appearance-user-settings-tab.spec.ts`

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Empty commit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix a comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-05-11 06:33:50 +00:00
Kerry
675756a699
Flaky Cypress test - should handle long room address and long room name on right-panel.spec.ts (#10835)
* wait for room alias to be set before closing modal

* retrigger sonar
2023-05-11 02:32:32 +00:00
RiotRobot
a18e66c69b Reset matrix-js-sdk back to develop branch 2023-05-10 12:21:14 +01:00
RiotRobot
7287415ab9 Resetting package fields for development 2023-05-10 12:20:47 +01:00
RiotRobot
f020235958 Merge branch 'master' into develop 2023-05-10 12:20:40 +01:00
RiotRobot
0e2f0009ce v3.72.0 2023-05-10 12:20:23 +01:00
RiotRobot
5e7b49c212 Prepare changelog for v3.72.0 2023-05-10 12:20:21 +01:00
RiotRobot
5a2043b472 Upgrade matrix-js-sdk to 25.1.0 2023-05-10 12:14:51 +01:00
Andy Balaam
33ddec4211
Revert "Update browser-actions/setup-chrome digest to 5dc4fd3 (#10759)" (#10839)
This reverts commit adb29b38a3.
2023-05-10 11:58:53 +01:00
Michael Telatynski
456c66db5b
Conform more of the codebase to strictNullChecks (#10800) 2023-05-10 08:41:55 +01:00
renovate[bot]
adb29b38a3
Update browser-actions/setup-chrome digest to 5dc4fd3 (#10759)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-05-10 00:54:47 +00:00
Suguru Hirahara
5cdbdd9f97
Update some class names of AppTile on the naming policy (#10777) 2023-05-09 21:07:12 +00:00
Suguru Hirahara
dc8ea8dc27
Replace $timeline-image-border-radius with a CSS custom property (#10792)
* Use CSS custom property: --timeline-image-border-radius

Remove the same variable from _MImageBody.pcss

* Rename the property

The property is neither limited to a timeline nor image, but applied to M.*?Body components as well, such as MLocationBody and MVideoBody.
2023-05-09 21:06:19 +00:00
Suguru Hirahara
c4f59d4d56
Add E2E test of ThemeChoicePanel (#10469)
* Add E2E test of ThemeChoicePanel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Edit a comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply feedback

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete data-testId attributes

They has become obsolete with bfa8152538a3a0804ac14e231578d0cba73aa308.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Update a jest snapshot

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-05-09 13:48:55 +00:00
Michael Telatynski
52017f62e1
Conform more of the codebase to strictNullChecks (#10738) 2023-05-09 18:24:40 +01:00
Richard van der Hoff
5e8488c283
DeviceListener: use new getUserDeviceInfo method (#10826)
* DeviceListener: use new `getUserDeviceInfo` method

https://github.com/matrix-org/matrix-js-sdk/pull/3272 added a new
`CryptoApi.getUserDeviceInfo` method, which also works with rust crypto. Update
DeviceListener to use it, thus making many of the cypress tests work on Element
Web R.

* add missing await

... mostly to silence the quality gate
2023-05-09 13:39:51 +00:00
Michael Telatynski
339e7dab18
Use semantically correct elements for room sublist context menu (#10831) 2023-05-09 11:13:55 +00:00
Michael Telatynski
08368860f4
Avoid calling prepareToEncrypt onKeyDown (#10828)
* Avoid calling prepareToEncrypt onKeyDown

* Iterate
2023-05-09 10:56:12 +00:00
Suguru Hirahara
b3fd9377d6
Use shorthand "inset" property (#10825) 2023-05-09 10:02:12 +00:00
Michael Telatynski
5d0b5131f2
Treat thumbnail upload failures as complete upload failures (#10829)
Without this it'll be treated the same as a thumbnailing failure which falls back to m.file
2023-05-09 09:52:07 +00:00
Suguru Hirahara
9b6973d71a
Manage rules for mx_RoomView on _RoomView.pcss - _ScrollPanel.pcss (#10770)
* Move style rules of `mx_RoomView_MessageList` from _ScrollPanel.pcss on _RoomView.pcss

* Nesting: `mx_RoomView--local .mx_ScrollPanel`
2023-05-09 08:32:16 +00:00
Suguru Hirahara
d2fa0af3c0
Manage rules for mx_RoomView on _RoomView.pcss - _ScrollPanel.pcss (#10770)
* Move style rules of `mx_RoomView_MessageList` from _ScrollPanel.pcss on _RoomView.pcss

* Nesting: `mx_RoomView--local .mx_ScrollPanel`
2023-05-09 08:32:16 +00:00
Suguru Hirahara
556a36f7d5
Remove obsolete style blocks from _MemberInfo.pcss (#10816)
* Remove obsolete style blocks from _MemberInfo.pcss

Deprecated by 2b432b0d82

* Remove obsolete style blocks from _MemberInfo.pcss

Deprecated by fce36ec826
2023-05-09 08:22:40 +00:00
Michael Telatynski
f4f2cb19b7
Fix merge queue X-Needs-Percy handling (#10802) 2023-05-09 08:22:16 +00:00
Suguru Hirahara
a0228994dc
Remove unused class names from AppWarning (#10823) 2023-05-09 07:59:42 +00:00
Suguru Hirahara
ed5c02be6d
Fix long room address and name not being clipped on room info card and update _RoomSummaryCard.pcss (#10811)
* Handle a long room address and name with ellipsis on RoomSummaryCard

* Use a class selector for maintainability

Sort the selectors
2023-05-09 07:56:09 +00:00
Boluwatife Omosowon
739eec8555
Allows search to recognize full room links (#8275)
* fix matrix search link

* fix matrix search link

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* fix: allow full link search

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* fix: allow full link search on new search feature

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* improve transformSearchTerm function

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* improve transformSearchTerm function

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* add review changes

* Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

added review correction

changed the transformSearchTerm function to use parsePermaLink
removed extra spaces

* add angle brackets to copyright email title

* removed extra space

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>

* Update src/utils/SearchInput.ts

Co-authored-by: Travis Ralston <travpc@gmail.com>

* fixed spolight dialog search for room and user links

* added tests for transformSearchTerm

* removed transformSearchTerm from room search bar

* replaces two test cases to one that should return the primaryEntityId if the search term was a permalink

* corrected ts issues

* changed type of transformSearchTerm to string

* changed return value from empty string to the original search term if the primaryEntityId of the parsedLink is null

* changed return value from empty string to the original search term if the primaryEntityId of the parsedLink is null

* refactored transformSearchTerm and added a new test case

* rewrote transformSearchTerm doc

* changed mocked return values of test case - should return the original search term if the search term is a permalink and the primaryEntityId is null

* lint corrections

---------

Signed-off-by: Boluwatife Omosowon <boluomosowon@gmail.com>
Co-authored-by: Boluwatife Omosowon <boluwatifeomosowon@Jesus-Loves-You.local>
Co-authored-by: Travis Ralston <travpc@gmail.com>
2023-05-09 07:55:50 +00:00
Michael Telatynski
bf641d1823
Fix more detached DOM leaks (#10806) 2023-05-09 07:50:57 +00:00
Michael Telatynski
84786ad342
Null-guard sync handler in AutoRageshakeStore (#10805) 2023-05-09 07:50:46 +00:00
Michael Telatynski
3692de0460
Update finite automate to match user identifiers as per spec (#10798) 2023-05-09 07:46:19 +00:00