Commit graph

1387 commits

Author SHA1 Message Date
Suguru Hirahara
dbd9911fe7
Align EventTile_line with display name on message bubble (#8692) 2022-05-25 14:08:43 +00:00
Suguru Hirahara
90dfb8d61f
Move style rules related to ThreadPanel from EventTile (#8683)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 09:36:12 +02:00
Suguru Hirahara
03c2bdbde1
Remove ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text (#8678)
To respect the concept of cascading. Also using a mixin to unset the declarations can easily cause a style inconsistency.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 08:45:18 +02:00
Suguru Hirahara
8afb1abd36
Fix a grid blowout due to nowrap displayName on a bubble with UTD (#8688) 2022-05-25 06:50:36 +02:00
Suguru Hirahara
412c207b23
Apply the same max-width to image tile on the thread timeline as message bubble (#8669) 2022-05-25 06:31:39 +02:00
Suguru Hirahara
9f1bffcd34
Fix file button and audio player overflowing from message bubble (#8666)
* Fix file button and audio player overflowing from message bubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move '.mx_EventTile_image' to '.mx_EventTile_mediaLine'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use class names for now, adding a TODO comment

Remove unset as it is no longer required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-24 09:06:04 +02:00
Suguru Hirahara
ef977146c3
Prevent possible regressions of EventTile structurally (#8647)
* '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'

- Include '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'
- Merge '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* mx_EventTile_spoiler

- Group 'mx_EventTile_spoiler'
- mx_EventTile_spoiler.visible

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group 'mx_EventTile_button'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton' and '.mx_EventTile_expandButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_body .mx_EventTile_pre_container'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_copyButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_expandButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_copyButton' and '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include '.mx_EventTile_collapsedCodeBlock' in '.mx_EventTile_pre_container'

Collapsed code block is displayed only in mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_EventTile_keyRequestInfo

- Include '.mx_EventTile_keyRequestInfo_text' in '.mx_EventTile_keyRequestInfo'
- Include '.mx_AccessibleButton' in '.mx_EventTile_keyRequestInfo_text'
- Include '.mx_EventTile_keyRequestInfo_tooltip_contents p:first-child' and 'p:last-child' in '.mx_EventTile_keyRequestInfo_tooltip_contents p'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Separate properties of mx_EventTile_button

The properties which should only be applied to buttons inside mx_EventTile_pre_container should not be applied to the top level.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply mask-size of collapse button and expand button to ones in mx_EventTile_pre_container only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move declarations of buttons from mx_EventTile_button to mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move buttons declarations below mx_EventTile_button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include '.mx_EventTile_pre_container' in '.mx_EventTile_body .mx_EventTile_pre_container'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Specify width and height to only buttons in mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Dedupe 'mx_EventTile_e2eIcon' ::before

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Hide buttons in mx_EventTile_pre_container and show them on hover by default

Setting "visibility: hidden" to mx_EventTile_button can easily cause a regression. The declaration should be exclusively applied to buttons inside mx_EventTile_pre_container, and "visibility: visible" should be set to those buttons only.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant nestings for E2E icons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 21:16:50 +01:00
Suguru Hirahara
764b307e63
Edit properties and values of EventTile on ThreadView (#8638)
* Edit properties and values of EventTile on ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete order properties of EventTile on ThreadView

These values are no longer required as the reactions row is displayed under the message by default.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 11:11:55 +01:00
Suguru Hirahara
5446d5d6ba
Fix position of wide images on IRC / modern layout (#8667)
* Move declarations related to position from _MImageBody.scss to _EventTile.scss

These declarations should not be defined as default values as position depends on other factors such as layout, etc.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move min-height and min-width declarations from _MImageBody.scss to _EventTile.scss

Since min-height and min-width have been specified for bubble layout, the declarations have been expected to be applied to the other layouts.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply 'justify-content: center' to bubble layout only

'justify-content: center' was added for the bubble layout with 1436f23. It should not be applied to the other layouts.

In order to prevent an issue related to cascading from happening, 'justify-content: flex-start' is explicitly specified.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:02:13 +02:00
Suguru Hirahara
11cb48176e
Fix other user's displayName being wrapped on the bubble message layout (#8456) 2022-05-22 09:07:29 +02:00
Suguru Hirahara
6825b43f42
Set spacing declarations to elements in mx_EventTile_mediaLine (#8665) 2022-05-22 08:19:45 +02:00
Suguru Hirahara
23babbb8ab
Normalize inline spacing of image and file button on ThreadView (#8664) 2022-05-21 22:19:56 +02:00
Suguru Hirahara
30b03776b8
Align input area with event body's first letter in a thread on IRC/modern layout (#8636)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-20 10:14:37 +01:00
Suguru Hirahara
c715f72745
Remove obsolete declarations for buttons on EditMessageComposer on ThreadView (#8632)
Those declarations are no longer necessary to align the buttons with the right edge of the input area and background.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:22:42 +01:00
Suguru Hirahara
9b92eca73d
Organize rules of GenericEventListSummary on bubble layout (#8599)
* Organize - data-expanded=false

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Organize - data-expanded=true

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Organize - EventTile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Dedupe mx_GenericEventListSummary[data-layout=bubble]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:10:02 +01:00
Suguru Hirahara
bb46846981
Set common horizontal spacing rules for EventTile on the right panel (#8528)
* Remove an obsolete override against .mx_EventTile_line

- Move &[data-layout=bubble] under mx_ThreadView
- Use variables for .mx_NewRoomIntro
- Move the variable to BaseCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use --ThreadView_group_spacing-end variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply GenericEventListSummary rules to ThreadView only

This commit stops those declarations from being applied to TimelineCard, which is also applied with mx_ThreadPanel class name.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Nesting - mx_GenericEventListSummary:not([data-layout=bubble])

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:08:39 +01:00
Suguru Hirahara
8d59612c74
Merge styles of mx_EventTile_content for maintainability (#8605)
* Include mx_EventTile_edited in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_EventTile_pendingModeration in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules of mx_EventTile_edited and mx_EventTile_pendingModeration

Except "cursor: pointer" of mx_EventTile_edited

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include markdown-body in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'pre code' in 'pre'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content' in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content .markdown-body' header in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content .markdown-body' a, blockquote, and em in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a comment on selector 'code'

There is technically nothing wrong that a declaration for 'code' is inherited to 'pre code'.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:04:39 +01:00
Suguru Hirahara
9889aa0de2
Adjust EditMessageComposer style declarations (#8631) 2022-05-17 19:12:13 +02:00
Suguru Hirahara
6f851108be
Fix position of the message action bar on left side bubbles (#8398)
* Fix position of the message action bar on data-self=false bubble

- Fix position of the bar on GenericEventListSummary as well
- Override default value `right: 8px` of MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the right property to [data-self=true]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space for "React" and "Reply" buttons inside MessageActionBar on the left side bubble inside ThreadView

This commit removes space reserved for those buttons on deleted or "Unable to decrypt" message bubble inside ThreadView.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-16 15:44:05 +00:00
Šimon Brandner
fb30b67b14
Fix issues with the new topic dialog (#8608) 2022-05-16 14:10:00 +02:00
Suguru Hirahara
f54d54b3ff
Fix MessageTimestamp position next to redacted messages on IRC/modern layout (#8591) 2022-05-14 09:55:52 +02:00
Suguru Hirahara
1fc8009109
Fix padding of messages in threads (#8574)
* Apply the padding setting of EventTile_line of ThreadView to TimelineCard

Set 2px padding-top and padding-bottom property to EventTile_line on IRC/modern layout of TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

f

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move position property of mx_EventTile_e2eIcon from ThreadPanel to TimelineCard

The E2E icon is available only on TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-13 12:04:27 -06:00
Robin
46bdccea9d
Increase composer line height to avoid cutting off emoji (#8583) 2022-05-13 11:31:27 -04:00
Travis Ralston
bc0bfa6377
Iterate on search results for message bubbles (#7047)
* PSFD-455: Iterate on search results for message bubbles

Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*. 

There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity:
* Message bubbles have the wrong corners for the display format (pre-existing).
* The sender's own messages are missing avatars/names. This is just way too complex to fix.

**Requires https://github.com/matrix-org/matrix-js-sdk/pull/2004**

* Tweak opacity

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-13 15:20:43 +00:00
Germain
fdd5494402
Add dialog to navigate long room topics (#8517) 2022-05-13 08:55:10 +01:00
Michael Weimann
7ed3089434 Improve tooltip positioning
Signed-off-by: Michael Weimann <michaelw@matrix.org>
2022-05-12 14:05:55 +02:00
Šimon Brandner
1e73184b78
Improve message editing UI (#8483)
* Improve message editing UI

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Remove weird padding on bubble layout

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-05-12 12:27:06 +02:00
Suguru Hirahara
0951a766aa
Fix displaying hidden events on threads (#8555)
* Fix avatar size and style inheritances for hidden events in the thread view

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reset the comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Re-add padding-left override for bubble layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add a empty line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Adjust avatar and E2E icon position inside .mx_EventTile_info

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Update src/components/views/rooms/EventTile.tsx

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Align with mx_EventTile_line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Align mx_EventTile_line and avatar + E2E icon

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-12 08:04:54 +01:00
Suguru Hirahara
ac46e6319b
Hide the verification left stroke only on the thread list (#8525)
* Hide the verification left stroke only in the thread panel (ie. let it shown in a chat panel with a maximized widget)

Respect the original comment that the stroke should be hidden in the thread list (and in a thread as well).

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Display the left stroke inside a thread

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-11 10:56:58 +01:00
Suguru Hirahara
14127c777b
Align thread summary button with bubble messages on the left side (#8388)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-10 18:01:46 +01:00
Yaya Usman
7e21be06d0
Fixes suggested room not ellipsized on shrinking (#8536)
* fixes suggested room not ellipsized on shrinking

* style-lint check update
2022-05-09 12:04:44 +00:00
Suguru Hirahara
cd8bdc1f54
Add box-shadow to the reply preview on the main (left) panel only (#8397)
Remove the box-shadow from the preview on the (right) panel for threads and a chat with a maximized widget.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-09 06:35:17 +00:00
Suguru Hirahara
50a714de4a
Add margin-top to the location body which is a sibling of DisambiguatedProfile (#8523)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-09 06:33:34 +00:00
Suguru Hirahara
ed086b0608
Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout (#8529)
* Move line-height of .mx_EventTile_line from _GroupLayout.scss to _EventTile.scss

Specifying mx_EventTile_line's line-height in mx_GroupLayout is too strong for mx_GenericEventListSummary.

- Set line-height:1 to mx_RedactedBody inside mx_GenericEventListSummary on IRC/modern layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a variable to remove the comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readability

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-09 06:27:13 +00:00
Michael Weimann
7e63202f9a Replace compose context menu with IconizedContextMenu (#22046)
Signed-off-by: Michael Weimann <michaelw@matrix.org>
2022-05-07 20:19:08 +02:00
Suguru Hirahara
c86040b77a
Fix timestamp's position on the chat panel with a maximized widget in IRC layout (#8464)
Fix avatar's position on the chat panel with a maximized widget in IRC layout
Fix timestamp's position on Message Edits history modal window

Also:
- Align DisambiguatedProfile with reactions row and thread summary with a variable
- Add width property as default
- Use the global variable on _IRCLayout.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-07 03:07:51 +00:00
Suguru Hirahara
cce0833c21
Simplify ReplyPreview implementation (#8516)
- Use AccessibleButton for cancel button, following other cases on UI
- Use flexbox for RTL layout to remove clear: both

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-06 18:06:32 +00:00
Suguru Hirahara
4d5a063cda
Set max-width for thread summary on narrow message panel (#8520)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-06 17:56:22 +00:00
Šimon Brandner
b5ac9493dd
Improve pills (#6398) 2022-05-05 11:13:09 +02:00
Robin
658ff4dfe6
Iterate video room designs in labs (#8499)
* Remove blank header from video room view frame

* Add video room option to space context menu

* Remove duplicate tooltips from face piles

* Factor RoomInfoLine out of SpaceRoomView

* Factor RoomPreviewCard out of SpaceRoomView

* Adapt RoomPreviewCard for video rooms

* "New video room" → "Video room"

* Add comment about unused cases in RoomPreviewCard

* Make widgets in video rooms mutable again to de-risk future upgrades

* Ensure that the video channel exists when mounting VideoRoomView
2022-05-04 17:02:06 -04:00
Suguru Hirahara
f08f764f22
Specify position of DisambiguatedProfile inside a thread on bubble message layout (#8452) 2022-05-03 14:28:17 +01:00
Kerry
12af3038a8
fix message indent in thread view (#8462)
Signed-off-by: Kerry Archibald <kerrya@element.io>

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-03 13:51:50 +02:00
Suguru Hirahara
483112950d
Fix poll overflowing a reply tile on bubble message layout (#8459)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-02 08:36:59 +00:00
Suguru Hirahara
12e8534c2b
Implement improved spacing for the thread list and timeline (#8337)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-04-29 11:03:39 +00:00
Suguru Hirahara
565488a10a
Add margin to the location map inside ThreadView (#8442)
* Add margin to the location map inside ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove margin from location map inside a reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add margin to the location map error message inside ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add margin-top to the map inside a reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-29 08:29:18 +00:00
Suguru Hirahara
7a0b3079be
Fix event text overflow on bubble message layout (#8391)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-28 16:33:54 +00:00
Suguru Hirahara
7208953e5f
Disable the message action bar when hovering over the 1px border between threads in the threads list (#8429)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-28 16:06:56 +00:00
Janne Mareike Koschinski
6120adaedd
correctly align read receipts to state events in bubble layout (#8419) 2022-04-28 15:39:17 +02:00
Michael Telatynski
8baa46b0dd
Fix baseline misalignment of thread panel summary by deduplication (#8413) 2022-04-27 18:10:27 +01:00
Janne Mareike Koschinski
ee2ee3c08c
Implement new Read Receipt design (#8389)
* feat: introduce new alignment types for tooltip
* feat: introduce new hook for tooltips
* feat: allow using onFocus callback for RovingAccessibleButton
* feat: allow using custom class for ContextMenu
* feat: allow setting tab index for avatar
* refactor: move read receipts out of event tile
* feat: implement new read receipt design
* feat: update SentReceipt to match new read receipts as well
2022-04-22 17:09:44 +02:00