mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2024-12-16 10:12:05 +03:00
Code Issues Projects Releases Packages Wiki Activity
22102 commits 219 branches 562 tags 474 MiB
Commit graph

9745 commits

Author SHA1 Message Date
J. Ryan Stinnett
88f351d5ca Keep sign in button disabled on success 
This changes password login to keep the sign in button locked when proceeding
successfully to avoid the possibility of double device sign in.

Part of https://github.com/vector-im/riot-web/issues/12546
 2020-03-03 10:42:08 +00:00
Travis Ralston
d95f843cd0 Don't group blank membership changes 
We already drop noop membership changes when they don't make it into a MELS, so we just need to make the MELS aware enough to drop messages early that are noops.

Fixes https://github.com/vector-im/riot-web/issues/12575
 2020-03-02 17:52:20 -07:00
Mark Striemer
07348a65ad Include a mark as read X under the scroll to unread button 2020-03-02 13:59:14 -06:00
Travis Ralston
680beb858e
Merge pull request #4150 from matrix-org/travis/fix-cutoff 
Fix the last char of people's names being cut off in the invite dialog
 2020-03-02 09:59:51 -07:00
Michael Telatynski
f8045e428b riot-desktop open SSO in browser so user doesn't have to auth twice 2020-03-02 14:59:54 +00:00
Michael Telatynski
3ba86ee655
Merge pull request #4153 from matrix-org/t3chguy/alias_invalid_valid 
don't show "This alias is available to use" if the alias is invalid
 2020-03-02 10:59:42 +00:00
Michael Telatynski
8aaab0a3ba refactor to add Validation::final 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-29 01:00:57 +00:00
Michael Telatynski
dc3afb3e57
Merge pull request #4098 from aaronraimist/donottrack 
Don't ask to enable analytics when Do Not Track is enabled
 2020-02-29 00:55:36 +00:00
Aaron Raimist
3a7454a52f Use !== instead 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
 2020-02-28 18:37:55 -06:00
Michael Telatynski
3e85f65d9e Also skip alias availability check if alias looks invalid 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-29 00:36:01 +00:00
Michael Telatynski
86a1327259 don't show "This alias is available to use" if an alias is not provided 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-29 00:31:56 +00:00
Michael Telatynski
0c4897a875
Merge pull request #4152 from matrix-org/t3chguy/fix_mels 
Fix MELS not breaking on day boundaries regression
 2020-02-29 00:18:00 +00:00
Michael Telatynski
9ff053c5a9 Fix MELS not breaking on day boundaries regression 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-29 00:09:19 +00:00
Michael Telatynski
87e717cd39 Fix Quote on search results page 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-28 23:12:10 +00:00
Travis Ralston
7cfaa63aac Fix the last char of people's names being cut off in the invite dialog 
If someone named "TravisR" was being searched for with just "Travis", the last R in their name would be cut off because of the highlighting. Entering "TravisR" would restore it. Likewise, searching for "vis" would have done the same thing.
 2020-02-28 14:08:43 -07:00
Travis Ralston
6269780f4b Suggest the server's results as lower quality 
This is a quick win for fixing https://github.com/vector-im/riot-web/issues/12488 but might not be a long-term solution. Idea is to see how this feels and go from there, which may mean scoring the results again to filter them in or altering the debounce timers.
 2020-02-28 13:57:56 -07:00
Travis Ralston
a44d96bb77
Merge pull request #4144 from matrix-org/travis/error-handler-invite 
Ensure errors when creating a DM are raised to the user
 2020-02-28 11:04:27 -07:00
Travis Ralston
60e26db729
Merge pull request #3829 from Cadair/login_group 
Add a Login button to startAnyRegistrationFlow
 2020-02-28 10:35:49 -07:00
Michael Telatynski
70bc405b6f
Merge pull request #4145 from MarcoZehe/ImproveUserListA11y 
Hide user avatars from screen readers in group and room user lists.
 2020-02-28 12:04:55 +00:00
Michael Telatynski
48dc671bcb
Merge pull request #4085 from matrix-org/t3chguy/alpha_room_list 
Room List sorting algorithms
 2020-02-28 12:04:10 +00:00
Marco Zehe
f4937a81cf Fix formatting 
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
 2020-02-28 12:56:53 +01:00
Marco Zehe
41e3e266e4 Hide user avatars from screen readers in group and room user lists. 
Like in pill components, these only duplicate information for screen readers, so hide them.

Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
 2020-02-28 12:40:43 +01:00
Stuart Mumford
aec622d5d0
Apply suggestions from code review 
Co-Authored-By: Travis Ralston <travpc@gmail.com>
 2020-02-28 10:47:23 +00:00
Travis Ralston
46a6af0ad1 Ensure errors when creating a DM are raised to the user 
Fixes https://github.com/vector-im/riot-web/issues/12186

Note: this will still result in an empty room being created, but that's a Synapse issue and not something we can solve.
 2020-02-27 17:10:31 -07:00
Ben Parsons
c99db2c385 sanitise quotes 2020-02-27 18:54:11 +00:00
J. Ryan Stinnett
b6a21509d5 Ignore cursor jumping shortcuts with shift 
This tweaks the new cursor jumping shortcuts in the composer so that they only
activate without shift. When shift _is_ pressed, you want to extend the
selection instead of just moving.

Fixes https://github.com/vector-im/riot-web/issues/12549
 2020-02-27 16:09:52 +00:00
J. Ryan Stinnett
5325b5677f
Merge pull request #4142 from matrix-org/jryans/shift-composer-shortcut 
Ignore cursor jumping shortcuts with shift
 2020-02-27 16:09:20 +00:00
Bruno Windels
f45dd311f9
Merge pull request #4138 from matrix-org/bwindels/moreverifuifeedback 
add local echo for clicking 'start verification' button
 2020-02-27 15:56:19 +00:00
J. Ryan Stinnett
95bb6f0d76 Ignore cursor jumping shortcuts with shift 
This tweaks the new cursor jumping shortcuts in the composer so that they only
activate without shift. When shift _is_ pressed, you want to extend the
selection instead of just moving.

Fixes https://github.com/vector-im/riot-web/issues/12549
 2020-02-27 11:39:11 +00:00
Bruno Windels
400cb33247 put state declaration on top 2020-02-27 12:35:34 +01:00
Michael Telatynski
b3fbcd4521 Fix formatting buttons not marking the composer as modified 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-27 11:01:22 +00:00
Michael Telatynski
6a66c4162b Space preference sections out more significantly to make the section headers obvious 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-26 23:16:27 +00:00
Michael Telatynski
ed650d5b90 Move Room List preferences section to be first 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-26 23:07:43 +00:00
Michael Telatynski
3ad8b6e9cc Use RoomList.orderAlphabetically as the inverse of RoomList.orderByRecents for migration 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-26 23:05:08 +00:00
Michael Telatynski
a1908a208e Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into t3chguy/alpha_room_list 
 Conflicts:
	src/components/views/rooms/RoomList.js
	src/stores/RoomListStore.js
 2020-02-26 23:02:06 +00:00
Stuart Mumford
c96dd9715a
Fix no cancel button just for Registration 2020-02-26 21:56:01 +00:00
Stuart Mumford
5edb0ec912
Resolve correct screen not being shown after new registration 2020-02-26 21:55:09 +00:00
Stuart Mumford
e454d84e9d
Lint 
Signed-off-by: Stuart Mumford <stuart@cadair.com>
 2020-02-26 21:55:08 +00:00
Stuart Mumford
32eb2c13bf
Add support for specifying the screen after require_registration 
Also use it in start chat and join group

Signed-off-by: Stuart Mumford <stuart@cadair.com>
 2020-02-26 21:55:08 +00:00
Travis Ralston
3abd3137c7 Use the right function for creating binary verification QR codes 
`writeInt8` happened to work because the strings we're writing happen to fit within a single byte so the LSB doesn't matter. We actually want a 16 bit (2 byte) number in big-endian format.
 2020-02-26 13:37:34 -07:00
Travis Ralston
347f56b983 Ensure verification QR codes use the right buffer size 
The string length buffer only needs 2 bytes, not 4.
 2020-02-26 13:21:11 -07:00
Travis Ralston
49ec79515c
Merge pull request #4128 from matrix-org/travis/dont-prefix-length 
Don't prefix QR codes with the length of the static marker string
 2020-02-26 12:07:24 -07:00
Bruno Windels
50b64d8c55 add local echo for clicking 'start verification' button 2020-02-26 18:30:20 +01:00
Michael Telatynski
d5177ddc04
Merge pull request #4133 from matrix-org/t3chguy/pinned 
Fix message context menu breaking on invalid m.room.pinned_events event
 2020-02-26 11:36:46 +00:00
Michael Telatynski
9a1236a016 Fix message context menu breaking on invalid m.room.pinned_events event 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-26 10:40:33 +00:00
Travis Ralston
9be61497fb Handle errors when previewing rooms more safely 
Fixes https://github.com/vector-im/riot-web/issues/12500

See https://github.com/matrix-org/synapse/issues/6992 for additional context.
 2020-02-25 16:11:07 -07:00
Travis Ralston
b32fbcb64f Don't try to collapse zero events with a group 
Fixes https://github.com/vector-im/riot-web/issues/12423

When events are redacted they fail to make it into the Grouper because the `shouldAddEvent` check blocks them from entering. However, the grouper expects that when `getTiles()` is called that there's events to group and dutifully grabs some context from the array. Because JavaScript is the least helpful language, `myArray[-1]` returns `undefined` or `null` and thus you get `cannot read 'sender' of undefined`.

Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/4059
 2020-02-25 15:40:15 -07:00
Travis Ralston
30a0d88074 Don't print errors when the tab is used with no autocomplete present 
Fixes https://github.com/vector-im/riot-web/issues/12461

Not a release blocker because the error is caught, and is at the end of the function. Just log spam.
 2020-02-25 13:13:41 -07:00
Ben Parsons
566db6c406 link to matrix.org/security-disclosure-policy in help screen 2020-02-25 17:29:59 +00:00
J. Ryan Stinnett
1958dae519
Merge pull request #4124 from matrix-org/jryans/show-bootstrap-more 
Show both bootstrap and reset cross-signing where appropriate
 2020-02-25 17:29:31 +00:00
Bruno Windels
17d55abed7
Merge pull request #4126 from matrix-org/bwindels/verifuifeedbackonlag 
Improve UI feedback while waiting for network
 2020-02-25 17:08:06 +00:00
Travis Ralston
f6fdddb9ba Don't prefix QR codes with the length of the static marker string 
Fixes https://github.com/vector-im/riot-web/issues/12489
 2020-02-25 09:54:48 -07:00
Travis Ralston
6dcbed0320
Merge pull request #4123 from matrix-org/travis/invite-populate 
Ensure DMs tagged outside of account data work in the invite dialog
 2020-02-25 09:45:52 -07:00
Travis Ralston
7091e7a4af
Use the right keyword 2020-02-25 09:19:37 -07:00
Zoe
1d8756b95d text improvements 2020-02-25 15:40:06 +00:00
Bruno Windels
682781aa48 better word smithing 2020-02-25 13:27:59 +01:00
Bruno Windels
bd584ab236 from verification tile, also don't wait to show right panel 2020-02-25 13:27:19 +01:00
Bruno Windels
b0c87b0eaf UI spinner when clicking "they don't match" 2020-02-25 13:18:27 +01:00
Bruno Windels
2127edb7b8 show "Waiting for network" in EncryptionInfo after accepting in toast 2020-02-25 13:13:51 +01:00
Bruno Windels
569d5b6156 show right panel before waiting for .ready event to send 2020-02-25 13:13:31 +01:00
Zoe
9ed83b8648 Show a warning dialog when user indicates a new session wasn't them 2020-02-25 11:37:01 +00:00
J. Ryan Stinnett
12e8ad8f6b Show both bootstrap and reset cross-signing where appropriate 
For cases like having keys on your account but not on the current device, this
ensures we offer both bootstrap and reset as possible paths.
 2020-02-25 11:23:51 +00:00
Travis Ralston
866ed68615 Ensure DMs tagged outside of account data work in the invite dialog 
Fixes https://github.com/vector-im/riot-web/issues/12418

Includes a refactor so we don't need to litter the code with the same magic string for DM tags.
 2020-02-24 19:43:49 -07:00
Zoe
866fdd6185
Merge pull request #4120 from matrix-org/foldleft/cancel-events 
Show cancel events as hidden events if we wouldn't usually render them
 2020-02-24 17:02:11 +00:00
Travis Ralston
2cb699ae8b
Merge pull request #4033 from TestardR/feature/padLockInviteOnly 
Collapsed room list has unaligned room tiles #4030 version 2
 2020-02-24 09:59:26 -07:00
J. Ryan Stinnett
64dc776e43
Merge pull request #4118 from matrix-org/jryans/hs-xsign-check 
Check for cross-signing homeserver support
 2020-02-24 16:58:57 +00:00
Zoe
d01c58bd41 added comment 2020-02-24 16:54:10 +00:00
Zoe
91b85cd060 show cancel events as hidden events if we wouldn't usually render them 2020-02-24 16:51:06 +00:00
Travis Ralston
d2e7cc7f19 Merge branch 'develop' into feature/padLockInviteOnly 2020-02-24 09:50:06 -07:00
Bruno Windels
818156663a don't leak if show_sas never comes (or already came) 2020-02-24 17:00:55 +01:00
J. Ryan Stinnett
a71a234622 Check for cross-signing homeserver support 
This checks the homeserver to ensure it supports cross-signing (via the versions
feature flag) before attempting bootstrapping or offering user verification.

Fixes https://github.com/vector-im/riot-web/issues/11863
 2020-02-24 15:04:34 +00:00
Zoe
381cbbabb0
Merge pull request #4106 from matrix-org/foldleft/verification-devtool 
Add verification request viewer in devtools
 2020-02-24 14:34:45 +00:00
Zoe
f3ac3554a9 include observeOnly 2020-02-24 14:17:34 +00:00
Zoe
0d3d837871 useEventEmitter hook instead of manually using code 2020-02-24 13:44:04 +00:00
Bruno Windels
2b61988d30
Merge pull request #4117 from matrix-org/bwindels/fixinfinispinneronencryptioninfo 
update phase when request prop changes
 2020-02-24 13:39:51 +00:00
Michael Telatynski
72e5313a5a
Merge pull request #4113 from matrix-org/t3chguy/fix_downloading 
Handle file downloading locally in electron rather than sending to browser
 2020-02-24 13:37:16 +00:00
J. Ryan Stinnett
f80582a51d
Merge pull request #4116 from matrix-org/jryans/rm-cider-watcher 
Remove unused CIDER setting watcher
 2020-02-24 13:10:59 +00:00
Bruno Windels
2350d102e3 update phase when request prop changes 2020-02-24 13:39:20 +01:00
J. Ryan Stinnett
8e39bd8885 Remove unused CIDER setting watcher 
This setting watcher for CIDER seems unused and logs a warning at the moment, so
this change removes it.
 2020-02-24 12:36:25 +00:00
Bruno Windels
dc85346e5c
Merge pull request #4102 from matrix-org/bwindels/aliasautocomplete 
Use alt_aliases for pills and autocomplete
 2020-02-24 12:18:07 +00:00
J. Ryan Stinnett
c0c22ba7f9
Merge pull request #4108 from matrix-org/jryans/a11y-editor-keyboard 
Add shortcuts for beginning / end of composer
 2020-02-24 12:02:03 +00:00
Zoe
af514385b2 Avoid shadowing window.setTimeout 2020-02-24 11:53:12 +00:00
Zoe
71bdc5987b added clarifying comment 2020-02-24 11:33:49 +00:00
Zoe
0663ab3b87 lint, and detect new requests 2020-02-24 10:17:33 +00:00
Michael Telatynski
0bcdf062a3 reset opener when using window.open 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-23 22:22:12 +00:00
Michael Telatynski
b2c1242207 delint 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-23 22:19:18 +00:00
Michael Telatynski
d783ce86c8 Use noreferrer in addition to noopener for edge case browsers 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-23 22:14:29 +00:00
Michael Telatynski
d89b8b5148 Fix downloading files in electron not being sent into browser 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-23 22:10:36 +00:00
Michael Telatynski
3308152439 Fix a couple of React warnings/errors 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-23 14:10:41 +00:00
Matthew Hodgson
7696f704b2 Fix two big DOM leaks which were locking Chrome solid. 
pillifyLinks leaked Pill components, which if they contained a BaseAvatar
would leak a whole DOM tree retained by the BaseAvatar's onClientSync
event listener.  This tracks the Pill containers so they can be unmounted
via unmountPills.

BasicMessageComposer set an event listener on selectionchange in onFocus
which leaked if onBlur wasn't called.  This removes it in unmount.

We've also seen Velociraptor retaining full DOM trees from RRs, which
this doesn't address as the leak is probably within Velocity, and the plan
is to replace it with CSS animations.

Should fix https://github.com/vector-im/riot-web/issues/12417
 2020-02-22 23:51:30 +00:00
Travis Ralston
c906b9eccf Filter out empty strings when pasting IDs into the invite dialog 
Fixes https://github.com/vector-im/riot-web/issues/12459
 2020-02-21 13:26:37 -07:00
J. Ryan Stinnett
dc6a4854ce Add shortcuts for beginning / end of composer 
This adds Ctrl/Command+Home/End shortcuts for jumping to the start and end of
the composer contents.

Fixes https://github.com/vector-im/riot-web/issues/12438
 2020-02-21 18:50:44 +00:00
Zoe
72789897a0 Quick n dirty verificatio request viewer in devtools 2020-02-21 17:15:53 +00:00
Travis Ralston
f74b283287
Merge pull request #4091 from matrix-org/travis/qr-binary 
Use binary packing for verification QR codes
 2020-02-21 10:05:12 -07:00
Travis Ralston
4de2fdc5c3
Merge pull request #4099 from matrix-org/travis/invite-fixes 
Fix several small bugs with the invite/DM dialog
 2020-02-21 09:24:53 -07:00
Michael Telatynski
4ed4d91b48 move to a more reusable code path 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-21 14:54:56 +00:00
Michael Telatynski
b77c2df2be Fix theme being overridden to light even after login is completed 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-02-21 14:40:42 +00:00
Bruno Windels
07d24038a3 fix lint 2020-02-21 14:11:30 +01:00
Bruno Windels
fada013f9e this isn't doing anything because we don't have a room when the alias is not moderated 2020-02-21 14:06:57 +01:00
Bruno Windels
3c3839f863 show a pill as a moderated alias (canonical or alt) if available 
otherwise, display as the label in the link
 2020-02-21 13:02:41 +01:00