Michael Telatynski
7a936798b9
Fix invalid commands when figuring out whether to send typing notification
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-11 16:42:14 +01:00
Michael Telatynski
c000583099
Merge pull request #4384 from matrix-org/t3chguy/composer_pills
...
Composer pills respect showPillAvatar setting
2020-04-10 16:45:46 +01:00
Michael Telatynski
caf0b25bd0
Only send typing notification when composing commands which send messages
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-10 13:59:01 +01:00
Michael Telatynski
740b6f6cac
Composer pills respect showPillAvatar setting
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-10 09:34:38 +01:00
Michael Telatynski
4447370764
Fix composer placeholder not updating
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-08 10:19:52 +01:00
JungEon Kim
94236de637
Fix Hangul typing does not work properly
...
compositionstart event may fire in the meantime because
compositionend event is being processed asynchronously.
Signed-off-by: JungEon Kim <me@jungeon.kim>
2020-04-03 20:43:34 +09:00
Travis Ralston
c5cf04f6d2
More appeasing of the linter
2020-04-01 16:25:59 -06:00
Travis Ralston
8e405dda2e
Fix soft crash when editing message
...
Fixes https://github.com/matrix-org/riot-web-rageshakes/issues/2504
2020-04-01 16:22:42 -06:00
thobyv-kismat
1713006958
recommit bwindels commited changes to refactor check logic after rebase mistake
2020-03-26 14:03:38 +01:00
thobyv-kismat
2bd112ca7c
add delete support and to keyboard shortcuts
2020-03-26 12:40:31 +01:00
thobyv-kismat
c95b23f3ec
fix formatBar not hidden after highlight-backspacing text partially
2020-03-26 12:40:31 +01:00
thobyv-kismat
b817c06c6e
fix failing linter tests
2020-03-24 19:09:50 +01:00
thobyv-kismat
91b9a04ede
refactor:consider checking if no placeholder
2020-03-24 19:00:43 +01:00
thobyv-kismat
d7953dfa6d
fix formatbar not hidden on highlighted message sent
2020-03-24 13:09:06 +01:00
Aaron Raimist
038888f2d4
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into mac-redo
2020-03-17 13:52:43 -05:00
Aaron Raimist
84a8ca6982
Fix typo
...
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2020-03-17 13:18:27 -05:00
J. Ryan Stinnett
5325b5677f
Merge pull request #4142 from matrix-org/jryans/shift-composer-shortcut
...
Ignore cursor jumping shortcuts with shift
2020-02-27 16:09:20 +00:00
J. Ryan Stinnett
95bb6f0d76
Ignore cursor jumping shortcuts with shift
...
This tweaks the new cursor jumping shortcuts in the composer so that they only
activate without shift. When shift _is_ pressed, you want to extend the
selection instead of just moving.
Fixes https://github.com/vector-im/riot-web/issues/12549
2020-02-27 11:39:11 +00:00
Michael Telatynski
b3fbcd4521
Fix formatting buttons not marking the composer as modified
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-27 11:01:22 +00:00
Travis Ralston
30a0d88074
Don't print errors when the tab is used with no autocomplete present
...
Fixes https://github.com/vector-im/riot-web/issues/12461
Not a release blocker because the error is caught, and is at the end of the function. Just log spam.
2020-02-25 13:13:41 -07:00
Aaron Raimist
550ee216c6
Apply suggestions from code review
...
Co-Authored-By: David Baker <dbkr@users.noreply.github.com>
2020-02-24 18:22:07 -06:00
J. Ryan Stinnett
c0c22ba7f9
Merge pull request #4108 from matrix-org/jryans/a11y-editor-keyboard
...
Add shortcuts for beginning / end of composer
2020-02-24 12:02:03 +00:00
Matthew Hodgson
7696f704b2
Fix two big DOM leaks which were locking Chrome solid.
...
pillifyLinks leaked Pill components, which if they contained a BaseAvatar
would leak a whole DOM tree retained by the BaseAvatar's onClientSync
event listener. This tracks the Pill containers so they can be unmounted
via unmountPills.
BasicMessageComposer set an event listener on selectionchange in onFocus
which leaked if onBlur wasn't called. This removes it in unmount.
We've also seen Velociraptor retaining full DOM trees from RRs, which
this doesn't address as the leak is probably within Velocity, and the plan
is to replace it with CSS animations.
Should fix https://github.com/vector-im/riot-web/issues/12417
2020-02-22 23:51:30 +00:00
Aaron Raimist
42c6818f95
Remove debugger;
...
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2020-02-21 22:00:00 -06:00
Aaron Raimist
d3367834d0
Fix redo keyboard shortcut on macOS
...
I added the correct macOS shortcut for redo which is Cmd+Shift+Z. I had to reorder the if statement so redo is checked first, otherwise it would detect the undo first and never check that I was actually trying to redo.
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2020-02-21 21:56:58 -06:00
J. Ryan Stinnett
dc6a4854ce
Add shortcuts for beginning / end of composer
...
This adds Ctrl/Command+Home/End shortcuts for jumping to the start and end of
the composer contents.
Fixes https://github.com/vector-im/riot-web/issues/12438
2020-02-21 18:50:44 +00:00
Michael Telatynski
52ed55d887
Update placeholder when it changes, not sure how this ever worked
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-01-30 00:23:19 +00:00
Travis Ralston
915c4efeac
Ensure a plaintext version of the composer ends up on the clipboard
...
Fixes https://github.com/vector-im/riot-web/issues/12018
2020-01-23 15:53:32 -07:00
Michael Telatynski
26bba4416b
Fix emoticon space completion for upper case emoticons like :D xD
2020-01-21 10:12:23 +00:00
David Baker
277f107924
Set flag before mutating on cut too
2020-01-20 13:03:09 +00:00
David Baker
2ed5d89c9f
Fix arrows keys moving through edit history
...
Different fix that fixes https://github.com/vector-im/riot-web/issues/11817
by setting the flag before the callback rather than having the update
method set the flag.
Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/3842
Fixes https://github.com/vector-im/riot-web/issues/11917
2020-01-20 12:20:21 +00:00
Travis Ralston
43f97af805
Merge pull request #3848 from matrix-org/travis/fix-cut
...
Remove all text when cutting in the composer
2020-01-16 15:03:41 -07:00
Travis Ralston
4ea2a2fee4
Merge branch 'develop' into t3chguy/fix_isModified
2020-01-16 09:46:28 -07:00
Travis Ralston
b137cd21d3
Replace the selected range instead of force-setting it
...
This gives people the option of cutting parts or all of their message.
2020-01-15 21:04:18 -07:00
Travis Ralston
be3ef2b50e
Remove all text when cutting in the composer
...
The previous function did in fact remove the elements, but left the model thinking there was a zero-length string. This approach deletes the text from the model and the DOM, resulting in the placeholder being shown when cutting all the text.
Part of https://github.com/vector-im/riot-web/issues/11378
2020-01-15 19:08:14 -07:00
Travis Ralston
cad9562f8d
Merge pull request #3828 from krkc/develop
...
Added cut/copy and pasting user pills from editor.
2020-01-15 15:36:33 -07:00
Michael Telatynski
d37c19d785
Fix timing of when Composer considers itself to be modified
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-01-15 00:27:54 +00:00
Christopher
59ea865e8e
Added missing semicolon.
2020-01-13 14:29:42 +00:00
Christopher
c370b28694
#11378 . Added cut/copy and pasting user pills from editor.
2020-01-12 16:19:24 +00:00
Travis Ralston
fde32f13a5
[CONFLICT CHUNKS] Merge branch 'develop' into travis/sourcemaps-develop
2020-01-09 14:15:09 -07:00
Travis Ralston
d56f0f2a25
Convert many imports to handle ES6 exports
...
Reliant upon https://github.com/matrix-org/matrix-react-sdk/pull/3761
2019-12-22 21:04:42 -07:00
Michael Telatynski
24d0d0d596
Merge pull request #3743 from matrix-org/t3chguy/react16_contexts
...
Migrate away from React Legacy contexts API
2019-12-19 20:32:11 +00:00
Michael Telatynski
d35b01b63a
Get rid of stripped-emoji.json in favour of an in-memory single truth source
2019-12-18 15:40:19 +00:00
Michael Telatynski
937b32663c
Migrate away from Legacy React Contexts
2019-12-17 17:26:12 +00:00
sha-265
bc924bbd82
Support RTL language in message composer
2019-11-04 17:37:36 +00:00
Michael Telatynski
5643743167
Don't intercept TAB on the app outside of the composer, fix tabIndex > 0
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-10-10 14:13:29 +01:00
Michael Telatynski
58317b1608
Use Keyboard Key variables instead of hardcoded strings
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-10-09 19:59:11 +01:00
Bruno Windels
91d593cb71
watch emoticon autoreplace setting
2019-10-08 14:40:10 +02:00
Michael Telatynski
f160a308b4
Make Autocomplete more accessible to screen reader users
...
Use ARIA to:
+ notate that the composer has an autocomplete
+ notate the open/closed state of the autocomplete
+ notate the name of the open autocomplete options
+ notate the ID of the highlighted autocomplete option
+ improve naming of emoji autocomplete options for screen readers
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-09-30 14:04:39 +01:00
Bruno Windels
8301943cfa
Merge pull request #3481 from matrix-org/bwindels/cider-ac-shifttab
...
Fix: don't block Shift+Tab in CIDER autocomplete
2019-09-26 15:08:36 +00:00