Commit graph

4626 commits

Author SHA1 Message Date
Janne Mareike Koschinski
57dff8131c
Prevent new composer from overflowing from non-breakable text (#8829) 2022-06-13 13:05:41 +02:00
Suguru Hirahara
cda18a3dfb
Improve CSS rules of zoom buttons on live location (#8728)
* Use flex to stop redundant margin-top from appearing

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove ButtonResetDefault which resets nothing

It should be avoided to use ButtonResetDefault where there is nothing to be reset, in order to prevent resources from being wasted.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Ensure that unexpected regressions will never happen on the buttons and their icons

Rules can be extracted when needed. Until then there is no point of exposing elements to possible regressions, which could easily happen on the current architecture.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use SASS variables and remove a redundant declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-13 09:23:49 +02:00
Suguru Hirahara
68ce7bf35e
Remove an obsolete style declaration of .mx_ReplyChain_show (#8743)
It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163

It has not been effective for unknown period, and since the layout of the area has changed, it should be able to be safely removed.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-13 09:17:48 +02:00
Suguru Hirahara
18d7f7c525
Use mx_SettingsTab_subsectionText for the text under the top header of appearance user settings tab (#8822) 2022-06-12 14:52:55 +00:00
Suguru Hirahara
d1d4cc42bc
Use common subheading on sidebar user settings tab (#8823) 2022-06-12 15:12:34 +02:00
Suguru Hirahara
6b40c0b2e3
Tidy _AppearanceUserSettingsTab.scss (#8824) 2022-06-12 15:11:33 +02:00
Suguru Hirahara
89743c9321
Fix clickable area of advanced toggle on appearance user settings tab (#8820) 2022-06-12 13:13:41 +02:00
Šimon Brandner
9b8b1d193e
Disable redacting reactions if we don't have sufficient permissions (#8767) 2022-06-10 18:41:05 +00:00
Suguru Hirahara
1b7e9d95da
Fix flex blowout on image reply (#8809)
* Set min-width to prevent a flex blowout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a native spacing property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set max-width: 100% to display name inside the image reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-10 12:36:17 +01:00
Suguru Hirahara
0d3fe300aa
Enable background color on hover for chat panel and thread panel (#8644)
* Enable background color on hover for chat panel and thread panel

- Display reactions row on hover
- Use variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace --BaseCard_EventTile-spacing-horizontal with --BaseCard_EventTile-spacing-inline

- horizontal: inline
- vertical: block

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* mx_EventTile.mx_EventTile_bad[data-layout=bubble] seems to require bubble layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-10 10:21:22 +02:00
Robin
8e9f7407e9
Allow AppTiles to shrink as much as necessary (#8805) 2022-06-09 13:30:58 -04:00
Robin
30460943b2
Release video rooms as a beta feature (#8431)
* Remove blank header from video room view frame

* Add a beta card for video rooms

* Rename the 'disclaimer' on beta cards to 'FAQ'

Because that's what the section actually gets used as

* Add beta pills to video room creation buttons

* Remove duplicate tooltips from face piles

* Add beta pill to headers of video rooms

* Factor RoomInfoLine out of SpaceRoomView

* Factor RoomPreviewCard out of SpaceRoomView

* Adapt RoomPreviewCard for video rooms

* "New video room" → "Video room"

* Add comment about unused cases in RoomPreviewCard

* Add types

* Clarify !important comments

* Add a reload warning

* Fix the reload warning being the wrong way around

* Fix lints

* Make widgets in video rooms mutable again to de-risk future upgrades

* Ensure that the video channel exists when mounting VideoRoomView

* Fix lint

* Iterate beta reload warning
2022-06-09 13:07:59 -04:00
Robin
d9396b0b54
Expire video member events after 1 hour (#8776)
* Expire video member events after 1 hour

* Iterate based on feedback

* Validate the types of video member events better

* Even more parentheses
2022-06-09 13:19:52 +00:00
Suguru Hirahara
12dd5a7ef0
Name lists on invite dialog (#8046)
* Place room tiles with grid

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set padding inside of name stack

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove overflow:hidden (to be cancelled)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace text-align with margin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Style invite failure dialog with display:grid

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules of room tiles and tiles on invitation failure dialog

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize avatar size for multiInviterError

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set text overflow with ellipsis

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set narrow gap to nameStack

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Rename mx_InviteDialog_inviterErrorTile_error

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Create mx_InviteDialog_tile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set padding to room tiles only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space between name / userID and time (there is gap by default)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove the margin from the last child

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-09 13:45:33 +01:00
Suguru Hirahara
67cace7de7
Move style rules for EventTile on ThreadView from _ThreadPanel.scss to _EventTile.scss (#8689) 2022-06-09 13:31:38 +01:00
Germain
5167521ea4
Fix scroll jump issue with the composer (#8791) 2022-06-08 15:02:15 +01:00
Germain
f568a76dc6
Fix scroll jump issue with the composer (#8788) 2022-06-08 13:29:16 +01:00
Suguru Hirahara
c304e3da51
Fix the incorrect nesting of MessageActionBar (#8785)
mx_MessageActionBar_downloadSpinnerButton::after

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 13:16:24 +02:00
Suguru Hirahara
36f2f3e2ce
Use MessageActionBar style declarations on pinned message card (#8757)
* Refer mx_MessageActionBar on pinned messages card

Normalize mx_MessageActionBar style rules

- Allow the varaible (--MessageActionBar-size-button) to be used
- Remove redundant declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for normalization

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set class name

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readd the comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use Heading size='h4'

- Use size='h4' instead of 'h2' as 15px has been specified as the font-size of the header
- Use logical values following _Heading.scss
- Remove line-height declaration in favor of the default value

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 12:52:25 +02:00
Suguru Hirahara
c016815562
Normalize the name of buttons on MessageActionBar (#8781)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 10:53:58 +01:00
Germain
aedbeb2995
Revert link color change in composer (#8784) 2022-06-08 09:11:14 +00:00
Suguru Hirahara
66daaf0748
Force style rules of buttons on MessageActionBar used with maskButton selector (#8780)
* Include mx_MessageActionBar_maskButton::after in mx_MessageActionBar_maskButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_MessageActionBar_maskButton:hover::after in mx_MessageActionBar_maskButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Ensure buttons on message action bar used only with mx_MessageActionBar_maskButton as expected

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_Indicator in mx_MessageActionBar_threadButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_MessageActionBar_downloadButton.mx_MessageActionBar_downloadSpinnerButton in mx_MessageActionBar_downloadButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 11:08:49 +02:00
Suguru Hirahara
8362174039
Improve style of DialogSidebar (of live location map) (#8760) 2022-06-08 09:38:20 +01:00
Suguru Hirahara
46f07a8edb
Organize style rules of ThreadPanel header (#8672)
* Move declarations for ThreadPanel_dropdown to '.ThreadPanel__header'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move declarations under '.mx_ThreadPanel_dropdown'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move '~ .mx_ThreadPanel__header'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move '.mx_ThreadPanel__header' under '.mx_BaseCard_header'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables for dropdown

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run link:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 10:22:43 +02:00
Johannes Marbach
abd39c61b1
Add support for MD / HTML in room topics (#8215)
* Add support for MD / HTML in room topics

Setting MD / HTML supported:
- /topic command
- Room settings overlay
- Space settings overlay

Display of MD / HTML supported:
- /topic command
- Room header
- Space home

Based on extensible events as defined in [MSC1767]

Fixes: vector-im/element-web#5180
Signed-off-by: Johannes Marbach <johannesm@element.io>

[MSC1767]: matrix-org/matrix-spec-proposals#1767

* Fix build error

* Add comment to explain origin of styles

Co-authored-by: Travis Ralston <travpc@gmail.com>

* Empty commit to retrigger build

* Fix import grouping

* Fix useTopic test

* Add tests for HtmlUtils

* Add slash command test

* Add further serialize test

* Fix ternary formatting

Co-authored-by: Travis Ralston <travpc@gmail.com>

* Add blank line

Co-authored-by: Travis Ralston <travpc@gmail.com>

* Properly mock SettingsStore access

* Remove trailing space

* Assert on HTML content and add test for plain text in HTML parameter

* Appease the linter

* Fix JSDoc comment

* Fix toEqual call formatting

* Repurpose test for literal HTML case

* Empty commit to fix CI

Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-06-07 14:20:32 -06:00
Suguru Hirahara
3a20cb1703
Improve style rules of threads list (#8706)
* Remove obsolete declarations - border-radius of EventTile_line

The border-radius is specified with .mx_EventTile[data-shape="ThreadsList"]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move declarations for ThreadSummary on Threadslist from _ThreadsPanel.scss to _EventTile.scss

To .mx_EventTile[data-shape=ThreadsList]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* mx_ThreadPanel_replies block is used only on threads list after all

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* &::after and &::before

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set shorthand property and use variables

- Shorthand for inset property of border between threads
- Use variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Change 'ThreadPanel_ThreadsAmount' class name to 'ThreadPanel_replies_amount'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* specific to prevent regressions

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-07 14:55:11 +01:00
Kerry
56b0b79fb7
Live location share - link to timeline tile from share warning (PSF-1078) (#8752)
* navigate to live location tile from left panel live warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* navigate to beacon tile from room live share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add cursor

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-06-07 10:15:09 +00:00
Germain
f14374a51c
Improve composer visiblity (#8578)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-06-07 07:28:29 +00:00
Šimon Brandner
8c13a0f8d4
Slightly improve the look of the Message edits dialog (#8763)
* Improve the look of the `Message edits` dialog

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Left-align title

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-06-07 07:00:27 +02:00
Germain
d388ef0e96
Reduce gutter with the new read receipt UI (#8736) 2022-06-06 10:14:38 +01:00
Suguru Hirahara
a6da89481c
Makes the avatar of the user menu non-draggable (#8765) 2022-06-06 04:25:19 +00:00
Suguru Hirahara
5ca035772d
Remove ListResetDefault (#8769) 2022-06-05 18:44:23 +00:00
Suguru Hirahara
41ee47f8c4
Tidy up mx_InviteDialog_dialPad style rules (#8762) 2022-06-05 14:31:13 +00:00
Suguru Hirahara
022535e389
Remove unnecessary ButtonResetDefault from mx_LeftPanelLiveShareWarning (#8761) 2022-06-05 13:38:57 +00:00
Suguru Hirahara
4b5816f5c1
Make the pill on the basic message composer compatible with display name in RTL languages (#8758) 2022-06-05 15:22:44 +02:00
Suguru Hirahara
dc1f53b6e9
Prevent the banner text from being selected, replacing the spacing values with the variable (#8756) 2022-06-05 08:30:29 +02:00
Suguru Hirahara
323e911fe7
Add ellipsis effect to hidden beacon status (#8755) 2022-06-05 05:40:17 +00:00
Suguru Hirahara
ef6bd3540d
Revert "Move style rules of MatrixChat_useCompactLayout from _GroupLayout.scss to _EventTile.scss and _RoomView.scss (#8725)" (#8751)
This reverts commit 228abb6f07.
2022-06-03 12:22:13 +02:00
Michael Weimann
3174cf2606
Improve widget buttons behaviour and layout (#8734)
* Improve widet buttons behaviour and layout

Relates to vector-im/element-web#20506
See PSC-79

Signed-off-by: Michael Weimann <michaelw@matrix.org>

* Add AppTile tests
2022-06-03 12:00:16 +02:00
Suguru Hirahara
228abb6f07
Move style rules of MatrixChat_useCompactLayout from _GroupLayout.scss to _EventTile.scss and _RoomView.scss (#8725)
* Move mx_RoomView_MessageList h2 block from _GroupLayout.scss to _RoomView.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move mx_MatrixChat_useCompactLayout block from _GroupLayout.scss to _EventTile.scss

This block is not related to the group layout.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include EventTile_continuation block in EventTile_emote

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use logical properties for the padding values

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Sort declarations for maintainability

- EventTile_avatar
- EventTile_line
- EventTile_reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Separate selectors of .markdown-body

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-03 08:45:10 +02:00
Suguru Hirahara
b5ed051ecc
Use AccessibleButton for 'Reset All' link button on SetupEncryptionBody (#8730)
- Remove ButtonResetDefault to respect the concept of cascading

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-03 08:07:18 +02:00
Suguru Hirahara
54239464fa
Make sure MessageTimestamp is not hidden by EventTile_line (#8748)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 22:38:39 -04:00
Suguru Hirahara
68bc8112b3
Adjust message timestamp position on TimelineCard in non-bubble layouts (#8745) 2022-06-02 19:26:48 +02:00
Kerry
79a2dfe171
Live location share - enable reply and react to tiles (#8721)
* test most basic paths in messageactionbar

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tidy

Signed-off-by: Kerry Archibald <kerrya@element.io>

* use rtl for MessageActionBar test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* make beacon_info events semi actionable

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove log

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test thread exception for beacon

Signed-off-by: Kerry Archibald <kerrya@element.io>

* eat click events in beacon status to stop jumping from reply tile

Signed-off-by: Kerry Archibald <kerrya@element.io>

* set max width on beaconbody for render in thread panel
2022-06-02 15:43:19 +00:00
Janne Mareike Koschinski
a74b9a7083
Prevent Invite and DevTools dialogs from being cut off (#8646)
* fix: replace fixed height based styling with flex for invite and dev dialogs
* feat: create flex wrapper class for dialogs
* feat: make invite dialogs use flex layout
* feat: make devtools dialogs use flex layout
2022-06-02 15:59:40 +02:00
Robin
4b957b57af
Squish event bubble tiles less (#8740) 2022-06-02 09:10:41 -04:00
Suguru Hirahara
abfc66a34e
Improve _ShareType.scss (#8737)
* Specify the button style explicitly removing the dependency on the mixin

The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove element='button' from AccessibleButton

Since AccessibleButton has role='button' by default, setting the element button property is redundant.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Protect mx_ShareType_option from being regressed structurally

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Wrap buttons with declarations for spacing

box-sizing is not required for the buttons or the wrapper.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* fix eslint errors

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix LocationShareMenu-test.tsx

AccessibleButton is div by default

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reflect the review

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Remove element='button' from AccessibleButton"

This reverts commit af78d2713f6b4fca9405498e0090db1e6218ff1b.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Fix LocationShareMenu-test.tsx"

This reverts commit 7d783a733ec84af6453b2359b2d00443fcece2ef.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 14:18:26 +02:00
Suguru Hirahara
7c57680b93
Fix read avatars overflow from the right chat panel with a maximized widget on bubble message layout (#8470)
* Fix RR overflow on the right chat panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Align with RR outside of info tile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use inset-inline property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 02:43:07 +00:00
Suguru Hirahara
b12a272385
Use AccessibleButton for 'In reply to' link button on ReplyChain (#8726)
- Remove ButtonResetDefault mixin to respect the concept of cascading

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-31 15:52:12 -06:00
Suguru Hirahara
bae8854c13
Remove inline margin from UTD error message inside a reply tile on ThreadView (#8708)
* Remove inline margin from UTD error message inside a reply tile on ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge 'mx_ReplyChain_wrapper' blocks

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-30 08:55:12 +02:00