Travis Ralston
0fcbe40bec
Merge pull request #4314 from matrix-org/travis/react-warnings/2-code-quality
...
Fix a number of minor code quality issues
2020-04-01 11:13:46 -06:00
Travis Ralston
59a99bbad8
Merge pull request #4313 from matrix-org/travis/react-warnings/1-componentDidMount
...
Use componentDidMount in place of componentWillMount where possible
2020-04-01 11:13:04 -06:00
David Baker
8aa24f8987
Fix jitsi popout URL
...
Needs the template variables filled in
2020-04-01 14:42:17 +01:00
David Baker
ce68b960f4
Use our own jitsi widget for the popout URL
...
rather than the URL supplied by the widget
2020-04-01 13:58:44 +01:00
David Baker
a76b089cf3
Merge pull request #4319 from matrix-org/dbkr/jitsi_fix_popout
...
Fix popout support for jitsi widgets
2020-04-01 11:57:25 +01:00
David Baker
9b4ce02eaf
lint
2020-04-01 11:28:02 +01:00
David Baker
a2f92e93a7
Use URL without wurl params for popout
...
The popout can't be assumed to have the widget API available, so
just leave these params out.
2020-04-01 11:18:45 +01:00
David Baker
538147f7fa
Better support for widgets overriding their URLs
...
Move the URL processing into AppTile so that the widget can have a
URL used for embedding in the page and a separate one for popping
out into a browser.
2020-04-01 10:00:33 +01:00
Travis Ralston
6d0d77f98e
Disable the linter on lines it complaints about UNSAFE_componentWillMount
2020-03-31 14:21:12 -06:00
Travis Ralston
0a6f54da33
Label and use UNSAFE_componentWillMount to minimize warnings
...
These TODO comments are expected to be fixed ASAP, but until that happens let's minimize the errors in the console for development.
For https://github.com/vector-im/riot-web/issues/12877
These all aren't using componentDidMount because they do something which causes application instability if componentDidMount were used. Much of these calls are expected to move into constructors once they are converted to real classes.
2020-03-31 14:15:23 -06:00
Travis Ralston
3f99332f4b
Use componentDidMount in place of componentWillMount where possible
...
This fixes a common React warning we see. Most of these components should be using constructors instead, however componentDidMount is just as good (and doesn't require converting most of these).
Conversion to classes will be done in a later stage of React warning fixes.
For https://github.com/vector-im/riot-web/issues/12877
2020-03-31 14:14:17 -06:00
Travis Ralston
c86d75693b
Fix a number of minor code quality issues
...
Most of these are complaints from my IDE. Discovered by going through nearly every file looking for React warnings.
2020-03-31 14:05:56 -06:00
Michael Telatynski
c094afbbe6
Merge pull request #4295 from matrix-org/t3chguy/a11y2
...
Accessibility fixed for Event List Summary and Composer Format Bar
2020-03-31 09:41:20 +01:00
Michael Telatynski
147e7bc57e
Field: mark id as optional in propTypes
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-30 18:42:47 +01:00
Michael Telatynski
55c2d98571
Fix Field ctor
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-29 23:16:57 +01:00
Michael Telatynski
19aae087e0
Field: make id optional, generate one if not provided
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-29 22:59:15 +01:00
Michael Telatynski
2ff16844e5
Make ELS somewhat more accessible
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-29 20:12:10 +01:00
Travis Ralston
bdcb65de77
Support and send the config over to capable widgets
...
For https://github.com/vector-im/riot-web/pull/12845
2020-03-24 09:55:54 -06:00
Travis Ralston
9da57817d1
Use a local wrapper for Jitsi calls
...
Requires https://github.com/vector-im/riot-web/pull/12780
2020-03-18 15:50:12 -06:00
Michael Telatynski
42ee157645
Merge pull request #4217 from matrix-org/t3chguy/gemini
...
Remove Gemini Scrollbars
2020-03-18 14:03:51 +00:00
Michael Telatynski
44b0aa2d88
Remove remainders of gemini-scrollbar and react-gemini-scrollbar
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-17 10:31:45 +00:00
Bruno Windels
db10fcd2b7
make editable list look like something closer to design
2020-03-16 17:29:35 +01:00
Bruno Windels
053ba1110a
make pressing enter not reload riot when editable list is in form
2020-03-09 16:32:31 +01:00
Bruno Windels
eb539537f2
add recommendations for alt aliases
2020-03-09 16:31:07 +01:00
RiotRobot
1d4f77dacc
Merge branch 'master' into develop
2020-03-04 11:40:35 +00:00
Travis Ralston
846170b371
Revert "Fix downloading files in electron not being sent into browser"
...
This reverts commit d89b8b5148
.
2020-03-03 13:33:07 -07:00
Michael Telatynski
f8045e428b
riot-desktop open SSO in browser so user doesn't have to auth twice
2020-03-02 14:59:54 +00:00
Michael Telatynski
8aaab0a3ba
refactor to add Validation::final
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-29 01:00:57 +00:00
Michael Telatynski
3e85f65d9e
Also skip alias availability check if alias looks invalid
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-29 00:36:01 +00:00
Michael Telatynski
86a1327259
don't show "This alias is available to use" if an alias is not provided
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-29 00:31:56 +00:00
Travis Ralston
3abd3137c7
Use the right function for creating binary verification QR codes
...
`writeInt8` happened to work because the strings we're writing happen to fit within a single byte so the LSB doesn't matter. We actually want a 16 bit (2 byte) number in big-endian format.
2020-02-26 13:37:34 -07:00
Travis Ralston
347f56b983
Ensure verification QR codes use the right buffer size
...
The string length buffer only needs 2 bytes, not 4.
2020-02-26 13:21:11 -07:00
Travis Ralston
f6fdddb9ba
Don't prefix QR codes with the length of the static marker string
...
Fixes https://github.com/vector-im/riot-web/issues/12489
2020-02-25 09:54:48 -07:00
Michael Telatynski
72e5313a5a
Merge pull request #4113 from matrix-org/t3chguy/fix_downloading
...
Handle file downloading locally in electron rather than sending to browser
2020-02-24 13:37:16 +00:00
Bruno Windels
dc85346e5c
Merge pull request #4102 from matrix-org/bwindels/aliasautocomplete
...
Use alt_aliases for pills and autocomplete
2020-02-24 12:18:07 +00:00
Michael Telatynski
d783ce86c8
Use noreferrer in addition to noopener for edge case browsers
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:14:29 +00:00
Michael Telatynski
d89b8b5148
Fix downloading files in electron not being sent into browser
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:10:36 +00:00
Travis Ralston
f74b283287
Merge pull request #4091 from matrix-org/travis/qr-binary
...
Use binary packing for verification QR codes
2020-02-21 10:05:12 -07:00
Bruno Windels
07d24038a3
fix lint
2020-02-21 14:11:30 +01:00
Bruno Windels
fada013f9e
this isn't doing anything because we don't have a room when the alias is not moderated
2020-02-21 14:06:57 +01:00
Bruno Windels
3c3839f863
show a pill as a moderated alias (canonical or alt) if available
...
otherwise, display as the label in the link
2020-02-21 13:02:41 +01:00
Bruno Windels
4219d2fcf6
style a room pill even if we don't find the room
2020-02-21 13:02:41 +01:00
Bruno Windels
f6313b51e6
also look in alt_aliases to match a pill to a room
2020-02-21 13:02:41 +01:00
Bruno Windels
fee9c7d21f
accept canonical alias for pills
2020-02-20 17:43:33 +01:00
Travis Ralston
760a472be5
Appease the linter
2020-02-19 17:05:32 -07:00
Travis Ralston
3b6a201d4e
Add comments
2020-02-19 17:03:50 -07:00
Travis Ralston
45963adeb4
Use binary packing for verification QR codes
...
Fixes https://github.com/vector-im/riot-web/issues/12257
Fixes https://github.com/vector-im/riot-web/issues/12375
We do not remove the existing QR code library in this commit because it is still used elsewhere (like the share dialog).
This should be as accurate as possible to what [MSC1543](https://github.com/matrix-org/matrix-doc/pull/1544 ) asks for.
2020-02-19 17:02:14 -07:00
Marco Zehe
8004a35179
Update to use proper quotes and fix code styling. And fix test.
...
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-12 10:54:08 +01:00
Marco Zehe
6fe4eb1fc3
Don't render avatars in pills for screen readers.
...
These don't provide any additional information, but add extraneous noise. The link text and title already provide all information. Therefore, mark the avatar inside pills (the mention links inside messages) as hidden. Note that due to the images being part of something focusable, role "presentation" does not work here.
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-12 09:36:59 +01:00
Travis Ralston
f6abd369ca
Fix comments
2020-02-07 15:36:57 +00:00
Travis Ralston
bdeb9cccc4
Rename estimatedTargetDevice to targetDevice
2020-02-07 15:34:45 +00:00
Travis Ralston
724cff6a2e
Update QR code rendering to support VerificationRequests
...
Makes for building the QR code easier and more common.
2020-01-30 17:12:44 +00:00
Michael Telatynski
76e61b9948
Merge branches 'develop' and 't3chguy/cs_verification_decoration' of https://github.com/matrix-org/matrix-react-sdk into t3chguy/cs_verification_decoration
2020-01-28 17:19:59 +00:00
J. Ryan Stinnett
d014c5239b
Add new session verification details dialog
...
This gives more info on the session you're about to verify, including device
name and ID.
Fixes https://github.com/vector-im/riot-web/issues/11977
2020-01-27 23:16:26 +00:00
Michael Telatynski
ca5d4d88a2
Style the QR code
2020-01-27 17:17:05 +00:00
Damir Jelić
e2dd2bd950
Merge branch 'poljar/seshat-ui-pr' into develop
2020-01-27 17:18:17 +01:00
Damir Jelić
5d3b916a89
DialogButtons: Allow setting the cancel button class with a prop.
2020-01-24 16:46:46 +01:00
Travis Ralston
12fa94106e
Actually add the secret to the QR code url
2020-01-23 20:19:17 -07:00
Travis Ralston
0ce9da5d36
Appease the linter
2020-01-23 20:12:24 -07:00
Travis Ralston
b682e7d908
Generate a QR code for apps to scan
2020-01-23 20:05:32 -07:00
Travis Ralston
1ec746c014
Add verification with QR codes
2020-01-23 19:29:54 -07:00
David Baker
d211372740
UI to bootsrap SSSS from key backup
2020-01-22 10:44:02 +00:00
Michael Telatynski
c97de43f69
Remove unused fetch polyfills, querystring, require-json. Move glob to dev-dep
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-01-18 02:01:45 +00:00
Travis Ralston
135c84251c
Fix more imports post-merge
2020-01-09 14:19:19 -07:00
Travis Ralston
3e5cc9550b
Fix import merge conflicts, removing any that aren't needed anymore
...
Many imports were removed as part of refactoring work, so here we are.
2020-01-09 14:17:33 -07:00
Travis Ralston
fde32f13a5
[CONFLICT CHUNKS] Merge branch 'develop' into travis/sourcemaps-develop
2020-01-09 14:15:09 -07:00
Michael Telatynski
245a68b3ba
Merge branches 'develop' and 't3chguy/clean_up_TextualBody' of github.com:matrix-org/matrix-react-sdk into t3chguy/clean_up_TextualBody
...
Conflicts:
yarn.lock
2020-01-09 12:17:21 +00:00
Travis Ralston
59f608ffd6
Merge pull request #3761 from matrix-org/travis/babel7-wp-es6-export
...
Convert CommonJS exports to ES6 exports
2020-01-08 09:09:11 -07:00
Michael Telatynski
c551f2983a
Add TextualBody-test.js
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-01-06 13:28:29 +00:00
Michael Telatynski
bd0a96f2b2
Merge branches 'develop' and 't3chguy/fix_react_complaining' of github.com:matrix-org/matrix-react-sdk into t3chguy/fix_react_complaining
...
Conflicts:
src/components/views/elements/Pill.js
2020-01-06 09:35:59 +00:00
Michael Telatynski
ac1d9b03bf
undo one of the "fixes"
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-01-06 09:35:14 +00:00
David Baker
2125bcf5a6
Comment remaining non-cross-signing-compliant components
...
Fixes https://github.com/vector-im/riot-web/issues/11748
2020-01-03 15:38:59 +00:00
Michael Telatynski
ebf7eb698d
Turn RoomAliasField into properly controlled and use in RoomSettings
2019-12-26 18:52:57 +00:00
Michael Telatynski
661701f7ca
Merge branches 'develop' and 't3chguy/tags_changes' of https://github.com/matrix-org/matrix-react-sdk into t3chguy/tags_changes
...
Conflicts:
src/components/views/elements/TagTile.js
2019-12-23 11:00:42 +00:00
Travis Ralston
f1ac3d2f64
Convert imports to ES6 from CommonJS
...
This is needed because `require()` means something different in webpack - it ends up importing the module as something we didn't expect (and is occasionally async)
2019-12-22 21:16:06 -07:00
Travis Ralston
042bd35d79
Fix MatrixClientPeg imports
2019-12-22 21:15:54 -07:00
Travis Ralston
d56f0f2a25
Convert many imports to handle ES6 exports
...
Reliant upon https://github.com/matrix-org/matrix-react-sdk/pull/3761
2019-12-22 21:04:42 -07:00
Travis Ralston
344dac4fb9
Convert CommonJS exports to ES6-compatible exports
...
We use `export default` begrudgingly here. Ideally we'd use just `export`, though this entire SDK expects things to be exported as a default. Instead of breaking everything, we'll sacrifice our export pattern for a smaller diff - a later commit can always do the default export -> regular export conversion.
2019-12-22 21:01:02 -07:00
Michael Telatynski
3a36d61fab
delint
2019-12-19 21:10:22 +00:00
Michael Telatynski
24d0d0d596
Merge pull request #3743 from matrix-org/t3chguy/react16_contexts
...
Migrate away from React Legacy contexts API
2019-12-19 20:32:11 +00:00
Michael Telatynski
b2249d0561
Initial rejig
2019-12-19 20:09:05 +00:00
Michael Telatynski
709b2eed7c
Add bunch of null-guards and similar to fix React Errors/complaints
2019-12-19 15:10:54 +00:00
Michael Telatynski
f30e919f9e
Merge pull request #3741 from matrix-org/t3chguy/dropdown_keyboard_propagation
...
Dropdown stop keyboard propagation if key handled
2019-12-17 17:39:41 +00:00
Michael Telatynski
da4d72b3c4
delint
2019-12-17 17:34:03 +00:00
Michael Telatynski
b094f0fe47
delint
2019-12-17 17:31:29 +00:00
Michael Telatynski
937b32663c
Migrate away from Legacy React Contexts
2019-12-17 17:26:12 +00:00
Michael Telatynski
2e8d66fa36
Null-guard member mention pills for rooms you have left (notif panel)
2019-12-17 16:54:59 +00:00
Michael Telatynski
7f78f55c94
Dropdown stop keyboard propagation if key handled
2019-12-17 15:14:01 +00:00
Michael Telatynski
0e86c2648d
improve comment
2019-12-17 14:36:20 +00:00
Michael Telatynski
213bc4c3ac
Fix Field validation tooltip sticking if blurred before async validation resolved
2019-12-17 14:28:18 +00:00
Michael Telatynski
d28a892bb0
Stop using KeyboardEvent.keyCode as it is deprecated
2019-12-16 17:14:03 +00:00
Michael Telatynski
2569b78db3
Merge pull request #3729 from matrix-org/t3chguy/aria_dropdown
...
Make combobox dropdown keyboard and screen reader accessible
2019-12-16 11:14:46 +00:00
David Baker
be914c7b0c
Merge pull request #3728 from matrix-org/jryans/verify-users
...
Verify users when cross-signing enabled
2019-12-16 10:12:46 +00:00
Michael Telatynski
9c4eb1d649
clean up new code
2019-12-16 10:03:40 +00:00
Michael Telatynski
224ee05b62
this is a combobox, HOME/END should pertain to the input, not selection
2019-12-15 15:07:49 +00:00
Michael Telatynski
cecf581e04
Make Combobox dropdown keyboard and screen reader accessible
2019-12-15 15:04:57 +00:00
Michael Telatynski
f67eedf843
Fix keyboard handling including scroll into view, add aria roles
2019-12-15 14:24:56 +00:00
Michael Telatynski
9d0bf13ca0
Fix ToggleSwitch A11Y (trapping tab and switch v. checkbox)
2019-12-13 14:18:41 +00:00
J. Ryan Stinnett
3ac0deebab
Use static modals for verification
...
Verification with cross-signing may requiring asking for your secret storage
passphrase, which is displayed in it's own modal on top of flows. For now while
verification takes in modals also, mark the verification ones as static so they
don't lose state when secret storage appears on top mid-flow.
2019-12-13 13:55:28 +00:00
Michael Telatynski
d22985f12e
Migrate string refs over to createRef
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:16:17 +00:00