* PSFD-455: Iterate on search results for message bubbles
Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*.
There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity:
* Message bubbles have the wrong corners for the display format (pre-existing).
* The sender's own messages are missing avatars/names. This is just way too complex to fix.
**Requires https://github.com/matrix-org/matrix-js-sdk/pull/2004**
* Tweak opacity
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Fix button width and align 絵文字 (emoji) on the user panel
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* mx_UserInfo_container:not(.mx_UserInfo_separator)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move the spinner to the center
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add indent to 'Unable to load session list' paragraph
Because the indent style has been specified with ':not(h3)', wrapping
with something is required for the indent.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Align the spinner to the center
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove margin of paragraph inside div on verification panel
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove duplicate mx_Dialog_buttons
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Group buttons on mx_Dialog with span
- Cancel default styling for elements inside .mx_AccessSecretStorageDialog_primaryContainer
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common rules of mx_Dialog_buttons_row to _common.scss
- Set 16px gap between buttons per https://github.com/vector-im/element-web/issues/19426#issuecomment-949778515
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Spacing variables
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Nesting - .mx_AccessSecretStorageDialog_reset
- Fix the reset link color
- Set $spacingStart variable
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove unnecessary rule
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove the hardcoded width of the clock on the AudioPlayer
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use text-align: justify
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Hide the verification left stroke only in the thread panel (ie. let it shown in a chat panel with a maximized widget)
Respect the original comment that the stroke should be hidden in the thread list (and in a thread as well).
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Display the left stroke inside a thread
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Fix the look of pills
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix comment
Co-authored-by: Robin <robin@robin.town>
Co-authored-by: Robin <robin@robin.town>
* include Inter natively on legacy & custom themes
* fix theming of beta button
* fix beta pill skinning properly
* switch back to accent-alt for beta pills
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Remove the box-shadow from the preview on the (right) panel for threads and a chat with a maximized widget.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move line-height of .mx_EventTile_line from _GroupLayout.scss to _EventTile.scss
Specifying mx_EventTile_line's line-height in mx_GroupLayout is too strong for mx_GenericEventListSummary.
- Set line-height:1 to mx_RedactedBody inside mx_GenericEventListSummary on IRC/modern layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a variable to remove the comment
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Readability
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Fix avatar's position on the chat panel with a maximized widget in IRC layout
Fix timestamp's position on Message Edits history modal window
Also:
- Align DisambiguatedProfile with reactions row and thread summary with a variable
- Add width property as default
- Use the global variable on _IRCLayout.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- Use AccessibleButton for cancel button, following other cases on UI
- Use flexbox for RTL layout to remove clear: both
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove blank header from video room view frame
* Add video room option to space context menu
* Remove duplicate tooltips from face piles
* Factor RoomInfoLine out of SpaceRoomView
* Factor RoomPreviewCard out of SpaceRoomView
* Adapt RoomPreviewCard for video rooms
* "New video room" → "Video room"
* Add comment about unused cases in RoomPreviewCard
* Make widgets in video rooms mutable again to de-risk future upgrades
* Ensure that the video channel exists when mounting VideoRoomView
* feat: introduce new alignment types for tooltip
* feat: introduce new hook for tooltips
* feat: allow using onFocus callback for RovingAccessibleButton
* feat: allow using custom class for ContextMenu
* feat: allow setting tab index for avatar
* refactor: move read receipts out of event tile
* feat: implement new read receipt design
* feat: update SentReceipt to match new read receipts as well
* Add margin between events on bubble message layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use more simplified way
Because the float property prevents the margin from appearing, removing
the property is more straightforward than adding other rules.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Kerry <kerrya@element.io>
* Show a lobby screen in video rooms
* Add connecting state
* Test VideoRoomView
* Test VideoLobby
* Get the local video stream with useAsyncMemo
* Clean up code review nits
* Explicitly state what !important is overriding
* Use spacing variables
* Wait for video channel messaging
* Update join button copy
* Show frame on both the lobby and widget
* Force dark theme for video lobby
* Wait for the widget to be ready
* Make VideoChannelStore constructor private
* Allow video lobby to shrink
* Add invite button to video room header
* Show connected members on lobby screen
* Make avatars in video lobby clickable
* Increase video channel store timeout
* Fix Jitsi Meet getting wedged on startup in Chrome and Safari
* Revert "Fix Jitsi Meet getting wedged on startup in Chrome and Safari"
This reverts commit 9f77b8c227c1a5bffa5d91b0c48bf3bbc44d4cec.
* Disable device buttons while connecting
* Factor RoomFacePile into a separate file
* Fix i18n lint
* Fix switching video channels while connected
* Properly limit number of connected members in face pile
* Fix CSS lint
* Specify the correct padding to the chat panel aka mx_ThreadPanel
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add border to the right chat panel
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Fixes button labels being collapsed per a character in CJK languages
Closes https://github.com/vector-im/element-web/issues/21287
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add a comment
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add font-size: inherit to link button
Remove redundant font-size settings
_FeedbackDialog.scss
_GenericFeatureFeedbackDialog.scss
_Login.scss
_NewRoomIntro.scss
_NotificationSettingsTab.scss
_PinnedEventTile.scss
_PreferencesUserSettingsTab.scss
_SpaceCreateMenu.scss
_ToastContainer.scss
_UserMenu.scss
Specify font-size
- _ProfileSettings.scss
- _SpaceBasicSettings.scss
- _SpaceSettingsDialog.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add line-height: inherit to link button
Remove redundant setting
- _GenericFeatureFeedbackDialog.scss
- _PinnedEventTile.scss
- _SpaceCreateMenu.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add font-weight: normal to link button
Remove redundant setting
- _SpotlightDialog.scss
- _UserMenu.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Dedupe _link and _link_inline
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Set inline to "link_inline"
Treat the button as its name indicates.
For elements that should not be inlined, "link" should be used.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove radio component
* "Voice room" → "video room"
* Remove interactivity from video room tiles
* Update connection state when joining via widget
* Simplify room header buttons for video rooms
* Split out video room creation into a separate menu option
* Simplify room options for video rooms
* Update video room tile layout
* Tell the Jitsi widget whether it's a video channel
* Update tests
* "Voice" → "video" in more places
* Fix tests
* Re-add frame to immersive Jitsi widgets
* Comment ack
* Make updateDevices more readable
* Type FacePile
* Remove deprecated feature_communities_v2_prototypes
* Update _components
* i18n
* delint
* Cut out a bit more dead code
* Carve into legacy components
* Carve into mostly the room list code
* Carve into instances of "groupId"
* Carve out more of what comes up with "groups"
* Carve out some settings
* ignore related groups state
* Remove instances of spacesEnabled
* Fix some obvious issues
* Remove now-unused css
* Fix variable naming for legacy components
* Update i18n
* Misc cleanup from manual review
* Update snapshot for changed flag
* Appease linters
* rethemedex
* Remove now-unused AddressPickerDialog
* Make ConfirmUserActionDialog's member a required prop
* Remove useless override from RightPanelStore
* Remove extraneous CSS
* Update i18n
* Demo: "Communities are now Spaces" landing page
* Restore linkify for group IDs
* Demo: Dialog on click for communities->spaces notice
* i18n for demos
* i18n post-merge
* Update copy
* Appease the linter
* Post-merge cleanup
* Re-add spaces_learn_more_url to the new SdkConfig place
* Round 1 of post-merge fixes
* i18n
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Revert "Revert "Use styled mxids in member list (#6328)" (#8107)"
This reverts commit 709e6e78d2.
* Fix disambiguated profile for bubbles
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add voice room labs flag
Signed-off-by: Robin Townsend <robin@robin.town>
* Add more widget actions for interacting with Jitsi
Signed-off-by: Robin Townsend <robin@robin.town>
* Factor out a more generic Jitsi creation utility
Signed-off-by: Robin Townsend <robin@robin.town>
* Add utilities for managing voice channels
Signed-off-by: Robin Townsend <robin@robin.town>
* Enable creation of voice rooms
Signed-off-by: Robin Townsend <robin@robin.town>
* Force a maximized view of voice channel widgets
Signed-off-by: Robin Townsend <robin@robin.town>
* Add voice channel store
Signed-off-by: Robin Townsend <robin@robin.town>
* Factor out a more generic FacePile
Signed-off-by: Robin Townsend <robin@robin.town>
* Implement room tile changes for voice rooms
Signed-off-by: Robin Townsend <robin@robin.town>
* Add interactive radio component to the left panel
Signed-off-by: Robin Townsend <robin@robin.town>
* Test voice rooms
Signed-off-by: Robin Townsend <robin@robin.town>
* Update name of call room type
Signed-off-by: Robin Townsend <robin@robin.town>
* Clarify that voice rooms are under development
Signed-off-by: Robin Townsend <robin@robin.town>
* Use readonly
Signed-off-by: Robin Townsend <robin@robin.town>
* Move acks to the end of handlers
Signed-off-by: Robin Townsend <robin@robin.town>
* Add comment about avatar URLs coming from Jitsi
Signed-off-by: Robin Townsend <robin@robin.town>
* Don't use unicode ellipses
for translation reasons?
Signed-off-by: Robin Townsend <robin@robin.town>
* Fix tests
Signed-off-by: Robin Townsend <robin@robin.town>
* Fix tests, again
Signed-off-by: Robin Townsend <robin@robin.town>
* Remove unnecessary export
Signed-off-by: Robin Townsend <robin@robin.town>
* Ack Jitsi events when we wait for them
Signed-off-by: Robin Townsend <robin@robin.town>
* Allow keeping state events when removing recent messages
The remove recent messages dialog redacts most state events since they
can be abuse vectors as well, however some users that see the option
actually want to use it to only remove messages. This adds a checkbox
option to do so.
Signed-off-by: Robin Townsend <robin@robin.town>
* Don't redact encryption events when removing recent messages
Signed-off-by: Robin Townsend <robin@robin.town>
* Show UserMenu spinner while removing recent messages
This also generalizes the UserMenu spinner to work with other types of
actions in the future.
Signed-off-by: Robin Townsend <robin@robin.town>
* Clarify remove recent messages warning
Clarify that they are removed for everyone in the conversation, not just
yourself.
Signed-off-by: Robin Townsend <robin@robin.town>
* Adjust copy and preserve state events by default
* Redact messages in reverse chronological order
Signed-off-by: Robin Townsend <robin@robin.town>
* Show displayname in non-narrow thread summeries
* Iterate PR
* Iterate PR to use line-height based approach
* Fix hover/focus chevron on thread summary relying on font character
* Hide pinned messages header button when nothing is pinned
Signed-off-by: Robin Townsend <robin@robin.town>
* Add pinned messages option to room info panel
Signed-off-by: Robin Townsend <robin@robin.town>
* Add pinned messages option to room header menu
Signed-off-by: Robin Townsend <robin@robin.town>
* Make condition more concise
Signed-off-by: Robin Townsend <robin@robin.town>
* Fix missing padding on server picker
Signed-off-by: Robin Townsend <robin@robin.town>
* Use spacing variable
Signed-off-by: Robin Townsend <robin@robin.town>
* Render a CollapsibleButton's children (needed by UploadButton)
* Make UploadButton ready to live inside an overflow menu
* Always show overflow menu in composer: main buttons are emoji and attach
* Re-order composer buttons as per design
* Re-word composer button captions to be simple nouns
* Don't rotate More options button when clicked
* Move the composer menu and dialogs 16px in from right
* Reduce shadow on composer More menu
* From review: remove else clause
* From review: take input out of button
* Update test snapshots
* Update snapshots
Fix https://github.com/vector-im/element-web/issues/20801
Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/7339
Relevant styles were first added in https://github.com/matrix-org/matrix-react-sdk/pull/4858
(context behind why the original styles were added)
---
## Cause
Battling CSS specificity between the default and compact styles, https://specificity.keegan.st/
Known good (On `app.element.io` (expected)):
```css
// 0 3 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton {
padding-top: 12px;
padding-bottom: 12px;
}
// Compact styles override our default rules because they come
// after the other styles (source order) and have the same specificity
// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
padding: 8px 16px 8px 11px;
}
```
Bad (On `develop` (broken)):
```css
// Default rules always override because they have higher specificity.
// The `:not()` selector doesn't add any extra specificity but the selectors inside the `:not(...)` do.
// 0 4 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
padding-top: 12px;
padding-bottom: 12px;
}
// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
padding: 8px 16px 8px 11px;
}
```
