Commit graph

9646 commits

Author SHA1 Message Date
Travis Ralston
347f56b983 Ensure verification QR codes use the right buffer size
The string length buffer only needs 2 bytes, not 4.
2020-02-26 13:21:11 -07:00
Travis Ralston
49ec79515c
Merge pull request #4128 from matrix-org/travis/dont-prefix-length
Don't prefix QR codes with the length of the static marker string
2020-02-26 12:07:24 -07:00
Michael Telatynski
d5177ddc04
Merge pull request #4133 from matrix-org/t3chguy/pinned
Fix message context menu breaking on invalid m.room.pinned_events event
2020-02-26 11:36:46 +00:00
Michael Telatynski
9a1236a016 Fix message context menu breaking on invalid m.room.pinned_events event
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-26 10:40:33 +00:00
Travis Ralston
9be61497fb Handle errors when previewing rooms more safely
Fixes https://github.com/vector-im/riot-web/issues/12500

See https://github.com/matrix-org/synapse/issues/6992 for additional context.
2020-02-25 16:11:07 -07:00
Travis Ralston
b32fbcb64f Don't try to collapse zero events with a group
Fixes https://github.com/vector-im/riot-web/issues/12423

When events are redacted they fail to make it into the Grouper because the `shouldAddEvent` check blocks them from entering. However, the grouper expects that when `getTiles()` is called that there's events to group and dutifully grabs some context from the array. Because JavaScript is the least helpful language, `myArray[-1]` returns `undefined` or `null` and thus you get `cannot read 'sender' of undefined`.

Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/4059
2020-02-25 15:40:15 -07:00
Travis Ralston
30a0d88074 Don't print errors when the tab is used with no autocomplete present
Fixes https://github.com/vector-im/riot-web/issues/12461

Not a release blocker because the error is caught, and is at the end of the function. Just log spam.
2020-02-25 13:13:41 -07:00
J. Ryan Stinnett
1958dae519
Merge pull request #4124 from matrix-org/jryans/show-bootstrap-more
Show both bootstrap and reset cross-signing where appropriate
2020-02-25 17:29:31 +00:00
Bruno Windels
17d55abed7
Merge pull request #4126 from matrix-org/bwindels/verifuifeedbackonlag
Improve UI feedback while waiting for network
2020-02-25 17:08:06 +00:00
Travis Ralston
f6fdddb9ba Don't prefix QR codes with the length of the static marker string
Fixes https://github.com/vector-im/riot-web/issues/12489
2020-02-25 09:54:48 -07:00
Travis Ralston
6dcbed0320
Merge pull request #4123 from matrix-org/travis/invite-populate
Ensure DMs tagged outside of account data work in the invite dialog
2020-02-25 09:45:52 -07:00
Travis Ralston
7091e7a4af
Use the right keyword 2020-02-25 09:19:37 -07:00
Zoe
1d8756b95d text improvements 2020-02-25 15:40:06 +00:00
Bruno Windels
682781aa48 better word smithing 2020-02-25 13:27:59 +01:00
Bruno Windels
bd584ab236 from verification tile, also don't wait to show right panel 2020-02-25 13:27:19 +01:00
Bruno Windels
b0c87b0eaf UI spinner when clicking "they don't match" 2020-02-25 13:18:27 +01:00
Bruno Windels
2127edb7b8 show "Waiting for network" in EncryptionInfo after accepting in toast 2020-02-25 13:13:51 +01:00
Bruno Windels
569d5b6156 show right panel before waiting for .ready event to send 2020-02-25 13:13:31 +01:00
Zoe
9ed83b8648 Show a warning dialog when user indicates a new session wasn't them 2020-02-25 11:37:01 +00:00
J. Ryan Stinnett
12e8ad8f6b Show both bootstrap and reset cross-signing where appropriate
For cases like having keys on your account but not on the current device, this
ensures we offer both bootstrap and reset as possible paths.
2020-02-25 11:23:51 +00:00
Travis Ralston
866ed68615 Ensure DMs tagged outside of account data work in the invite dialog
Fixes https://github.com/vector-im/riot-web/issues/12418

Includes a refactor so we don't need to litter the code with the same magic string for DM tags.
2020-02-24 19:43:49 -07:00
Zoe
866fdd6185
Merge pull request #4120 from matrix-org/foldleft/cancel-events
Show cancel events as hidden events if we wouldn't usually render them
2020-02-24 17:02:11 +00:00
Travis Ralston
2cb699ae8b
Merge pull request #4033 from TestardR/feature/padLockInviteOnly
Collapsed room list has unaligned room tiles #4030 version 2
2020-02-24 09:59:26 -07:00
J. Ryan Stinnett
64dc776e43
Merge pull request #4118 from matrix-org/jryans/hs-xsign-check
Check for cross-signing homeserver support
2020-02-24 16:58:57 +00:00
Zoe
d01c58bd41 added comment 2020-02-24 16:54:10 +00:00
Zoe
91b85cd060 show cancel events as hidden events if we wouldn't usually render them 2020-02-24 16:51:06 +00:00
Travis Ralston
d2e7cc7f19 Merge branch 'develop' into feature/padLockInviteOnly 2020-02-24 09:50:06 -07:00
Bruno Windels
818156663a don't leak if show_sas never comes (or already came) 2020-02-24 17:00:55 +01:00
J. Ryan Stinnett
a71a234622 Check for cross-signing homeserver support
This checks the homeserver to ensure it supports cross-signing (via the versions
feature flag) before attempting bootstrapping or offering user verification.

Fixes https://github.com/vector-im/riot-web/issues/11863
2020-02-24 15:04:34 +00:00
Zoe
381cbbabb0
Merge pull request #4106 from matrix-org/foldleft/verification-devtool
Add verification request viewer in devtools
2020-02-24 14:34:45 +00:00
Zoe
f3ac3554a9 include observeOnly 2020-02-24 14:17:34 +00:00
Zoe
0d3d837871 useEventEmitter hook instead of manually using code 2020-02-24 13:44:04 +00:00
Bruno Windels
2b61988d30
Merge pull request #4117 from matrix-org/bwindels/fixinfinispinneronencryptioninfo
update phase when request prop changes
2020-02-24 13:39:51 +00:00
Michael Telatynski
72e5313a5a
Merge pull request #4113 from matrix-org/t3chguy/fix_downloading
Handle file downloading locally in electron rather than sending to browser
2020-02-24 13:37:16 +00:00
J. Ryan Stinnett
f80582a51d
Merge pull request #4116 from matrix-org/jryans/rm-cider-watcher
Remove unused CIDER setting watcher
2020-02-24 13:10:59 +00:00
Bruno Windels
2350d102e3 update phase when request prop changes 2020-02-24 13:39:20 +01:00
J. Ryan Stinnett
8e39bd8885 Remove unused CIDER setting watcher
This setting watcher for CIDER seems unused and logs a warning at the moment, so
this change removes it.
2020-02-24 12:36:25 +00:00
Bruno Windels
dc85346e5c
Merge pull request #4102 from matrix-org/bwindels/aliasautocomplete
Use alt_aliases for pills and autocomplete
2020-02-24 12:18:07 +00:00
J. Ryan Stinnett
c0c22ba7f9
Merge pull request #4108 from matrix-org/jryans/a11y-editor-keyboard
Add shortcuts for beginning / end of composer
2020-02-24 12:02:03 +00:00
Zoe
af514385b2 Avoid shadowing window.setTimeout 2020-02-24 11:53:12 +00:00
Zoe
71bdc5987b added clarifying comment 2020-02-24 11:33:49 +00:00
Zoe
0663ab3b87 lint, and detect new requests 2020-02-24 10:17:33 +00:00
Michael Telatynski
0bcdf062a3 reset opener when using window.open
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:22:12 +00:00
Michael Telatynski
b2c1242207 delint
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:19:18 +00:00
Michael Telatynski
d783ce86c8 Use noreferrer in addition to noopener for edge case browsers
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:14:29 +00:00
Michael Telatynski
d89b8b5148 Fix downloading files in electron not being sent into browser
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:10:36 +00:00
Michael Telatynski
3308152439 Fix a couple of React warnings/errors
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 14:10:41 +00:00
Matthew Hodgson
7696f704b2 Fix two big DOM leaks which were locking Chrome solid.
pillifyLinks leaked Pill components, which if they contained a BaseAvatar
would leak a whole DOM tree retained by the BaseAvatar's onClientSync
event listener.  This tracks the Pill containers so they can be unmounted
via unmountPills.

BasicMessageComposer set an event listener on selectionchange in onFocus
which leaked if onBlur wasn't called.  This removes it in unmount.

We've also seen Velociraptor retaining full DOM trees from RRs, which
this doesn't address as the leak is probably within Velocity, and the plan
is to replace it with CSS animations.

Should fix https://github.com/vector-im/riot-web/issues/12417
2020-02-22 23:51:30 +00:00
Travis Ralston
c906b9eccf Filter out empty strings when pasting IDs into the invite dialog
Fixes https://github.com/vector-im/riot-web/issues/12459
2020-02-21 13:26:37 -07:00
J. Ryan Stinnett
dc6a4854ce Add shortcuts for beginning / end of composer
This adds Ctrl/Command+Home/End shortcuts for jumping to the start and end of
the composer contents.

Fixes https://github.com/vector-im/riot-web/issues/12438
2020-02-21 18:50:44 +00:00