J. Ryan Stinnett
4b5faf8148
Update top vs. bottom sticky styles separately
...
If a sublist changes from sticky top to sticky bottom in a single run of the
logic (without passing through the default state), we were leaving the previous
top position set. This handles them independently to resolve this.
Fixes https://github.com/vector-im/riot-web/issues/14390
Maybe helps with https://github.com/vector-im/riot-web/issues/14443
For vector-im/riot-web#13635
2020-07-13 21:24:47 +01:00
Michael Telatynski
72407a30d3
Merge pull request #4954 from matrix-org/t3chguy/room-list/14409
...
Room List v2 Enter in the filter field should select the first result
2020-07-13 15:27:16 +01:00
Michael Telatynski
d253c58830
Room List v2 Enter in the filter field should select the first result
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-12 19:06:47 +01:00
Travis Ralston
75dbd5f1d4
Merge branch 'develop' into travis/room-list/enable
2020-07-09 22:28:16 -06:00
Travis Ralston
74ca0618ac
Improve scrolling performance for sticky headers
...
The layout updates are anecdotal based on devtools flagging the values which are "changing" even if they aren't. The scrolling feels better with this as well, though this might be placebo.
2020-07-08 14:55:28 -06:00
Travis Ralston
f9aca7c05e
Avoid bounding box usage in sticky headers & improve reliability
...
We now use offsets and scroll information to determine where the headers should be stuck to, still supporting the transparent background.
Some scroll jumps were originally introduced as part of the change in numbering, so they have been fixed here. By proxy, some additional scroll jump/instability should be fixed as well.
This has a lingering problem of still causing a huge number of no-op UI updates though, which will be dealt with in a future commit.
2020-07-08 14:37:35 -06:00
Travis Ralston
6e20850567
Remove sanity check from requestAnimationFrame
...
It should be in all major browsers as of years ago, and we use it unguarded elsewhere in the app. The performance benefits of it appear to be worthwhile enough to keep it, though it's not a perfect solution.
2020-07-08 12:17:51 -06:00
Bruno Windels
989e4a9ceb
Merge pull request #4912 from matrix-org/bwindels/bettersticky
...
Add wrapper to room list so sticky headers don't need a background
2020-07-08 13:34:01 +00:00
Bruno Windels
a361ac3f83
make collapsing/expanding the first header work again
2020-07-08 15:11:47 +02:00
Bruno Windels
0d94cfa97a
put sticky headers in padding of wrapper
...
this way they don't need a background, as the list is already clipped
2020-07-08 14:49:38 +02:00
Bruno Windels
75751abc60
add wrapper we can then add padding to when sticking headers
2020-07-08 14:49:04 +02:00
Michael Telatynski
7b115056b0
Fix sticky headers being left on display:none if they change too quickly
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-08 09:21:33 +01:00
Travis Ralston
a59a8b76a9
Update TODO comments to point to new issue
2020-07-07 14:51:43 -06:00
Travis Ralston
baccabeae4
Remove extraneous true
2020-07-07 11:34:52 -06:00
Travis Ralston
e6b20088c0
Try using requestAnimationFrame if available for sticky headers
...
This might help performance, or it might not. Let's try it!
2020-07-07 11:33:32 -06:00
Michael Telatynski
f18db23cc4
Remove some TODOs
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-07 17:18:56 +01:00
Michael Telatynski
69852ecef4
Merge branches 'develop' and 't3chguy/room-list/123' of github.com:matrix-org/matrix-react-sdk into t3chguy/room-list/123
...
Conflicts:
src/components/views/rooms/RoomSublist2.tsx
2020-07-07 14:10:58 +01:00
Travis Ralston
d14dd777b7
Revert "don't need to set width with javascript?"
...
This reverts commit a2cf641c0e
.
2020-07-06 15:23:20 -06:00
Michael Telatynski
3094bb32ec
Merge pull request #4901 from matrix-org/t3chguy/room-list/112
...
Fix some room list sticky header instabilities
2020-07-06 22:21:02 +01:00
Michael Telatynski
97d4295bf5
Merge pull request #4902 from matrix-org/t3chguy/room-list/14306
...
Allow vertical scrolling on the new room list breadcrumbs
2020-07-06 21:53:54 +01:00
Bruno Windels
7647072b05
remove prop instead of assigning unset
2020-07-06 14:36:07 -06:00
Bruno Windels
201f6ebe83
make stick headers jump in a bit later so the transition is less jumpy
2020-07-06 14:36:01 -06:00
Bruno Windels
a2cf641c0e
don't need to set width with javascript?
2020-07-06 14:35:53 -06:00
Bruno Windels
61a5807fd1
only show topmost top sticky header
2020-07-06 14:35:46 -06:00
Michael Telatynski
c9bc318ca7
Allow vertical scrolling on the new room list breadcrumbs
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-06 21:32:46 +01:00
Michael Telatynski
8233dec72e
Fix some room list sticky header instabilities
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-06 21:05:06 +01:00
Michael Telatynski
b7c23b690c
Include more classes for room list keyboard navigation
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-06 01:14:02 +01:00
Michael Telatynski
1620feb55e
Sprinkle in some better ARIA props
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-05 01:07:46 +01:00
Michael Telatynski
c8a93e9dd7
clean-up
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-03 14:49:25 +01:00
Michael Telatynski
47ee00ec5d
Make explore button at all accessible
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-03 14:43:02 +01:00
Michael Telatynski
289f40ce29
First step towards a11y in the new room list
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-02 22:21:10 +01:00
Travis Ralston
43db4b98df
Merge branch 'develop' into joriks/room-list-breadcrumbs
2020-07-02 13:22:51 -06:00
Jorik Schellekens
2162517a37
Display breadcrumbs only after 20 rooms have been joined
2020-07-01 16:05:27 +01:00
Jorik Schellekens
ad27dbbfab
Clean up classnames
2020-07-01 15:15:18 +01:00
Jorik Schellekens
d2fb30a211
Hide scrollbar without pixel jumping
2020-06-30 23:52:13 +01:00
Jorik Schellekens
dcd51b5be3
Implement breadcrumb notifications and scrolling
2020-06-30 23:24:46 +01:00
Travis Ralston
ee2c216c4d
Clean up TODO comments for new room list
...
All relevant TODOs should still be present, and reference an issue for easy finding.
2020-06-28 20:03:04 -06:00
Travis Ralston
3abc9d8d56
Merge branch 'develop' into travis/room-list/tag-panel
2020-06-26 07:26:57 -06:00
Travis Ralston
7ce3cc1db7
Allow the tag panel to be disabled in the new room list
...
Fixes https://github.com/vector-im/riot-web/issues/14156
2020-06-25 20:35:40 -06:00
Travis Ralston
bcfdd4d984
Move all of the UserMenu into the UserMenu component
2020-06-25 19:38:11 -06:00
Travis Ralston
dafce40d1b
Rename UserMenuButton to UserMenu for new scope
2020-06-25 19:29:12 -06:00
Travis Ralston
90ff4585d5
Remove extraneous debug from the new left panel
2020-06-24 20:14:01 -06:00
Travis Ralston
380aed4244
Update profile information in User Menu
...
Fixes https://github.com/vector-im/riot-web/issues/14158 (we needed an HTTP avatar URL)
Fixes https://github.com/vector-im/riot-web/issues/14159
Fixes https://github.com/vector-im/riot-web/issues/14157
Also fixes an issue where it wasn't updating automatically when the user changed their profile info.
This is all achieved through a new OwnProfileStore which does the heavy lifting, as we have to keep at least 2 components updated.
2020-06-23 21:01:50 -06:00
Travis Ralston
1a427b8ff7
Fix sticky headers over/under extending themselves in the new room list
...
Fixes https://github.com/vector-im/riot-web/issues/14095
2020-06-22 13:09:42 -06:00
Travis Ralston
8f3a6fc30e
Consistent quotes
2020-06-18 07:48:36 -06:00
Travis Ralston
321889f95b
Clear top
when not sticking headers to the top
...
Fixes https://github.com/vector-im/riot-web/issues/14070
2020-06-17 20:01:03 -06:00
Travis Ralston
4186070489
Support list collapsing and jumping
...
Fixes https://github.com/vector-im/riot-web/issues/14036
2020-06-15 19:47:43 -06:00
Travis Ralston
eeac80096c
Float the badges with the sticky headers
2020-06-13 19:07:19 -06:00
Travis Ralston
c26c79bda8
Remove dead code
2020-06-13 19:02:21 -06:00
Travis Ralston
1bbf2e053b
Initial attempt at sticky headers
...
Docs enclosed in diff.
2020-06-13 11:55:11 -06:00