Fix 'missing page_type' error

LoggedInView will complain if it is instantiated without a page_type, so let's
keep showing the syncing spinner until we have one.
This commit is contained in:
Richard van der Hoff 2017-05-17 18:49:59 +01:00
parent c61294f71c
commit e3dbf057fb

View file

@ -1171,7 +1171,12 @@ module.exports = React.createClass({
<PostRegistration
onComplete={this.onFinishPostRegistration} />
);
} else if (this.state.loggedIn && this.state.ready) {
}
// `ready` and `loggedIn` may be set before `page_type` (because the
// latter is set via the dispatcher). If we don't yet have a `page_type`,
// keep showing the spinner for now.
if (this.state.loggedIn && this.state.ready && this.state.page_type) {
/* for now, we stuff the entirety of our props and state into the LoggedInView.
* we should go through and figure out what we actually need to pass down, as well
* as using something like redux to avoid having a billion bits of state kicking around.