mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-10-22 18:55:47 +03:00
Code Issues Projects Releases Packages Wiki Activity

Pause voice broadcast on calls (#9623)

Browse source
This commit is contained in:
Michael Weimann 2022-11-28 12:43:59 +01:00 committed by GitHub
parent ad190b1dcc
commit e38c59c535
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/stores/widgets/StopGapWidget.ts
View file

@ -283,8 +283,8 @@ export class StopGapWidget extends EventEmitter {
this.messaging.on("capabilitiesNotified", () => this.emit("capabilitiesNotified"));
this.messaging.on(`action:${WidgetApiFromWidgetAction.OpenModalWidget}`, this.onOpenModal);
this.messaging.on(`action:${ElementWidgetActions.JoinCall}`, () => {
// stop voice broadcast recording when any widget sends a "join"
VoiceBroadcastRecordingsStore.instance().getCurrent()?.stop();
// pause voice broadcast recording when any widget sends a "join"
VoiceBroadcastRecordingsStore.instance().getCurrent()?.pause();
});
// Always attach a handler for ViewRoom, but permission check it internally

4
src/voice-broadcast/models/VoiceBroadcastRecording.ts
View file

@ -222,8 +222,8 @@ export class VoiceBroadcastRecording
private onAction = (payload: ActionPayload) => {
if (payload.action !== "call_state") return;
// stop on any call action
this.stop();
// pause on any call action
this.pause();
};
private setState(state: VoiceBroadcastInfoState): void {

6
test/stores/widgets/StopGapWidget-test.ts
View file

@ -89,7 +89,7 @@ describe("StopGapWidget", () => {
content: {},
});
voiceBroadcastRecording = new VoiceBroadcastRecording(voiceBroadcastInfoEvent, client);
jest.spyOn(voiceBroadcastRecording, "stop");
jest.spyOn(voiceBroadcastRecording, "pause");
jest.spyOn(VoiceBroadcastRecordingsStore.instance(), "getCurrent").mockReturnValue(voiceBroadcastRecording);
});
@ -105,8 +105,8 @@ describe("StopGapWidget", () => {
);
});
it("should stop the current voice broadcast recording", () => {
expect(voiceBroadcastRecording.stop).toHaveBeenCalled();
it("should pause the current voice broadcast recording", () => {
expect(voiceBroadcastRecording.pause).toHaveBeenCalled();
});
});
});

2
test/voice-broadcast/models/VoiceBroadcastRecording-test.ts
View file

@ -296,7 +296,7 @@ describe("VoiceBroadcastRecording", () => {
}, true);
});
itShouldBeInState(VoiceBroadcastInfoState.Stopped);
itShouldBeInState(VoiceBroadcastInfoState.Paused);
});
describe("and a chunk time update occurs", () => {